Account created on 6 October 2017, about 8 years ago
  • Drupal FullStack Developer at abventorย 
#

Merge Requests

More

Recent comments

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

I reverted commit from ๐Ÿ› Accessibility : Focus lost when link is clicked Needs work

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Merged! Thanks!

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Thanks @deaom

Please reopen if needed

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Could you provide more info and steps to reproduce?

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Add to issue summary full steps to reproduce

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Thanks @jernejmramor

Please reopen if still relevant

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

I tested VBO flag/unflag and it works as expected. Please reopen with more info if still relevant

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

@kate.k do you enable "render flags as field or links"? Attach screenshot of flag settings

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Thanks @deaom.

Please reopen if needed

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Merged! thanks!

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Needs to fix phpcs warnings

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Merged! Thanks!

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Merged! Thanks!

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Merged! Thanks!

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Why we do it via JS ?

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Merged! Thanks!

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Hey folks, how can I benchmark this? Needs steps to reproduce/benchmark

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

@arthur.baghdasar

I tested VBO for articles with flag action. $configuration['flag_id'] always used. Where did you have $configuration['flag_id'] empty?

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

I improved your MR and added a simple test. Thanks!

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Thanks you! i will test it soon

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Thanks! Merged!

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ changed the visibility of the branch 2723703-add-relationship-to to hidden.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Please reopen if needed

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

I tested this patch and I got

Error: Call to a member function chat() on null in Drupal\ai\Base\OpenAiBasedProviderClientBase->chat() (line 339 of /var/www/web/modules/contrib/ai/src/Base/OpenAiBasedProviderClientBase.php).

after chat request

$this->client is NULL

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Yes, needs to check every function from issue summary and if it not used then remove it. And fix tests of course

@jatin812 Also, I think "Flag" module is too hard to novices. Try to help with another (simple) modules

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

@jatin812

You don't need to move parentheses to a new line. In addition, read carefully the description of issue

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

I applied suggestions from #96.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

I fixed pipeline here ๐Ÿ“Œ Fix Drupal 11.2 pipeline Active

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

WOW, very fast. Thanks Jonathan!

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Fixed. @freelylw try dev-version

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

I think @damienmckenna you need to request "administer maintainers" permission from Dave or create issue about it to "project ownership'

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Sorry, MR doesn't ready to review yet

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

I created an MR with your commits

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

@hemuvyas97 Have you started working on it?

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

@awasson could you provide steps to reproduce and HTML output?

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

Needs reroll to MR

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

I added a test

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

I used code #7.

It works for me with

  /**
   * {@inheritdoc}
   */
  public function applies(RouteMatchInterface $route_match): bool {
    return $route_match->getRouteName() === 'entity.taxonomy_term.canonical';
  }
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ created an issue.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

ivnish โ†’ changed the visibility of the branch 3406677-how-to-delete to hidden.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish

@stado I've almost finished this feature and will commit within a few days.

๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
๐Ÿ‡ง๐Ÿ‡พBelarus ivnish
Production build 0.71.5 2024