Kazakhstan
Account created on 6 October 2017, over 7 years ago
  • Drupal FullStack Developer at abventor 
#

Merge Requests

More

Recent comments

ivnish Kazakhstan

ivnish changed the visibility of the branch 3481364-update-the-admin to hidden.

ivnish Kazakhstan

ivnish made their first commit to this issue’s fork.

ivnish Kazakhstan

I can reproduce this

The Anonymous vote restriction field needs to be installed.

after upgrade from alpha3 to alpha4 even after poll_update_8007 ran

ivnish Kazakhstan

I think we can close it as fixed

ivnish Kazakhstan

Postponed before 📌 Use default ref in CI Active

ivnish Kazakhstan

It also fixed stylelint crash

ivnish Kazakhstan

I used steps for reproduce and I can't reproduce this. I got translated poll with correct language

ivnish Kazakhstan

I think the Flag is stable now. We can create a stable release. Needs @Berdir opinion

🐛 | Poll | Empty vote
ivnish Kazakhstan

Is this still relevant?

ivnish Kazakhstan

ivnish made their first commit to this issue’s fork.

ivnish Kazakhstan

Is this still relevant? How many poll users use also "conflict" module?

ivnish Kazakhstan

Is this still relevant for issue author or others?

ivnish Kazakhstan

What the initial task do you try to resolve? Looks like very very strange steps

ivnish Kazakhstan

Try the clean Drupal instance.

ivnish Kazakhstan

Do you use the last version?

Block Account menu:

ivnish Kazakhstan

I reinstalled module again and all works fine

I tested a functionality and all works as expected

ivnish Kazakhstan

I found some issues.

1) "Anonymous vote restriction" field doesn't save (or doesn't load saved value) when save/edit poll

2) When I uncheck "Allow anonymous votes" I can't save poll because of "Anonymous vote restriction field is required."

ivnish Kazakhstan

There are 2 existing notifications on site.

1) Privatemsg Block with new messages counter

2) Privatemsg menu item to Account menu

Please try it

ivnish Kazakhstan

Let's create a test with demonstration that it works as expected

ivnish Kazakhstan

Let's create a test with demonstration that it works as expected

ivnish Kazakhstan

ivnish changed the visibility of the branch 8.x-4.x to hidden.

ivnish Kazakhstan

Looks like this issue is not ready for review. Discussion is in progress

ivnish Kazakhstan

Is there here people who have this warning right now?

ivnish Kazakhstan

Please do not use patches! it's hard to review. This issue has an MR

ivnish Kazakhstan

Add to menu

ivnish Kazakhstan

I explored the same issue VBO support Needs review .

@jurgenhaas how do you think, do that change help you with ECA?

https://git.drupalcode.org/project/flag/-/merge_requests/31/diffs

Now, I reverted this issue commit

ivnish Kazakhstan

ivnish changed the visibility of the branch 8.x-4.x to hidden.

ivnish Kazakhstan

@ressa could you create "Code Examples" doc pages ?

ivnish Kazakhstan

ivnish made their first commit to this issue’s fork.

ivnish Kazakhstan

We need a tests to demonstrate that link doesn't render in not allowed entities

ivnish Kazakhstan

Sorry, I took your message #8 as meaning that the MR needs some work.

ivnish Kazakhstan

Yes, needs to fix all CI warnings

ivnish Kazakhstan

@lobsterr needs reroll to MR. Also tests needed

ivnish Kazakhstan

Needs reroll patch to MR. Also needs steps to reproduce

ivnish Kazakhstan

I tested both inline links and links as fields. With caching they works fine. Try to clean Drupal instance

ivnish Kazakhstan

@manuel.adan could you explain what links do you mean?

ivnish Kazakhstan

Thanks Liam!

Could you write a simple test for it?

ivnish Kazakhstan

Thanks all, MR29 committed!

ivnish Kazakhstan

Fasttoggle supports only nodes and comments now

ivnish Kazakhstan

Please do not include other fixes except documentation text. Create a new issue with other phpcs/unserialize fixes. Thanks!

Production build 0.71.5 2024