Account created on 6 October 2017, over 8 years ago
  • Drupal FullStack Developer at abventor 
#

Merge Requests

More

Recent comments

🇧🇾Belarus ivnish

@sirclickalot let's create a new issue about schema (if it doesn't exists)

🇧🇾Belarus ivnish

@sirclickalot could you remove "canonical" = from src/Entity/SettingsProfile.php as here https://git.drupalcode.org/project/backup_migrate/-/merge_requests/63/di..., clear cache and test again ?

🇧🇾Belarus ivnish

Nice catch!

The problem was reproduced when I created a new setting

🇧🇾Belarus ivnish

@sirclickalot, entity.backup_migrate_settings.canonical is dynamic route for entity. It shouldn't be in backup_migrate.routing.yml file.

🇧🇾Belarus ivnish

Try to reinstall the module

🇧🇾Belarus ivnish

I tested again manually. Drupal 11.3, PHP 8.4.

I can't reproduce this. Try to remove old patches for this issue if they exists

Also it could be APCu cache, try to restart web-server

🇧🇾Belarus ivnish

ivnish created an issue.

🇧🇾Belarus ivnish

ivnish created an issue.

🇧🇾Belarus ivnish

ivnish created an issue.

🇧🇾Belarus ivnish

ivnish changed the visibility of the branch 8.x-1.x to hidden.

🇧🇾Belarus ivnish

ivnish created an issue.

🇧🇾Belarus ivnish

I don't have permissions to create releases. Contact to @japerry

@medha kumari this is already fixed.

🇧🇾Belarus ivnish

Looks like already fixed in dev version https://git.drupalcode.org/project/field_permissions/-/commit/278fd5ed31...

Did you scan dev or release version of module?

🇧🇾Belarus ivnish

ivnish changed the visibility of the branch 8.x-4.x to hidden.

🇧🇾Belarus ivnish

I think it can be getFlagUserEntities

🇧🇾Belarus ivnish

Unfortunately it can breaks a lot of existing sites. I think the best way is using flag-count.html.twig in your theme and edit it as you need

🇧🇾Belarus ivnish

In 2025 this simple task could be resolved with CSS only.

My flag machine name is "test_flag"

CSS code

.flag-test-flag {
  position: relative;
  display: inline-block;
  cursor: pointer;
  user-select: none;
}

.flag-test-flag a {
  display: inline-flex;
  align-items: center;
  gap: 8px;
  padding: 4px 12px;
  border: 2px solid #cbd5e1;
  border-radius: 6px;
  background-color: #f8fafc;
  transition: all 0.2s ease;
  cursor: pointer;
  text-decoration: none !important;
  color: #1e293b !important;
}

.flag-test-flag.action-flag a:hover {
  border-color: #3b82f6;
  background-color: #eff6ff;
}

.flag-test-flag.action-unflag a {
  border-color: #10b981;
  background-color: #dcfce7;
}

.flag-test-flag.action-unflag a:hover {
  border-color: #059669;
  background-color: #d1fae8;
}

.flag-test-flag a::before {
  content: "";
  display: inline-block;
  width: 16px;
  height: 16px;
  border: 2px solid currentColor;
  border-radius: 3px;
  background-color: #fff;
  transition: all 0.2s ease;
}

.flag-test-flag.action-unflag a::before {
  background-color: #10b981;
  border-color: #10b981;
  box-shadow: inset 0 0 0 3px #fff;
}

.flag-test-flag.action-unflag a span {
  color: #166537;
}
🇧🇾Belarus ivnish

@anybody is this still relevant for you?

🇧🇾Belarus ivnish

Mmm, but haven't they been doing this through REST for a long time? Is REST not suitable for you?

🇧🇾Belarus ivnish

This is already resolved. I tested it manually

🇧🇾Belarus ivnish

Still needs steps to reproduce and tests

🇧🇾Belarus ivnish

Needs check

🇧🇾Belarus ivnish

ivnish made their first commit to this issue’s fork.

🇧🇾Belarus ivnish

Straight forward

🇧🇾Belarus ivnish

ivnish made their first commit to this issue’s fork.

🇧🇾Belarus ivnish

I forgot to remove "status" filter like this

$this->drupalGet('/admin/structure/views/nojs/handler/flag_bookmark/page_1/filter/status');

(facepalm)

Tested again, it works as expected

🇧🇾Belarus ivnish

ivnish created an issue.

🇧🇾Belarus ivnish

PHPCS has "565 ERRORS AND 10 WARNINGS"

I think needs to separate issue to PHPCS and PHPSTAN fixes. This issue about PHPSTAN issues

🇧🇾Belarus ivnish

Yes, try without -W

🇧🇾Belarus ivnish

I fixed two bugs with WSOD

🇧🇾Belarus ivnish

Just upgrade to 5.1.1

Backup Migrate can't require drupal/core-composer-scaffold, see https://git.drupalcode.org/project/backup_migrate/-/blob/5.1.x/composer....

🇧🇾Belarus ivnish

I can't reproduce this on the latest dev

🇧🇾Belarus ivnish

@uv516, could you test the patch from MR ?

🇧🇾Belarus ivnish

ivnish made their first commit to this issue’s fork.

🇧🇾Belarus ivnish

I tagged a 5.1.1 release with PHP 8.4/8.5 fixes

🇧🇾Belarus ivnish

@joachim could you have a look?

Production build 0.71.5 2024