Poland
Account created on 6 October 2017, over 6 years ago
  • Drupal FullStack Developer at abventor 
#

Merge Requests

More

Recent comments

ivnish Poland

Will need some form of upgrade path for the new settings.

Upgrade path is not needed in this case. The new setting is disabled by default and does not affect existing sites.

ivnish Poland

I think some changes to the tests are also required

Can you explain? Or do you want to fix it yourself?

ivnish Poland

I added commit to MR with order type select. Please review, test and comment

ivnish Poland

Yes, I understand. We can commit only in 11.x. Upgrade from 10 to 11 will require reading documentation and changes any way

ivnish Poland

Patch #5 works but

The commerce_product_variation.license_type field needs to be uninstalled.
The commerce_product_variation.license_expiration field needs to be uninstalled.

On the status page still exists

ivnish Poland

You created 20+ issues about co-maintaining. Are you sure that you have time to all these modules? :)

ivnish Poland

I need more info how to reproduce and what is expected

ivnish Poland

But this module supports Drupal 9

Drupal 9 is EOL since November 1st, 2023. Next release views_blogspot_archive drops Drupal 9 support. Drupal 9 users can use 2.0.0 version with custom patches if necessary

ivnish Poland

Ok, let's check:

1) SQL Injection is not relevant, because the new module uses Drupal Entity, not direct SQL.

2) Cross Site Scripting problem is not relevant too, because the new module uses views table instead of custom table.

3) Denial of service is not relevant too, because if I added any UID to my cookie, it doesn't affect other users after my login

ivnish Poland

Yes, because this is current Drupal standard and global usage is 97.91%

ivnish Poland

I missed this field :) But I'm trying it now and your suggestion doesn't work

The code from

https://git.drupalcode.org/project/stage_file_proxy/-/blob/2.1.x/src/Eve...

doesn't execute. I think we missed using proxy_headers settings when StageFileProxySubscriber was created.

I created a MR with a fix

ivnish Poland

@chaitanyadessai issues from MR are not resolved

ivnish Poland

Thanks @pianomansam!

I fixed eslint warnings, fixed olivero js error, added test for olivero

ivnish Poland

Created MR for more simple review and merge

ivnish Poland

@Berdir, @BramDriesen I want to discuss this feature. I have a client which is using Poll module to create photo competitions :)

He adds some code to choices:

<div class="photoswipe-gallery">
<a href="/sites/default/files/2023/10/27/pexels-craig-adderley-1563356_0.jpg" class="photoswipe" data-size="1024x682"><img src="/sites/default/files/styles/thumbnail/public/2023/10/27/pexels-craig-adderley-1563356_0.jpg" loading="lazy" width="100" height="60">
</a>
<a href="/sites/default/files/2023/10/27/pexels-isabella-mendes-341013_0.jpg" class="photoswipe" data-size="1024x678"><img src="/sites/default/files/styles/thumbnail/public/2023/10/27/pexels-isabella-mendes-341013_0.jpg" loading="lazy" width="100" height="60">
</a>
</div>

Now we can add HTML to choices, but only 255 symbols.

I changed choice field from

$fields['choice'] = BaseFieldDefinition::create('string')

to

$fields['choice'] = BaseFieldDefinition::create('string_long')

And PollChoiceDefaultWidget from

'#type' => 'textfield',

to

'#type' => 'textarea',
'#rows' => 1,

It looks like

Of course we need to update existing field definition.

Is there any chance to add feature to mainstream if I make a patch?

ivnish Poland

Good feature. Needs reroll and check tests

Production build https://api.contrib.social 0.62.1