@ivnish

When I used swiper in the block I got a lot of PHP warnings. Please check it

I fixed the broken test

ivnish → changed the visibility of the branch 3.1.x to hidden.

@drumm could I and @jonathan1055 get a contribution credit? :)

Ok, I will try to fix it

The sidebar with contribute button breaks issue edit form

Needs reroll to MR

I have the same problem now. Some orders still in draft after payment. I will try patches from 🐛 The order can stay unplaced after an offsite authorization only payment Needs review

I enabled tests for Drupal 10 too. Could you fix LatestGalleryItemsBlockJavascriptTest.php ? It fails in Drupal 10

Thanks for your contribution!

I changed the default viewmode to "default" to fix old contrib modules

ivnish → changed the visibility of the branch 11.x to hidden.

@poker10

I don't like idea to removing previous messages. As I know Drupal (and symfony) can't remove message by ID or text. But without removing we have 2 messages and messages region shows twice. Any ideas how to fix it?

We need to choose one solution here

Let's check the status

@DieterHolvoet is MR ready to test/review ?

I moved the code to the page_cache module as @catch suggested

Rebased

I improved some code. Please review

I left a few comments

Drupal 7 is EOL. Issue will be closed, but patches are still here

Drupal 7 is EOL. Issue will be closed, but patches are still here

Merged! Thanks!

@omarlopesino I don't see in the new test the case from steps to reproduce. Could you add it?

Needs steps for reproduce

Merged! Thanks!

Merged! Thanks!

Merged! Thanks!

Same problem

ivnish → created an issue.

Thanks, Fixed!

@manishsaharan needs reroll to MR. Also needs tests to show that the template is not broken after this patch

How to reproduce this?

Folks, how to reproduce this? Do you use contrib or custom modules?

ivnish → created an issue.

ivnish → created an issue.

ivnish → created an issue.

Looks like you are using eca module. This error from his file: /eca/modules/render/src/Hook/RenderHooks.php not from commerce

Awesome functionality!

Also ✨ Fix Layout Builder compatibility for Media Gallery Active merged!

I tested manually and don't find any problems in my existing projects

Only string literals should be passed to t() where possible

Hmmm. Yes, we can ignore this and use // phpcs:ignore

Does $this->t not work there?

Thanks! Fixed

I need some time to review this MR.

Who can test it manually?

Nice work! LGTM. I need some time for manual testing

Could you explain: I understand when gallery added to node LB as block. But what is your use case for using LB for render gallery?

Thanks!

I don't know about "code coverage" like here https://www.drupal.org/project/knowledge/issues/3526796 📌 Add Code Coverage Active

The default CI is enough for me :)

LGTM

if no more code updates are planned, I think I can commit this

so reopening as RTBC

Ah, sorry)

Since getFlagUserFlaggings() already covers the per-flag case, maybe we could simplify getAllFlaggingByUser() to just handle “all by user” and drop the “optionally narrowed by flag” bit? That way each method has a clear, distinct role.

Could you update the MR ?

@amitsedaiz is this still relevant to you?

There is sub-module flag_bookmark. Try it

#14 is the solution

You can create Pseudo Field (or twig variable) programmatically

Looks like not relevant anymore for the issue author

Looks like not relevant anymore for the issue author

Is this still relevant to you?

Could you add full steps for reproduce?

Looks like not relevant anymore for the issue author

Looks like the patch for theming was committed https://git.drupalcode.org/project/flag/-/commit/dd511975ef69acafd8381fe...