🇧🇾Belarus @ivnish

I reverted this commit because of 🐛 Implementation of 2901287 causes issues when multiple instances of a flag are rendered on page Active

I reverted commit from 🐛 Accessibility : Focus lost when link is clicked Needs work

Merged! Thanks!

Thanks @deaom

Please reopen if needed

ivnish → made their first commit to this issue’s fork.

Could you provide more info and steps to reproduce?

Add to issue summary full steps to reproduce

Thanks @jernejmramor

Please reopen if still relevant

I tested VBO flag/unflag and it works as expected. Please reopen with more info if still relevant

@kate.k do you enable "render flags as field or links"? Attach screenshot of flag settings

Thanks @deaom.

Please reopen if needed

Merged! thanks!

Needs to fix phpcs warnings

Merged! Thanks!

Merged! Thanks!

Merged! Thanks!

Why we do it via JS ?

Merged! Thanks!

Hey folks, how can I benchmark this? Needs steps to reproduce/benchmark

@arthur.baghdasar

I tested VBO for articles with flag action. $configuration['flag_id'] always used. Where did you have $configuration['flag_id'] empty?

I improved your MR and added a simple test. Thanks!

Thanks you! i will test it soon

Thanks! Merged!

ivnish → changed the visibility of the branch 2723703-add-relationship-to to hidden.

Please reopen if needed

ivnish → created an issue.

ivnish → created an issue.

I tested this patch and I got

Error: Call to a member function chat() on null in Drupal\ai\Base\OpenAiBasedProviderClientBase->chat() (line 339 of /var/www/web/modules/contrib/ai/src/Base/OpenAiBasedProviderClientBase.php).

after chat request

$this->client is NULL

Yes, needs to check every function from issue summary and if it not used then remove it. And fix tests of course

@jatin812 Also, I think "Flag" module is too hard to novices. Try to help with another (simple) modules

@jatin812

You don't need to move parentheses to a new line. In addition, read carefully the description of issue

I applied suggestions from #96.

ivnish → created an issue.

I fixed pipeline here 📌 Fix Drupal 11.2 pipeline Active

ivnish → created an issue.

ivnish → created an issue.

WOW, very fast. Thanks Jonathan!

ivnish → created an issue.

ivnish → created an issue.

Fixed. @freelylw try dev-version

ivnish → made their first commit to this issue’s fork.

ivnish → created an issue.

I think @damienmckenna you need to request "administer maintainers" permission from Dave or create issue about it to "project ownership'

ivnish → created an issue.

Sorry, MR doesn't ready to review yet

I created an MR with your commits

@hemuvyas97 Have you started working on it?

@awasson could you provide steps to reproduce and HTML output?

Needs reroll to MR

I added a test

ivnish → made their first commit to this issue’s fork.

ivnish → created an issue.

ivnish → made their first commit to this issue’s fork.

I used code #7.

It works for me with

  /**
   * {@inheritdoc}
   */
  public function applies(RouteMatchInterface $route_match): bool {
    return $route_match->getRouteName() === 'entity.taxonomy_term.canonical';
  }

Committed https://git.drupalcode.org/project/privatemsg/-/commit/b1cc256606ccaad84...

@stado please test

ivnish → created an issue.

ivnish → changed the visibility of the branch 3406677-how-to-delete to hidden.

@stado I've almost finished this feature and will commit within a few days.