remove unused setters on Flag

Created on 17 April 2017, over 7 years ago
Updated 19 October 2024, about 2 months ago

The following methods on Flag aren't used in our codebase, or are used only in tests:

- setGlobal($global = TRUE)
- setFlagShortText($text)
- setFlagLongText($flag_long)
- setFlagMessage($flag_message)
- setUnflagLongText($unflag_long)
- setUnflagMessage($unflag_message)
- setUnflagShortText($unflag_short)
- setUnflagDeniedText($unflag_denied_text)
- setWeight($weight)

There's no use case for them, as these are config settings that won't be changed on a Flag entity dynamically. If developers REALLY want to change them, they can use the set() method. We shouldn't support all this code that's useless to us.

Postponed on #2868098: refactor all get(un)Flag*() methods .

📌 Task
Status

Postponed: needs info

Version

4.0

Component

Flag core

Created by

🇬🇧United Kingdom joachim

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024