Imported PO files have no public URL but have a link at admin/content/files

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Think the method should be deprecated first right? This could break existing sites.

Still needs a change record.

Added a deprecation notice and created a (draft) change record https://www.drupal.org/node/3378735 →

The last submitted patch, 99: 2449895_99.patch, failed testing. View results →

For info, patch #92 → worked for me.
Config: PHP 8.3.3, Drupal 10.2.3.

Confirming patch #92 works on PHP 8.1.28 / Drupal 10.2.6.

Unfortunately patch #99 did not work.

Confirming patch #92 works on PHP 8.3.10 / Drupal 10.3.10.

Uploading patch for D11. Couldn't produce interdiff due to `Whitespace damage detected in input`. But basically it's the same with #92. I've only removed : void from importPoFile().

Have not reviewed but fixes should be in MRs please.

I added the changes from 104 + native typehint. But then I saw getExternalUrl was removed, which I added again.

Rethinking.

Based on LocalStream -> getExternalUrl-> exception -> yes please.
Based on PrivateStream -> getExternalUrl -> exception -> why?

Removing \Drupal\locale\StreamWrapper\TranslationsStream::getExternalUrl would use \Drupal\Core\StreamWrapper\PrivateStream::getExternalUrl then and no Change record is required.

I need to review it in a real drupal installation.

So with PrivateStream and \Drupal\Core\StreamWrapper\PrivateStream::getExternalUrl the view links to system/files/my.po, which does not exists, but that is ok. The file is then removed, when file_cron cleanups temporary files.

Better would be. Upload file -> import translation -> remove file. But this is out of scope.