🇨🇦Canada @andrew.wang

Account created on 19 June 2019, over 5 years ago
#

Recent comments

🇨🇦Canada andrew.wang

I came here from Google - seems this is still the case in Drupal 10.3.10.
I found https://www.drupal.org/node/3013865 and https://www.drupal.org/project/drupal/issues/1154180 , but path alias still doesn't seem to show up when comparing revisions using the diff module.

🇨🇦Canada andrew.wang

There seems to be a white margin on the right on mobile (iPhone 13 mini, iOS 17.7.2)?

If you can’t see it the first time, try doing the zoom out gesture and the white margin appears

🇨🇦Canada andrew.wang

There are still many projects that do not have an automated Drupal 11 readiness issue created. For example, both masquerade_field and openid_connect_windows_aad do not have an "Automated Drupal 11 compatibility fixes" issue.

🇨🇦Canada andrew.wang

Been using the patch in #9 for 2 months. It works great.

🇨🇦Canada andrew.wang

I encountered the same issue - header check is always failing for my basic auth protected site:

🇨🇦Canada andrew.wang

However, this looks like a WordPress site?

https://mechanicshub.com/wp-login.php

🇨🇦Canada andrew.wang

FWIW, full screen mode is already provided in the official CKEditor 5 Plugin Pack as a “premium plugins available for free”: https://www.drupal.org/project/ckeditor5_plugin_pack

🇨🇦Canada andrew.wang

I see @joco_sp can now opt projects into security advisory coverage - moving this issue back to Drupal.org project ownership.

🇨🇦Canada andrew.wang

@joco_sp maybe try opening a new issue for maintaining offer? This issue is already closed so it likely won't get any attention.

🇨🇦Canada andrew.wang

I second that this issue might be unrelated to #3384400, which is about CKEditor 5 mangling an existing table that might already have the scope attribute in the markup.

On the other hand, this issue is an accessibility issue and can be reproduced from scratch, without any existing markup. CKEditor should automatically add the scope attribute to <th> elements for accessibility reasons when defining a row or column as header using the toolbar. This used to work in CKEditor 4, but is absent in CKEditor 5. Although we can go to source mode and add scope attribute to <th> elements manually, tables with header rows and/or header columns created using only WYSIWYG are by default inaccessible.

In addition to the GitHub comment mentioned in #5, there’s a separate upstream issue about this accessibility issue on GitHub: https://github.com/ckeditor/ckeditor5/issues/3175

🇨🇦Canada andrew.wang

The aforementioned upstream issue is now marked as completed!

🇨🇦Canada andrew.wang

I didn't review the code but just wanna report that #179 works well for me on a big site running Drupal 10.2.1!

🇨🇦Canada andrew.wang

Tested using simplytest.me with this patch applied to the 4.0.0-alpha1 branch on Drupal 10.2.0. The toolbar icon does not seem to reflect /js/plugins/abbr/icons/abbr.png?

🇨🇦Canada andrew.wang

I ran into this issue too. Before applying the patch, Drupal does not bootstrap and I see error as shown in the screenshot. After the patch, the error is cleared. RTBC +1.

🇨🇦Canada andrew.wang

I found a typo on the now launched landing page. I came across this issue through a search and hope that this is the right place to report!

On https://www.drupal.org/about/drupal-7/d7eol/partners#type-simple , there’s a sentence that reads the following:

If your need is truly a node code solution that can be as basic as a simple online brochure

Shouldn’t it be “no code” instead of “node code”?

🇨🇦Canada andrew.wang

I’ll try contacting the maintainers for a release.

🇨🇦Canada andrew.wang

+1. Kindly requesting a tagged release :-)

🇨🇦Canada andrew.wang

I second #12 - the patch has been applied to the site I'm working on for 2 years and it's been working great on a high volume website.

(Disclaimer: Nick and I work at the same organization but a different site ;-P)

🇨🇦Canada andrew.wang

In my site, I had to downgrade to 0.15.13 instead of 0.15.18 for some reason.

🇨🇦Canada andrew.wang

Tried panels with the same method as #14 and I can reproduce the same behaviour.

Production build 0.71.5 2024