Favicon always shows `(` after upgrading to 4.0.11

The MR uses only the environment name to generate the favicon.

This patch actually tracks with the original functionality. There is another issue 🐛 JS adds "(()" on mobile Closed: duplicate which swaps the title and the version around, but the truth is, all we need is the first character of the title, so no version is needed at all.

This issue should probably be closed as a duplicate of 🐛 Whether deployment identifier is used as fallback for current_release should be configurable Needs work .

I like the fix, but there is another place where this should be fixed in environment_indicator.module:94. @prudloff, Can you please add the same code there?

Thanks!

I like the fix, but there is another place where this should be fixed in environment_indicator.module:94.

I don't think it needs to be fixed there, $title already takes its value from $active_environment->get('name').

This issue should probably be closed as a duplicate of 🐛 Whether deployment identifier is used as fallback for current_release should be configurable Needs work .

The patch in 🐛 Whether deployment identifier is used as fallback for current_release should be configurable Needs work seems to remove the deployment identifier from everywhere the environment title is displayed.
The current MR only removes it from drupalSettings (because we don't want to use it to generate the favicon but we do want to display it in the toolbar).

Looks good now after applying the patch:

In case the maintainers were wondering, this merge request is compatible with the merge request in #3324621 and is not a duplicate.

This issue (#3325119) is strictly about the Favicon.

+1 for merging

I'm going to add this to the 4.0.20 release. Thanks for the work