Whether deployment identifier is used as current_release value should be configurable

Needs IS summary update for suggested new configuration setting. Affects all 4.x-dev (and all 4.x releases since 4.0.11).

Issue was introduced with the changes committed for #2610208: Move procedural functions to a manager → due to the deployment identifier now being used (if available) as the current_release value that is prepended to the environment title when the current_release value is not set in the state.

Closed 🐛 Remove extra strings added to the environment title after upgraded to 4.0.11 Closed: duplicate as duplicate of this issue. Credit should be included for the contributors to that issue when this fixed.

We have also been experiencing the random characters in parentheses prepended to the environment label. We also observed that the characters come from a deployment_identifier file located in our project's root directory.

I'm submitting patch #20 → which is similar to #9, but it keeps the environment_indicator.current_release state variable check. It only replaces the deployment_identifier fallback with a \Drupal::VERSION fallback.

I was for disabling the fallback but I really like @ericjenkins' idea of showing the Drupal version. I think that would be useful info to highlight, whereas the deploy ID is really really not.

Adding static patch for CI tools with all the changes in the merge request as of 17c96bd7b7b4d916f43bd30dd58806e21fc956bf against the 4.x branch.

I've added a second merge request with the fallback option in case folks think that is a better path forward. https://git.drupalcode.org/project/environment_indicator/-/merge_request...

trackleft2 → closed merge request !43

Adding static patch of https://git.drupalcode.org/project/environment_indicator/-/merge_request...

Suggestion: when the none option is selected for the Source of version identifier to display field, a fall back option should not be allowed.

I've updated the merge request to disallow setting a fallback if a primary version indicator source is set to none.

trackleft2 → changed the visibility of the branch environment_indicator-3324621-3324621-with-fallback to hidden.

The changes in @trackleft2's MR work great for me in my testing. I really like that it adds additional configuration options for what is used as the version indicator and the fallback.

Uploading static patch with latest changes from MR (usable with 4.0.19).

Excelent work. I'll release it in the 4.0.20 version.