xjm → credited pameeela → .
pameeela → created an issue.
pameeela → created an issue.
Updating to reflect that simple sitemap (XML sitemap generator) already works.
Not having enough time would be a pretty excellent reason to not do this :) Here's hoping.
I manually tested this and was perplexed about why the content menu didn't get imported, but it was just a typo in the recipe that I fixed.
I'm not sure why we aren't importing the settings file but we don't seem to need it.
Thanks @jurgenhaas, I have tested and this is looking great! I think an alpha is a good next step.
Nah we don't want all the config because we don't want Help or Shortcuts, which come with navigation.block_layout.yml. But agree we should update it for this change.
Right but we still have the module, can't we use it to add the styles but nothing else?
Tested this in Drupal CMS. It is already much better and I agree re: merging to make it easier to test because it was a pain to get it going to test myself :)
The main issue is that without Gin Toolbar, the navigation loses the Gin styling on front-end pages, so it gets the Claro styling instead.
@phenaproxima can we update it from b2b_saas, to saas_product?
The module was just a sandbox, I shouldn't have linked to it initially. The intention is to get this into core in ✨ Allow disabling a route for a bundle and adding additional routes for view modes other than 'full' Postponed .
Added task for trash, the module works, just need to work out how to modify the confirmation message to reflect that.
pameeela → created an issue.
pameeela → created an issue.
Nevermind this is already done! Forgot to pull I guess.
pameeela → created an issue.
This is already logged but we can't reproduce it on the latest version. See 🐛 Drupal CMS requirements page styling Active
Agreed.
Tested what happens when you update an existing site to 11.2 and updating this to a bug based on that. I think it's major since it's a pretty big regression.
On admin pages, it is the empty toolbar as shown in the previous comment.
When viewing site pages, you get the double toolbar:
Just was testing Drupal CMS on the 2.x branch, which is on 11.2.0-beta, so it has nav top bar enabled by default. There are quite a few issues to resolve and I'm not entirely sure what the correct state is for testing.
Should Gin Toolbar be installed? If so then Toolbar also must be installed which seems like a problem. But without Gin Toolbar, the navigation doesn't get Gin's styles outside of admin pages.
I tried with this patch to see if it resolved things but it doesn't seem to make much difference. What I'm seeing is basically an empty top bar on all admin pages. I'm not seeing the action links appearing in the toolbar as in the other screenshots posted here.
This is with Gin Toolbar and Toolbar uninstalled.
Can we not actually ship the site template recipes with Drupal CMS, and instead require them on application?
Yes, but from the user's perspective it makes no difference, the options come with it. So 'ship with' is not implying any implementation specifics, just a way of describing the experience.
Yes exactly, we plan to specify the recipes we want to expose, but will need to do this in a way that it can be updated so not sure exactly how yet. Because hardcoding fully where it's static post-install is also not really acceptable.
We are also not sure what the actual recommended recipes will be. So since we don't know the recipes and don't know the mechanism, we don't have an issue but I guess we can create a placeholder that is postponed.
Seems like there is agreement on the suggested approach of having two landmarks but can someone update the IS with exactly what the proposed markup should be?
This is already the plan, happy to have it documented here but not sure that we need anything further?
Excellent! I didn't get around to testing it until today but working well, thanks :)
That's awesome, thanks @godotislate! @catch said this can probably get committed during RC since the module is not stable yet.
xjm → credited pameeela → .
griffynh → credited pameeela → .
griffynh → credited pameeela → .
griffynh → credited pameeela → .
griffynh → credited pameeela → .
Personally I prefer the original approach, adding just 'Overview' is simpler and cleaner and avoids repetition. Screenshots below showing the difference between these. I've asked @ckrina to weigh in so we can have a final decision and ideally get this committed soon.
MR 10900:
MR 12148:
I've removed the microcontent heading from the IS. Although I can see a use case for having testimonials and FAQs being reusable, it adds a lot of complexity to the content model, and for me does not add much value. In other words, I think it's possible but not that common that a site may want to reuse these but I don't think it meets the 80% threshold and therefore does not feel like MVP.
The features listed are specific to the SaaS template, but are we missing some features that site owners just expect to be present?
Not sure whether it has been made explicitly clear but we assume that Drupal CMS will provide this basic functionality for all of the templates that we develop. There are definitely things missing from Drupal CMS itself on this front but we should aim to add them there rather than in each template so they are consistent across sites that use it.
thejimbirch → credited pameeela → .
Thanks, yes I assumed that the fix would be in core :) Just didn't want this to get lost.
Re-rolled the branch and attaching a patch file to use for this. It's working for us, but I haven't looked into the test fails so still NW.
pameeela → made their first commit to this issue’s fork.
@phenaproxima So should we create a new issue for better error handling?
It makes perfect sense to me that this doesn't work, but this is going to be pretty common in a world of contrib recipes and site templates. So it's definitely worth capturing these cases and improving the experience.
In this case, the error itself is not very helpful. So improving the error message to provide specific information about what config is causing the problem, and what you can do to get around it, might be a good first step? That would be a recipe feature I assume?
Sitemap module just allows you to enable various menus or taxonomy vocabs to display on the sitemap page. So it shouldn't be affected by XB I think? If there are XB pages in the menu, they would appear in the sitemap.
Updated the IS to group the modules based on whether they are relevant to XB and made a few other updates.
pameeela → created an issue.
pameeela → created an issue.
@phenaproxima are you saying we should have Drupal CMS running on 11.2 beta by default?
@kunalgautam thank you for working on this, however, we are not currently seeking contribution of a specific recipe. @jose reyero is working on the underlying features required to support this.
Until we are ready to proceed with the actual recipe, I will mark this task as Postponed.
I've gotten the same result:
@penyaskito can you try again and see if you are still having this issue?
Created the MR, will ping Emma for approval :)
Huge support for this from me! Emma has been fantastic to work with on Drupal CMS and I think it will be great to formalise her involvement in core too. This also feels like a big step generally toward prioritising UX!
Using this patch on a project and it works quite well! Would be great to get it in before 11.2.
We are having the same issue trying to use this module with D11. Wonder if anyone else has had any luck?
@kunalgautam this is a feature suggestion, not something that we are actively planning to add at this time. If we do decide to go ahead with it, we will define the approach in the issue. I'm updating the status to 'Postponed' to reflect this as there is nothing to action right now.
Tested the patch and it works to hide the menu link. I'm not the best person to do a code review of this as it's outside of my expertise, but I am not sure about the empty pages. The top level page is reachable via the side navigation:
For now, the second level pages don't link but they may in future.
I see, wow, I was way off thinking thinking initially this was a simple fix! For our case, we were able to patch by just making the change I proposed because we won't have any users with access to only some of the tools.
I will try to find time to test this proper fix during the week.
Just hit this on a project yesterday, and I think it belongs in the navigation itself, not the top bar. And the user menu is a logical place. So +1 to #1!
Also was super confused by #7 because I could not find this menu, until I reread the comment, and yes, the user block isn't a proper menu until 11.2 :)
Ah, wait -- this probably doesn't work because it means the cron permission can't be used separately. So I guess the fix would be to add a new general permission?
pameeela → created an issue.
I think this is unblocked now.
hestenet → credited pameeela → .
Thanks @dww!
I'd love to do this, but there is no way we would be able to get it done before 11.2 anyway unfortunately.
I also could swear there was already an issue for this! But I can't find it.
We already have a process for taking over modules that are no longer maintained. A "guarantee" is not really feasible, since there is nothing commercial here, we are all just volunteers or sponsored by our companies at their discretion.
Certainly, we are vetting the modules included in Drupal CMS carefully, and it is highly unlikely that a module that is included would be totally abandoned. But if that did happen, the Drupal CMS team and the wider community would work toward a solution. I don't think this can be formalised, at least not for now.
Last child meta is closed, I hereby declare Drupal CMS 1.0 complete :)
Going to close this because there is some work being done on the larger AI strategy that will define what happens post v1. No need to update this issue I think.