Account created on 19 July 2011, almost 13 years ago
#

Merge Requests

More

Recent comments

πŸ‡¦πŸ‡ΊAustralia pameeela

Updating this to remove the 'finish' language, I see others agreed with this change :)

πŸ‡¦πŸ‡ΊAustralia pameeela

The MR is pretty straightforward but I added a line about the proposed resolution. Not sure if that is what you mean @smustgrave?

πŸ‡¦πŸ‡ΊAustralia pameeela

Assigning to Tim as his team is going to get started on this for now.

πŸ‡¦πŸ‡ΊAustralia pameeela

Created an MR to add a check that $values is an array. There is no test here because it would be very difficult to come up with one, so hoping it qualifies for an exemption given both the simplicity of the fix and the fact that it is only resolving a warning.

πŸ‡¦πŸ‡ΊAustralia pameeela

Discussed in Slack, will create an MR with a modified fix.

πŸ‡¦πŸ‡ΊAustralia pameeela

Thank you @dreambubbler! Next week we will put out a formal call for folks who want to be a track lead, we will post the details in each issue so keep an eye out :)

πŸ‡¦πŸ‡ΊAustralia pameeela

Thank you @mandclu! Next week we will put out a formal call for folks who want to be a track lead, we will post the details in each issue so keep an eye out :)

πŸ‡¦πŸ‡ΊAustralia pameeela

I've tried to reproduce using the info in the IS on 10.2 and no luck, not seeing any warnings with this config. The steps in #12 are not clear enough to test them. If this is still occurring could someone please update the issue summary with specific steps to reproduce it?

πŸ‡¦πŸ‡ΊAustralia pameeela

This discussion got a bit side tracked I think! Updating the title because I don't think we will be prompting users only to apply recipes. I also don't think that 'Finish your site' is a realistic title for this, considering what would be required to actually 'finish' a site from here.

What we are really doing is providing some suggestions (next steps?) for what to do now that you have installed Drupal.

Thinking of a few things we could prompt, not in any particular order and not at all exhaustive:

  1. Create an event / blog / landing page (based on the available content types)
  2. Add a new content type (this could be applying a recipe OR creating one from scratch?)
  3. Browse module add-ons (not the correct wording but this would take you to Project Browser)
  4. Move to hosting (if this is a browser trial)
  5. Collaborate with your team (add a user, but this only makes sense if it is on hosting already)
πŸ‡¦πŸ‡ΊAustralia pameeela

Cross-linking the Github issue where GDPR was being discussed.

I think there are two parts to this:

  1. Ensure Starshot is GDPR compliant OOTB
  2. Provide a recipe for users who are planning to use cookies/tracking so they can easily remain compliant

Not sure if #2 is in v1? I guess it depends on how complex it would be.

πŸ‡¦πŸ‡ΊAustralia pameeela

I’m not totally sold on the grouping idea, that was proposed in the other issue. I guess I don’t have the solution, just raising a concern about the current UX.

I myself find it hard to parse even the shortest list to find the content type I’m after. But I'm willing to concede that this is just because it’s a change and new users may not find the same.

πŸ‡¦πŸ‡ΊAustralia pameeela

I created ✨ Grouping or prioritisation for items in create menu Active for the first part of this. The second two items are a separate feature request I think, to allow individual users to customise their own menu. Separate to that could be a feature to allow customisation of it globally. I haven't created issues for those although they may already exist.

πŸ‡¦πŸ‡ΊAustralia pameeela

This should not be postponed as the latest comment says it can be reproduced in several core themes. Updated IS to reflect this.

πŸ‡¦πŸ‡ΊAustralia pameeela

Going to close this since there is no recent info on seeing it, or specific steps to test.

πŸ‡¦πŸ‡ΊAustralia pameeela

Thanks for confirming.

πŸ‡¦πŸ‡ΊAustralia pameeela

@nicxvan could you expand on why you think this change should be called out? The setting doesn't do anything. Why would it be disruptive for it to not be set on a new install?

πŸ‡¦πŸ‡ΊAustralia pameeela

Edit: going to move my comment to the specific issue.

πŸ‡¦πŸ‡ΊAustralia pameeela

@phenaproxima would you be able to create an issue for it, since it sounds like you have the direction?

πŸ‡¦πŸ‡ΊAustralia pameeela

Presumably it will have whatever styles apply to other forms though, and if you have users logging in I'd expect your login form to have some styles. I see the snippet is already updated to remove the part about the site's theme. I do think the rest can go in a follow up but just wondering about why a theme would have no styles or why this would look particularly ugly when it's just a heading and two buttons.

πŸ‡¦πŸ‡ΊAustralia pameeela

Link to the comment πŸ“Œ 10.3.0 release notes Active

Not much information to go on.

πŸ‡¦πŸ‡ΊAustralia pameeela

Link to the comment πŸ“Œ 10.3.0 release notes Active

Not much information to go on.

πŸ‡¦πŸ‡ΊAustralia pameeela

"a pretty ugly unthemed confirmation form"

It looked OK to me in testing but that was using Olivero (see screenshot in IS). I'm not sure why it would not appear in the site's theme? I think a follow up would be good with some additional details and what the proposed fixes would be to address the concern. But it would definitely be good to clarify for the release note as I think the current text is not very clear.

πŸ‡¦πŸ‡ΊAustralia pameeela

Thanks Adam! This looks good to me.

πŸ‡¦πŸ‡ΊAustralia pameeela

I think the driving factor for this was D8 readiness, but Rules got over that hurdle and now has a release for the latest version of Drupal, and there shouldn't be ongoing issues with this given the updated core release plan.

And since there has been no activity on this in years, I'm going to mark it closed. This is a great and very popular contrib module, let's not mess with what works!

πŸ‡¦πŸ‡ΊAustralia pameeela

In light of the the latest comments, I'm marking this as Closed (won't fix) since the consensus is not to progress this any further.

πŸ‡¦πŸ‡ΊAustralia pameeela

Marking this fixed since it's way beyond an idea now :) Tried to add credit for all who meaningfully contributed to the discussion, but please comment if anyone feels they missed out.

πŸ‡¦πŸ‡ΊAustralia pameeela

There's a contrib module for this for CKE5: https://www.drupal.org/project/ckeditor_emoji β†’

Is there a specific reason that this should be in core? The module reports ~250 sites. I can say in all my years I have never had a need for this, so it seems like a great contrib feature.

πŸ‡¦πŸ‡ΊAustralia pameeela

What is the specific case for including this in core? Big Menu is a great contrib solution that can be used on sites with large menus. I think it's safe to say most sites don't have this requirement, the module usage is ~6,500.

πŸ‡¦πŸ‡ΊAustralia pameeela

Beyond the practicality of this I don't really understand the need. If you see language that could be improved, you can submit a merge request to fix it. I've done this many times.

Since the OP seems to no longer have an account, I'm going to close this one for now.

πŸ‡¦πŸ‡ΊAustralia pameeela

I can see how this would be valuable for auditing a site's content structure, but I don't understand how it would be helpful in developing the structure. There would generally be 0 usage for all fields when developing, right? Or at least very low?

Again I see the value for audits/reviews but I am not sure that justifies placing this data on the page at all times. Or maybe I have misunderstood?

πŸ‡¦πŸ‡ΊAustralia pameeela

Does the current state roughly meet this vision? We have starterkit to provide a bare bones theme, and Olivero for deluxe.

πŸ‡¦πŸ‡ΊAustralia pameeela

Thanks for documenting these ideas! I am not sure what the best status is for this as none of them quite fit, but I do think it should be closed.

πŸ‡¦πŸ‡ΊAustralia pameeela

Moving this to the right queue.

πŸ‡¦πŸ‡ΊAustralia pameeela

Thanks to everyone who chimed in. Since this has been approved by a product manager and has moved into implementation, I'm going to mark this issue as fixed. Ongoing discussion should take place at #3398293: Consolidate local development environment documentation to recommend DDEV β†’ .

πŸ‡¦πŸ‡ΊAustralia pameeela

Adding credit for everyone who participated in this lively discussion :)

πŸ‡¦πŸ‡ΊAustralia pameeela

I have the same feedback as #18, was thinking about this just yesterday! But I think this feedback is probably better off going into the actual issue queue? Since it's well past the idea phase now.

πŸ‡¦πŸ‡ΊAustralia pameeela

@mindaugasd are you able to move this one over to the AI initiative project? I don't seem to be able to.

πŸ‡¦πŸ‡ΊAustralia pameeela

Thanks for proposing, this is a great idea of course. It took a few years but it has come together in the Experience Builder initiative β†’ , which pretty much maps onto this exactly.

The issue statuses don't really map that well to ideas but I've marked this as Closed (outdated) since it ended up being done elsewhere. Please feel free to update to a different status if appropriate.

πŸ‡¦πŸ‡ΊAustralia pameeela

Given that this is a full blown initiative now, we can close of the original idea. Thanks to everyone who offered to help!

πŸ‡¦πŸ‡ΊAustralia pameeela

Crediting those who contributed to the issue.

πŸ‡¦πŸ‡ΊAustralia pameeela

So are there specific changes you would propose to core to get to the point you are after? If so, a good next step would be to update this issue summary based on that, using the template suggested on the project page β†’ . The current summary (and its tone) are not super helpful along those lines.

πŸ‡¦πŸ‡ΊAustralia pameeela

I think that the module usage suggests this isn't *that* widely needed as a feature. For my part, I have needed it on occasion but it is far from an 80% use case for me.

So apart from it being used on most sites, another reason to add it to core would be to provide (or just unblock) extensibility for contrib. So if contrib can already do it, then it might be better off there? Because having it in contrib allows for faster innovation and more variety.

Production build 0.69.0 2024