Account created on 19 July 2011, over 12 years ago
#

Merge Requests

Recent comments

πŸ‡¦πŸ‡ΊAustralia pameeela

We are a bit puzzled by the suggestion that this is a duplicate of πŸ› User can't reference unpublished content even when they have access to it Needs work as it does not seem related at all. Just in case, we tried the patch from there and it did not resolve our issue.

πŸ‡¦πŸ‡ΊAustralia pameeela

each translation can essentially have their own moderation state associated with them

Having some trouble with this on nodes where we have set the 'Published status' to be untranslatable. This makes the published status sync between the translations, but the moderation state becomes mismatched. I thought I could just uncheck that too but am seeing what is reported here, it is always checked when the form loads.

Should the moderation state be translatable if the published status is not? I guess I can see how it still might be different but that doesn't make much sense in practice. Or at least, I think it is logical to want this to not be translatable.

πŸ‡¦πŸ‡ΊAustralia pameeela

Created an MR, only fair to fix my mistake!

πŸ‡¦πŸ‡ΊAustralia pameeela

pameeela β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia pameeela

The committer team facilitator approaches committers whose terms are ending (with term end dates distributed either quarterly or semi-annually). They have a private conversation about continuing as a core committer.

Sorry to complicate things but any reliance on the committer facilitator is not advisable. There as only ever been one person (me) to hold this role for more than a few months despite several attempts to recruit. I think we would need at least two people actively doing the role before we can make it a key part of the team governance.

πŸ‡¦πŸ‡ΊAustralia pameeela

I could not agree more with #3367191-75: Speed up decision making: define the project lead as an arbitrator/tie breaker instead of ultimate decision maker β†’ . I admittedly have not been across the full discussion, but it feels like we are trying to get it perfect before making any changes. I wonder whether the governance process being so slow in the past is resulting in folks being concerned with getting it exactly right because we may only have one shot.

I would encourage aiming for good over perfect. Being able to adapt more easily seems like the goal here, so if we find that the changes have created a new problem or failed to address an existing one, we can iterate on it.

πŸ‡¦πŸ‡ΊAustralia pameeela

On trying to reproduce from scratch, I did get a warning that the role would be deleted:

So maybe I ignored the warning on the first pass.

πŸ‡¦πŸ‡ΊAustralia pameeela

I've just hit this issue on a site. We uninstalled EB and switched to media library. Any role that contained EB permissions was deleted and recreated on config import, which meant that any users who had the role lost it.

I haven't investigated yet but sounds similar to πŸ› Roles can be deleted when upgrading from 9.5 to 10 if a module had removed permissions Active ? Although in this case it wasn't removing non-existent permissions. The previously granted permissions are valid, they just are for a module that is uninstalled.

πŸ‡¦πŸ‡ΊAustralia pameeela

Actually adding credit this time!

πŸ‡¦πŸ‡ΊAustralia pameeela

I was for disabling the fallback but I really like @ericjenkins' idea of showing the Drupal version. I think that would be useful info to highlight, whereas the deploy ID is really really not.

πŸ‡¦πŸ‡ΊAustralia pameeela

Patch applies still, setting to NR.

πŸ‡¦πŸ‡ΊAustralia pameeela

Just hit this on a D10 site, here is the updated command:
drush php-eval "\Drupal::service('update.update_hook_registry')->setInstalledVersion('password_policy', 8301)"

πŸ‡¦πŸ‡ΊAustralia pameeela

Am I the only one finding the custom breadcrumbs aren't working in D10? Have a site using it just fine in D9 and with this latest MR for D10, I can't get even the simplest custom breadcrumb to work.

πŸ‡¦πŸ‡ΊAustralia pameeela

pameeela β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia pameeela

Just realised there was no MR for this so I created one.

πŸ‡¦πŸ‡ΊAustralia pameeela

This description seems fine, it's not really what I've been doing but it's what we could use :)

πŸ‡¦πŸ‡ΊAustralia pameeela

I know Lee is away all month but maybe @acbramley or @dpi could give us a review :)

πŸ‡¦πŸ‡ΊAustralia pameeela

I didn't realise that the committer team facilitator role didn't officially exist!

I've discussed this elsewhere with several people but my main bit of feedback is that it's not realistic to perform this job as described with 10-15 hours per month.

It seems strange having this conversation now, having now been in the role since 2019, but I am not sure how best to move this forward.

πŸ‡¦πŸ‡ΊAustralia pameeela

Thanks for everything Angie, you will be missed! Just gave you a shoutout during my contribution talk at DrupalSouth (with larowlan), throwing back to my first core patch in 2013. Your encouraging comments meant a lot to me then, and definitely helped make me feel like I belonged and was welcome.

Sorry to see you go and hope to see you back sometime :)

πŸ‡¦πŸ‡ΊAustralia pameeela

Created an MR with the updated path, this seems to work for me.

πŸ‡¦πŸ‡ΊAustralia pameeela

This is definitely covered by the many other related issues; so I'm closing this to avoid duplicated work.

πŸ‡¦πŸ‡ΊAustralia pameeela

I don't understand the issue being reported here. If you are still having this issue please update the issue summary with steps to reproduce β†’ and set the issue back to Active.

πŸ‡¦πŸ‡ΊAustralia pameeela

This URL is working fine at the moment, although it does redirect to https://signup.dropout.tv/

So I think these examples should be updated, since the videos are not actually available.

πŸ‡¦πŸ‡ΊAustralia pameeela

I'm not able to reproduce this on D10. Steps I followed:

  1. Edit layout on a node
  2. Create an inline block with HTML
  3. Save block
  4. Edit block before saving node

The block text appears as expected, without visible HTML.

πŸ‡¦πŸ‡ΊAustralia pameeela

This is still the case, but the patch to remove the default value breaks the node add form with:
InvalidArgumentException: The timestamp must be numeric. in Drupal\Component\Datetime\DateTimePlus::createFromTimestamp() (line 201 of core/lib/Drupal/Component/Datetime/DateTimePlus.php).

πŸ‡¦πŸ‡ΊAustralia pameeela

To clarify, I wasn't suggesting that we *should* wait for it to be marked fixed, I was just trying to understand what the possible paths forward are.

πŸ‡¦πŸ‡ΊAustralia pameeela

Sorry, I posted my reply before I saw yours! Understood and I think we both recognise that the review is not strictly about security-related blockers.

It seems there is a genuine debate about the current coding standard, so I was just weighing in on that.

πŸ‡¦πŸ‡ΊAustralia pameeela

@apaderno thanks for coming back to us but just wondering what it will take to resolve this?

If the other issue is marked fixed would that be sufficient to progress as is? Or are there any other blockers?

πŸ‡¦πŸ‡ΊAustralia pameeela

So I read the existence of #3295249: Allow multi-line function declarations β†’ as an indication that there is currently no standard for this. The purpose of that issue was to decide whether to allow them or not. Option A is to adopt the PSR-12 standard, and option B is to adopt a standard not to allow multi-line function declarations.

If #3295249: Allow multi-line function declarations β†’ were leaning toward option B, then this probably should be changed. But option A has been agreed and the issue is RTBC so it certainly seems safe to assume it will be adopted.

In the interest of moving things forward, @apaderno, would you remove your objection only if the issue to adopt the standard is marked fixed?

πŸ‡¦πŸ‡ΊAustralia pameeela

Switching back to bug report since there is a patch that needs committing.

πŸ‡¦πŸ‡ΊAustralia pameeela

Just came across this issue as it's the oldest open bug in core. One thing that jumps out to me is that 8 years ago in #82751-50: Impossibility to add HTML in node title field violates accessibility/WAI criteria β†’ @effulgentsia notes that about 4,000 people were using the contrib module HTML Title β†’ . That stat is currently ~4,571 so not much of a change in that time.

Anyway, at that point, the decision seemed to be to not address this in core, but does that need to be re-assessed? I think it would be good to get some input on that before any work is done.

πŸ‡¦πŸ‡ΊAustralia pameeela

Closing this now for lack of relevant updates in 2+ years. If this is still occurring in a supported version of Drupal, please create a new issue with details.

πŸ‡¦πŸ‡ΊAustralia pameeela

Closing as it's been almost 2 years since the initial triage, and almost 1 year since the follow up. Best to create a new issue based on the current state if there are still suggestions for improvement.

πŸ‡¦πŸ‡ΊAustralia pameeela

Going to bite the bullet and close this, as I think it's too outdated to be useful. If anyone feels the current functionality needs modification for usability, it will be best to create a new issue with suggestions.

πŸ‡¦πŸ‡ΊAustralia pameeela

I have confirmed this works, so that's a good, simple solution. Tested the full guide and it works through to a functioning local site :)

Thanks!

πŸ‡¦πŸ‡ΊAustralia pameeela

Made an updated MR with the changes from #2912824-22: Inappropriate trailing colons in Claro and Umami β†’ just applied to the current core themes.

πŸ‡¦πŸ‡ΊAustralia pameeela

Yeah, confirmed it occurs with the regular 'Autocomplete' widget and not the tags style one.

πŸ‡¦πŸ‡ΊAustralia pameeela

I’m not sure, since it’s sticking to the existing color scheme, and changing that is definitely out of scope.

πŸ‡¦πŸ‡ΊAustralia pameeela

Yeah, #3283803-12: [upstream] CKE5 toggleable toolbar items not enough contrast β†’ explains the current active state behaviour which is handled upstream in CKEditor.

πŸ‡¦πŸ‡ΊAustralia pameeela

@smustgrave this issue adds an outline matching the existing color scheme, so I think changing the color scheme should be a separate issue?

πŸ‡¦πŸ‡ΊAustralia pameeela

Added #3068696: Tables overflow on mobile β†’ as related. To answer @smustgrave I think the horizontal scroll is the only way to fix this particular issue without some other, major changes to responsive tables, which are out of scope for this issue.

πŸ‡¦πŸ‡ΊAustralia pameeela

Still needs some grammar fixes, I will give a proper review a bit later.

πŸ‡¦πŸ‡ΊAustralia pameeela

Interesting suggestion, I like it! Just wondering about the effect on existing sites? Do we need to include an update to set the value to /user/login if it is blank in an existing site? Would be a bit confusing to be forced to set this with no explanation when updating the site settings at some point in the future.

Production build https://api.contrib.social 0.61.6-2-g546bc20