Umami experimental profile warning shouldn't vary by route

Cleaned up the IS slightly.

Re-ran the test failures and Javascript + nightwatch were random (shocker)

Applied the patch locally with Umami install and didn't notice any issues. Believe the removal is fine. Going to mark but

It would be possible to move this into a #lazy_builder so it doesn't affect navigation cacheability, but I don't really see why the admin toolbar should behave differently based on different pages.

Should this be a follow up?

If we go ahead here, we don't need the #lazy_builder approach IMO.

@smustgrave Did you also test Umami without the patch and verify the bug? If you happen to catch it in action, screenshots would be cool.

Aside from that, is this actually making the warning displayed on all pages rather than admin pages? If so, that change would need product signoff. Could a manual tester confirm whether the warning is present on all pages or just admin pages with the patch?

Thanks!

Aside from that, is this actually making the warning displayed on all pages rather than admin pages?

Yes.

OK, in that case we'll definitely need screenshots of the new behavior, and product manager review. :) The warning on admin pages only was a long negotiation between us and them IIRC.

Added screenshots.

Note that without this change the vertical alignment of the items beneath the warning message keeps changing when you go in and out of admin pages.

I haven't tested this, but as an Umami maintainer I have no problem with us showing the warning messages on the navigation on all pages rather than just admin pages.

The reason it was on admin pages only was - iirc - so people wouldn't start site building on top of Umami.

Tested this on a fresh D11 install of Umami profile
Installed navigation module
Verified on the homepage that I don't see "This site is intended for demonstration purposes." in the navigation toolbar
I applied the MR
cleared cache
Verified on the homepage that I do now see "This site is intended for demonstration purposes."

Screenshots are roughly the same as #10 and don't want to re-upload the same stuff :)

Removing manual tag

Drupal CMS is the primary thing promoted now on drupal.org. From DrupalCon Vienna (2025 October) onwards that will include Umami-like things (known as site templates) that are built-out demo sites of sorts but more complete and include contributed projects and Experience Builder. So the age of Umami is pretty much over at that point as it is unfortunately. I think ideally it is moved to contrib and could flourish as a site template built on XB (keeping the recipes, photos and all that people took so much precious time building). In that light I think investing time into making the core Umami demo better is not necessarily the best thing to do.

There is 📌 Make Umami a testing profile (not shown to users) in preparation of moving to contrib Active and 📌 Deprecate and remove the Umami demonstration profile from core, make it a contributed site template Active .

That said, if people want to invest time into this, I don't think it is a problem at all to change this. So removing the needs product manager tag.

smustgrave → credited ckrina → .

smustgrave → credited pameeela → .

Thanks @gabor! Also crediting ckrina, pameeela for the slack conversation.

Since the work is already done going to mark and look at the ticket about making Umami hidden.

Agreed with #13 and #14 the main reason I opened this is because it's a regression in 11.2, so until the other issues are done it seemed worth fixing.

Adding credits for maintainer signoffs, and for @smustgrave for manual testing.

Committed to 11.x, and backported to 11.2.x since it's fixing a regression in the demo profile, which has a relaxed BC policy anyway. Thanks everyone!