Warning: Invalid argument supplied for foreach() with Better Exposed Filter & Grouped Filter

Should this be reopened based on previous comments? Anyone able to replicate on D10?

I've tried to reproduce using the info in the IS on 10.2 and no luck, not seeing any warnings with this config. The steps in #12 are not clear enough to test them. If this is still occurring could someone please update the issue summary with specific steps to reproduce it?

Discussed in Slack, will create an MR with a modified fix.

Created an MR to add a check that $values is an array. There is no test here because it would be very difficult to come up with one, so hoping it qualifies for an exemption given both the simplicity of the fix and the fact that it is only resolving a warning.

pameeela → credited chx → .

Crediting @chx for Slack participation.

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

Hiding patches

Wondering if we the summary could be updated with proposed solution from the slack channel.

The MR is pretty straightforward but I added a line about the proposed resolution. Not sure if that is what you mean @smustgrave?

Yup just because not everyone is in slack so any discussion there isn’t known

Meant to mark this a few days ago.

I read the issue summary, comments and the MR. I see there are no tests, but that is explained in #19. I have not evaluated that with the testing heuristics. A reminder to us all to summary Slack discussions in a comment. There is no indication here why $value is not an array or if that is really a contrib problem.

Also, trying for a better title. Leaving at RTBC.

Better title, I hope.

I'm inclined to mark this won't fix as it feels that exposing a single checkbox for a views filter that expects multiple values is not correct.

i.e. I don't think BEF should allow using a single checkbox for any filter plugin that extends from InOperator

In addition I don't think the fix is correct. Rather than casting a single value to an array, its just ignoring the value and hence the submitted value will not be seen. So I think that would mean the filter doesn't work at all.

As maintainer of BEF @smustgrave is there scope for it to prevent assigning a single-value field to a multi-value filter?

If we can fix in BEF I'm fine with that.

smustgrave → closed merge request !8725