[upstream] Support full-screen editing - distraction free mode when it is available upstream

@cmcnamee did you remove the tag wcag336 on purpose? Looks like it was accidental so am adding it back.

That's strange, I didn't even expand the metadata box when commenting, so I'm not sure how the tag got removed. Thanks for adding it back in.

Sometimes it is just bad timing..

thanks for looking into this! Highly appreciated!

Sorely missed. I guess I won't be using CK5 until I have to.

Thanks for considering this. It's essential to many content editors that I'm working with.

In case anyone is interested, I've taken the plunge and adapted the plugin mentioned by @joelpittet in #10 📌 [upstream] Support full-screen editing - distraction free mode when it is available upstream Active and created it as a standalone project → for now.

Thank you @Occupant - that module is perfect for our needs.

A

https://www.drupal.org/project/ckeditor5_fullscreen →

Wim Leers → credited witeksocha → .

I learned yesterday that https://www.drupal.org/project/ckeditor5_premium_features → contains a free to use feature that addresses this:

Full screen mode
The full screen mode is a free-to-use plugin that maximizes the editing area. It is especially useful when using features like Document outline or Comments which take up extra space around the editor.

(It was actually announced by @witeksocha 2 weeks ago at https://github.com/ckeditor/ckeditor5/issues/1235#issuecomment-1783119311.)

See https://git.drupalcode.org/project/ckeditor5_premium_features/-/blob/1.2...

What do people think?

Tested the module and seems to be working

> What do people think?

How hard would it be to extract the fullscreen feature into its own contrib module (or into core), so as not to confuse end user admins who are not interested in premium features. Would a Drupal maintainer then need to maintain the plugin JS ourselves as a fork?

@smustgrave What does "RTBC" mean here to you? That we don't need to fix it in core?

+1 to #24. If the plugin is free to use, it should be separated from the rest of the "pay to use" plugins, as it is confusing to be required to pay for all except one of the included plugins under a nomenclature of "premium".

I've tried out the fullscreen feature on a local site and it's pretty much exactly what our users want, so it would be nice if it was standalone.

What’s there to fix in core?

And agree with the last few comments. I don’t want the paid module for one feature. And is there agreement that wouldn’t become paid later?

I almost missed comment #20. We have https://www.drupal.org/project/ckeditor5_fullscreen → contrib module that works without the “premium” module getting in the way. Of course the premium module is supported by the core CKE team, however, seems like it may be more resilient to go with a standalone module (which depends on a cke contrib plugin) that would presumable be deprecated and have a max Drupal version constraint added once Drupal core supports a version of CKEditor where they’ve actually built this plugin into the upstream CKE core at some future date.

If anything, the issue status here seems like it has to be "postponed", and then would automatically go to "closed (outdated)" once we update to said CKE version in core.

Agree this could be closed out once upstream is updated and we update core.

My understanding is that they will not be adding this to "CKEditor 5 core", because there are reasons for why they cannot make this feature work universally. I didn't dig in deep, but my high-level understanding is that every "integrator" of CKEditor 5 would have to build their own full screen mode, it just happens to be that they wrote one for us and are shipping it in that "Premium Features" module.

So, I don't think makes sense in that case. Unless/until we can convince them to eventually add it to "CKEditor 5 core".

We will not be adding it now but it's still in our plans to provide this feature in the core.

Creating a module for Drupal was just faster and easier for us, as we didn't need to think about all corner cases and editor types.

FWIW, full screen mode is already provided in the official CKEditor 5 Plugin Pack as a “premium plugins available for free”: https://www.drupal.org/project/ckeditor5_plugin_pack →

I would vote for having the full screen feature inside CKEditor 5 core. Any idea, tentatively when this feature will be incorporated in CKEditor 5 core?

CKEditor 45.0.0 has been released with support for full screen mode: https://github.com/ckeditor/ckeditor5/releases/tag/v45.0.0
I opened 📌 Update CKEditor 5 to 45.0.0 Active to update CKEditor in core.

Fixing attribution.

IS seems incomplete

But question why do we need this when https://www.drupal.org/project/ckeditor5_plugin_pack → offers fullscreen?

Hi @smustgrave,

In the latest Drupal releases (10.5.2 and 11.2.2) using CKEditor5 v45.2.0, the Fullscreen feature is intended to be part of core. While the button is referenced and the related functionality appears to be present in the codebase, the actual CKEditor 5 plugin code required to enable Fullscreen is missing.

The following merge request addresses this issue by properly including the plugin implementation in core:
🔗 merge request !12406

Once this is merged, the Fullscreen button will become available in the CKEditor 5 Toolbar configuration interface as expected.

Hope it will be included in the next release.

Tagging for approval but this MR isn’t ready to be merged yet. Missing test coverage