- 🇳🇿New Zealand ericgsmith
I believe the issue is that currently users may have
<ul type>enabled in source editing, but not
With the introduction of this plugin you would not be able to do that - if you left the plugin option disabled and tried to add
<ul type>to the source editing you would get this validation error:
The following attribute(s) are already supported by enabled plugins and should not be added to the Source Editing "Manually editable HTML tags" field: List (
I agree we shouldn't need to wait for CKEditor to proceed with this, but I do think this scenario is another use case for reverting the validation of optional attributes that requires you to use the plugin 🐛 CKEditor5 breaks when "Source"/Source editing button is added and "Manually editable HTML tags" are specified Active
- 🇺🇸United States neclimdul Houston, TX
Do we need to hang this on a ckeditor feature with an indeterminate timeline? Seems like we could provide this as a feature with the caveat and support the new feature after ckeditor supports. That would provide some immediate functionality for people that can use it as is but also highlight the feature request to more users.
With that in mind though, we should probably default this off and make sure administrators opt in and understand what they're opting in to.
A quick test of the merge request, this seems to work pretty well as a user. Very nice!
- 🇳🇿New Zealand jweowu
I don't understand the argument that making this an option is currently problematic.
Sure, in its current state such an option would mean "enabled for both ul and ol" or "disabled for both ul and ol", and some users might want only one or the other. But at the moment those users don't have any way to do that, so they'll be no worse off. Meanwhile the other users who want it enabled for both ul and ol also don't have any way to do that, and their requirement could be fulfilled. (And I'm struggling to imagine that the latter would not be the majority.)
This would in no way preclude a more granular config down the track, and in the interim it would resolve the issue for lots of people.
- 🇺🇦Ukraine Taran2L Lviv
hi @acbramley, we had a discussion with @Wim Leers the other day in Slack: https://drupal.slack.com/archives/C1BMUQ9U6/p1708010000803059
> The problem is that not having that choice from the start means that some sites who only want
- and not
- (or vice versa) will see it appear on both. And so then they’re allowing markup that they don’t want to allow. We don’t want to force that upon them.
So, probably this is no go for now. Don't know
My response is that: this fix is a direct upgrade path from
- 🇦🇺Australia acbramley
#63 is now fixed with the latest MR changes - thanks @Taran2L!
The MR is green too, should we consider unpostponing?