Yerevan, Armenia
Account created on 25 June 2007, over 18 years ago
#

Merge Requests

More

Recent comments

🇦🇲Armenia murz Yerevan, Armenia

And to make the list of themes more compact, let's show them as a horizontal list separated by '|' like this:

Bootstrap [Used as default] | Bootstrap5 [Set as default] | Bootstrap Barrio | Radix | ...

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Fixed.

🇦🇲Armenia murz Yerevan, Armenia

Seems this is not possible from the technical side because of the limitation of the initial architecture of the Layout Builder components. So, the Drupal community rethought this approach from scratch and re-implemented it as Drupal Canvas https://www.drupal.org/project/canvas

Therefore, seems all new efforts will be invested into developing Drupal Canvas, instead of improving the Layout Builder ;(

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Implemented.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Implemented.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Implemented.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

I would like to opt-in this module:
https://www.drupal.org/project/commercetools - it has 84 issues, and all maintainers agree we are ready to try GitLab issues.
We understand we cannot revert this change and there may be some unexpected issues as early adopters.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

I prepared a MR with adding the langcode: en to the config/install, please review.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

Seems I found the source of the problem! We have the logic that adds the missing items that are active inside the "if" condition in the file src/Plugin/facets/query_type/SearchApiString.php:

  public function build() {
...
    if (!empty($this->results)) {
      // Add unprocessed active values to the result. These are selected items
      // that do not match the results anymore.
      foreach ($unprocessed_active_items as $val) {
...
    }
  }
}

So, it is simply skipped if no results are retrieved from the facet. And moving it outside of this condition fixes the issue.

I created a fix in the MR https://git.drupalcode.org/project/facets/-/merge_requests/341 - please review the approach, is it right?

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

Alexey Korepov (@murz): working on AI Observability, logging, and Usage Reports ( Add default views to the AI Logging module Active ).

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

I would like to opt-in these modules:
https://www.drupal.org/project/logger - it has 6 issues, and all maintainers agree we are ready to try GitLab issues.
https://www.drupal.org/project/logger_db - it has 6 issues too, and all maintainers agree we are ready to try GitLab issues.
We understand we cannot revert this change and there may be some unexpected issues as early adopters.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

Also, would be great to simplify the inclusion of the original Twig file from the SDC component to override only parts of it. Usually, theme developers want to just extend the base Twig file, instead of producing a totally new Twig from scratch.

Now it is possible, but you have to provide a full path to the component like this:

{{ include('@my_module/components/my_cool_component/my_cool_component.twig') }}

instead of just its name like this

{{ extend ('@my_module/my_cool_component') }}
🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

I reworked the View to extract all the needed data from the log entry and add filters, now it looks much more useful and powerful, see:

Please review and test it locally.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

The time field in PostgreSQL stores only time, not date, so using timestamp(6) to store the time with microsecond.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

The database logger storage is moved to a separate project, this feature will be implemented in Export logs to file and import with deduplication Active

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

The database logger storage is moved to a separate project, this feature will be implemented in Allow configuring indexes for JSON fields Active

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Implemented in a reworked version of the module - get it here https://www.drupal.org/project/logger

🇦🇲Armenia murz Yerevan, Armenia

Implemented in a reworked version of the module - get it here https://www.drupal.org/project/logger - see the issue Add support for logging the request UUID Active

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Implemented choosing the log level on the per-plugin level in a reworked version of the module - get it here https://www.drupal.org/project/logger

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Implemented in the reworked version of the module with a new name "Logger" - see the issue Allow logging to several log targets at once Active

🇦🇲Armenia murz Yerevan, Armenia

The idea is cool, but worth being a separate module!

So, I implemented it as a 3.x branch in a separate module "Request Logger" - get it here: https://www.drupal.org/project/request_logger

🇦🇲Armenia murz Yerevan, Armenia

By the way, the Prettier Plugin for Twig has an issue with formatting constructions like <div{{ attributes }}> - more details here: https://github.com/zackad/prettier-plugin-twig/issues/139

So, if we're fixing there other styling issues, maybe fix this one too?

P.S. I need to use the Prettier Plugin for Twig to get automatic formatting in VS Code, cuz still can't manage to make this work with "twig-cs-fixer".

🇦🇲Armenia murz Yerevan, Armenia

Released the 3.0 alpha version with new features. Let's close this as fixed.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Fixed.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Implemented.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Implemented

🇦🇲Armenia murz Yerevan, Armenia

However, I wonder if it would be possible to somehow still link errors to their corresponding requests.

This feature is implemented in the MR https://www.drupal.org/project/logger/issues/3551603 Add support for logging the request UUID Active

🇦🇲Armenia murz Yerevan, Armenia

Implemented.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

Implemented.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Implemented.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia
🇦🇲Armenia murz Yerevan, Armenia

Implemented.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

Prepared a MR, please review.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

I created a draft of the MR with the quick implementation of the idea: https://git.drupalcode.org/project/request_logger/-/merge_requests/3

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz created an issue.

🇦🇲Armenia murz Yerevan, Armenia

murz changed the visibility of the branch 3514236-chore-check-for to active.

Production build 0.71.5 2024