vipul tulse → created an issue.
Please check video
Yes I have used ckeditor liststyle earlier, but then Drupal 10.3.0 includes the list style type option into core, so removed contrib module.
Unless I install the plugin pack module it is working fine, once I'm installing the module it removing the style.
vipul tulse → created an issue.
vipul tulse → created an issue. See original summary → .
Yes, this is an issue with our preprocessor function where we are altering the html, closing this for working as expcted
Added the new build for find and replace, tested on local working fine for me.
Please verify
vipul tulse → created an issue.
Im also getting error
ckeditor5-dll.js?v=41.3.1:5 Uncaught TypeError: Cannot read properties of null (reading 'disableCssTransitions')
at n.on.priority (find-and-replace.js?shf7cj:488:40)
at $e.fire (ckeditor5-dll.js?v=41.3.1:5:663135)
at $e.set [as isOpen] (ckeditor5-dll.js?v=41.3.1:5:665707)
at Ue. (ckeditor5-dll.js?v=41.3.1:5:523921)
at Ue.fire (ckeditor5-dll.js?v=41.3.1:5:663135)
at M (ckeditor5-dll.js?v=41.3.1:5:664785)
at Ue.fire (ckeditor5-dll.js?v=41.3.1:5:663305)
at f. (ckeditor5-dll.js?v=41.3.1:5:505369)
at ue.s (ckeditor5-dll.js?v=41.3.1:5:491979)
at ue.fire (ckeditor5-dll.js?v=41.3.1:5:663135)
Yes, it is not data loss, but it is breaking a normal working mechanism. No user can add two blockquote sequentially.
see below example how its breaking content editing experiance
I have added below text
Post save what i can see
This is simple example it is breaking in many cases.
Still, you don't think this is a critical issue?
@cilefen Why for 11, it is critical issue in 10 right?
vipul tulse → created an issue.
Rerolled patch for Drupal 10.3.0
Team any plan to work on this issues
@kerasai Thete is a way to create CKEditor 5 plugin structure when we do some changes to the plugin code we build though the webpack for that we need proper webpack and we found security issue with packages inside package.json are older while security audit, we have upgraded that. https://git.drupalcode.org/project/ckeditor_font/-/merge_requests/20/dif...
Last one the current plugin missing the color picker implementation you can see below screenshot
@gisle Guys any plan to release new version with this issue
This request not needed as after CKEditor plugin implementation used latest package
vipul tulse → created an issue.
vipul tulse → created an issue.
vipul tulse → created an issue.
Added the upgrade-transitive-dependencies for braces and glob upgrade to remove inflight
Please use latest patch, now require js is the only issue(https://github.com/requirejs/r.js/issues/1015)
Created build and test, looks good.
Please ignore the above patch, which has issues.
Updated packages and yarn run build
Tested after upgrade build looks good
Added below override dependencies.
"resolutions": {
"raw-loader/loader-utils": "2.0.4",
"raw-loader/json5": "2.2.2",
"@ckeditor/ckeditor5-dev-utils/del/globby/glob": "10.3.16",
"@ckeditor/ckeditor5-dev-utils/del/rimraf/glob": "10.3.16",
"@ckeditor/ckeditor5-dev-utils/@ckeditor/ckeditor5-dev-translations/rimraf/glob": "10.3.16",
"@ckeditor/ckeditor5-dev-utils/terser-webpack-plugin/serialize-javascript": "6.0.2",
"@ckeditor/ckeditor5-dev-utils/shelljs/glob": "10.3.16",
"@ckeditor/ckeditor5-dev-utils/terser-webpack-plugin/cacache/glob": "10.3.16"
}
Latest patch to resolve the
------------------------------
json5 Prototype Pollution
VULNERABILITY
CWE-1321OPEN THIS LINK IN A NEW TAB
CVE-2022-46175OPEN THIS LINK IN A NEW TAB
CVSS 6.4OPEN THIS LINK IN A NEW TAB MEDIUM
SNYK-JS-JSON5-3182856
------------------------------
loader-utils Prototype Pollution
VULNERABILITY
CWE-1321OPEN THIS LINK IN A NEW TAB
CVE-2022-37601OPEN THIS LINK IN A NEW TAB
CVSS 7.5OPEN THIS LINK IN A NEW TAB HIGH
SNYK-JS-LOADERUTILS-3043105
------------------------------
loader-utils Regular Expression Denial of Service (ReDoS)
VULNERABILITY
CWE-1333OPEN THIS LINK IN A NEW TAB
CVE-2022-37599OPEN THIS LINK IN A NEW TAB
CVSS 5.3OPEN THIS LINK IN A NEW TAB MEDIUM
SNYK-JS-LOADERUTILS-3042992
------------------------------
loader-utils Regular Expression Denial of Service (ReDoS)
VULNERABILITY
CWE-1333OPEN THIS LINK IN A NEW TAB
CVE-2022-37603OPEN THIS LINK IN A NEW TAB
CVSS 5.3OPEN THIS LINK IN A NEW TAB MEDIUM
SNYK-JS-LOADERUTILS-3105943
------------------------------
docroot/modules/contrib/ckeditor_font/js/package.json decode-uri-component 0.2.0 high ["CVE-2022-38900"] js npm
docroot/modules/contrib/ckeditor_font/js/ckeditor5_plugins/ckeditor5-font/package.json micromatch 4.0.5 high ["CVE-2024-4067"] js npm
docroot/modules/contrib/ckeditor_font/js/package.json micromatch 3.1.10 high ["CVE-2024-4067"] js npm
docroot/modules/contrib/ckeditor_font/js/package.json loader-utils 1.4.0 high ["CVE-2022-37601"] js npm
docroot/modules/contrib/ckeditor_font/js/package.json unset-value 1.0.0 high [] js npm
docroot/modules/contrib/ckeditor_font/js/package.json nth-check 1.0.2 high ["CVE-2021-3803"] js npm
docroot/modules/contrib/ckeditor_font/js/package.json semver 6.3.0 high ["CVE-2022-25883"] js npm
docroot/modules/contrib/ckeditor_font/js/package.json webpack 5.73.0 high ["CVE-2023-28154"] js npm
docroot/modules/contrib/ckeditor_font/js/package.json braces 2.3.2 No remediation path available. high ["CVE-2024-4068"] js npm
Above the issues in the package.json, team any update on upgrading those packages
Updated patch to resolve @babel/traverse crtical issues
Patch with package upgrade and new build with latest packages
@team any update on this as this is critical issue if we use plugin with VULNERABILITY and synk show arround 42 issues
Added patch for upgrade latest packages and build
Check lot of issues in sass lint and ls lint we need to remove those packages
vipul tulse → created an issue.
vipul tulse → created an issue.
vipul tulse → created an issue.
vipul tulse → created an issue.
vipul tulse → created an issue.
vipul tulse → created an issue.
Hello Team,
Any plan to release this fix.
@s_leu there one issue I'm facing, unable to add a code block inside list
can you check
Still, I can see the video is there in the issue, please delete the video, which I have marked hidden
vipul tulse → created an issue.
vipul tulse → created an issue.
@Dylan Donkersgoed can you make me maintainer for Drupal 10 branch so will add library inside module to instead of dependent other Git repo
Please check attached image.
When you do edit in the node and make the changes to the node body where the Creditor available and try to refresh the page, it is not asking me the Reload Page? browser popup.
I will make video and post for more information.
vipul tulse → created an issue.
@DamienMcKenna we have PR for empty anchor edit, please review and merge into the 3.0
Or Please ad me to module maintainer I will do it.
I have added few comments with code fix which we need to do in the code changes.
Thanks for the great work.
This is issue with drupalImage core plugin, so closing this issue
vipul tulse → created an issue.
@handkerchief Can guide us which additional template file you changes/deleted
Hello Team, Anyone has got chance to work on this.
If any one has idea how we can accomplish this please guide here.
Committed Thanks !
vipul tulse → created an issue.
Hello smulvih2, Did you got any chance to review my MR
vipul tulse → created an issue.
Please use 8.x-1.x branch for review
You can review my existing module for d8 and d9
https://www.drupal.org/project/privacy_docs_world_map →
https://git.drupalcode.org/project/privacy_docs_world_map
Hello Team,
Corrected the git repo branch name with fixes if Drupal coding standard.
Please review branch 8.x-1.x
https://git.drupalcode.org/project/ckeditor5_show_block/-/tree/8.x-1.x?r...
Yes this is already in progress
https://www.drupal.org/project/projectapplications/issues/3385262 →
Created new branch 8.x-1.5 from master, please review
I
vipul tulse → created an issue.
Hello smulvih2, Please review the MR.
I have rewritten the whole plugin with dialog, will commit the change soon
Added the css and Committed with new release thanks !
Guys any plan to work on this?
Hey team
Any update on this issue
Fixed and committed, Thanks!
vipul tulse → created an issue.
Currently created contrib module to support
https://www.drupal.org/project/ckeditor5_show_block →
Hello s_leu,
I have cloned the module and enabled it locally, the module working fine and covers all the functionality from the existing module
list type (e.g. circle, square, dot for bulleted list or decimal, lower/upper roman, lower/upper alpha for numbered list)
start number (for numbered list).
Please check the screenshot, all the options working fine