- Issue created by @vipul tulse
- 🇮🇳India vishal.kadam Mumbai
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPractice
on the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
- If you have not done it yet, you should run
- Status changed to Postponed: needs info
about 1 year ago 5:40am 5 September 2023 - 🇮🇳India vishal.kadam Mumbai
Neither
master
,css-fix
norissue-fix
are correct branch names.The
8.x-1.5
branch the title suggest to review does not exist. Which branch should be reviewed? - Status changed to Needs review
about 1 year ago 10:47am 5 September 2023 - 🇮🇳India vipul tulse
Created new branch 8.x-1.5 from master, please review
I - Status changed to Needs work
about 1 year ago 11:37am 5 September 2023 - 🇮🇳India vishal.kadam Mumbai
1.
8.x-1.5
is a wrong branch name, as branch names end with the literal .x. That branch needs to be removed. It should be8.x-1.x
2. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ckeditor5_show_block/ FILE: ckeditor5_show_block/README.md ----------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------- 3 | WARNING | [ ] Line exceeds 80 characters; contains 215 characters 5 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters 5 | ERROR | [x] Expected 1 newline at end of file; 2 found ----------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------- FILE: ckeditor5_show_block/js/build/README.txt ------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------ 1 | ERROR | [x] Expected 1 newline at end of file; 0 found ------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------ FILE: ckeditor5_show_block/js/ckeditor5_plugins/showblock/theme/showblocks.css ------------------------------------------------------------------------------ FOUND 28 ERRORS AFFECTING 28 LINES ------------------------------------------------------------------------------ 2 | ERROR | [ ] Style definitions must end with a semicolon 6 | ERROR | [ ] Style definitions must end with a semicolon 24 | ERROR | [ ] Style definitions must end with a semicolon 42 | ERROR | [ ] Style definitions must end with a semicolon 60 | ERROR | [ ] Style definitions must end with a semicolon 77 | ERROR | [x] Multiple selectors should each be on a single line 78 | ERROR | [ ] Style definitions must end with a semicolon 81 | ERROR | [x] Multiple selectors should each be on a single line 89 | ERROR | [x] Multiple selectors should each be on a single line 97 | ERROR | [ ] Style definitions must end with a semicolon 115 | ERROR | [ ] Style definitions must end with a semicolon 133 | ERROR | [ ] Style definitions must end with a semicolon 151 | ERROR | [ ] Style definitions must end with a semicolon 169 | ERROR | [ ] Style definitions must end with a semicolon 187 | ERROR | [ ] Style definitions must end with a semicolon 205 | ERROR | [ ] Style definitions must end with a semicolon 223 | ERROR | [ ] Style definitions must end with a semicolon 241 | ERROR | [ ] Style definitions must end with a semicolon 259 | ERROR | [ ] Style definitions must end with a semicolon 277 | ERROR | [ ] Style definitions must end with a semicolon 295 | ERROR | [ ] Style definitions must end with a semicolon 313 | ERROR | [ ] Style definitions must end with a semicolon 331 | ERROR | [ ] Style definitions must end with a semicolon 349 | ERROR | [ ] Style definitions must end with a semicolon 366 | ERROR | [x] Multiple selectors should each be on a single line 367 | ERROR | [ ] Style definitions must end with a semicolon 370 | ERROR | [x] Multiple selectors should each be on a single line 377 | ERROR | [x] Multiple selectors should each be on a single line ------------------------------------------------------------------------------ PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------ FILE: ckeditor5_show_block/css/build/show_block.css ------------------------------------------------------------------------------ FOUND 30 ERRORS AFFECTING 30 LINES ------------------------------------------------------------------------------ 2 | ERROR | [ ] Style definitions must end with a semicolon 6 | ERROR | [ ] Style definitions must end with a semicolon 24 | ERROR | [ ] Style definitions must end with a semicolon 42 | ERROR | [ ] Style definitions must end with a semicolon 60 | ERROR | [ ] Style definitions must end with a semicolon 77 | ERROR | [x] Multiple selectors should each be on a single line 78 | ERROR | [ ] Style definitions must end with a semicolon 81 | ERROR | [x] Multiple selectors should each be on a single line 89 | ERROR | [x] Multiple selectors should each be on a single line 97 | ERROR | [ ] Style definitions must end with a semicolon 115 | ERROR | [ ] Style definitions must end with a semicolon 133 | ERROR | [ ] Style definitions must end with a semicolon 151 | ERROR | [ ] Style definitions must end with a semicolon 169 | ERROR | [ ] Style definitions must end with a semicolon 187 | ERROR | [ ] Style definitions must end with a semicolon 205 | ERROR | [ ] Style definitions must end with a semicolon 223 | ERROR | [ ] Style definitions must end with a semicolon 241 | ERROR | [ ] Style definitions must end with a semicolon 259 | ERROR | [ ] Style definitions must end with a semicolon 277 | ERROR | [ ] Style definitions must end with a semicolon 295 | ERROR | [ ] Style definitions must end with a semicolon 313 | ERROR | [ ] Style definitions must end with a semicolon 331 | ERROR | [ ] Style definitions must end with a semicolon 349 | ERROR | [ ] Style definitions must end with a semicolon 366 | ERROR | [x] Multiple selectors should each be on a single line 367 | ERROR | [ ] Style definitions must end with a semicolon 370 | ERROR | [x] Multiple selectors should each be on a single line 377 | ERROR | [x] Multiple selectors should each be on a single line 382 | ERROR | [x] Expected 1 newline at end of file; 2 found 383 | ERROR | [x] Additional whitespace found at end of file ------------------------------------------------------------------------------ PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------
- Status changed to Needs review
about 1 year ago 6:04am 14 September 2023 - 🇮🇳India vipul tulse
Hello Team,
Corrected the git repo branch name with fixes if Drupal coding standard.
Please review branch 8.x-1.x
https://git.drupalcode.org/project/ckeditor5_show_block/-/tree/8.x-1.x?r... - 🇮🇳India vishal.kadam Mumbai
Rest looks fine to me.
Let’s wait for other reviewers to take a look and if everything goes fine, you will get the role.
- Status changed to Needs work
about 1 year ago 11:03am 28 September 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage. This project is too small for us and it doesn't contain enough PHP code to really assess your skills as developer.
Have you created any other project on drupal.org (module, theme, distribution) we could instead review? The project needs to have most of the commits (preferable all the commits) done by you.
- Status changed to Needs review
about 1 year ago 8:30am 6 October 2023 - 🇮🇳India vipul tulse
You can review my existing module for d8 and d9
https://www.drupal.org/project/privacy_docs_world_map →
https://git.drupalcode.org/project/privacy_docs_world_map - Status changed to Needs work
about 1 year ago 5:53pm 9 October 2023 - 🇮🇳India vishal.kadam Mumbai
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml privacy_docs_world_map/ FILE: privacy_docs_world_map/privacy_docs_world_map.module -------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------- 10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Routing\RouteMatchInterface. 82 | WARNING | [ ] Only string literals should be passed to t() where possible -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: privacy_docs_world_map/privacy_docs_world_map.info.yml -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 2 LINES -------------------------------------------------------------------------------- 1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically 1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically 8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:" -------------------------------------------------------------------------------- FILE: privacy_docs_world_map/style/privacy_documents.css -------------------------------------------------------------------------------- FOUND 207 ERRORS AFFECTING 97 LINES -------------------------------------------------------------------------------- 74 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 74 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 75 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 76 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 76 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 77 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 77 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 78 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 79 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 80 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 81 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 82 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 83 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 84 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 85 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 86 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 86 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 87 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 87 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 88 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 88 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 89 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 89 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 90 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 90 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 91 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 91 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 91 | ERROR | [ ] Style definitions must end with a semicolon 95 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 96 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 96 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 97 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 97 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 98 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 98 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 98 | ERROR | [ ] Style definitions must end with a semicolon 102 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 103 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 104 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 105 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 106 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 107 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 107 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 108 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 109 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 110 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 110 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 110 | ERROR | [x] CSS colours must be defined in lowercase; expected #00539f but found #00539F 114 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 114 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 115 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 116 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 116 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 117 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 117 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 117 | ERROR | [ ] Style definitions must end with a semicolon 121 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 121 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 122 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 123 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 124 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 124 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 124 | ERROR | [ ] Style definitions must end with a semicolon 128 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 128 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 129 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 129 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 130 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 130 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 131 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 131 | ERROR | [ ] Style definitions must end with a semicolon 135 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 136 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 137 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 137 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 138 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 138 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 138 | ERROR | [ ] Style definitions must end with a semicolon 142 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 143 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 144 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 145 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 145 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 145 | ERROR | [ ] Style definitions must end with a semicolon 149 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 149 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 150 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 150 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 151 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 151 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 152 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 152 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 152 | ERROR | [ ] Style definitions must end with a semicolon 156 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 156 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 157 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 157 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 158 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 158 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 159 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 159 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 159 | ERROR | [ ] Style definitions must end with a semicolon 163 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 163 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 164 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 164 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 165 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 165 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 166 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 166 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 166 | ERROR | [ ] Style definitions must end with a semicolon 170 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 170 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 171 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 171 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 172 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 172 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 173 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 173 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 173 | ERROR | [ ] Style definitions must end with a semicolon 177 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 177 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 178 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 178 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 179 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 180 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 180 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 180 | ERROR | [ ] Style definitions must end with a semicolon 184 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 184 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 185 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 185 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 186 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 186 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 187 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 187 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 187 | ERROR | [ ] Style definitions must end with a semicolon 191 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 191 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 192 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 192 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 193 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 193 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 194 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 194 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 194 | ERROR | [ ] Style definitions must end with a semicolon 198 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 199 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 202 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 203 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 206 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 206 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 207 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 207 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 207 | ERROR | [ ] Style definitions must end with a semicolon 208 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 208 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 210 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 210 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 211 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 211 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 211 | ERROR | [ ] Style definitions must end with a semicolon 212 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 212 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 216 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 216 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 217 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 217 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 217 | ERROR | [ ] Style definitions must end with a semicolon 218 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 218 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 220 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 220 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 221 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 221 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 221 | ERROR | [ ] Style definitions must end with a semicolon 222 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 222 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 223 | ERROR | [x] Expected 1 newline at end of file; 2 found 224 | ERROR | [x] Additional whitespace found at end of file -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 189 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: privacy_docs_world_map/style/jqvmap.css -------------------------------------------------------------------------------- FOUND 44 ERRORS AFFECTING 31 LINES -------------------------------------------------------------------------------- 1 | ERROR | [x] Selectors must be on a single line 2 | ERROR | [x] Blank lines are not allowed between class names 2 | ERROR | [x] Expected 1 space before opening brace of class definition; newline found 3 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 4 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 4 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 5 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 6 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 7 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 8 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 9 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 10 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 11 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 12 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 13 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 16 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 24 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 27 | ERROR | [x] Multiple selectors should each be on a single line 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 33 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4 39 | ERROR | [x] Selectors must be on a single line 40 | ERROR | [x] Blank lines are not allowed between class names 40 | ERROR | [x] Expected 1 space before opening brace of class definition; newline found 43 | ERROR | [x] Selectors must be on a single line 44 | ERROR | [x] Blank lines are not allowed between class names 44 | ERROR | [x] Expected 1 space before opening brace of class definition; newline found -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 44 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: privacy_docs_world_map/src/Plugin/Block/PrivacyDoucmentsWorldMapBlock.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Config\ConfigFactoryInterface. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: privacy_docs_world_map/src/Form/WorldMapConfigSettingsForm.php -------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE -------------------------------------------------------------------------------- 66 | WARNING | Possible useless method overriding detected -------------------------------------------------------------------------------- FILE: privacy_docs_world_map/src/Controller/LoadDocumentsDataController.php -------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES -------------------------------------------------------------------------------- 6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Controller\ControllerBase. 32 | WARNING | [ ] Unused variable $key. -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------
- 🇮🇹Italy apaderno Brescia, 🇮🇹
I am changing priority as per Issue priorities → .
- Status changed to Closed: won't fix
3 months ago 7:12am 13 August 2024 - 🇮🇳India vishal.kadam Mumbai
This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).
If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.