Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage.
This project is too small for us and it doesn't contain enough PHP code to really assess your skills as a developer.
Have you created any other project on drupal.org (module, theme, distribution) we could instead review? The project needs to have most of the commits (preferable all the commits) done by you.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Rest seems fine to me.
Let’s wait for other reviewers and Code Review Administrator to take a look and if everything goes fine, you will get the role.
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml coupons_migrate/
FILE: coupons_migrate/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 116 characters
38 | WARNING | Line exceeds 80 characters; contains 100 characters
43 | WARNING | Line exceeds 80 characters; contains 83 characters
48 | WARNING | Line exceeds 80 characters; contains 90 characters
51 | WARNING | Line exceeds 80 characters; contains 145 characters
----------------------------------------------------------------------
FILE: coupons_migrate/src/Plugin/Commerce/PromotionOffer/SetPrice.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\commerce_order\Adjustment.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: coupons_migrate/src/Commands/CouponsMigrate.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
@arwillame Thank you for reporting this. I’ve merged the MR.
Thank you for the suggestion! I followed your advice to require drupal/webform first and then drupal/eca_webform, and it worked perfectly.
I attempted to install the eca_webform module on a vanilla Drupal 11 setup using Composer but was unsuccessful.
Have you been able to install eca_webform on a vanilla Drupal 11 setup using Composer?
vishal.kadam → created an issue.
vishal.kadam → created an issue.
vishal.kadam → created an issue.
vishal.kadam → created an issue.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
All Twig files are still improperly indented. Ensure that two spaces are used for indentation instead of four spaces or tabs.
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml seeds_toolbar/
FILE: seeds_toolbar/seeds_toolbar.libraries.yml
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
16 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------
FILE: seeds_toolbar/seeds_toolbar.module
------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------
446 | ERROR | Doc comment is empty
------------------------------------------------------------------------
FILE: seeds_toolbar/assets/css/seeds-toolbar-rtl.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
87 | ERROR | [x] Multiple selectors should each be on a single line
93 | ERROR | [x] Multiple selectors should each be on a single line
118 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: seeds_toolbar/assets/css/seeds-toolbar.css
--------------------------------------------------------------------------------
FOUND 65 ERRORS AFFECTING 54 LINES
--------------------------------------------------------------------------------
93 | ERROR | [x] Multiple selectors should each be on a single line
93 | ERROR | [x] Multiple selectors should each be on a single line
103 | ERROR | [x] Multiple selectors should each be on a single line
106 | ERROR | [x] Multiple selectors should each be on a single line
106 | ERROR | [x] Multiple selectors should each be on a single line
106 | ERROR | [x] Multiple selectors should each be on a single line
106 | ERROR | [x] Multiple selectors should each be on a single line
106 | ERROR | [x] Multiple selectors should each be on a single line
115 | ERROR | [x] Multiple selectors should each be on a single line
118 | ERROR | [x] Multiple selectors should each be on a single line
126 | ERROR | [x] Multiple selectors should each be on a single line
142 | ERROR | [x] Multiple selectors should each be on a single line
180 | ERROR | [x] Multiple selectors should each be on a single line
180 | ERROR | [x] Multiple selectors should each be on a single line
183 | ERROR | [x] Multiple selectors should each be on a single line
183 | ERROR | [x] Multiple selectors should each be on a single line
206 | ERROR | [x] Multiple selectors should each be on a single line
206 | ERROR | [x] Multiple selectors should each be on a single line
206 | ERROR | [x] Multiple selectors should each be on a single line
297 | ERROR | [x] Multiple selectors should each be on a single line
412 | ERROR | [x] Multiple selectors should each be on a single line
473 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
480 | ERROR | [x] Multiple selectors should each be on a single line
492 | ERROR | [x] Multiple selectors should each be on a single line
496 | ERROR | [x] Multiple selectors should each be on a single line
500 | ERROR | [x] Multiple selectors should each be on a single line
507 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 5
508 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
509 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
512 | ERROR | [x] Multiple selectors should each be on a single line
516 | ERROR | [x] Multiple selectors should each be on a single line
520 | ERROR | [x] Multiple selectors should each be on a single line
547 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
548 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
550 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
551 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
554 | ERROR | [x] Multiple selectors should each be on a single line
571 | ERROR | [x] Multiple selectors should each be on a single line
574 | ERROR | [x] Multiple selectors should each be on a single line
574 | ERROR | [x] Multiple selectors should each be on a single line
574 | ERROR | [x] Multiple selectors should each be on a single line
577 | ERROR | [x] Multiple selectors should each be on a single line
601 | ERROR | [x] Multiple selectors should each be on a single line
605 | ERROR | [x] Multiple selectors should each be on a single line
608 | ERROR | [x] Multiple selectors should each be on a single line
644 | ERROR | [x] Multiple selectors should each be on a single line
647 | ERROR | [x] Multiple selectors should each be on a single line
683 | ERROR | [x] Multiple selectors should each be on a single line
700 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
704 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
723 | ERROR | [x] Multiple selectors should each be on a single line
727 | ERROR | [x] Multiple selectors should each be on a single line
751 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
753 | ERROR | [x] Multiple selectors should each be on a single line
771 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
821 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
822 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
824 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
825 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
842 | ERROR | [x] Multiple selectors should each be on a single line
846 | ERROR | [x] Multiple selectors should each be on a single line
860 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
861 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
872 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
917 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 65 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: seeds_toolbar/seeds_toolbar.permissions.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
1. FILE: README.md
The README file is missing the required sections → , including Requirements, Installation, and Configuration.
2. FILE: src/Component/DataComponent.php
/**
* DataComponent constructor.
*
* @param string $bundle
* The bundle of the data component.
* @param array<string, mixed> $data
* The multi-dimensional array data.
*/
public function __construct(string $bundle, array $data) {FILE: src/Event/UnknownDataProcessorEvent.php
/**
* Pass in connector config by default to all events.
*
* @param mixed $dataSource
* The unknown data source about to be processed.
* @param string $variant
* The processor variant requested for the data source.
*/
public function __construct(mixed $dataSource, string $variant) {FILE: src/Plugin/DataProcessorBase.php
/**
* {@inheritdoc}
*/
public function __construct(FILE: src/Plugin/DataProcessorManager.php
/**
* Constructor for TaskPluginManager objects.
*
* @param \Traversable $namespaces
* An object that implements \Traversable which contains the root paths
* keyed by the corresponding namespace to look for plugin implementations.
* @param \Drupal\Core\Cache\CacheBackendInterface $cache_backend
* Cache backend instance to use.
* @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
* The module handler to invoke the alter hook with.
* @param \Symfony\Component\EventDispatcher\EventDispatcherInterface $dispatcher
* The event dispatcher.
*/
public function __construct(The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.
A site moderator will review your post, publish it, and confirm your account.
I have reviewed your posts and confirmed the account.
A site moderator user will review your post and publish it.
MR seems good to me and working fine. Moving to RTBC.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
I have fixed the above error and Drupal 11 compatibility fixes in my MR.
Getting below error at /admin/config/search/advanced-datalayer/page-variables/settings :
ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/advanced_datalayer/src/Form/AdvancedDatalayerSettingsForm.php on line 57 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 44 of core/lib/Drupal/Core/Form/ConfigFormBase.php).
Given the changes in ConfigFormBase, the module cannot be compatible with all those Drupal releases. (In particular, see the changes to the constructor between Drupal 9.x and Drupal 10.x.)
ConfigFormBase::__construct() requires two parameters from Drupal 10.
vishal.kadam → made their first commit to this issue’s fork.
FILE: src/Controller/ContentInsightsReportController.php
/**
* The configuration factory.
*
* @var \Drupal\Core\Config\ConfigFactoryInterface
*/
protected $configFactory; /**
* The entity type manager.
*
* @var \Drupal\Core\Entity\EntityTypeManagerInterface
*/
protected $entityTypeManager;The parent class already has properties and methods for the entity type manager, and the configuration object. There is no need to redefine properties for the same purpose; instead, the parent class methods should be used.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
These applications do not require that new releases are created after reviews.
I ran the phpcs command (phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml) and confirm that all coding standard issues have been resolved.
vishal.kadam → made their first commit to this issue’s fork.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
1. main is a wrong name for a branch. Release branch names always end with the literal .x as described in
Release branches →
. The only exception is for the main branch, which is actually not fully supported on drupal.org and should be avoided.
main will be a supported branch in future, but for the moment it is better not to use it. It is not wrong, but it is not completely supported on drupal.org.
2. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml zohozeptomail/
FILE: zohozeptomail/zohozeptomail.install
--------------------------------------------------------------------------------
FOUND 12 ERRORS AND 3 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
39 | ERROR | [x] Missing function doc comment
51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
51 | ERROR | [x] Expected 1 space after closing parenthesis; found 0
53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1
54 | ERROR | [x] Whitespace found at end of line
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
56 | WARNING | [ ] Unused variable $key.
56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
57 | WARNING | [ ] Unused variable $fromaddress.
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
59 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [x] Whitespace found at end of line
61 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: zohozeptomail/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 360 characters
24 | WARNING | Line exceeds 80 characters; contains 91 characters
29 | WARNING | Line exceeds 80 characters; contains 95 characters
30 | WARNING | Line exceeds 80 characters; contains 86 characters
38 | WARNING | Line exceeds 80 characters; contains 131 characters
----------------------------------------------------------------------
FILE: zohozeptomail/zohozeptomail.info.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
8 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: zohozeptomail/src/Plugin/Mail/ZeptoMail.php
--------------------------------------------------------------------------------
FOUND 20 ERRORS AND 3 WARNINGS AFFECTING 20 LINES
--------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
10 | WARNING | [x] Unused use statement
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Utility\Html.
12 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
15 | ERROR | [x] Missing class doc comment
17 | ERROR | [ ] Missing member variable doc comment
19 | ERROR | [ ] Missing member variable doc comment
21 | ERROR | [ ] Missing member variable doc comment
23 | ERROR | [x] Missing function doc comment
64 | ERROR | [x] Missing function doc comment
94 | WARNING | [x] 'TODO handle attachment' should match the format '@todo Fix problem X here.'
94 | ERROR | [x] No space found before comment text; expected "// TODO handle attachment" but found "//TODO handle attachment"
94 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
100 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
101 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 10
102 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
103 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
105 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
106 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
107 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 6
109 | ERROR | [x] Line indented incorrectly; expected 5 spaces, found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 20 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: zohozeptomail/src/Form/ZeptoMailSettingsForm.php
--------------------------------------------------------------------------------
FOUND 8 ERRORS AND 1 WARNING AFFECTING 8 LINES
--------------------------------------------------------------------------------
16 | ERROR | [x] Whitespace found at end of line
17 | ERROR | [ ] Missing member variable doc comment
20 | ERROR | [x] Missing function doc comment
20 | ERROR | [x] Expected 1 blank line before function; 2 found
54 | ERROR | [x] Whitespace found at end of line
69 | ERROR | [x] Whitespace found at end of line
81 | ERROR | [x] Whitespace found at end of line
88 | WARNING | [ ] Possible useless method overriding detected
110 | ERROR | [x] Whitespace found at end of line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: zohozeptomail/src/ZeptoMailHandler.php
--------------------------------------------------------------------------------
FOUND 16 ERRORS AFFECTING 14 LINES
--------------------------------------------------------------------------------
6 | ERROR | [x] There must be one blank line after the last USE statement; 2 found;
9 | ERROR | [x] Missing class doc comment
12 | ERROR | [ ] Missing member variable doc comment
15 | ERROR | [ ] Missing member variable doc comment
18 | ERROR | [ ] More than 2 empty lines are not allowed
19 | ERROR | [x] Missing function doc comment
19 | ERROR | [x] Expected 1 blank line before function; 3 found
22 | ERROR | [x] Whitespace found at end of line
23 | ERROR | [x] Expected 1 blank line after function; 2 found
26 | ERROR | [x] Missing function doc comment
28 | ERROR | [x] Expected 1 blank line after function; 2 found
35 | ERROR | [x] Whitespace found at end of line
35 | ERROR | [x] Functions must not contain multiple empty lines in a row; found 2 empty lines
38 | ERROR | [x] Expected 1 blank line after function; 3 found
41 | ERROR | [ ] More than 2 empty lines are not allowed
42 | ERROR | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------3. FILE: zohozeptomail.module
/**
* @file
* Tntegrate the third party Zoho ZeptoMail service with Drupal.
*/The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
Rest seems fine to me.
Let’s wait for other reviewers and Code Review Administrator to take a look and if everything goes fine, you will get the role.
No, there is no restriction that limits Drupal repositories to only having release branches.
1. main is a wrong name for a branch. Release branch names always end with the literal .x as described in
Release branches →
. The only exception is for the main branch, which is actually not fully supported on drupal.org and should be avoided.
main will be a supported branch in future, but for the moment it is better not to use it. It is not wrong, but it is not completely supported on drupal.org.
2. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml content_insights_report/
FILE: content_insights_report/src/Controller/ContentInsightsReportController.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
361 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines
375 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------3. FILE: README.md
The README file is missing the required sections → , including Project name, Requirements, and Configuration.
4. FILE: content_insights_report.info.yml
core_version_requirement: ^8 || ^9 || ^10 || ^11
The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement → key.
5. FILE: content_insights_report.module
/**
* @file
* Contains content_insights_report.module.
*/The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.
6. FILE: templates/content-insights-report.html.twig
{% if show_created_by_and_date == 'yes' %}
{% set today = date() %}
<p id="created-by-and-date" class="text-right">{{ 'Created by'|trans }} <i>{{ user.displayname }}</i> on {{ today|date('Y/m/d H:i') }}</p>
{% endif %} <tbody>
<tr>
<td><a href="/admin/content?type={{ data.content_type_id }}" class="btn btn-primary btn-lg square" role="button">{{ data.total_count }}</a></td>
<td><a href="/admin/content?status=1&type={{ data.content_type_id }}" class="btn btn-primary btn-lg square" role="button">{{ data.published_count }}</a></td>
<td><a href="/admin/content?status=2&type={{ data.content_type_id }}" class="btn btn-primary btn-lg square" role="button">{{ data.unpublished_count }}</a></td>
</tr>
</tbody> <thead>
<th>{{ 'Nodes'|trans }}</th>
{% for ms_stage in ms.status['1'].stage %}
<th>{{ ms_stage.name }}</th>
{% endfor %}
</thead> {% if show_created_by_and_date == 'yes' %}
{% set today = date() %}
<p id="created-by-and-date" class="text-right">{{ 'Created by'|trans }} <i>{{ user.displayname }}</i> on {{ today|date('Y/m/d H:i') }}</p>
{% endif %}Twig code needs to be correctly indented. Drupal uses two spaces for indentation, not four spaces or tabs.
7. FILE: src/Controller/ContentInsightsReportController.php
/**
* Constructs a content_insights_report object.
*
* @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
* The config factory.
* @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
* The entity type manager.
* @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
* The module handler service.
*/
public function __construct(ConfigFactoryInterface $config_factory, EntityTypeManagerInterface $entity_type_manager, ModuleHandlerInterface $module_handler) {FILE: src/Form/ContentInsightsReportConfigForm.php
/**
* Constructs a content_insights_report object.
*
* @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
* The config factory.
*/
public function __construct(ConfigFactoryInterface $config_factory) {The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.
wip-test is a wrong name for a branch. Release branch names always end with the literal .x as described in
Release branches →
. The only exception is for the main branch, which is actually not fully supported on drupal.org and should be avoided.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
I've reviewed your recent post and given you the 'confirmed' role.
✅ Released visualization_charts-8.x-1.4 →
FILE: README.md
The README file is missing the required sections, including Requirements, and Installation.
@aneeshthankachan and @samberry
To make the previous comment clearer: This application requires reviewers to review the project files and report what needs to be changed. We do not debug projects or verify their functionality.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. FILE: src/Plugin/Devel/Dumper/DevelDumper.php
/**
* {@inheritdoc}
*/
public function __construct(protected Config $kintConfig, array $configuration, $plugin_id, $plugin_definition) {The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.
2. FILE: kint.links.menu.yml
# devel.admin_settings_link:
# title: 'Devel settings'
# description: 'Helper functions, pages, and blocks to assist Drupal developers. The devel blocks can be managed via the block administration page.'
# route_name: devel.admin_settings
# menu_name: develRemove commented code.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
1. 1.1.1 is a wrong name for a branch. Release branch names always end with the literal .x as described in
Release branches →
.
2. FILE: src/Plugin/views/field/ViewsRegexFunctionsField.php
/**
* {@inheritdoc}
*/
public function __construct(array $configuration, $plugin_id, $plugin_definition, DateFormatter $dateFormatter, TimeInterface $dateTime, RendererInterface $renderer) {The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.
It appears that PHPCS checks are already enabled in your current CI, and the pipeline is running successfully without any errors.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
FILE: src/Plugin/views/field/ViewsRegexFunctionsField.php
// '#prefix' => '<hr>',
// \Drupal::messenger()->addMessage(json_encode($returnValue), true);
Remove commented code.
The README file is missing the required sections → , including Project name and introduction, Requirements, Installation, and Configuration.
1. main is a wrong name for a branch. Release branch names always end with the literal .x as described in
Release branches →
.
main will be a supported branch in future, but for the moment it is better not to use it. It is not wrong, but it is not completely supported on drupal.org.
2. FILE: webform_openfisca.module
/**
* @file
* Webform OpenFisca module.
*/FILE: modules/webform_openfisca_key_auth/webform_openfisca_key_auth.module
/**
* @file
* Webform OpenFisca Key Authentication.
*/The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.
3. FILE: src/RacContentHelper.php
/**
* Constructor.
*
* @param \Drupal\Core\Entity\EntityTypeManagerInterface $entityTypeManager
* Entity Type Manager service.
*/
public function __construct(FILE: src/WebformFormAlterBase.php
/**
* Constructor.
*
* @param \Drupal\webform_openfisca\OpenFisca\ClientFactoryInterface $openFiscaClientFactory
* OpenFisca connector.
* @param \Drupal\Core\StringTranslation\TranslationInterface $string_translation
* String translation.
* @param \Drupal\Core\Messenger\MessengerInterface $messenger
* Messenger service.
* @param \Drupal\Core\Cache\CacheTagsInvalidatorInterface $cacheTagsInvalidator
* Cache tags invalidator.
*/
public function __construct(FILE: src/WebformOpenFiscaSettings.php
/**
* Constructor.
*
* @param \Drupal\webform\WebformInterface $webform
* The webform.
*/
protected function __construct(WebformInterface $webform) {FILE: src/OpenFisca/Client.php
/**
* Constructor.
*
* @param string $baseApiUri
* The base API endpoint.
* @param \GuzzleHttp\ClientInterface $httpClient
* The HTTP Client service.
* @param \Psr\Log\LoggerInterface $logger
* The logger service.
* @param array $httpClientOptions
* The options initialising the HTTP Client (used by the client factory).
*/
public function __construct(FILE: src/OpenFisca/ClientFactory.php
/**
* Constructor.
*
* @param \Drupal\Core\Http\ClientFactory $httpClientFactory
* HTTP Client Factory service.
* @param \Psr\Log\LoggerInterface $logger
* Logger service.
* @param \Drupal\Core\Extension\ModuleHandlerInterface $moduleHandler
* Module handler.
* @param \Drupal\Core\Theme\ThemeManagerInterface $themeManager
* Theme manager.
*/
public function __construct(FILE: src/OpenFisca/Payload.php
/**
* Constructor.
*/
final public function __construct() {}The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
1. FILE: templates/node-data.html.twig and templates/user-data.html.twig
Twig code needs to be correctly indented. Drupal uses two spaces for indentation, not four spaces or tabs.
Strings shown in the user interface needs to be translated.
2. FILE: pie_chart.module
/**
* @file
* A pie_chart.module file.
*
* This file contains the logic to generate pie charts in Drupal using Chart.js.
*/The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.
@vishalydv Don't remove issue summary
README.md file content and formatting is pending. It should follow the content and formatting described in README.md template → .
It appears there are multiple project applications created using your account.
Since a successful completion of the project application process results in the applicant being granted the necessary role to be able to opt projects into security advisory coverage, there is no need to take multiple applications through the process. Once the first application has been successfully approved, the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers, which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as Closed (duplicate), with only one application left open.
If you prefer that we proceed through this review process with a different application, then feel free to close the application left open as a duplicate, and re-open one of the project applications which had been closed.
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Review points 2, 3 and 4 are still pending from Comment #5 📌 [1.0.0] Accessibility tools Needs review .
1. master and feature/add-ci-file are wrong names for a branch. Release branch names always end with the literal .x as described in
Release branches →
.
2. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml jsonapi_request_logger/
FILE: jsonapi_request_logger/jsonapi_request_logger.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: jsonapi_request_logger/src/Form/SettingsForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
96 | ERROR | [x] Comments may not appear after statements
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: jsonapi_request_logger/src/EventSubscriber/RequestLoggerSubscriber.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
96 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
135 | ERROR | [x] Expected 1 blank line after function; 2 found
150 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
228 | ERROR | [x] Expected 1 blank line after function; 0 found
229 | ERROR | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml commerce_imoje/
FILE: commerce_imoje/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
----------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 100 characters
24 | WARNING | Line exceeds 80 characters; contains 120 characters
32 | WARNING | Line exceeds 80 characters; contains 119 characters
----------------------------------------------------------------------
FILE: commerce_imoje/commerce_imoje.module
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
--------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
5 | ERROR | [x] Missing function doc comment
32 | ERROR | [x] Each PHP statement must be on a line by itself
38 | ERROR | [x] Expected 1 newline at end of file; 2 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
FILE: commerce_imoje/src/IPNHandler.php
------------------------------------------------------------------------------
FOUND 8 ERRORS AND 1 WARNING AFFECTING 8 LINES
------------------------------------------------------------------------------
16 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Json.
18 | ERROR | [x] Missing class doc comment
57 | ERROR | [ ] Missing parameter comment
58 | ERROR | [ ] Missing parameter comment
110 | ERROR | [x] Case breaking statements must be followed by a single blank line
115 | ERROR | [x] Case breaking statements must be followed by a single blank line
150 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
150 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
152 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: commerce_imoje/src/BlikPaymentFormBuilderInterface.php
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
8 | ERROR | [x] Missing interface doc comment
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: commerce_imoje/src/Plugin/Commerce/PaymentGateway/ImojeRedirect.php
------------------------------------------------------------------------------
FOUND 1 ERROR AND 17 WARNINGS AFFECTING 17 LINES
------------------------------------------------------------------------------
5 | WARNING | [x] Unused use statement
6 | WARNING | [x] Unused use statement
7 | WARNING | [x] Unused use statement
8 | WARNING | [x] Unused use statement
9 | WARNING | [x] Unused use statement
10 | WARNING | [x] Unused use statement
11 | WARNING | [x] Unused use statement
13 | WARNING | [x] Unused use statement
14 | WARNING | [x] Unused use statement
15 | WARNING | [x] Unused use statement
15 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\DependencyInjection\ContainerInterface.
16 | WARNING | [x] Unused use statement
17 | WARNING | [x] Unused use statement
18 | WARNING | [x] Unused use statement
19 | WARNING | [x] Unused use statement
20 | WARNING | [x] Unused use statement
21 | WARNING | [x] Unused use statement
67 | WARNING | [ ] #description values usually have to run through t() for translation
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: commerce_imoje/src/Plugin/Commerce/PaymentGateway/ImojeOffsitePaymentGatewayBase.php
------------------------------------------------------------------------------
FOUND 24 ERRORS AND 2 WARNINGS AFFECTING 26 LINES
------------------------------------------------------------------------------
15 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\DependencyInjection\ContainerInterface.
23 | ERROR | [x] Missing class doc comment
46 | ERROR | [x] Missing function doc comment
199 | ERROR | [ ] Missing parameter comment
201 | ERROR | [ ] Description for the @return value is missing
213 | ERROR | [ ] Missing parameter comment
215 | ERROR | [ ] Description for the @return value is missing
227 | ERROR | [ ] Missing parameter comment
228 | ERROR | [ ] Missing parameter comment
229 | ERROR | [ ] Missing parameter comment
231 | ERROR | [ ] Description for the @return value is missing
242 | ERROR | [ ] Missing parameter comment
243 | ERROR | [ ] Missing parameter comment
245 | ERROR | [ ] Description for the @return value is missing
280 | WARNING | [ ] Exceptions should not be translated
285 | WARNING | [ ] Exceptions should not be translated
301 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
303 | ERROR | [ ] Missing parameter comment
305 | ERROR | [ ] Description for the @return value is missing
306 | ERROR | [x] Separate the @return and @throws sections by a blank line.
318 | ERROR | [ ] Missing parameter comment
320 | ERROR | [ ] Description for the @return value is missing
321 | ERROR | [x] Separate the @return and @throws sections by a blank line.
331 | ERROR | [ ] Missing parameter comment
333 | ERROR | [ ] Description for the @return value is missing
334 | ERROR | [x] Separate the @return and @throws sections by a blank line.
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: commerce_imoje/src/ImojeGatewayInterface.php
------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------
15 | ERROR | [x] Missing function doc comment
17 | ERROR | [x] Missing function doc comment
19 | ERROR | [x] Missing function doc comment
21 | ERROR | [x] Missing function doc comment
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: commerce_imoje/src/BlikPaymentFormBuilder.php
------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------------
38 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
40 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
47 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------
FILE: commerce_imoje/src/Event/ImojePaymentEvent.php
------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\commerce\EventBase.
35 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
37 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 2 spaces
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: commerce_imoje/src/IPNHandlerInterface.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 1 LINE
--------------------------------------------------------------------------------
12 | ERROR | Parameter $service_key is not described in comment
12 | ERROR | Parameter $payment_gateway_id is not described in comment
--------------------------------------------------------------------------------
FILE: commerce_imoje/src/PluginForm/ImojeRedirect/ImojePaymentForm.php
------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
------------------------------------------------------------------------------
9 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\DependencyInjection\ContainerInjectionInterface.
26 | ERROR | [ ] Missing parameter comment
67 | WARNING | [ ] t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: commerce_imoje/src/ImojeGateway.php
------------------------------------------------------------------------------
FOUND 16 ERRORS AND 3 WARNINGS AFFECTING 18 LINES
------------------------------------------------------------------------------
14 | WARNING | [x] Unused use statement
15 | WARNING | [x] Unused use statement
16 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Serialization\Json.
18 | WARNING | [x] Unused use statement
20 | ERROR | [x] Missing class doc comment
56 | ERROR | [ ] Parameter $time is not described in comment
63 | ERROR | [ ] Missing parameter comment
72 | ERROR | [ ] Missing short description in doc comment
85 | ERROR | [ ] Missing short description in doc comment
86 | ERROR | [ ] @throws comment must be on the next line
117 | ERROR | [ ] Missing short description in doc comment
118 | ERROR | [ ] @throws comment must be on the next line
138 | ERROR | [ ] Missing parameter comment
139 | ERROR | [ ] Missing parameter comment
140 | ERROR | [ ] Missing parameter comment
141 | ERROR | [ ] Missing parameter comment
143 | ERROR | [ ] Description for the @return value is missing
144 | ERROR | [x] Separate the @return and @throws sections by a blank line.
144 | ERROR | [ ] @throws comment must be on the next line
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: commerce_imoje/src/Controller/BlikController.php
------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
------------------------------------------------------------------------------
51 | ERROR | Missing parameter comment
80 | ERROR | Return type "\Symfony\Component\HttpFoundation\JsonResponse A response." must not contain spaces
114 | ERROR | Return type "\Symfony\Component\HttpFoundation\JsonResponse A response." must not contain spaces
------------------------------------------------------------------------------
FILE: commerce_imoje/css/blik-payment-form.css
------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------
65 | ERROR | [x] Opening brace should be the last content on the line
65 | ERROR | [x] Closing brace of class definition must be on new line
66 | ERROR | [x] Opening brace should be the last content on the line
66 | ERROR | [x] Closing brace of class definition must be on new line
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------master is a wrong name for a branch. Release branch names always end with the literal .x as described in
Release branches →
.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml webform_pipedrive/
FILE: webform_pipedrive/webform_pipedrive.routing.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
7 | WARNING | The administration page callback should probably use "administer site configuration" - which implies the user can change something - rather than "access
| | administration pages" which is about viewing but not changing configurations.
--------------------------------------------------------------------------------
FILE: webform_pipedrive/src/Plugin/WebformHandler/WebformPipedrive.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------
75 | WARNING | Unused variable $webform_settings.
187 | WARNING | Unused variable $user_field_mapping.
209 | WARNING | Unused variable $webform_name.
210 | WARNING | Unused variable $webform_uuid.
212 | WARNING | Unused variable $submission_uuid.
251 | WARNING | Unused variable $mapping_options.
--------------------------------------------------------------------------------
FILE: webform_pipedrive/src/Service/PipedriveIntegration.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
--------------------------------------------------------------------------------
22 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
42 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
55 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
84 | WARNING | Unused variable $datadeal.
91 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------
FILE: webform_pipedrive/src/Service/GetAccessToken.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
20 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------2. FILE: webform_pipedrive.info.yml
core: 8.x
core_version_requirement: ^9 || ^10
If the module is compatible with all Drupal 8 versions, include ^8 in core_version_requirement; otherwise, remove core: 8.x.
3. FILE: webform_pipedrive.module
/**
* @file
* Webform Integration with Pipedrive module.
*
* This module integrates the Drupal Webform module with Pipedrive CRM.
* It automates the submission of Webform data to Pipedrive, providing
* seamless synchronization between Drupal forms and Pipedrive records.
*/The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.
@wouters_f Thank you for suggesting the use of the AI module to support multiple AI providers.
I noticed that the AI module is currently in beta. Could you please let us know when the stable release is planned? We prefer to add dependencies only on stable module releases.
It seems the "Create release" link provided on the Tags page isn't functioning.
Please visit https://www.drupal.org/project/fieldblock → and use the "Add new release" link located at the bottom of the page instead.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml brevo_contact_sync/
FILE: brevo_contact_sync/brevo_contact_sync.module
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
15 | ERROR | Doc comment is empty
22 | WARNING | Unused variable $uid.
24 | WARNING | Unused variable $name.
53 | WARNING | Unused variable $name.
--------------------------------------------------------------------------------
FILE: brevo_contact_sync/src/Form/BrevoContactMappingForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
100 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
108 | WARNING | Unused variable $id.
122 | WARNING | Unused variable $key.
134 | ERROR | The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines
134 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------
FILE: brevo_contact_sync/brevo_contact_sync.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
8 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
--------------------------------------------------------------------------------2. FILE: brevo_contact_sync.module
/**
* @file
* Code for the brevo_contact_sync module.
*/The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.
else {
$value = 'testst';
}Consider adding a comment to clarify the purpose of 'testst' or using more descriptive placeholder text.
1. main and develop are wrong names for a branch. Release branch names always end with the literal .x as described in
Release branches →
. The only exception is for the main branch, which is actually not fully supported on drupal.org and should be avoided.
2. FILE: README.md
README.md file should follow the content and formatting described in README.md template → .
3. FILE: a11y.module
/**
* @file
* Contains a11y.module.
*/The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.
/**
* Implements hook_preprocess_HOOK().
*/
function a11y_preprocess_a11y_template(&$variables) {The description for this hook should also say for which hook it is implemented.
4. FILE: src/Form/A11yEditForm.php
/**
* {@inheritdoc}
*/
public function __construct(FILE: src/Form/A11yForm.php
/**
* {@inheritdoc}
*/
public function __construct(The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.
1. 3480091-slider_arrow_wrong_direction and market_wave-3464923 are wrong names for a branch. Release branch names always end with the literal .x as described in
Release branches →
.
2. FILE: README.md
README.md file should follow the content and formatting described in README.md template → .
3. Fix phpcs issues.
See attached market_wave-phpcs-issues.txt →
4. FILE: js/script.js
// $(document).ready(function() {
// });
Remove commented code.
5. FILE: js/script.js, js/slider.js and js/status_alert.js
The code needs to be correctly indented. Drupal uses two spaces for indentation, not four spaces or tabs.