undefined - Contrib.social

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [2.x] Views table search

🇮🇳India vishal.kadam Mumbai

1. master is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → .

2. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml views_tablesearch/

FILE: views_tablesearch/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 355 characters
  5 | WARNING | Line exceeds 80 characters; contains 152 characters
 17 | WARNING | Line exceeds 80 characters; contains 159 characters
 19 | WARNING | Line exceeds 80 characters; contains 497 characters
----------------------------------------------------------------------

FILE: views_tablesearch/src/Plugin/views/style/TableSearch.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 319 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------

📌 | stub project from issue ref | [2.x] Views table search

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [2.x] Views table search

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

📌 | stub project from issue ref | [8.x-2.x] Advanced Link Attributes

🇮🇳India vishal.kadam Mumbai

1. FILE: ala.info.yml

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement → key.

2. FILE: ala.libraries.yml

version: VERSION

VERSION is only used by Drupal core modules. Contributed modules should use a literal string that does not change with the Drupal core version a site is using.

📌 | stub project from issue ref | [1.0.x] OverlayScrollbars

🇮🇳India vishal.kadam Mumbai

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

📌 | stub project from issue ref | Request for 'confirmed' user role

Comment 6 days ago →

🇮🇳India vishal.kadam Mumbai

I have reviewed your posts and confirmed the account.

📌 | stub project from issue ref | [1.0.x] OverlayScrollbars

🇮🇳India vishal.kadam Mumbai

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml overlayscrollbars/

FILE: overlayscrollbars/overlayscrollbars.libraries.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
 27 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: overlayscrollbars/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------
  3 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
 18 | WARNING | [ ] Line exceeds 80 characters; contains 82 characters
 19 | WARNING | [ ] Line exceeds 80 characters; contains 116 characters
 25 | ERROR   | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: overlayscrollbars/overlayscrollbars.module
------------------------------------------------------------------------------
FOUND 13 ERRORS AND 2 WARNINGS AFFECTING 13 LINES
------------------------------------------------------------------------------
 24 | ERROR   | [x] Expected 1 blank line after function; 2 found
 28 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
 36 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
    |         |     xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
 38 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
 39 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
 42 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 46 | ERROR   | [x] Expected newline after closing brace
 47 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 49 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 53 | ERROR   | [x] Expected newline after closing brace
 54 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
 63 | ERROR   | [x] Expected newline after closing brace
 64 | ERROR   | [x] No space found before comment text; expected "// throw $th;" but found "//throw $th;"
 64 | ERROR   | [x] Inline comments must start with a capital letter
 64 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 13 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

FILE: overlayscrollbars/overlayscrollbars.install
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
 12 | ERROR | [x] Opening brace should be on the same line as the declaration
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------

2. FILE: overlayscrollbars.module

/**
 * @file
 * Primary module hooks for overlayscrollbars module.
 */

Drupal does not have primary and secondary hooks. Instead of that, it is preferable to use the usual description: Hook implementations for the [module name] module. where [module name] is the name of the module given in its .info.yml file.

\Drupal::logger('overlayscrollbars')->error($th->getMessage());

The first argument passed to logger methods that log a message must be a literal string. Passing a dynamic string is considered a security issue.

📌 | stub project from issue ref | [1.0.x] OverlayScrollbars

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [1.0.x] OverlayScrollbars

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

📌 | stub project from issue ref | [1.0.x] Calculation Fields

🐛 | Views migration from Drupal 7 to Drupal 10 | Deprecated function: Creation of dynamic property Drupal\views_migration\Plugin\migrate\source\d7\ViewsMigration::$typeMap

🇮🇳India vishal.kadam Mumbai

1. FILE: README.md

The module uses a README.md file instead of a README.txt file. While the Drupal coding standards have not been yet updated about that, the Drupal.org community consider that positive.
Since there is a README.md file, that should follow the content and formatting described in README.md template → .

2. FILE: calculation_fields.module

/**
 * @file
 * Contains hooks implemented by the calculation fields module.
 */

FILE: modules/calculation_fields_example/calculation_fields_example.module

/**
 * @file
 * Contains custom feature for the module.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

📌 | stub project from issue ref | [2.0.x] NYS Universal Navigation Integration

Comment 12 days ago →

🇮🇳India vishal.kadam Mumbai

1. Fix phpcs issues.

See attached nys_unav-phpcs-errors.txt →

2. FILE: nys_unav.info.yml

core_version_requirement: ^8 || ^9 || ^10

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement → key.

3. FILE: README.md

The module uses a README.md file instead of a README.txt file. While the Drupal coding standards have not been yet updated about that, the Drupal.org community consider that positive.
Since there is a README.md file, that should follow the content and formatting described in README.md template → .

4. FILE: templates/nys-unav-header.html.twig

    <script type="text/javascript">
        var _NY = {
            HOST: "static-assets.ny.gov",
            BASE_HOST: "www.ny.gov",
            hideSettings: false,
            hideSearch: false
        };
        (function (document, bundle, head) {
            head = document.getElementsByTagName('head')[0];
            bundle = document.createElement('script');
            bundle.type = 'text/javascript';
            bundle.async = true;
            bundle.src = "//static-assets.ny.gov/sites/all/widgets/universal-navigation/js/dist/global-nav-bundle.js";
            head.appendChild(bundle);
        }(document));
    </script>

In Drupal 8 and later versions, stylesheets (CSS) and JavaScript (JS) are loaded through asset libraries → .

5. FILE: src/Form/NysUNavForm.php

    /**
     * {@inheritdoc}.
     */
    public function validateForm(array &$form, FormStateInterface $form_state)
    {

    }

Remove empty method.

📌 | stub project from issue ref | [2.0.x] NYS Universal Navigation Integration

Comment 12 days ago →

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [2.0.x] NYS Universal Navigation Integration

Comment 12 days ago →

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

📌 | stub project from issue ref | [1.0.x] Buy Me a Coffee

Comment 13 days ago →

🇮🇳India vishal.kadam Mumbai

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

📌 | stub project from issue ref | Request for 'confirmed' user role

Comment 13 days ago →

🇮🇳India vishal.kadam Mumbai

The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.

Since you haven't contributed yet here is a list of resources to help you on your journey:

Comment 15 days ago →

🇮🇳India vishal.kadam Mumbai

@Jeya sundhar Thank you for committing my changes and releasing the update. Could you please give me credit to acknowledge my contribution? Thanks!

📌 | stub project from issue ref | Request for 'confirmed' user role

Comment 15 days ago →

🇮🇳India vishal.kadam Mumbai

The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.

Since you haven't contributed yet here is a list of resources to help you on your journey:

📌 | stub project from issue ref | Request for 'confirmed' user role

🇮🇳India vishal.kadam Mumbai

The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.

Since you haven't contributed yet here is a list of resources to help you on your journey:

📌 | stub project from issue ref | Request for access to edit organization page

🇮🇳India vishal.kadam Mumbai

The account has been already confirmed.

📌 | stub project from issue ref | [1.x] Power BI Integration

🇮🇳India vishal.kadam Mumbai

1. FILE: pwbi.module

/**
 * Implements hook_form_FORM_ID_alter().
 *
 * Add tenant field to Power Bi service principal auth workflow configuration.
 */
function pwbi_form_oauth2_client_edit_form_alter(&$form, FormStateInterface $form_state, $form_id) {

The description for that hook should also say for which form that hook is implemented, either by indicating that with the name of the class that implements the form (namespace included) or the form ID (which is usually indicated by getFormId()).

2. FILE: src/PowerBiEmbed.php

  /**
   * Constructor for PowerBiEmbed.
   *
   * @param \Drupal\Core\State\StateInterface $state
   *   The state service.
   * @param \Drupal\Core\Logger\LoggerChannelFactoryInterface $loggerFactory
   *   The logger service.
   * @param \Drupal\pwbi\Api\PowerBiClient $pwbiClient
   *   The PowerBi RestAPI client.
   */
  public function __construct(

FILE: src/Api/PowerBiClient.php

  /**
   * Constructor for PowerBiClient.
   *
   * @param \Drupal\Core\State\StateInterface $state
   *   The state service.
   * @param \Drupal\Core\Logger\LoggerChannelFactoryInterface $loggerFactory
   *   The logger service.
   * @param \GuzzleHttp\ClientInterface $httpClient
   *   The http_request service.
   * @param \Drupal\oauth2_client\Service\Oauth2ClientService $auth
   *   The PowerBi authentication service.
   * @param \Drupal\Core\File\FileUrlGenerator $fileUrlGenerator
   *   The file url generator service.
   * @param \Drupal\Core\File\FileSystemInterface $fileSystem
   *   The file system service.
   */
  public function __construct(

FILE: src/Form/PowerBiEmbedConfigForm.php

  /**
   * Constructor for PowerBiEmbedConfigForm.
   *
   * @param \Drupal\pwbi\PowerBiEmbed $pwbiEmbed
   *   The PowerBi embed service.
   */
  public function __construct(

FILE: src/Form/PowerBiRestApiTestForm.php

  /**
   * Constructor for PowerBiRestApiTestForm.
   *
   * @param \Drupal\pwbi\Api\PowerBiClient $client
   *   The PowerBi api client service.
   */
  public function __construct(PowerBiClient $client) {

FILE: src/Plugin/Field/FieldFormatter/PowerBiEmbedFormatter.php

  /**
   * {@inheritDoc}
   */
  public function __construct(

FILE: src/Plugin/Field/FieldWidget/PowerBiEmbedWidget.php

  /**
   * {@inheritdoc}
   */
  public function __construct(

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

📌 | stub project from issue ref | [1.x] Power BI Integration

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [1.x] Power BI Integration

📌 | Flickr Integration Suite | Automated Drupal 11 compatibility fixes for flickr_integration_suite

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Comment 17 days ago →

🇮🇳India vishal.kadam Mumbai

Working on an alternative to the Slick library (which is not compatible with jQuery 4).

📌 | stub project from issue ref | Request for 'confirmed' user role

Comment 19 days ago →

🇮🇳India vishal.kadam Mumbai

Hello, and a warm welcome to the Drupal community!

You can contribute to drupal.org without having the role.

The 'confirmed' role is for users that contribute to this website. In this case, you've not contributed any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org.

You can add a comment to this issue to request a new review in order to get 'confirmed' or you will get that automatically.

Please visit the Become a confirmed user → page for information.

Here is a list of resources that will assist you in making helpful contributions:

📌 | stub project from issue ref | Request for 'confirmed' user role

Comment 21 days ago →

🇮🇳India vishal.kadam Mumbai

Hello, and a warm welcome to the Drupal community!

You can contribute to drupal.org without having the role.

The 'confirmed' role is for users that contribute to this website. In this case, you've not contributed any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org.

You can add a comment to this issue to request a new review in order to get 'confirmed' or you will get that automatically.

Please visit the Become a confirmed user → page for information.

Here is a list of resources that will assist you in making helpful contributions:

📌 | stub project from issue ref | [2.0.x] Layout Builder Lock

Comment 21 days ago →

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | Request for 'confirmed' user role

Comment 22 days ago →

🇮🇳India vishal.kadam Mumbai

Hello, and a warm welcome to the Drupal community!

You can contribute to drupal.org without having the role.

The 'confirmed' role is for users that contribute to this website. In this case, you've not contributed any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org.

You can add a comment to this issue to request a new review in order to get 'confirmed' or you will get that automatically.

Please visit the Become a confirmed user → page for information.

Here is a list of resources that will assist you in making helpful contributions:

📌 | stub project from issue ref | [1.0.x] SmartLink Formatter

Comment 23 days ago →

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [2.x] IEF Complex Widget Dialog

Comment 23 days ago →

🇮🇳India vishal.kadam Mumbai

1. FILE: ief_popup.info.yml

core_version_requirement: ^8 || ^9 || ^10 || ^11

The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement → key.

package: Custom

This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.

2. FILE: ief_popup.module

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

📌 | stub project from issue ref | [2.x] IEF Complex Widget Dialog

Comment 24 days ago →

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [2.x] IEF Complex Widget Dialog

Comment 24 days ago →

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

📌 | stub project from issue ref | [1.0.x] Smileys Field

🇮🇳India vishal.kadam Mumbai

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

📌 | stub project from issue ref | [1.0.x] Smileys Field

🇮🇳India vishal.kadam Mumbai

1. FILE: smileys_field.module

/**
 * @file
 * Primary module hooks for Smileys Field module.
 */

Drupal does not have primary and secondary hooks. Instead of that, it is preferable to use the usual description: Hook implementations for the [module name] module. where [module name] is the name of the module given in its .info.yml file.

/**
 * Implements hook_form_FORM_ID_alter().
 */
function smileys_field_form_node_form_alter(&$form, FormStateInterface $form_state, $form_id) {

/**
 * Implements hook_form_FORM_ID_alter().
 */
function smileys_field_form_comment_form_alter(&$form, FormStateInterface $form_state, $form_id) {

/**
 * Implements hook_form_FORM_ID_alter().
 */
function smileys_field_form_privatemsg_message_add_form_alter(&$form, FormStateInterface $form_state, $form_id) {

The description for that hook should also say for which form that hook is implemented, either by indicating that with the name of the class that implements the form (namespace included) or the form ID (which is usually indicated by getFormId()).

2. FILE: src/Form/SmileysAddEditForm.php

  /**
   * Constructs a form.
   *
   * @param \Drupal\Core\Database\Connection $database
   *   The database connection.
   */
  public function __construct(Connection $database) {

FILE: src/Form/SmileysDeleteForm.php

  /**
   * Constructs a form.
   *
   * @param \Drupal\Core\Database\Connection $database
   *   The database connection.
   */
  public function __construct(Connection $database) {

FILE: src/Form/SmileysListForm.php

  /**
   * Constructs a form.
   *
   * @param \Drupal\Core\Database\Connection $database
   *   The database connection.
   */
  public function __construct(Connection $database) {

FILE: src/Form/SmileysSelectForm.php

  /**
   * Constructs a form.
   *
   * @param \Drupal\Core\Database\Connection $database
   *   The database connection.
   * @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
   *   The module handler service.
   */
  public function __construct(Connection $database, ModuleHandlerInterface $module_handler) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

📌 | stub project from issue ref | [1.0.x] Smileys Field

🇮🇳India vishal.kadam Mumbai

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

📌 | stub project from issue ref | [1.0.x] Smileys Field

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [1.0.x] Smileys Field

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

📌 | stub project from issue ref | [1.0.X] SSO Connector

🇮🇳India vishal.kadam Mumbai

Yes, it is normal. Sometimes the application queue experiences a backlog, and applications may sit in the queue for months before getting reviewed.

📌 | stub project from issue ref | Request for 'confirmed' user role

🇮🇳India vishal.kadam Mumbai

Hello, and a warm welcome to the Drupal community!

You can contribute to drupal.org without having the role.

The 'confirmed' role is for users that contribute to this website. In this case, you've not contributed any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org.

You can add a comment to this issue to request a new review in order to get 'confirmed' or you will get that automatically.

Please visit the Become a confirmed user → page for information.

Here is a list of resources that will assist you in making helpful contributions:

💬 | stub project from issue ref | Request for 'confirmed' user role

📌 | Flickr Integration Suite | Automated Drupal 11 compatibility fixes for flickr_integration_suite

🇮🇳India vishal.kadam Mumbai

This issue does not seem to be a request for a confirmed account, but a support request posted in the wrong queue.

This issue queue is for problems, tasks, and support requests related to Drupal.org, not any site running on Drupal. For questions and support on sites you maintain or develop, please post on the forums → .

🐛 | Views migration from Drupal 7 to Drupal 10 | Deprecated function: Creation of dynamic property Drupal\views_migration\Plugin\migrate\source\d7\ViewsMigration::$typeMap

🇮🇳India vishal.kadam Mumbai

This module is dependent on the Key → module. The Key module does not have a Drupal 11 release.

Additionally, this module uses the Slick library, which is not compatible with jQuery 4.

🐛 | Views migration from Drupal 7 to Drupal 10 | Deprecated function: Creation of dynamic property Drupal\views_migration\Plugin\migrate\source\d7\ViewsMigration::$typeMap

🇮🇳India vishal.kadam Mumbai

🐛 | Views migration from Drupal 7 to Drupal 10 | Deprecated function: Creation of dynamic property Drupal\views_migration\Plugin\migrate\source\d7\ViewsMigration::$typeMap

🇮🇳India vishal.kadam Mumbai

🐛 | Views migration from Drupal 7 to Drupal 10 | Deprecated function: Creation of dynamic property Drupal\views_migration\Plugin\migrate\source\d7\ViewsMigration::$typeMap

🇮🇳India vishal.kadam Mumbai

Created a patch to define property $typeMap to fix the error.

🐛 | Views migration from Drupal 7 to Drupal 10 | Deprecated function: Creation of dynamic property Drupal\views_migration\Plugin\migrate\source\d7\ViewsMigration::$typeMap

🇮🇳India vishal.kadam Mumbai

🇮🇳India vishal.kadam Mumbai

vishal.kadam → created an issue.

📌 | stub project from issue ref | [1.0.x] Buy Me a Coffee

🇮🇳India vishal.kadam Mumbai

1. main is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → . The only exception is for the main branch, which is actually not fully supported on drupal.org and should be avoided.

2. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml bmc

FILE: bmc/bmc.module
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 1 | ERROR | [x] Missing file doc comment
 3 | ERROR | [x] When importing a class with "use", do not include a leading \
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: bmc/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
----------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 301 characters
 27 | WARNING | Line exceeds 80 characters; contains 100 characters
 29 | WARNING | Line exceeds 80 characters; contains 200 characters
 33 | WARNING | Line exceeds 80 characters; contains 126 characters
 35 | WARNING | Line exceeds 80 characters; contains 93 characters
 37 | WARNING | Line exceeds 80 characters; contains 98 characters
 39 | WARNING | Line exceeds 80 characters; contains 121 characters
 41 | WARNING | Line exceeds 80 characters; contains 104 characters
 43 | WARNING | Line exceeds 80 characters; contains 126 characters
 56 | WARNING | Line exceeds 80 characters; contains 125 characters
 60 | WARNING | Line exceeds 80 characters; contains 92 characters
----------------------------------------------------------------------

FILE: bmc/src/Plugin/Block/BmcButtonBlock.php
----------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 6 LINES
----------------------------------------------------------------------
 20 | ERROR | Missing short description in doc comment
 25 | ERROR | Missing short description in doc comment
 26 | ERROR | Missing parameter comment
 27 | ERROR | Missing parameter comment
 27 | ERROR | Missing parameter type
 28 | ERROR | Missing parameter comment
 28 | ERROR | Missing parameter type
 29 | ERROR | Missing parameter comment
----------------------------------------------------------------------

FILE: bmc/src/Form/BmcConfigurationForm.php
----------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------
   8 | ERROR | [x] Missing class doc comment
 231 | ERROR | [x] Expected 1 blank line after function; 0 found
 232 | ERROR | [x] Expected 1 newline at end of file; 2 found
 232 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: bmc/src/Controller/BmcHelpController.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 23 | ERROR | [x] Expected 1 blank line after function; 0 found
 24 | ERROR | [x] The closing brace for the class must have an empty line before it
----------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: bmc/bmc.routing.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 15 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

3. Add README.md file and follow the content and formatting described in README.md template → .

4. FILE: bmc.info.yml

package: Custom

This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.

5. FILE: bmc.module

/**
 * Implements hook_help().
 */
function bmc_help($route_name, RouteMatchInterface $route_match) {
  // Stubs for Module overviews block.
}

Remove empty hook.

6. FILE: src/Plugin/Block/BmcButtonBlock.php

  /**
   * @param array $configuration
   * @param $plugin_id
   * @param $plugin_definition
   * @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
   */
  public function __construct(array $configuration, $plugin_id, $plugin_definition, ConfigFactoryInterface $config_factory) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

7. FILE: templates/bmc.html.twig

    <style>
      .bmc-btn {
        min-width: 210px;
        color: #FFFFFF !important;
        background-color: {{ background_color }} !important;
        height: 60px;
        border-radius: 12px;
        font-size: 28px !important;
        font-weight: Normal;
        border: none;
        padding: 0px 24px;
        line-height: 27px;
        text-decoration: none !important;
        display: inline-flex !important;
        align-items: center;
        font-family: {{ font_family }} !important;
        -webkit-box-sizing: border-box !important;
        box-sizing: border-box !important;
        text-align: left !important;
      }

      .bmc-btn-text {
        margin-left: 8px;
        display: inline;
        line-height: 0;
      }

      .bmc-btn svg {
        height: 32px !important;
        margin-bottom: 0px !important;
        box-shadow: none !important;
        border: none !important;
        vertical-align: middle !important;
        transform: scale(0.9);
      }

      @media (max-width: 1200px) {
        .bmc-btn {
          font-size: 24px !important;
        }
        .bmc-btn svg {
          height: 28px !important;
        }

      }
      .bmc-button img {
        box-shadow: none !important;
        vertical-align:
          middle !important;
      }

      .bmc-button {
        display:
          inline-block !important;
        padding:0px 10px  !important;
        color:
          #FFFFFF !important;
        background-color:
      {{ background_color }} !important;
        border-radius: 3px !important;
        border: 1px solid transparent !important;
        font-size: 28px !important;
        box-shadow: 0px 1px 2px rgba(190, 190, 190, 0.5) !important;
        -webkit-box-shadow: 0px 1px 2px 2px rgba(190, 190, 190, 0.5) !important;
        -webkit-transition: 0.3s all linear !important;
        transition: 0.3s all linear !important;
        margin: 0 auto !important;
        font-family: "{{ font_family }}"
        !important;
      }

      .bmc-button: hover,
      .bmc-button: active,
      .bmc-button: focus {
        -webkit-box-shadow: 0 4px 16px 0 rgba(190, 190, 190, .45) !important;
        box-shadow: 0 4px 16px 0 rgba(190, 190, 190, .45) !important;
        opacity: 0.85 !important;
        color:
          #FFFFFF !important;
      }
    </style>

    <link href="https://fonts.googleapis.com/css?family={{ font_family }}" rel="stylesheet">

In Drupal 8 and later versions, stylesheets (CSS) and JavaScript (JS) are loaded through asset libraries → .

<span class="bmc-btn-text">{{ custom_text|t }}</span>

Variable translation should be handled in render array.

📌 | stub project from issue ref | Request for 'confirmed' user role

🇮🇳India vishal.kadam Mumbai

Hello, and a warm welcome to the Drupal community!

You can contribute to drupal.org without having the role.

The 'confirmed' role is for users that contribute to this website. In this case, you've not contributed any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org.

You can add a comment to this issue to request a new review in order to get 'confirmed' or you will get that automatically.

Please visit the Become a confirmed user → page for information.

Here is a list of resources that will assist you in making helpful contributions:

📌 | stub project from issue ref | [1.0.x] mosparo Integration

🇮🇳India vishal.kadam Mumbai

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

📌 | stub project from issue ref | Request for 'confirmed' user role

🇮🇳India vishal.kadam Mumbai

Hello, and a warm welcome to the Drupal community!

You can contribute to drupal.org without having the role.

The 'confirmed' role is for users that contribute to this website. In this case, you've not contributed any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org.

You can add a comment to this issue to request a new review in order to get 'confirmed' or you will get that automatically.

Please visit the Become a confirmed user → page for information.

Here is a list of resources that will assist you in making helpful contributions:

📌 | stub project from issue ref | [1.0.x] Event Log Track Encrypt

🇮🇳India vishal.kadam Mumbai

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

📌 | stub project from issue ref | [1.3.x] Advance Importer

🇮🇳India vishal.kadam Mumbai

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

📌 | stub project from issue ref | [1.3.x] Advance Importer

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [1.3.x] Advance Importer

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

📌 | stub project from issue ref | [1.0.x] Event Log Track Encrypt

Comment 28 days ago →

🇮🇳India vishal.kadam Mumbai

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml event_log_track_encrypt/

FILE: event_log_track_encrypt/README.md
-------------------------------------------------------------------------
FOUND 1 ERROR AND 34 WARNINGS AFFECTING 35 LINES
-------------------------------------------------------------------------
   7 | WARNING | [ ] Line exceeds 80 characters; contains 180 characters
  35 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
  36 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
  42 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
  45 | WARNING | [ ] Line exceeds 80 characters; contains 138 characters
  48 | WARNING | [ ] Line exceeds 80 characters; contains 98 characters
  49 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
  50 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
  57 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
  58 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
  59 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
  60 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters
  63 | WARNING | [ ] Line exceeds 80 characters; contains 148 characters
  71 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
  75 | WARNING | [ ] Line exceeds 80 characters; contains 270 characters
  78 | WARNING | [ ] Line exceeds 80 characters; contains 167 characters
  80 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
  82 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
  92 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 104 | WARNING | [ ] Line exceeds 80 characters; contains 155 characters
 105 | WARNING | [ ] Line exceeds 80 characters; contains 126 characters
 106 | WARNING | [ ] Line exceeds 80 characters; contains 165 characters
 108 | WARNING | [ ] Line exceeds 80 characters; contains 152 characters
 110 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
 136 | WARNING | [ ] Line exceeds 80 characters; contains 146 characters
 137 | WARNING | [ ] Line exceeds 80 characters; contains 670 characters
 138 | WARNING | [ ] Line exceeds 80 characters; contains 170 characters
 139 | WARNING | [ ] Line exceeds 80 characters; contains 169 characters
 151 | WARNING | [ ] Line exceeds 80 characters; contains 126 characters
 152 | WARNING | [ ] Line exceeds 80 characters; contains 652 characters
 156 | WARNING | [ ] Line exceeds 80 characters; contains 114 characters
 164 | WARNING | [ ] Line exceeds 80 characters; contains 777 characters
 165 | WARNING | [ ] Line exceeds 80 characters; contains 776 characters
 166 | WARNING | [ ] Line exceeds 80 characters; contains 653 characters
 167 | ERROR   | [x] Expected 1 newline at end of file; 4 found
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------

FILE: event_log_track_encrypt/config/install/event_log_track.encrypt.settings.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 15 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: event_log_track_encrypt/config/schema/event_log_track_encrypt.schema.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 49 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: event_log_track_encrypt/src/Commands/EventLogTrackDecryptCommands.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 353 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------

2. FILE: event_log_track_encrypt.module

/**
 * @file
 * Integrates encrypt.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

3. FILE: src/Commands/EventLogTrackDecryptCommands.php

  /**
   * EventLogTrackDecryptCommands constructor.
   *
   * @param \Drupal\Core\Database\Connection $connection
   *   The database connection service.
   * @param \Drupal\Core\Extension\ModuleHandlerInterface $moduleHandler
   *   The module_handler service.
   */
  public function __construct(Connection $connection, ModuleHandlerInterface $moduleHandler) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

📌 | stub project from issue ref | Request for manual review

Comment 28 days ago →

🇮🇳India vishal.kadam Mumbai

I have reviewed your posts and confirmed the account.

A site moderator user will review your post and publish it.

📌 | stub project from issue ref | [1.0.x] Event Log Track Encrypt

Comment 28 days ago →

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

📌 | stub project from issue ref | [10.x-4.x] Desk-Net

Comment 30 days ago →

🇮🇳India vishal.kadam Mumbai

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml desk_net/

FILE: desk_net/desk_net.module
-----------------------------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 9 LINES
-----------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
  11 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
  35 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
  39 | ERROR   | [x] Object operator not indented correctly; expected 4 spaces but found 6
  54 | ERROR   | [x] list(...) is forbidden, use [...] instead.
  59 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
  98 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 111 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 237 | ERROR   | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: desk_net/desk_net.info.yml
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------
  1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
  9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
 10 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-----------------------------------------------------------------------


FILE: desk_net/desk_net.install
-----------------------------------------------------------------------
FOUND 2 ERRORS AND 7 WARNINGS AFFECTING 8 LINES
-----------------------------------------------------------------------
  9 | WARNING | [x] Unused use statement
  9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection.
 10 | WARNING | [x] Unused use statement
 11 | WARNING | [x] Unused use statement
 14 | WARNING | [x] Unused use statement
 15 | WARNING | [x] Unused use statement
 16 | WARNING | [x] Unused use statement
 41 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 69 | ERROR   | [x] Object operator not indented correctly; expected 4 spaces but found 6
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: desk_net/config/install/desk_net.settings.yml
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
 24 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: desk_net/config/schema/desk_net.schema.yml
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
 76 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: desk_net/src/Controller/ActionController.php
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
-----------------------------------------------------------------------
 1335 | WARNING | Line exceeds 80 characters; contains 92 characters
 1417 | WARNING | Line exceeds 80 characters; contains 95 characters
 1419 | WARNING | Line exceeds 80 characters; contains 103 characters
 1426 | WARNING | Line exceeds 80 characters; contains 99 characters
 1448 | WARNING | Line exceeds 80 characters; contains 99 characters
 1450 | WARNING | Line exceeds 80 characters; contains 107 characters
 1457 | WARNING | Line exceeds 80 characters; contains 99 characters
 1463 | WARNING | Line exceeds 80 characters; contains 83 characters
-----------------------------------------------------------------------


FILE: desk_net/desk_net.permissions.yml
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
 3 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: desk_net/desk_net.links.task.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 53 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

2. FILE: desk_net.module

/**
 * Implements HOOK_form_BASE_FORM_ID_alter.
 */
function desk_net_form_node_form_alter(&$form, FormStateInterface $form_state) {

The description for that hook should also say for which form that hook is implemented, either by indicating that with the name of the class that implements the form (namespace included) or the form ID.

📌 | stub project from issue ref | [10.x-4.x] Desk-Net

Comment 30 days ago →

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [10.x-4.x] Desk-Net

Comment 30 days ago →

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

📌 | stub project from issue ref | [1.0.x] SmartLink Formatter

🇮🇳India vishal.kadam Mumbai

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

📌 | stub project from issue ref | [1.0.x] SmartLink Formatter

🇮🇳India vishal.kadam Mumbai

FILE: src/Plugin/Field/FieldFormatter/SmartLinkFormatter.php

$link_title = \Drupal::token()->replace($item->title, [$entity->getEntityTypeId() => $entity], ['clear' => TRUE]);

\Drupal calls should be avoided in classes, use dependency injection instead

📌 | stub project from issue ref | Request for 'confirmed' user role

🇮🇳India vishal.kadam Mumbai

I have reviewed your posts and confirmed the account.

📌 | stub project from issue ref | [1.0.x] mosparo Integration

🇮🇳India vishal.kadam Mumbai

1. FILE: mosparo_integration.libraries.yml

version: VERSION

FILE: modules/mosparo_captcha/mosparo_captcha.libraries.yml

version: VERSION

VERSION is only used by Drupal core modules. Contributed modules should use a literal string that does not change with the Drupal core version a site is using.

2. FILE: src/Event/MosparoIntegrationFilterFieldTypesEvent.php

  /**
   * Constructs the object.
   *
   * @param array $ignoredFieldTypes
   *   The list of ignored field types.
   * @param array $verifiableFieldTypes
   *   The list of verifiable field types.
   */
  public function __construct(array $ignoredFieldTypes, array $verifiableFieldTypes) {

FILE: src/Event/MosparoIntegrationFilterFormDataEvent.php

  /**
   * Constructs the object.
   *
   * @param array $formData
   *   The form data as array.
   * @param array $requiredFields
   *   List of keys of the required fields.
   * @param array $verifiableFields
   *   List of keys of the verifiable fields.
   */
  public function __construct(array $formData, array $requiredFields, array $verifiableFields) {

FILE: src/Form/MosparoConnectionForm.php

  /**
   * Constructs the form.
   *
   * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entityTypeManager
   *   The entity type manager.
   */
  public function __construct(EntityTypeManagerInterface $entityTypeManager) {

FILE: src/Form/MosparoConnectionForm.php

  /**
   * Constructs the form.
   *
   * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entityTypeManager
   *   The entity type manager.
   */
  public function __construct(EntityTypeManagerInterface $entityTypeManager) {

FILE: modules/mosparo_webform/src/Plugin/WebformElement/MosparoElement.php

  /**
   * {@inheritdoc}
   */
  public static function create(ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

3. FILE: modules/mosparo_contact/mosparo_contact.module

/**
 * Validates the form.
 *
 */
function mosparo_contact_form_validate(array $form, FormStateInterface &$form_state, MosparoConnectionInterface $connection, MosparoWidget $widget) {

/**
 * Drupal hook: hook_help()
 */
function mosparo_contact_help($route_name, RouteMatchInterface $route_match) {

FILE: modules/mosparo_webform/mosparo_webform.module

/**
 * Drupal hook: hook_help()
 */
function mosparo_webform_help($route_name, RouteMatchInterface $route_match) {

When implementing a hook, use a short summary of the form "Implements hook_menu().". Omit the parameter and return value documentation in this case.

📌 | stub project from issue ref | [1.0.x] IP Country Logger

🇮🇳India vishal.kadam Mumbai

It appears there are multiple project applications created using your account.

Since a successful completion of the project application process results in the applicant being granted the necessary role to be able to opt projects into security advisory coverage, there is no need to take multiple applications through the process. Once the first application has been successfully approved, the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers, which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as Closed (duplicate), with only one application left open.

If you prefer that we proceed through this review process with a different application, then feel free to close the application left open as a duplicate, and re-open one of the project applications which had been closed.

📌 | stub project from issue ref | [1.0.x] IP Country Logger

🇮🇳India vishal.kadam Mumbai

It appears there are multiple project applications created using your account.

Since a successful completion of the project application process results in the applicant being granted the necessary role to be able to opt projects into security advisory coverage, there is no need to take multiple applications through the process. Once the first application has been successfully approved, the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers, which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as Closed (duplicate), with only one application left open.

If you prefer that we proceed through this review process with a different application, then feel free to close the application left open as a duplicate, and re-open one of the project applications which had been closed.

📌 | stub project from issue ref | [1.0.x] TFA Headless

🇮🇳India vishal.kadam Mumbai

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

📌 | stub project from issue ref | [1.0.x] DonorPerfect

🇮🇳India vishal.kadam Mumbai

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

📌 | stub project from issue ref | [1.0.x] CaptchEtat

🇮🇳India vishal.kadam Mumbai

LICENSE.txt is not a mandatory file, but it can be left, as long as the license is the same used by Drupal core.

📌 | Visualization Charts | Automated Drupal 11 compatibility fixes for visualization_charts

🇮🇳India vishal.kadam Mumbai

vishal.kadam → made their first commit to this issue’s fork.

📌 | stub project from issue ref | [1.0.x] DonorPerfect

🇮🇳India vishal.kadam Mumbai

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml donorperfect/

FILE: donorperfect/modules/gift/src/Form/GiftForm.php
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------
 51 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------

FILE: donorperfect/modules/other/src/Form/OtherForm.php
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------
 51 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------

FILE: donorperfect/modules/contact/src/Form/ContactForm.php
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------
 51 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------

FILE: donorperfect/modules/donor/src/Form/DonorForm.php
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------
 51 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------

FILE: donorperfect/modules/donor/src/Entity/DonorController.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 71 | ERROR | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------

FILE: donorperfect/modules/donor/src/DonorNameAlphaFieldItemList.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 10 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------

FILE: donorperfect/donorperfect.routing.yml
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
 32 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------

FILE: donorperfect/donorperfect.module
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------
 9 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
   |         | xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
-------------------------------------------------------------------------------

FILE: donorperfect/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 7 WARNINGS AFFECTING 7 LINES
----------------------------------------------------------------------
 18 | WARNING | Line exceeds 80 characters; contains 81 characters
 25 | WARNING | Line exceeds 80 characters; contains 83 characters
 37 | WARNING | Line exceeds 80 characters; contains 81 characters
 57 | WARNING | Line exceeds 80 characters; contains 81 characters
 58 | WARNING | Line exceeds 80 characters; contains 82 characters
 59 | WARNING | Line exceeds 80 characters; contains 81 characters
 70 | WARNING | Line exceeds 80 characters; contains 81 characters
----------------------------------------------------------------------

FILE: donorperfect/src/DPQuery.php
-------------------------------------------------------------------------------
FOUND 33 ERRORS AND 9 WARNINGS AFFECTING 42 LINES
-------------------------------------------------------------------------------
    9 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
   64 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  103 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  118 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  126 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  169 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  226 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  287 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  323 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
  329 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  376 | ERROR   | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
  409 | ERROR   | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
  443 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  526 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  545 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  564 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  641 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  723 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  744 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
  970 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 1060 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 1142 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 1186 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 1239 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 1618 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 1791 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 1847 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 1953 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 1969 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 1985 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 2017 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 2027 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 2030 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 2031 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 2125 | ERROR   | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
 2213 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 2245 | ERROR   | The array declaration extends to column 102 (the limit is 80). The array content should be split up over multiple lines
 2302 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 2310 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 2343 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 2351 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 2368 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------

FILE: donorperfect/src/Plugin/views/query/DonorPerfect.php
-------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
-------------------------------------------------------------------------------
  34 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
  84 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 142 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 216 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 244 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 258 | ERROR | The array declaration extends to column 85 (the limit is 80). The array content should be split up over multiple lines
 334 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------

FILE: donorperfect/src/Form/EntitySettingsFormBase.php
-------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------
  50 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 126 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 127 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------

FILE: donorperfect/src/Form/SettingsForm.php
-------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------
 82 | ERROR   | The array declaration extends to column 108 (the limit is 80). The array content should be split up over multiple lines
 82 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 82 | ERROR   | The array declaration extends to column 107 (the limit is 80). The array content should be split up over multiple lines
 82 | ERROR   | The array declaration extends to column 106 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------

FILE: donorperfect/src/Entity/Query/QueryAggregate.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 108 | ERROR | The array declaration extends to column 110 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------

FILE: donorperfect/src/Entity/ControllerInterface.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 14 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------

FILE: donorperfect/src/Entity/ControllerServiceInterface.php
-------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------
 24 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 33 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 42 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 56 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 67 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 78 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------

FILE: donorperfect/src/Entity/ControllerService.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------
 30 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
 67 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------

FILE: donorperfect/src/Entity/DefaultTableMapping.php
-------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------
  76 | ERROR | The array declaration extends to column 107 (the limit is 80). The array content should be split up over multiple lines
 146 | ERROR | The array declaration extends to column 81 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------

FILE: donorperfect/src/DPUtility.php
-------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-------------------------------------------------------------------------------
 194 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 245 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 287 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
 418 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------

FILE: donorperfect/src/Element/Name.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 174 | ERROR | The array declaration extends to column 104 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------

FILE: donorperfect/src/Element/Email.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 71 | ERROR | The array declaration extends to column 106 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------

FILE: donorperfect/src/Controller/DonorPerfectController.php
-------------------------------------------------------------------------------
FOUND 4 ERRORS AND 1 WARNING AFFECTING 5 LINES
-------------------------------------------------------------------------------
  55 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
  84 | ERROR   | [x] Namespaced classes/interfaces/traits should be referenced with use statements
  95 | ERROR   | [ ] The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
 126 | ERROR   | [ ] The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines
 145 | ERROR   | [ ] The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------

FILE: donorperfect/donorperfect.api.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 29 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------

2. FILE: donorperfect.module

/**
 * @file
 * Code for the DonorPerfect module.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

📌 | stub project from issue ref | [2.x] Multistep Form Framework

🇮🇳India vishal.kadam Mumbai

1. @branch is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → .

2. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml multistep_form_framework/

FILE: multistep_form_framework/modules/multistep_form_framework_examples/src/Form/BuyBookStep/Description.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 54 | ERROR | No key specified for array entry; first entry specifies key
--------------------------------------------------------------------------------

FILE: multistep_form_framework/README.md
------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
------------------------------------------------------------------------
 13 | WARNING | Line exceeds 80 characters; contains 89 characters
 16 | WARNING | Line exceeds 80 characters; contains 94 characters
 18 | WARNING | Line exceeds 80 characters; contains 194 characters
 21 | WARNING | Line exceeds 80 characters; contains 83 characters
------------------------------------------------------------------------

📌 | Drupal.org customizations | Remove the line that a new packaging process has been queued

🇮🇳India vishal.kadam Mumbai

Apologies.

I have replicated this issue and believe it should be considered as a bug.

Technically, when we update the release node, there is no code change, yet it still proceeds with packaging.

📌 | Drupal.org customizations | Remove the line that a new packaging process has been queued

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [1.0.x] DonorPerfect

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [1.0.x] DonorPerfect

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

📌 | stub project from issue ref | Request for 'confirmed' user role

🇮🇳India vishal.kadam Mumbai

I have reviewed your post and confirmed the account.

📌 | stub project from issue ref | [1.0.x] Azure OAuth Client SSO

🇮🇳India vishal.kadam Mumbai

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

📌 | Azure OAuth Client SSO | Module have some PHPCS Issue

🇮🇳India vishal.kadam Mumbai

I have reviewed the latest development release code and confirmed that there are no PHPCS issues present.

📌 | stub project from issue ref | [1.0.x] Image Scale and Fill Background Effect

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [1.0.x] Image Scale and Fill Background Effect

🇮🇳India vishal.kadam Mumbai

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
For the time this application is open, only your commits are allowed.
The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
Reviewers should show the output of a CLI tool → only once per application.
It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

📌 | stub project from issue ref | Request for spam detection removal

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | Request for 'confirmed' user role

🇮🇳India vishal.kadam Mumbai

💬 | stub project from issue ref | Site functionality problem

🇮🇳India vishal.kadam Mumbai

📌 | stub project from issue ref | [1.0.x] Personality Assessment Test/Quiz

🇮🇳India vishal.kadam Mumbai

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml personality_assessment_test/

FILE: personality_assessment_test/personality_test.install
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 149 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------

FILE: personality_assessment_test/src/Plugin/Block/PersonalityTestQuizBlock.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
 20 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
--------------------------------------------------------------------------------

FILE: personality_assessment_test/src/Options.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 113 | ERROR | The array declaration extends to column 83 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------

FILE: personality_assessment_test/src/Controller/PersonalityTestController.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 16 | WARNING | @author tags are not usually used in Drupal, because over time multiple contributors will touch the code anyway
 38 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 59 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------

2. FILE: personality_test.module

/**
 * @file
 * Primary module hooks for personality_test module.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

3. FILE: templates/personality-test-quiz.html.twig

Move all scripts (JavaScript) and styles (CSS) into a library and attach them. See the process here → .

📌 | stub project from issue ref | [1.0.x] Node field values

🇮🇳India vishal.kadam Mumbai

It seems you are already able to opt projects projects for which you can edit the project page. In this case, there is no need to apply for a second time, as these applications just give the permission to opt projects into security advisory coverage.

If you are not able to opt a project into security advisory coverage, and you maintainer of that project, it means that either you do not have the permission to edit the project node, or the project has been created less than ten days ago. In both the cases, there is nothing a second application would fix.

I am closing this issue as duplicate of the issue that gave you the permission to opt projects into security coverage.

📌 | stub project from issue ref | [1.1.x] Rest Password Reset

🇮🇳India vishal.kadam Mumbai

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

📌 | AI Auto-reference | #options values usually have to run through t() for translation

🇮🇳India vishal.kadam Mumbai

📌 | AI Auto-reference | #options values usually have to run through t() for translation

🇮🇳India vishal.kadam Mumbai

I have checked and confirmed that the reported issue has been fixed in 1.0.x-dev.

📌 | stub project from issue ref | [1.0.x] Personality Assessment Test/Quiz

🐛 | AI Interpolator | The service "ai_interpolator.rule_helper.general" has a dependency on a non-existent service "token.tree_builder".

🇮🇳India vishal.kadam Mumbai

🇮🇳India vishal.kadam Mumbai

🇮🇳India vishal.kadam Mumbai

added screenshot of configuration page