1. 2.x-dev is a wrong name for a branch. Release branch names always end with the literal .x as described in
Release branches →
.
2. FILE: feeds_ical.info.yml
core_version_requirement: ^8 || ^9 || ^10
The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement → key.
You need to create a new issue → in the Drupal.org security advisory coverage applications queue.
1. FILE: guest_suite.info.yml
package: Custom
2. FILE: guest_suite.module
/**
* @file
* Guest suite module file.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
1. FILE: README.md
The README file is missing the required sections → , including Project name, Requirements, Installation, and Configuration.
2. FILE: easy_lqp.module
/**
* @file
* Easy LQP hooks.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
3. FILE: src/Form/Config/GenerateImageStyles.php
ConfigFormBase::__construct() requires two parameters. See the change record → .
FILE: easy_lqp.info.yml
Given the changes in ConfigFormBase, the module cannot be compatible with Drupal releases before 10.2.0.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
- For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage. - Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
- For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage. - Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
@srtmdev Check the application process → .
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
The account has been already confirmed.
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. FILE: README.md
The README file is missing the required sections → , including Project name, Requirements, Installation and Configuration.
2. FILE: custom_status_report.module
/**
* @file
* Implements custom status report functionality.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
/**
* Implements hook_requirements().
*/
function custom_status_report_requirements_alter(array &$requirements) {Doc comment is incorrect. It should be "Implements hook_requirements_alter().".
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
Rest seems fine to me.
Let’s wait for other reviewers and Code Review Administrator to take a look and if everything goes fine, you will get the role.
I have reviewed your posts and confirmed the account.
1. FILE: view_pager_plugin.info.yml
package: Custom
This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.
2. FILE: README.md
The README file is missing the required sections → , including Project name, and Requirements.
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
1. FILE: src/Service/UrlStatusScannerService.php
/**
* Construct the service.
*
* @param \Drupal\Core\Database\Connection $database
* The database connection.
* @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
* The config factory.
* @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity
* The entity object.
* @param \Drupal\Core\Entity\EntityTypeBundleInfoInterface $entity_type_bundle_info
* The entity type bundle service.
*/
public function __construct(FILE: src/Form/UrlStatusScannerDashboard.php
/**
* Construct the service.
*
* @param \Drupal\url_status_scanner\Service\UrlStatusScannerService $url_status_scanner_service
* The urlStatusScannerService.
* @param \Drupal\Core\Database\Connection $database
* The database connection.
* @param \Drupal\Core\Extension\ExtensionList $extension_list
* The module extension list service.
*/
public function __construct(UrlStatusScannerService $url_status_scanner_service, Connection $database, ExtensionList $extension_list) {The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.
2. FILE: url_status_scanner.module
/**
* @file
* Provides help documentation for the URL Status Scanner module.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
I have reviewed your posts and confirmed the account.
A site moderator will review your post, publish it, and confirm your account.
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
I have reviewed your posts and confirmed the account.
Rest seems fine to me.
Let’s wait for other reviewers and Code Review Administrator to take a look and if everything goes fine, you will get the role.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
These applications do not require that new releases are created after reviews.
What I Recommend
- If you’re maintaining only one stable branch → Keep
1.xas is. - If you need to support multiple minor versions separately → Create
1.2.xfor1.2.*patches.
Just a quick note: The reported changes should be committed to the review branch (1.x).
If you changed what has been reported, please change the status to Needs review. In this way, reviewers will know everything has been changed and can be reviewed again.
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml markdownify/
FILE: markdownify/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 17 WARNINGS AFFECTING 17 LINES
----------------------------------------------------------------------
3 | WARNING | Line exceeds 80 characters; contains 334 characters
26 | WARNING | Line exceeds 80 characters; contains 88 characters
28 | WARNING | Line exceeds 80 characters; contains 210 characters
29 | WARNING | Line exceeds 80 characters; contains 123 characters
30 | WARNING | Line exceeds 80 characters; contains 161 characters
31 | WARNING | Line exceeds 80 characters; contains 141 characters
58 | WARNING | Line exceeds 80 characters; contains 141 characters
64 | WARNING | Line exceeds 80 characters; contains 160 characters
68 | WARNING | Line exceeds 80 characters; contains 162 characters
76 | WARNING | Line exceeds 80 characters; contains 139 characters
77 | WARNING | Line exceeds 80 characters; contains 159 characters
78 | WARNING | Line exceeds 80 characters; contains 165 characters
84 | WARNING | Line exceeds 80 characters; contains 200 characters
112 | WARNING | Line exceeds 80 characters; contains 100 characters
164 | WARNING | Line exceeds 80 characters; contains 87 characters
166 | WARNING | Line exceeds 80 characters; contains 96 characters
174 | WARNING | Line exceeds 80 characters; contains 82 characters
----------------------------------------------------------------------
FILE: markdownify/src/Service/MarkdownifyEntityRenderer.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: markdownify/src/Controller/MarkdownifyController.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Symfony\Component\DependencyInjection\ContainerInterface.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
I confirmed the account, since creating an organization node requires a confirmed account.
Rest seems fine to me.
Let’s wait for other reviewers and Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. develop and main are wrong names for a branch. Release branch names always end with the literal .x as described in
Release branches →
. The only exception is for the main branch, which is actually not fully supported on drupal.org and should be avoided.
2. FILE: README.md
The README file is missing the required section → - Requirements.
3. FILE: decorative_images.info.yml
package: Custom
This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.
4. FILE: decorative_images.module
/**
* @file
* Allows giving images a presentation role.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml media_default_image/
FILE: media_default_image/Readme.md
-----------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------
34 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
36 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
40 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------2. FILE: media_default_image.module
/**
* @file
* Contains media default image module.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
3. FILE: src/Form/DefaultImageSettingsForm.php
Properties should be declared first in a class, followed by methods.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. FILE: README.md
The README file is missing the required sections → including Requirements.
2. FILE: entity_usage_explorer.module
/**
* @file
* The module file.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
3. FILE: templates/entity-usage-overview-page.html.twig
Twig code needs to be correctly indented. Drupal uses two spaces for indentation, not four spaces or tabs.
Strings shown in the user interface must be translatable. That holds true also for strings used in template files.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. FILE: README.md
The README file is missing the required sections → , including Installation, and Configuration.
2. FILE: field_visibility_conditions.info.yml
package: Custom
This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.
3. FILE: field_visibility_conditions.module
/**
* @file
* Primary module hooks for Field Visibility Conditions module.
*/Drupal does not have primary and secondary hooks. Instead of that, it is preferable to use the usual description: “Hook implementations for the [module name] module”, where [module name] is the name of the module given in its .info.yml file.
/**
* Implements hook_form_BASE_FORM_ID_alter().
*/
function field_visibility_conditions_form_field_config_edit_form_alter(&$form, FormStateInterface $form_state, $form_id) {The description for that hook should also say for which form that hook is implemented, either by indicating that with the name of the class that implements the form (namespace included) or the form ID (which is usually indicated by getFormId()).
4. FILE: src/FormAlters.php
/**
* Constructor for FormAlters.
*/
public function __construct(The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.
FILE: templates/whatsapp-button-template.html.twig
Twig code needs to be correctly indented. Drupal uses two spaces for indentation, not four spaces or tabs.
1. FILE: README.md
The README file is missing the required sections → , including Requirements and Installation.
2. FILE: mattermost_logger.info.yml
package: Custom
This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
I have confirmed the account based on module project contribution.
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml whatsapp_button/
FILE: whatsapp_button/src/Plugin/Block/WhatsappButtonBlock.php
--------------------------------------------------------------------------------
FOUND 11 ERRORS AFFECTING 11 LINES
--------------------------------------------------------------------------------
426 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
427 | ERROR | The array declaration extends to column 86 (the limit is 80). The array content should be split up over multiple lines
428 | ERROR | The array declaration extends to column 120 (the limit is 80). The array content should be split up over multiple lines
429 | ERROR | The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines
449 | ERROR | The array declaration extends to column 88 (the limit is 80). The array content should be split up over multiple lines
456 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
470 | ERROR | The array declaration extends to column 92 (the limit is 80). The array content should be split up over multiple lines
473 | ERROR | The array declaration extends to column 91 (the limit is 80). The array content should be split up over multiple lines
480 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
483 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
499 | ERROR | The array declaration extends to column 84 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------2. FILE: README.txt
README file should follow the content and formatting described in README.md template → .
3. FILE: whatsapp_button.info.yml
package: Custom
This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.
4. FILE: whatsapp_button.module
/**
* @file
* Primary module hooks for Whatsapp Button module.
*
* @DCG
* This file is no longer required in Drupal 8.
* @see https://www.drupal.org/node/2217931
*/Drupal does not have primary and secondary hooks. Instead of that, it is preferable to use the usual description: “Hook implementations for the [module name] module”, where [module name] is the name of the module given in its .info.yml file.
/**
* Implements hook_preprocess_HOOK().
*/
function whatsapp_button_preprocess_block(&$variables) {The description for this hook should also say for which hook it is implemented.
5. FILE: templates/whatsapp-button-template.html.twig
Twig code needs to be correctly indented. Drupal uses two spaces for indentation, not four spaces or tabs.
6. FILE: src/Plugin/Block/WhatsappButtonBlock.php
/**
* Constructor with dependency injection.
*/
public function __construct(The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
The message you see is a standard message that is shown to all new users that have created an account here, but haven't created any content.
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. FILE: README.md
The README file is missing the required sections → , - Requirements.
2. FILE: README.txt
Remove README.txt since README.md is present.
3. FILE: fleetview_client.module
/**
* @file
* Fleetview client module.
*
* @author Dylan James
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
/**
* Implements hook_menu().
*/
function fleetview_client_menu() {
$items = [];
$items['admin/config/system/fleetview_client'] = [
'title' => 'System Status',
'description' => 'Configuration for the Fleetview client module',
'route_name' => 'fleetview_client.admin_settings',
'type' => MENU_LOCAL_TASK | MENU_NORMAL_ITEM,
];
return $items;
}This is deprecated code written in the Drupal 7 and should be removed.
4. FILE: src/Controller/FleetviewClientController.php
/**
* FleetviewClientController constructor.
*
* @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
* The module handler to invoke the alter hook with.
* @param \Drupal\Core\Extension\ThemeHandlerInterface $theme_handler
* The theme handler.
* @param \Drupal\fleetview_client\Services\FleetviewClientEncryption $encrypt
* The system status encrypt service.
* @param \Drupal\update\UpdateManagerInterface $updateManager
* The update manager.
* @param \Drupal\Core\State\StateInterface $state
* The state storage service.
* @param \Drupal\system\SystemManager $systemManager
* The system manager.
*/
public function __construct(ModuleHandlerInterface $module_handler, ThemeHandlerInterface $theme_handler, FleetviewClientEncryption $encrypt, UpdateManagerInterface $updateManager, StateInterface $state, $systemManager) {The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
I have confirmed the account based on module contribution.
The message you see is a standard message that is shown to all new users that have created an account here, but haven't created any content.
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
These applications do not require that new releases are created after reviews.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
The security advisory coverage application process assigns the required role to the applicant, enabling them to opt projects into security advisory coverage.
To verify if a user has the necessary role to opt a module into security advisory coverage, navigate to the user profile and check for the section labeled "Can opt projects into security advisory coverage."
A site moderator user will review your post and publish it.
I have reviewed your posts and confirmed the account.
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml masked_output/
FILE: masked_output/masked_output.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: masked_output/src/Plugin/Field/FieldFormatter/MaskOutputFormatter.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
31 | ERROR | [ ] Class property $field_definition should use lowerCamel naming without underscores
170 | WARNING | [ ] There must be no blank line following an inline comment
170 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
170 | ERROR | [x] Comments may not appear after statements
183 | ERROR | [x] Expected newline after closing brace
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: masked_output/src/Plugin/Field/FieldFormatter/MaskEmailOutputFormatter.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
24 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
25 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
26 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
27 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
28 | ERROR | [ ] Class property $field_definition should use lowerCamel naming without underscores
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------2. FILE: masked_output.module
/**
* @file
* Contains masked_output.module.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
I have reviewed the posts and confirmed the account.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
I have reviewed the `.gitlab-ci.yml` configuration, and everything looks good.
As for the pipeline, I can see that it has passed.
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml openai_client/
FILE: openai_client/query.txt
--------------------------------------------------------------------------------
FOUND 16 ERRORS AND 1 WARNING AFFECTING 16 LINES
--------------------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 133 characters
59 | ERROR | Missing short description in doc comment
64 | ERROR | Missing short description in doc comment
69 | ERROR | Parameter $api is not described in comment
69 | ERROR | Parameter $dateFormatter is not described in comment
154 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
155 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
156 | ERROR | The array declaration extends to column 108 (the limit is 80). The array content should be split up over multiple lines
158 | ERROR | The array declaration extends to column 137 (the limit is 80). The array content should be split up over multiple lines
159 | ERROR | The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines
160 | ERROR | The array declaration extends to column 104 (the limit is 80). The array content should be split up over multiple lines
270 | ERROR | Description for the @return value is missing
282 | ERROR | Description for the @return value is missing
292 | ERROR | Description for the @return value is missing
298 | ERROR | Doc comment is empty
315 | ERROR | Description for the @return value is missing
325 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------
FILE: openai_client/src/OpenAIClientWrapper.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
68 | ERROR | [x] Whitespace found at end of line
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------2. FILE: openai_client.info.yml
package: Custom
This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.
3. FILE: openai_client.module
/**
* @file
* Primary module hooks for OpenAI Client module.
*/Drupal does not have primary and secondary hooks. Instead of that, it is preferable to use the usual description: “Hook implementations for the [module name] module”, where [module name] is the name of the module given in its .info.yml file.
4. FILE: src/Controller/AssistantsListController.php
// {
// "id": "asst_wMdO2WcFgvAQgQhez5fZ4wxd",
// "object": "assistant",
// "createdAt": 1699353422,
// "name": "Prueba",
// "description": null,
// "model": "gpt-4-1106-preview",
// "instructions": null,
// "tools": [],
// "fileIds": [],
// "metadata": []
// }FILE: src/Form/AssistantEditForm.php
// $session->set($this->getFormId(), $form_state->getValue('value'));
Remove commented code.
5. FILE: src/Controller/AssistantsListController.php
/**
* The entity type manager.
*
* @var \Drupal\Core\Entity\EntityTypeManagerInterface
*/
protected $entityTypeManager;The parent class already has properties and methods for the entity type manager object. There is no need to redefine properties for the same purpose; instead, the parent class methods should be used.
6. FILE: src/Controller/AssistantsListController.php
/**
* The controller constructor.
*
* @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
* The entity type manager.
* @param \Drupal\openai_client\OpenAIClientWrapper $api
* Open API wrapper.
* @param \Drupal\Core\Datetime\DateFormatter $dateFormatter
* Date formatter.
* @param \Symfony\Component\HttpFoundation\RequestStack $requestStack
* The request stack.
*/
public function __construct(EntityTypeManagerInterface $entity_type_manager, OpenAIClientWrapper $api, DateFormatter $dateFormatter, RequestStack $requestStack) {FILE: src/Form/AssistantEditForm.php
/**
* Constructor.
*
* @param \Drupal\openai_client\OpenAIClientWrapper $api
* Open API wrapper.
*/
public function __construct(OpenAIClientWrapper $api) {FILE: src/Form/CreateImageForm.php
/**
* Constructor.
*
* @param \Drupal\openai_client\OpenAIClientWrapper $api
* OpenAI client API.
*/
public function __construct(OpenAIClientWrapper $api) {FILE: src/Form/SettingsForm.php
/**
* Constructs a \Drupal\system\ConfigFormBase object.
*
* @param \Drupal\openai_client\OpenAIClientWrapper $api
* Open API wrapper.
* @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
* The factory for configuration objects.
* @param \Drupal\Core\Datetime\DateFormatter $dateFormatter
* Date formatter.
*/
public function __construct(OpenAIClientWrapper $api, ConfigFactoryInterface $config_factory, DateFormatter $dateFormatter) {The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.
7. FILE: src/Form/SettingsForm.php
parent::__construct($config_factory);
ConfigFormBase::__construct() requires two parameters. See the change record → .
FILE: openai_client.info.yml
Given the changes in ConfigFormBase, the module cannot be compatible with Drupal releases before 10.2.0.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.