The security advisory coverage application process assigns the required role to the applicant, enabling them to opt projects into security advisory coverage.
To verify if a user has the necessary role to opt a module into security advisory coverage, navigate to the user profile and check for the section labeled "Can opt projects into security advisory coverage."
A site moderator user will review your post and publish it.
I have reviewed your posts and confirmed the account.
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml masked_output/
FILE: masked_output/masked_output.info.yml
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
--------------------------------------------------------------------------------
FILE: masked_output/src/Plugin/Field/FieldFormatter/MaskOutputFormatter.php
--------------------------------------------------------------------------------
FOUND 5 ERRORS AND 1 WARNING AFFECTING 4 LINES
--------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
31 | ERROR | [ ] Class property $field_definition should use lowerCamel naming without underscores
170 | WARNING | [ ] There must be no blank line following an inline comment
170 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
170 | ERROR | [x] Comments may not appear after statements
183 | ERROR | [x] Expected newline after closing brace
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: masked_output/src/Plugin/Field/FieldFormatter/MaskEmailOutputFormatter.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldItemListInterface.
24 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
25 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
26 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
27 | ERROR | [x] Expected 3 space(s) before asterisk; 1 found
28 | ERROR | [ ] Class property $field_definition should use lowerCamel naming without underscores
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------2. FILE: masked_output.module
/**
* @file
* Contains masked_output.module.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
I have reviewed the posts and confirmed the account.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
I have reviewed the `.gitlab-ci.yml` configuration, and everything looks good.
As for the pipeline, I can see that it has passed.
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml openai_client/
FILE: openai_client/query.txt
--------------------------------------------------------------------------------
FOUND 16 ERRORS AND 1 WARNING AFFECTING 16 LINES
--------------------------------------------------------------------------------
1 | WARNING | Line exceeds 80 characters; contains 133 characters
59 | ERROR | Missing short description in doc comment
64 | ERROR | Missing short description in doc comment
69 | ERROR | Parameter $api is not described in comment
69 | ERROR | Parameter $dateFormatter is not described in comment
154 | ERROR | The array declaration extends to column 93 (the limit is 80). The array content should be split up over multiple lines
155 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
156 | ERROR | The array declaration extends to column 108 (the limit is 80). The array content should be split up over multiple lines
158 | ERROR | The array declaration extends to column 137 (the limit is 80). The array content should be split up over multiple lines
159 | ERROR | The array declaration extends to column 112 (the limit is 80). The array content should be split up over multiple lines
160 | ERROR | The array declaration extends to column 104 (the limit is 80). The array content should be split up over multiple lines
270 | ERROR | Description for the @return value is missing
282 | ERROR | Description for the @return value is missing
292 | ERROR | Description for the @return value is missing
298 | ERROR | Doc comment is empty
315 | ERROR | Description for the @return value is missing
325 | ERROR | Description for the @return value is missing
--------------------------------------------------------------------------------
FILE: openai_client/src/OpenAIClientWrapper.php
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
68 | ERROR | [x] Whitespace found at end of line
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------2. FILE: openai_client.info.yml
package: Custom
This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.
3. FILE: openai_client.module
/**
* @file
* Primary module hooks for OpenAI Client module.
*/Drupal does not have primary and secondary hooks. Instead of that, it is preferable to use the usual description: “Hook implementations for the [module name] module”, where [module name] is the name of the module given in its .info.yml file.
4. FILE: src/Controller/AssistantsListController.php
// {
// "id": "asst_wMdO2WcFgvAQgQhez5fZ4wxd",
// "object": "assistant",
// "createdAt": 1699353422,
// "name": "Prueba",
// "description": null,
// "model": "gpt-4-1106-preview",
// "instructions": null,
// "tools": [],
// "fileIds": [],
// "metadata": []
// }FILE: src/Form/AssistantEditForm.php
// $session->set($this->getFormId(), $form_state->getValue('value'));
Remove commented code.
5. FILE: src/Controller/AssistantsListController.php
/**
* The entity type manager.
*
* @var \Drupal\Core\Entity\EntityTypeManagerInterface
*/
protected $entityTypeManager;The parent class already has properties and methods for the entity type manager object. There is no need to redefine properties for the same purpose; instead, the parent class methods should be used.
6. FILE: src/Controller/AssistantsListController.php
/**
* The controller constructor.
*
* @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
* The entity type manager.
* @param \Drupal\openai_client\OpenAIClientWrapper $api
* Open API wrapper.
* @param \Drupal\Core\Datetime\DateFormatter $dateFormatter
* Date formatter.
* @param \Symfony\Component\HttpFoundation\RequestStack $requestStack
* The request stack.
*/
public function __construct(EntityTypeManagerInterface $entity_type_manager, OpenAIClientWrapper $api, DateFormatter $dateFormatter, RequestStack $requestStack) {FILE: src/Form/AssistantEditForm.php
/**
* Constructor.
*
* @param \Drupal\openai_client\OpenAIClientWrapper $api
* Open API wrapper.
*/
public function __construct(OpenAIClientWrapper $api) {FILE: src/Form/CreateImageForm.php
/**
* Constructor.
*
* @param \Drupal\openai_client\OpenAIClientWrapper $api
* OpenAI client API.
*/
public function __construct(OpenAIClientWrapper $api) {FILE: src/Form/SettingsForm.php
/**
* Constructs a \Drupal\system\ConfigFormBase object.
*
* @param \Drupal\openai_client\OpenAIClientWrapper $api
* Open API wrapper.
* @param \Drupal\Core\Config\ConfigFactoryInterface $config_factory
* The factory for configuration objects.
* @param \Drupal\Core\Datetime\DateFormatter $dateFormatter
* Date formatter.
*/
public function __construct(OpenAIClientWrapper $api, ConfigFactoryInterface $config_factory, DateFormatter $dateFormatter) {The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.
7. FILE: src/Form/SettingsForm.php
parent::__construct($config_factory);
ConfigFormBase::__construct() requires two parameters. See the change record → .
FILE: openai_client.info.yml
Given the changes in ConfigFormBase, the module cannot be compatible with Drupal releases before 10.2.0.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml gmv
FILE: gmv/src/Plugin/Field/FieldFormatter/ThreeDeeObjectFieldFormatter.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
--------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Field\FieldDefinitionInterface.
122 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
128 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------2. FILE: README.md
The README file is missing the required sections → , including Requirements, and Configuration.
3. FILE: gmv.info.yml
core_version_requirement: ^8 || ^9 || ^10 || ^11
The Drupal Core versions before 8.7.7 do not recognize the core_version_requirement → key.
4. FILE: gmv.libraries.yml
version: VERSION
VERSION is only used by Drupal core modules. Contributed modules should use a literal string that does not change with the Drupal core version a site is using.
5. FILE: gmv.module
/**
* @file
* Implement of theme hook.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
To enable the green security coverage indicator, go to the module's project page and click "Edit." Find the "Security advisory coverage" section, check the box for "Opt into security advisory coverage," and save the changes. After doing this, the green security badge will be displayed on the project page.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. FILE: multisite_manager_tool.module
/**
* @file
* Primary module hooks for Multisite Manager Tool module.
*/Drupal does not have primary and secondary hooks. Instead of that, it is preferable to use the usual description: "Hook implementations for the [module name] module", where [module name] is the name of the module given in its .info.yml file.
2. FILE: src/SitesHelper.php
/**
* Inject Services.
*
* @param \Drupal\Core\Logger\LoggerChannelFactoryInterface $logger_factory
* The logger factory.
* @param \Drupal\Core\Database\Connection $database
* The database connection.
*/
public function __construct(LoggerChannelFactoryInterface $logger_factory, Connection $database) {FILE: src/Form/AddNewSiteForm.php
/**
* Inject services.
*
* @param \Drupal\multisite_manager_tool\SitesHelper $sites_helper
* The site helper.
* @param \Drupal\Core\File\FileSystem $file_system
* The file system.
* @param \Drupal\Core\Database\Connection $database
* The database connection.
* @param \Drupal\Core\Site\Settings $settings
* The settings.
*/
public function __construct(SitesHelper $sites_helper, FileSystem $file_system, Connection $database, Settings $settings) {FILE: src/Form/CacheClearSiteForm.php
/**
* The site helper.
*
* @param \Drupal\multisite_manager_tool\SitesHelper $sites_helper
* The site helper.
*/
public function __construct(SitesHelper $sites_helper) {FILE: src/Form/CacheClearSitesForm.php
/**
* The site helper.
*
* @param \Drupal\multisite_manager_tool\SitesHelper $sites_helper
* The site helper.
*/
public function __construct(SitesHelper $sites_helper) {The documentation comment for constructors is not mandatory anymore, If it is given, the description must be “Constructs a new [class name] object”, where [class name] includes the class namespace.
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
I have reviewed your post and confirmed the account.
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
This issue does not seem to be a request for a confirmed account, but a support request posted in the wrong queue.
This issue queue is for problems, tasks, and support requests related to Drupal.org, not any site running on Drupal. For questions and support on sites you maintain or develop, please post on the forums → .
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml voiceflow/
FILE: voiceflow/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 16 WARNINGS AFFECTING 16 LINES
----------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 251 characters
9 | WARNING | Line exceeds 80 characters; contains 144 characters
10 | WARNING | Line exceeds 80 characters; contains 139 characters
14 | WARNING | Line exceeds 80 characters; contains 152 characters
16 | WARNING | Line exceeds 80 characters; contains 84 characters
17 | WARNING | Line exceeds 80 characters; contains 120 characters
18 | WARNING | Line exceeds 80 characters; contains 121 characters
26 | WARNING | Line exceeds 80 characters; contains 241 characters
30 | WARNING | Line exceeds 80 characters; contains 239 characters
31 | WARNING | Line exceeds 80 characters; contains 183 characters
32 | WARNING | Line exceeds 80 characters; contains 125 characters
34 | WARNING | Line exceeds 80 characters; contains 132 characters
35 | WARNING | Line exceeds 80 characters; contains 123 characters
36 | WARNING | Line exceeds 80 characters; contains 100 characters
40 | WARNING | Line exceeds 80 characters; contains 170 characters
42 | WARNING | Line exceeds 80 characters; contains 142 characters
----------------------------------------------------------------------
FILE: voiceflow/config/schema/voiceflow.schema.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
13 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------2. FILE: voiceflow.module
/**
* @file
* Voiceflow.
*/FILE: modules/voiceflow_index/voiceflow_index.module
/**
* @file
* Voiceflow Index.
*/The usual description for a .module file is “Hook implementations for the [module name] module”, where [module name] is the module name given in the .info.yml file.
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. FILE: src/Form/InactiveUserNotificationSettingsForm.php
/**
* {@inheritdoc}
*/
public function __construct(FILE: src/Notification/InactiveUserNotification.php
/**
* The InactiveUserNotification constructor.
*/
public function __construct(FILE: src/Settings/GetNotificationSettings.php
/**
* The constructor.
*/
public function __construct(StateInterface $state) {The documentation comment for constructors is not mandatory anymore, If it is given, the description must be "Constructs a new [class name] object", where [class name] includes the class namespace.
2. FILE: inactive_user_management.module
/**
* @file
* Inactive user management module functions.
*/The usual description for a .module file is "Hook implementations for the [module name] module", where [module name] is the module name given in the .info.yml file.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
I have reviewed your post and confirmed the account.
I have reviewed your post and confirmed the account.
Hello, and a warm welcome to the Drupal community!
You can contribute to drupal.org without having the role.
Please see Become a confirmed user → for information on the role and how it is granted. After you have posted some content on Drupal.org, this issue will be revisited, or you will get the role automatically.
Here is a list of resources that will assist you in making helpful contributions:
I have reviewed your posts and confirmed the account.
Hello, and a warm welcome to the Drupal community!
You can contribute to drupal.org without having the role.
Please see Become a confirmed user → for information on the role and how it is granted. After you have posted some content on Drupal.org, this issue will be revisited, or you will get the role automatically.
Here is a list of resources that will assist you in making helpful contributions:
The "minimum-stability" of my project is "stable".
Hello, and a warm welcome to the Drupal community!
You can contribute to drupal.org without having the role.
Please see Become a confirmed user → for information on the role and how it is granted. After you have posted some content on Drupal.org, this issue will be revisited, or you will get the role automatically.
Here is a list of resources that will assist you in making helpful contributions:
The account has been already confirmed.
I have reviewed your posts and confirmed the account.
There's no need to create an issue after completing the reviews.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
harlor → credited vishal.kadam → .
1. FILE: form_decorator.info.yml
package: Custom
FILE: modules/form_decorator_example/form_decorator_example.info.yml
package: Custom
This line is used by custom modules created for specific sites. It is not a package name used for projects hosted on drupal.org.
2. FILE: src/FormDecoratorPluginManager.php
/**
* Constructs the object.
*/
public function __construct(\Traversable $namespaces, CacheBackendInterface $cache_backend, ModuleHandlerInterface $module_handler) {The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
These applications do not require that new releases are created after reviews.
I ran the phpcs command (phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml) on latest commit and confirm that coding standard issue related to 80 characters of README file has been resolved except below one.
FILE: rest_easy/modules/rest_easy_api_keys/README.md
-------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------
49 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------I have tested the MR changes in one of my projects (Drupal 10.4.1) and confirm that the issue is resolved. Moving it to RTBC.
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml rest_easy/
FILE: rest_easy/rest_easy.routing.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
2 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: rest_easy/modules/rest_easy_api_keys/rest_easy_api_keys.services.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
8 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/modules/rest_easy_api_keys/rest_easy_api_keys.links.task.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
5 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/modules/rest_easy_api_keys/rest_easy_api_keys.libraries.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/modules/rest_easy_api_keys/README.md
------------------------------------------------------------------------------
FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------
2 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
23 | WARNING | [ ] Line exceeds 80 characters; contains 378 characters
25 | WARNING | [ ] Line exceeds 80 characters; contains 127 characters
35 | WARNING | [ ] Line exceeds 80 characters; contains 243 characters
38 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/modules/rest_easy_api_keys/rest_easy_api_keys.permissions.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
3 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/modules/rest_easy_api_keys/rest_easy_api_keys.routing.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
13 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/modules/rest_easy_api_keys/rest_easy_api_keys.info.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------
1 | WARNING | [ ] Remove "version" from the info file, it will be added by drupal.org packaging automatically
9 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/modules/rest_easy_example/README.md
------------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------
2 | WARNING | [ ] Line exceeds 80 characters; contains 117 characters
23 | WARNING | [ ] Line exceeds 80 characters; contains 295 characters
26 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/modules/rest_easy_example/rest_easy_example.info.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------
1 | WARNING | [ ] Remove "version" from the info file, it will be added by drupal.org packaging automatically
8 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/modules/rest_easy_example/src/Plugin/rest_easy/Endpoint/SiteNameEndpoint.php
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
7 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\rest_easy\Attribute\RESTEasyEndpoint.
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------
2 | WARNING | [ ] Line exceeds 80 characters; contains 363 characters
17 | WARNING | [ ] Line exceeds 80 characters; contains 180 characters
25 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------
FILE: rest_easy/rest_easy.info.yml
------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------
1 | WARNING | [ ] Remove "version" from the info file, it will be added by drupal.org packaging automatically
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
FILE: rest_easy/rest_easy.services.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
15 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: rest_easy/src/Routing/APIRouteBuilder.php
------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Logger\LoggerChannelFactory.
------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
1. Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml keycloak_user_sync/
FILE: keycloak_user_sync/keycloak_user_sync.module
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
29 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
31 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: keycloak_user_sync/src/Form/KeycloakUserSyncSettingsForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
11 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\keycloak_user_sync\Service\KeycloakService.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------2. FILE: keycloak_user_sync.module
/**
* @file
* Contains keycloak_user_sync.module.
*/The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.
3. FILE: src/Form/KeycloakUserSyncSettingsForm.php
parent::__construct($config_factory);
ConfigFormBase::__construct() requires two parameters. See the change record → .
4. FILE: keycloak_user_sync.info.yml
core_version_requirement: ^10 || ^11
Given the changes in ConfigFormBase → , the module cannot be compatible with Drupal versions earlier than 10.2.0.
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Projects with releases cannot be deleted.
Regarding your issue, it seems your Drupal core’s composer.json file has the minimum-stability set to stable. Try changing it to dev and see if it resolves the problem.
Code of sub-module looks fine to me.
Usually, after reviewing a project, we allow the developer to opt projects into security advisory coverage.
This project is too small for us and it doesn't contain enough PHP code to really assess your skills as a developer.
Have you created any other project on drupal.org (module, theme, distribution) we could instead review? The project needs to have most of the commits (preferable all the commits) done by you.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
Rest seems fine to me.
Let’s wait for other reviewers and Code Review Administrator to take a look and if everything goes fine, you will get the role.
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml coupons_migrate/
FILE: coupons_migrate/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
----------------------------------------------------------------------
6 | WARNING | Line exceeds 80 characters; contains 116 characters
38 | WARNING | Line exceeds 80 characters; contains 100 characters
43 | WARNING | Line exceeds 80 characters; contains 83 characters
48 | WARNING | Line exceeds 80 characters; contains 90 characters
51 | WARNING | Line exceeds 80 characters; contains 145 characters
----------------------------------------------------------------------
FILE: coupons_migrate/src/Plugin/Commerce/PromotionOffer/SetPrice.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\commerce_order\Adjustment.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: coupons_migrate/src/Commands/CouponsMigrate.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
@arwillame Thank you for reporting this. I’ve merged the MR.
Thank you for the suggestion! I followed your advice to require drupal/webform first and then drupal/eca_webform, and it worked perfectly.
I attempted to install the eca_webform module on a vanilla Drupal 11 setup using Composer but was unsuccessful.
Have you been able to install eca_webform on a vanilla Drupal 11 setup using Composer?
vishal.kadam → created an issue.
vishal.kadam → created an issue.
vishal.kadam → created an issue.
vishal.kadam → created an issue.
Rest looks fine to me.
Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.
All Twig files are still improperly indented. Ensure that two spaces are used for indentation instead of four spaces or tabs.
Fix phpcs issues.
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml seeds_toolbar/
FILE: seeds_toolbar/seeds_toolbar.libraries.yml
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
16 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------
FILE: seeds_toolbar/seeds_toolbar.module
------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------
446 | ERROR | Doc comment is empty
------------------------------------------------------------------------
FILE: seeds_toolbar/assets/css/seeds-toolbar-rtl.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
87 | ERROR | [x] Multiple selectors should each be on a single line
93 | ERROR | [x] Multiple selectors should each be on a single line
118 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: seeds_toolbar/assets/css/seeds-toolbar.css
--------------------------------------------------------------------------------
FOUND 65 ERRORS AFFECTING 54 LINES
--------------------------------------------------------------------------------
93 | ERROR | [x] Multiple selectors should each be on a single line
93 | ERROR | [x] Multiple selectors should each be on a single line
103 | ERROR | [x] Multiple selectors should each be on a single line
106 | ERROR | [x] Multiple selectors should each be on a single line
106 | ERROR | [x] Multiple selectors should each be on a single line
106 | ERROR | [x] Multiple selectors should each be on a single line
106 | ERROR | [x] Multiple selectors should each be on a single line
106 | ERROR | [x] Multiple selectors should each be on a single line
115 | ERROR | [x] Multiple selectors should each be on a single line
118 | ERROR | [x] Multiple selectors should each be on a single line
126 | ERROR | [x] Multiple selectors should each be on a single line
142 | ERROR | [x] Multiple selectors should each be on a single line
180 | ERROR | [x] Multiple selectors should each be on a single line
180 | ERROR | [x] Multiple selectors should each be on a single line
183 | ERROR | [x] Multiple selectors should each be on a single line
183 | ERROR | [x] Multiple selectors should each be on a single line
206 | ERROR | [x] Multiple selectors should each be on a single line
206 | ERROR | [x] Multiple selectors should each be on a single line
206 | ERROR | [x] Multiple selectors should each be on a single line
297 | ERROR | [x] Multiple selectors should each be on a single line
412 | ERROR | [x] Multiple selectors should each be on a single line
473 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
480 | ERROR | [x] Multiple selectors should each be on a single line
492 | ERROR | [x] Multiple selectors should each be on a single line
496 | ERROR | [x] Multiple selectors should each be on a single line
500 | ERROR | [x] Multiple selectors should each be on a single line
507 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 5
508 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
509 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
512 | ERROR | [x] Multiple selectors should each be on a single line
516 | ERROR | [x] Multiple selectors should each be on a single line
520 | ERROR | [x] Multiple selectors should each be on a single line
547 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
548 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
550 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
551 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
554 | ERROR | [x] Multiple selectors should each be on a single line
571 | ERROR | [x] Multiple selectors should each be on a single line
574 | ERROR | [x] Multiple selectors should each be on a single line
574 | ERROR | [x] Multiple selectors should each be on a single line
574 | ERROR | [x] Multiple selectors should each be on a single line
577 | ERROR | [x] Multiple selectors should each be on a single line
601 | ERROR | [x] Multiple selectors should each be on a single line
605 | ERROR | [x] Multiple selectors should each be on a single line
608 | ERROR | [x] Multiple selectors should each be on a single line
644 | ERROR | [x] Multiple selectors should each be on a single line
647 | ERROR | [x] Multiple selectors should each be on a single line
683 | ERROR | [x] Multiple selectors should each be on a single line
700 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
704 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
723 | ERROR | [x] Multiple selectors should each be on a single line
727 | ERROR | [x] Multiple selectors should each be on a single line
751 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
753 | ERROR | [x] Multiple selectors should each be on a single line
771 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
821 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
822 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
824 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
825 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
842 | ERROR | [x] Multiple selectors should each be on a single line
846 | ERROR | [x] Multiple selectors should each be on a single line
860 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
861 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
872 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
917 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 65 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: seeds_toolbar/seeds_toolbar.permissions.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Thank you for applying!
Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.
The important notes are the following.
- If you have not done it yet, you should run
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report. - For the time this application is open, only your commits are allowed.
- The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
- We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.
To the reviewers
Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .
The important notes are the following.
- It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
- Reviewers should show the output of a CLI tool → only once per application.
- It may be best to have the applicant fix things before further review.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .
The typical path to confirming users usually involves reviewing the content that you've created on this site. In this case, you've not created any content except this post, so there is no content to review. Postponing for now, after you have posted some content on Drupal.org you may want to add a comment to this issue to request a new review. Please visit the Become a confirmed user → page for information. That page also tells you what "limitations" mean.
Since you haven't contributed yet here is a list of resources to help you on your journey:
1. FILE: README.md
The README file is missing the required sections → , including Requirements, Installation, and Configuration.
2. FILE: src/Component/DataComponent.php
/**
* DataComponent constructor.
*
* @param string $bundle
* The bundle of the data component.
* @param array<string, mixed> $data
* The multi-dimensional array data.
*/
public function __construct(string $bundle, array $data) {FILE: src/Event/UnknownDataProcessorEvent.php
/**
* Pass in connector config by default to all events.
*
* @param mixed $dataSource
* The unknown data source about to be processed.
* @param string $variant
* The processor variant requested for the data source.
*/
public function __construct(mixed $dataSource, string $variant) {FILE: src/Plugin/DataProcessorBase.php
/**
* {@inheritdoc}
*/
public function __construct(FILE: src/Plugin/DataProcessorManager.php
/**
* Constructor for TaskPluginManager objects.
*
* @param \Traversable $namespaces
* An object that implements \Traversable which contains the root paths
* keyed by the corresponding namespace to look for plugin implementations.
* @param \Drupal\Core\Cache\CacheBackendInterface $cache_backend
* Cache backend instance to use.
* @param \Drupal\Core\Extension\ModuleHandlerInterface $module_handler
* The module handler to invoke the alter hook with.
* @param \Symfony\Component\EventDispatcher\EventDispatcherInterface $dispatcher
* The event dispatcher.
*/
public function __construct(The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.