[1.0.x] Paragraph Lineage

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should enable GitLab CI for the project and fix the PHP_CodeSniffer errors/warnings it reports.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status will not be changed by this application; once this application is closed, you will be able to change the project status from Not covered to Opt into security advisory coverage. This is possible only 14 days after the project is created.
  
  Keep in mind that once the project is opted into security advisory coverage, only Security Team members may change coverage.
• Only the person who created the application will get the permission to opt projects into security advisory coverage. No other person will get the same permission from the same application; that applies also to co-maintainers/maintainers of the project used for the application.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a project moderator before posting the first comment on newly created applications. Project moderators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Remember to change status, when the project is ready to be reviewed. In this queue, projects are only reviewed when the status is Needs review.

I have created a fork branch with the expected files. https://www.drupal.org/project/paragraph_lineage/issues/3528635 📌 Add .gitlab-ci.yml Active

https://git.drupalcode.org/project/paragraph_lineage/-/merge_requests/11

The changes should be committed directly to the project repository. Please note that we do not review merge requests.

1. FILE: README.md

The README file is missing the required sections → - Requirements and Configuration.

2. FILE: templates/paragraph-lineage.html.twig

<div class="field__label" aria-label="type">Type</div>

<div class="field__label" aria-label="paragraph-bundle">Bundle</div>

<summary>Preview</summary>

<h3>Lineage</h3>

<p>No ancestors available. This appears to be an orphan paragraph.</p>

        <th>Type</th>
        <th>Bundle</th>
        <th>Preview</th>
        <th>Link</th>

Strings shown in the user interface must be translatable. That holds true also for strings used in template files.

3. FILE: src/Controller/ParagraphLineageViewController.php

  /**
   * @var \Drupal\Core\Entity\EntityTypeManagerInterface
   */
  private EntityTypeManagerInterface $entity_type_manager;

The parent class already has properties and methods for the entity type manager. There is no need to redefine properties for the same purpose; instead, the parent class methods should be used.

This is ready for review. I have updated the README.md, and the classes and the translation tags. https://git.drupalcode.org/project/paragraph_lineage/-/jobs

1. Fix errors/warnings reported by phpcs and phpstan job of Gitlab CI.

2. FILE: templates/paragraph-lineage.html.twig

<div class="field__label" aria-label="type">Type</div>

<div class="field__label" aria-label="paragraph-bundle">Bundle</div>

<summary>Preview</summary>

<h3>Lineage</h3>

Still some string are not translatable.

I have fixed the lines I missed earlier. All strings should now be translated in the twig file.

FILE: src/Plugin/Field/FieldFormatter/ParagraphIdLinkFormatter.php

$link_title = $this->t($label, ['@name' => $entity->label()]);

The first argument passed to t() must be a literal string.

I have fixed the issue with the $this->t() string literal concern.

Rest looks fine to me.

Please wait for a Project Moderator to take a look and if everything goes fine, you will get the role.