chris dart → created an issue.
chris dart → created an issue.
chris dart → created an issue.
chris dart → created an issue.
I have increased the width of the outline of the selected element so it is clearer that it has been selected. I'm not sure there's much that can be done about need to click several times.
chris dart → created an issue.
I have fixed the issue with the $this->t() string literal concern.
I have fixed the lines I missed earlier. All strings should now be translated in the twig file.
All items except for length issues that could not be reasonably fixed have been clear. phpstan tests all pass. All phpcs tests pass except for length issues.
chris dart → created an issue.
chris dart → created an issue.
chris dart → created an issue.
chris dart → created an issue.
This is ready for review. I have updated the README.md, and the classes and the translation tags. https://git.drupalcode.org/project/paragraph_lineage/-/jobs
chris dart → created an issue.
chris dart → created an issue.
All tests are now passing.
I have created a fork branch with the expected files. https://www.drupal.org/project/paragraph_lineage/issues/3528635 📌 Add .gitlab-ci.yml Active
https://git.drupalcode.org/project/paragraph_lineage/-/merge_requests/11
chris dart → created an issue.
chris dart → created an issue.
chris dart → created an issue.
Closed. The module is now D8-D10 compatible.
Not using the 8.x-1.x version any more.
chris dart → created an issue.
chris dart → created an issue.
The changes have been closed and fixed.
chris dart → made their first commit to this issue’s fork.
Here is a composer.json from a site I just tried this again with. I cannot replicate this in DDEV.
It is entirely possible this has to do with the runner. Attached is the FULL drainpipe build log. The other file Deplo file Deploy-log-only.txt contains all the actions that likely cause the failure. Start on line 6588.
Here's the full composer.json file.
{
"name": "pantheon-upstreams/drupal-project",
"description": "Install Drupal 9 with Composer on Pantheon.",
"type": "project",
"license": "MIT",
"repositories": {
"drupal-packagist": {
"type": "composer",
"url": "https://packages.drupal.org/8",
"exclude": [
"drupal/block_scheduler",
"drupal/field_inheritance",
"drupal/layout_builder_norender",
"drupal/view_mode_selector",
"drupal/recurring_events"
]
},
"pantheon-upstream": {
"type": "path",
"url": "upstream-configuration"
},
"asset-packagist": {
"type": "composer",
"url": "https://asset-packagist.org"
},
"drupal-fancy/view_mode_selector": {
"type": "package",
"package": {
"name": "drupal-fancy/view_mode_selector",
"version": "1.0.0",
"type": "drupal-module",
"source": {
"url": "https://github.com/drupal-fancy/view_mode_selector.git",
"type": "git",
"reference": "8.x-1.x"
}
}
},
"drupal/block_scheduler": {
"type": "package",
"package": {
"name": "drupal/block_scheduler",
"version": "2.0.1",
"type": "drupal-module",
"source": {
"url": "https://git.drupalcode.org/issue/block_scheduler-3429017.git",
"type": "git",
"reference": "87e6dc451f29d9eb64949301fcfb333c8a894c9a"
}
}
},
"drupal/field_inheritance": {
"type": "package",
"package": {
"name": "drupal/field_inheritance",
"version": "2.0.0",
"type": "drupal-module",
"source": {
"url": "https://git.drupalcode.org/issue/field_inheritance-3480537.git",
"type": "git",
"reference": "ab98b7e8d5e124d4ce648166c83344e374a23897"
}
}
},
"drupal/layout_builder_norender": {
"type": "package",
"package": {
"name": "drupal/layout_builder_norender",
"version": "1.0.0",
"type": "drupal-module",
"source": {
"url": "https://git.drupalcode.org/issue/layout_builder_norender-3431590.git",
"type": "git",
"reference": "9f938fbe06a493b5c657ef54b796c9c246e6b5d5"
}
}
},
"drupal/view_mode_selector": {
"type": "package",
"package": {
"name": "drupal/view_mode_selector",
"version": "1.0.0",
"type": "drupal-module",
"source": {
"url": "https://git.drupalcode.org/issue/view_mode_selector-3435379.git",
"type": "git",
"reference": "a72f5c49938ae28e0d8c351a13763565e3fa5d64"
}
}
},
"drupal/recurring_events": {
"type": "package",
"package": {
"name": "drupal/recurring_events",
"version": "3.0.0",
"type": "drupal-module",
"source": {
"url": "https://git.drupalcode.org/issue/recurring_events-3480491.git",
"type": "git",
"reference": "72ed9e72309ec0dfb0e3a2c288fbf087f1d6bbac"
}
}
}
},
"require": {
"ext-curl": "*",
"ext-zlib": "*",
"composer/installers": "^1.9",
"cweagans/composer-patches": "^1.7",
"drupal-fancy/view_mode_selector": "^1.0",
"drupal/address": "^2.0",
"drupal/admin_toolbar": "^3.1",
"drupal/allowed_formats": "^3.0",
"drupal/backup_migrate": "^5.0",
"drupal/better_exposed_filters": "^7.0",
"drupal/bg_image_formatter": "^1.15",
"drupal/block_class": "^4.0",
"drupal/block_field": "^1.0@RC",
"drupal/block_scheduler": "^2.0",
"drupal/block_visibility_groups": "^2.0",
"drupal/captcha": "^2.0",
"drupal/components": "^3.0@beta",
"drupal/config_filter": "^2.7",
"drupal/config_split": "^2.0",
"drupal/core-composer-scaffold": "^11",
"drupal/core-project-message": "^11",
"drupal/core-recommended": "^11",
"drupal/date_popup": "^2.0",
"drupal/diff": "^2.0@beta",
"drupal/easy_breadcrumb": "^2.0",
"drupal/entity": "^1.5",
"drupal/externalauth": "^2.0",
"drupal/field_group": "^4.0",
"drupal/field_inheritance": "^2.0",
"drupal/focal_point": "^2.0",
"drupal/gin": "^3.0@beta",
"drupal/group": "^3.2",
"drupal/honeypot": "^2.0",
"drupal/jquery_ui_datepicker": "^2.0",
"drupal/jquery_ui_slider": "^2.1",
"drupal/jquery_ui_touch_punch": "^1.1",
"drupal/jsonapi_extras": "^3.25",
"drupal/layout_builder_iframe_modal": "^1.3",
"drupal/layout_builder_norender": "^1.0",
"drupal/layout_builder_restrictions": "^3.0",
"drupal/layout_builder_styles": "^2.0",
"drupal/layoutbuilder_search_api": "^1.0",
"drupal/mailsystem": "^4.4",
"drupal/masquerade": "^2.0@RC",
"drupal/menu_block": "^1.8",
"drupal/menu_link_attributes": "^1.2",
"drupal/menu_position": "^1.0@beta",
"drupal/metatag": "^2.1",
"drupal/nomarkup": "^1.0",
"drupal/openid_connect": "^3.0@alpha",
"drupal/paragraph_lineage": "^1.0",
"drupal/paragraphs": "^1.13",
"drupal/pathauto": "^1.9",
"drupal/recaptcha_v3": "^2.0",
"drupal/recurring_events": "^3.0",
"drupal/redirect": "^1.7",
"drupal/redis": "^1.5",
"drupal/search_api": "^1.28",
"drupal/search_api_pantheon": "^8.3",
"drupal/search_api_solr": "^4.2",
"drupal/select_or_other": "^4.0",
"drupal/simple_sitemap": "^4.2",
"drupal/smart_date": "^4.2",
"drupal/smtp": "^1.0",
"drupal/svg_image": "^3.0",
"drupal/tb_megamenu": "^3.0",
"drupal/token": "^1.10",
"drupal/twig_field_value": "^2.0",
"drupal/twig_tweak": "^3.2",
"drupal/upgrade_status": "^4.3",
"drupal/view_mode_selector": "^1.0",
"drupal/views_bulk_operations": "^4.2",
"drupal/views_rest_serializer_extra": "^1.0",
"drupal/webform": "^6.3@beta",
"drush/drush": "^13.6",
"kint-php/kint": "^5.1",
"lullabot/drainpipe": "^3.12",
"npm-asset/litepicker": "^2.0",
"npm-asset/swiper": "^8.4",
"oomphinc/composer-installers-extender": "^2.0",
"pantheon-systems/drupal-integrations": "^11.0",
"pantheon-systems/search_api_pantheon": "^8.2",
"pantheon-upstreams/upstream-configuration": "dev-main"
},
"require-dev": {
"drupal/core-dev": "^11",
"drupal/devel": "^5.1",
"drupal/stage_file_proxy": "^3.1",
"lullabot/drainpipe-dev": "^3.4",
"weitzman/drupal-test-traits": "^2.2",
"weitzman/logintrait": "^1.2"
},
"conflict": {
"drupal/drupal": "*"
},
"minimum-stability": "dev",
"prefer-stable": true,
"extra": {
"drainpipe": {
"github": ["Pantheon", "ComposerLockDiff", "PantheonReviewApps"],
"tugboat": {
"terminus": true
}
},
"drupal-scaffold": {
"locations": {
"web-root": "./web"
},
"allowed-packages": ["lullabot/drainpipe", "lullabot/drainpipe-dev"],
"file-mapping": {
"[project-root]/.editorconfig": false,
"[project-root]/pantheon.upstream.yml": false,
"[project-root]/.gitattributes": false
},
"gitignore": "true"
},
"installer-types": [
"npm-asset"
],
"installer-paths": {
"web/core": [
"type:drupal-core"
],
"web/libraries/{$name}": [
"type:drupal-library",
"type:npm-asset"
],
"web/modules/contrib/{$name}": [
"type:drupal-module"
],
"web/profiles/contrib/{$name}": [
"type:drupal-profile"
],
"web/themes/contrib/{$name}": [
"type:drupal-theme"
],
"drush/Commands/contrib/{$name}": [
"type:drupal-drush"
],
"web/modules/custom/{$name}": [
"type:drupal-custom-module"
],
"web/profiles/custom/{$name}": [
"type:drupal-custom-profile"
],
"web/themes/custom/{$name}": [
"type:drupal-custom-theme"
],
"web/private/scripts/quicksilver/{$name}/": [
"type:quicksilver-script"
]
},
"composer-exit-on-patch-failure": true,
"patchLevel": {
"drupal/core": "-p2"
},
"patches": {
"drupal/menu_position": {
"https://www.drupal.org/project/menu_position/issues/3180912": "https://www.drupal.org/files/issues/2023-05-29/menu_position-3180912-6.patch"
},
"drupal/core": {
"https://www.drupal.org/project/drupal/issues/3239705": "https://www.drupal.org/files/issues/2021-10-06/make_link_fields_click_sortable-3239705-7.patch",
"Pantheon Compatibility Patch https://www.drupal.org/project/drupal/issues/3516912": "patches/3516912-core.patch"
},
"lullabot/drainpipe": {
"https://github.com/Lullabot/drainpipe/issues/357": "patches/drainpipe-skip-wipe-357.patch",
"Patch for MNHS builds": "patches/drainpipe-mnhs-builds.patch"
}
}
},
"config": {
"preferred-install": "dist",
"sort-packages": true,
"process-timeout": 0,
"platform": {
"php": "8.3"
},
"allow-plugins": {
"composer/installers": true,
"dealerdirect/phpcodesniffer-composer-installer": true,
"cweagans/composer-patches": true,
"drupal/core-composer-scaffold": true,
"drupal/core-project-message": true,
"oomphinc/composer-installers-extender": true,
"phpstan/extension-installer": true,
"lullabot/drainpipe": true,
"lullabot/drainpipe-dev": true,
"php-http/discovery": true,
"tbachert/spi": true
}
}
}I have made some commits to get this to be minimally D11 compatible. These are unrelated to the other child issues here which appear to aim to clean up and make the code more modern.
chris dart → made their first commit to this issue’s fork.
chris dart → created an issue.
chris dart → created an issue.
I'm not sure why the pipeline is failing, but I believe this is ready for review. The changes appear to work correctly in a client's installation. So I may have made an error in the test file changes?
chris dart → created an issue.
This automated fix is insuficient. There are other updates that are needed. I will create a separate ticket.
Updated the patch to remove all references to variationcache
This also needs a patch for the composer file. drupal/variationcache is not required for Group 3. This patch is only for Group 3 installations.
This is a puzzle. When I run composer require 'drupal/groupmedia:^4.0' it installs version 4.0.3, but config/optiona/view.views.group_media.yml still has the old default_argument_skip_url even after I have uninstalled and re-installed it.
Why would this be?
chris dart → created an issue.
This branch already has D11 updates for groupmedia_vbo but it is not available for patching. Use this patch to update groupmedia_vbo.
chris dart → made their first commit to this issue’s fork.
chris dart → created an issue.
chris dart → created an issue.
Updated view with more fields.
chris dart → created an issue.
chris dart → created an issue.
chris dart → created an issue.