[1.0.x] Partial Datelist

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
• For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
• Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. feature/add-module-tests and main are wrong names for a branch. Release branch names always end with the literal .x as described in Release branches → . The only exception is for the main branch, which is actually not fully supported on drupal.org and should be avoided.

2. FILE: README.md

The README file is missing the required section → - Requirements.

@avpaderno,

This module contains only code I have written. GitLab CI is enabled and the code passed validation.

@vishal.kadam,

Thank you for the quick response here, I will review your requests and get back to you once it is ready.

Changes are now ready.

I removed branches main and feature/add-module-tests.

Here is the merge request to incorporate the changes you requested in the README.md:
https://git.drupalcode.org/project/partial_datelist/-/merge_requests/9

I am also incorporating a .gitignore file to the codebase.

I have this open thread where I plan to apply your change requests:
https://www.drupal.org/project/partial_datelist/issues/3525354 ✨ Changes for Drupal.org security advisory review preparation Active

The reported changes should be committed directly to the project repository. Please note that we do not review merge requests.

Also, there's no need to create an issue thread in your module project, as this is already being tracked here.

@vishal.kadam,

Ok, done, I merged the changes in the issue queue into the main branch (1.0.x). It is ready for your review now.

Many thanks

Rest seems fine to me.

Let’s wait for other reviewers and Code Review Administrator to take a look and if everything goes fine, you will get the role.