[1.0.x] formatted_number_input

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, enable GitLab CI for the project, and fix what reported from the phpcs job. This help to fix most of what reviewers would report.
• For the time this application is open, only your commits are allowed. No other people, including other maintainers/co-maintainers can make commits.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application.
• Nobody else will get the permission to opt projects into security advisory policy. If there are other maintainers/co-maintainers who will to get that permission, they need to apply with a different module.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application. The configuration used for these tools needs to be the same configuration used by GitLab CI, stored in the GitLab Templates repository.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

I do not have time to make a more complete review, but the following point needs to be fixed.

Projects hosted on drupal.org are licensed under GPLv2+, the same license used from Drupal core. If you are licensing a project under a different license, it cannot he hosted on drupal.org. More details are given in Drupal Git Contributor Agreement & Repository Usage Policy → .

All code that is a derivative work of Drupal (typically PHP code, including but not limited to: core patches, modules, themes, etc) committed to Drupal.org's git repository is licensed as GPL version 2.0 and later (official short identifier: “GPL-2.0-or-later”). This means that the code is licensed under GPLv2, and there exists an option that allows downstream recipients to re-license the code to be under a later version of GPL.

For code licensed under GPLv3, see See I want to release my work under GPL version 3 or under GPL version 2-only. Can I do so and host it on Drupal.org? →

No. You can release your work under any GPL version 2 or later compatible license. However, you may only check it into Drupal's Git repositories if you are releasing it under the same license as Drupal itself, that is GPL version 2 or later, allowing users to choose between the terms of the GPL version 2 or the terms in any new versions as updated by the FSF. If you are unable or unwilling to do so, do not check it into a Drupal Git repository.

Thank you.
I am very confused about that license and where to obtain the original. https://www.gnu.org/licenses/old-licenses/gpl-2.0.html does not exist any longer.
Should I just copy the license file of Drupal core?

You can edit the LICENSE file in Gitlab and select GPL v2 from template ( see attached → ).

Thank you. I did that and followed the instructions on https://spdx.org/licenses/GPL-2.0-or-later.html

Please, see here: https://git.drupalcode.org/project/formatted_number_input/-/blob/1.0.x/L...

I usually create the license file from the GitLab interface, knowing that <year> and <name of author> are replaced by the current year and the name of the person adding the file, when they should not be.

See the merge request I created in the project issue queue. It contains the correct license file.

Thank you.

What happens to in line 307? Is it automatically replaced also?

At https://spdx.org/licenses/GPL-2.0-or-later.html it is recommended to add some header:

Formatted Number Input for Drupal
Copyright (C) 2025 maxilein

This program is free software; you can redistribute it and/or modify 
it under the terms of the GNU General Public License as published by 
the Free Software Foundation; either version 2 of the License, or (at
 your option) any later version.

This program is distributed in the hope that it will be useful, but 
WITHOUT ANY WARRANTY; without even the implied warranty of 
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 
General Public License for more details:

But that is not required, is it? Then I would just delete that header if the rest gets automatically replaced.

Anything that GitLab replaces should be reverted, including <one line to give the program's name and a brief idea of what it does.>.

The license file does not contain any header. It starts with GNU GENERAL PUBLIC LICENSE.

Then the license is ok now. Thank you for your help.

GPL2+ license included in release 2.0.3

As a side note: These applications do not require that new releases are created after reviews.

Thank you I figured. But to make the module consistent with the legal requirements before other people download it seems reasonable.