undefined - Contrib.social

📌 | Gemini Provider | Clarifying how conversation history is managed and persisted between requests within the Drupal AI module's ecosystem, specifically for multi-turn interactions

🇦🇹Austria maxilein

🇦🇹Austria maxilein

maxilein → created an issue.

🐛 | Drupal core | Simple decimals fail to pass validation

🇦🇹Austria maxilein

Thank you.
Let me explain my observation - an outside view so to say.

I added the field decimal, because I needed a place for huge numbers with not so many positions behind the comma.
Then I had to realize that a field called decimal is very much limited in comparison to what I expected, or from my experience with other decimal functionality in other system would have expected.
That was my confusion number one.

Then I learned I can configure the field upon its creation. And before this validation bug here - or better without realizing that again - it was not problem to set the gui to whatever I needed. A huge number with a few digits behind the comma.
Entering data caused numbers to be crunched ... we all know that story here.

Then you wonder what to do and how it all depends on each other.

The default database allows for much more digits before and after the comma than default Drupal.
In my opinion that is not good. It is confusion number one.
Then you realize that also php may have a limit inbetween. That is confusion number three.

In my opinion we should make that clear somehow.
I think Drupal should ask during install how the user wants it to be set.
e.g.
DB limit is ...
php limit is ...
Drupal default is ...
Would you like to use Drupal default precision/scale for decimal fields or would you like to increase the default to the php and DB limits.

Then at least it would be transparent what happens here.

The next problem is the intransparent limitation of this patch. I can set some precicion/scale during field creation and it may crash because of underlying system differences ... which were not obvious during field creation.

Why should this patch not be adjusted to system parameter settings? it does not make sence to me to keep an artificially limited number of digits before or after the comma it the system already provides for that bandwidth.

And btw: thank you all very much for your efforts!

The standard setting does not a

🐛 | Drupal core | Simple decimals fail to pass validation

🇦🇹Austria maxilein

#372 I completely agree.
And I don't understand this from #370 "We shouldn't make this field value dependent on an environment specific setting. It needs to be distinct."

We have three layers:
Database - php - drupal/gui

Why should they be distinct from each other?!

if php sends something too large for the db -> error.
If drupal sends something wrongly scaled -> error.
...

In my opinion we should specify rules on how they need to be in sync to each other.

💬 | Solo | How to have blocks of different width in the content region?

🇦🇹Austria maxilein

Thank you so much!

💬 | Solo | How to have blocks of different width in the content region?

🇦🇹Austria maxilein

maxilein → created an issue.

💬 | Drupal core | How to solve: Stage directory is a subdirectory

🇦🇹Austria maxilein

Everything is fine for me. You are the expert. I am not so deep in Drupal code in order to make these judgements.

💬 | Drupal core | How to solve: Stage directory is a subdirectory

🇦🇹Austria maxilein

And don't forget #17. It seems to be a rare trap.

💬 | Drupal core | How to solve: Stage directory is a subdirectory

🇦🇹Austria maxilein

Please someone check that code above and here are example cases.

// Example 1: Stage is a direct subdirectory
$stage1 = '/var/www/html/myproject/staging';
$active1 = '/var/www/html/myproject';
echo "Example 1: " . (isStageSubdirectoryOfActive($stage1, $active1) ? 'true' : 'false') . "\n"; // Output: true

// Example 2: Stage is nested deeper
$stage2 = '/var/www/html/myproject/staging/sub/folder';
$active2 = '/var/www/html/myproject';
echo "Example 2: " . (isStageSubdirectoryOfActive($stage2, $active2) ? 'true' : 'false') . "\n"; // Output: true

// Example 3: Paths are identical
$stage3 = '/var/www/html/myproject';
$active3 = '/var/www/html/myproject';
echo "Example 3: " . (isStageSubdirectoryOfActive($stage3, $active3) ? 'true' : 'false') . "\n"; // Output: false

// Example 4: Stage is a parent directory (or unrelated)
$stage4 = '/var/www/html';
$active4 = '/var/www/html/myproject';
echo "Example 4: " . (isStageSubdirectoryOfActive($stage4, $active4) ? 'true' : 'false') . "\n"; // Output: false

// Example 5: Unrelated paths
$stage5 = '/etc/nginx';
$active5 = '/var/www/html';
echo "Example 5: " . (isStageSubdirectoryOfActive($stage5, $active5) ? 'true' : 'false') . "\n"; // Output: false

// Example 6: Partial match, but not a directory boundary
$stage6 = '/var/www/html_extra';
$active6 = '/var/www/html';
echo "Example 6: " . (isStageSubdirectoryOfActive($stage6, $active6) ? 'true' : 'false') . "\n"; // Output: false

// Example 7: Windows-style paths
$stage7 = 'C:\\Users\\Test\\My Documents\\Stage';
$active7 = 'C:\\Users\\Test\\My Documents';
echo "Example 7: " . (isStageSubdirectoryOfActive($stage7, $active7) ? 'true' : 'false') . "\n"; // Output: true

// Example 8: Mixed separators
$stage8 = 'C:/Users/Test/My Documents/Stage/Sub';
$active8 = 'C:\\Users\\Test\\My Documents';
echo "Example 8: " . (isStageSubdirectoryOfActive($stage8, $active8) ? 'true' : 'false') . "\n"; // Output: true

// Example 9: Trailing slashes
$stage9 = '/var/www/html/myproject/staging/';
$active9 = '/var/www/html/myproject/';
echo "Example 9: " . (isStageSubdirectoryOfActive($stage9, $active9) ? 'true' : 'false') . "\n"; // Output: true

// Example 10: Root directory cases
$stage10a = '/var/log';
$active10a = '/';
echo "Example 10a (Root): " . (isStageSubdirectoryOfActive($stage10a, $active10a) ? 'true' : 'false') . "\n"; // Output: true

$stage10b = '/';
$active10b = '/';
echo "Example 10b (Root): " . (isStageSubdirectoryOfActive($stage10b, $active10b) ? 'true' : 'false') . "\n"; // Output: false

💬 | Drupal core | How to solve: Stage directory is a subdirectory

🇦🇹Austria maxilein

If you add this function to modules\contrib\automatic_updates\package_manager\src\PathLocator.php

 /**
 * Checks if a given path string ($stage) represents a subdirectory
 * of another path string ($active).
 *
 * This function compares absolute path strings, normalizes directory separators,
 * and handles edge cases like identical paths or root directories.
 * It does *not* check if the paths actually exist on the filesystem,
 * it purely performs a string comparison.
 *
 * @param string $stage The absolute path string that might be a subdirectory.
 * @param string $active The absolute path string that might be the parent directory.
 *
 * @return bool Returns true if $stage is a subdirectory of $active, false otherwise.
 */
    public function isStageSubdirectoryOfActive(string $stage, string $active): bool
    {
        // 1. Normalize directory separators to '/' for consistent comparison
        $stageNormalized = str_replace('\\', '/', $stage);
        $activeNormalized = str_replace('\\', '/', $active);

        // 2. If the normalized paths are identical, stage is not a *sub*directory.
        if ($stageNormalized === $activeNormalized) {
            return false;
        }

        // 3. Prepare the active path prefix for comparison.
        //    For a path to be a subdirectory, it must start with the parent path
        //    followed by a directory separator.
        //    We ensure the active path ends with a '/' for the check,
        //    unless the active path *is* the root directory itself ('/').
        $activePrefix = rtrim($activeNormalized, '/') . '/';
        if ($activeNormalized === '/') {
             // If active is the root, the prefix should just be '/'
            $activePrefix = '/';
        }

        // 4. Check if the normalized stage path *starts with* the active path prefix.
        //    Using strpos() === 0 is an efficient way to check for "starts with".
        //    Example 1: stage="/var/log/nginx", active="/var/log"
        //       -> stageNormalized="/var/log/nginx", activePrefix="/var/log/"
        //       -> strpos("/var/log/nginx", "/var/log/") === 0 -> TRUE
        //    Example 2: stage="/var/log", active="/var/log"
        //       -> Handled by check #2 -> FALSE
        //    Example 3: stage="/var/logs", active="/var/log"
        //       -> stageNormalized="/var/logs", activePrefix="/var/log/"
        //       -> strpos("/var/logs", "/var/log/") === false -> FALSE
        //    Example 4: stage="/var/log/nginx/error.log", active="/var/log"
        //       -> stageNormalized="/var/log/nginx/error.log", activePrefix="/var/log/"
        //       -> strpos("/var/log/nginx/error.log", "/var/log/") === 0 -> TRUE
        //    Example 5: stage="/home/user", active="/"
        //       -> stageNormalized="/home/user", activePrefix="/"
        //       -> strpos("/home/user", "/") === 0 -> TRUE

        if (strpos($stageNormalized, $activePrefix) === 0) {
            // It starts with the correct prefix, confirming it's inside the active directory.
            // The check in step 2 already ensured they aren't identical.
            return true;
        }

        // If the stage path doesn't start with the active prefix, it's not a subdirectory.
        return false;
    }

And then change ...modules\contrib\automatic_updates\package_manager\src\Validator\StageNotInActiveValidator.php to

  /**
   * Check if staging root is a subdirectory of active.
   */
  public function validate(PreOperationStageEvent $event): void {
    $project_root = $this->pathLocator->getProjectRoot();
    $staging_root = $this->pathLocator->getStagingRoot();
    
    if ($this->pathLocator->isStageSubdirectoryOfActive($staging_root, $project_root) == true )
    {
      $message = $this->t("Stage directory is a subdirectory of the active directory.");
      $currentconfiginfo = $message . " STAGE: " . $staging_root . " ACTIVE ROOT: " . $project_root;
      $event->addError([$currentconfiginfo]);
    }
  }

the error goes away.

And it seems that the comparison logic of paths does work. But I have not tested any other cases than mine.
I will post examples in the next comment. Can someone please convert them into test cases?

Attached is a patch to the 3.1.7 of automatic_updates contrib module.

💬 | Drupal core | How to solve: Stage directory is a subdirectory

🇦🇹Austria maxilein

Thinking about it ACTIVE ROOT: /var/www would correspond to my composer.json location ( see structure above #7)

That seems ok. But I wonder if it would be reliable in all cases because in modules\contrib\automatic_updates\package_manager\src\PathLocator.php the function

  public function getProjectRoot(): string {
    // Assume that the vendor directory is immediately below the project root.
    return realpath($this->getVendorDirectory() . DIRECTORY_SEPARATOR . '..');
  }

has a comment making an assumption about the vender directory being below ...
What if it is somewhere else? Should we check for this assumption also - and at least warn that this check will not work if that is not the case?

💬 | Drupal core | How to solve: Stage directory is a subdirectory

🇦🇹Austria maxilein

Ok. I have tried to make visible what the validator does by adding these lines (in bold):
...modules\contrib\automatic_updates\package_manager\src\Validator\StageNotInActiveValidator.php
lines 38+39

public function validate(PreOperationStageEvent $event): void {
$project_root = $this->pathLocator->getProjectRoot();
$staging_root = $this->pathLocator->getStagingRoot();
if (str_starts_with($staging_root, $project_root)) {
$message = $this->t("Stage directory is a subdirectory of the active directory.");
$currentconfiginfo = $message . " STAGE: " . $staging_root . " ACTIVE ROOT: " . $project_root;
$event->addError([$currentconfiginfo]);
}
}

The output gives:

Stage directory is a subdirectory of the active directory. STAGE: /var/www_tmp/.package_managerX...Y ACTIVE ROOT: /var/www

And that shows that str_starts_with just does not produce a proper result.

💬 | Drupal core | How to solve: Stage directory is a subdirectory

🇦🇹Austria maxilein

The error message is not understandable. It does not make sense to talk about a directory called staging when there is no such folder in real Drupal folder structure.
In oder to make it more easy to grasp and administer without deep knowledge add the path in question that should be moved.

I could not find any documentation on the prerequisites for the new update module. Can someone point into that directions please.

💬 | Drupal core | How to solve: Stage directory is a subdirectory

🇦🇹Austria maxilein

💬 | Drupal core | How to solve: Stage directory is a subdirectory

🇦🇹Austria maxilein

💬 | Drupal core | How to solve: Stage directory is a subdirectory

🐛 | CKEditor mentions | beta does not show which version is required and therefore marked as not compatible

🇦🇹Austria maxilein

Moving the tmp directory out from beneath the composer.json file location does not make the error go away.

moving it from /var/www/tmp
up to a new folder
$settings['file_temp_path'] = '/var/www_tmp';

Any other from php reported tmp directories are in on the testsystem.
/tmp

So I do not understand the error message. The message or check must be wrong.

OR is the Stage directory something completely different. like the sync folder?!

Comment 19 days ago →

🇦🇹Austria maxilein

🐛 | CKEditor mentions | beta does not show which version is required and therefore marked as not compatible

Comment 19 days ago →

🇦🇹Austria maxilein

maxilein → created an issue. See original summary → .

✨ | Solo | Add option to align blocks placed in Footer Third Container

Comment 20 days ago →

🇦🇹Austria maxilein

Thank you!

💬 | Drupal core | How to solve: Stage directory is a subdirectory

Comment 25 days ago →

🇦🇹Austria maxilein

Here is what I learned asking myself how I came to the conclusion it was the recommended place:

Drupal 11 was upgraded from a site I originally installed using Drupal 9 and then I adapted the folder structure with Drupal 10.

The drupal/recommended-project Composer template used to sets up the following general structure:

your-project-name/
├── composer.json # Defines project dependencies, scripts, etc.
├── composer.lock # Locks dependency versions.
├── config/ # Often used for configuration management (e.g., config/sync).
│ └── sync/ # Default location for configuration sync.
├── drush/ # Drush site aliases, commands, and configuration.
├── vendor/ # Composer-managed dependencies (core, contrib modules, themes, PHP libraries). Not committed to Git.
├── web/ # The web server's document root (sometimes called docroot, public_html, etc.).
│ ├── core/ # Drupal core files (managed by Composer).
│ ├── index.php # Drupal's front controller.

There isn't a predefined tmp folder in the standard drupal/recommended-project structure.
Its location is determined by the setting found in Admin > Configuration > Media > File system.
But most of the recommendations derive from web server configuration: It's best practice to explicitly configure a path outside the web root (web/) that is writable by the web server.

So I always figured that the composer.json above all folders is a safe bet - if the web server's root location is below it.
In my case the web server cannot access the folder where the composer.json file is located, because it is above the permissions of the web folder.
So a /tmp folder which is on the same level as the /web should be safe.
Why is it a problem that the /tmp is below the composer.json?

BTW: Here they call the /web structures Base-Level Directories: https://www.drupal.org/docs/getting-started/understanding-drupal/directo... → . But htere is no mention of a tmp folder in regards to the new update manager functionality.
Once this is cleared up we should not forget to add documentation there.

💬 | Drupal core | How to solve: Stage directory is a subdirectory

Comment 26 days ago →

🇦🇹Austria maxilein

Thank you. For the example below I added /active_directory in the structure.

/../active_directory/composer.json

/../active_directory/web/ (= Drupal) index.php

/../active_directory/web/vendor
/../active_directory/web/tmp
/../active_directory/web/recipes
/../active_directory/web/private

wasn't this the recommended structure until Drupal 9 or 10?

💬 | Drupal core | How to solve: Stage directory is a subdirectory

Comment 26 days ago →

🇦🇹Austria maxilein

maxilein → created an issue.

📌 | Drupal core | [META] Enable layout builder for form displays, and deprecate field_layout

🇦🇹Austria maxilein

thank you.

✨ | Entity Type Clone | Drupal 11 compatibility fixes

🇦🇹Austria maxilein

Please add a D11 version!

📌 | Drupal core | [META] Enable layout builder for form displays, and deprecate field_layout

🇦🇹Austria maxilein

What is the recommended alternative to this module?

🐛 | Edit Content Type Tab | Installation fails on D11.1.6

🐛 | Drupal core | Decimal separator and decimals settings ignored when aggregating decimal fields

🇦🇹Austria maxilein

maxilein → created an issue.

🇦🇹Austria maxilein

Maybe these errors are connected to this long standing issue: https://www.drupal.org/project/drupal/issues/2230909 🐛 Simple decimals fail to pass validation Needs work

✨ | Solo | Add option to align blocks placed in Footer Third Container

🇦🇹Austria maxilein

I don't know if aligning menus and text separately should be another feature with its own dropdown or if it the entire content should be right aligned.
The menu is right aligning if I uncheck display:flex; - but also other elements...

✨ | Solo | Add option to align blocks placed in Footer Third Container

✨ | Drupal core | Allow for expandable text with "Read more/less" links in Default field formatter

🇦🇹Austria maxilein

Thanks a lot again! Looks great thank you.
It right aligns all texts like "Powered by Drupal" or the headings of a Menu.

But the menu itself remains flexed and centered inside the block. Pls. see screenshot.