- Issue created by @dylan donkersgoed
- 🇮🇳India vipul tulse
Hello Team, Anyone has got chance to work on this.
If any one has idea how we can accomplish this please guide here. - 🇦🇺Australia mstrelan
The external plugin is a fork of bvedad/ckeditor5-anchor and probably needs to first be updated in https://github.com/bvedad/ckeditor5-anchor/issues/6
- 🇦🇺Australia mstrelan
Have posted a PR against northernco/ckeditor5-anchor-drupal
- 🇮🇳India vipul tulse
I have added few comments with code fix which we need to do in the code changes.
Thanks for the great work.
Thanks for the work on this. Are we at the mercy of northernco to merge in your requests, or is there a way we can patch this to get empty anchors working? Thanks!
- 🇦🇺Australia mstrelan
Merging would be ideal, I've addressed or at least responded to all feedback. But you can clone the PR from my fork and build it yourself and use the dist file in your Drupal site.
- 🇮🇳India vipul tulse
@Dylan Donkersgoed can you make me maintainer for Drupal 10 branch so will add library inside module to instead of dependent other Git repo
- Status changed to Fixed
12 months ago 9:05pm 30 November 2023 - 🇨🇦Canada dylan donkersgoed London, Ontario
Thanks for the PR mstrelan and vipul-tulse for reviewing. The latest dev version requires a tag with this PR merged in.
As for bringing this into Drupal I'm not sure bringing it into the module is the way to go. Despite the name of the repo, I don't think it's actually Drupal specific. It works inside the non-Drupal CKE5 sample environment at least.
When I first started work on this I was attempting to adapt the existing plugin to work the way I'd seen other Drupal CKE5 plugins work. I did not realize what I was actually doing was adapting it to be a DLL plugin, which is a recognized method of building a CKE5 plugin that works even outside of Drupal. So I called it ckeditor5-anchor-drupal.
Automatically closed - issue fixed for 2 weeks with no activity.