We don't have the libraries folder committed to source control, so I don't think the suggestion in #9 would work for us, however, the solution in comment #8 worked.
Should the description on the anchor_link module page be changed to have the instructions from comment #8?
Just to give additional details to what is recommended in comment #8, instead of using wikimedia/composer-merge-plugin, I added the following (at the time of this post) to the composer.json "repositories" section:
{
"type": "package",
"package": {
"name": "northernco/ckeditor5-anchor-drupal",
"version": "0.5.0",
"type": "drupal-library",
"dist": {
"url": "https://registry.npmjs.org/@northernco/ckeditor5-anchor-drupal/-/ckeditor5-anchor-drupal-0.5.0.tgz",
"type": "tar"
}
}
},
That is what was in the /modules/contrib/anchor_link/composer.libraries.json at the time of this post, but will change over time and would need to get changed on the module home page each time things changed with northernco/ckeditor5-anchor-drupal.
Then as mentioned in comment # 8, I ran: composer require northernco/ckeditor5-anchor-drupal
I am having a similar problem where the library doesn't show up until I run the composer install twice. Same with deleting the library, I have to run composer remove twice before it will get deleted. Not sure why.
Thanks for updating the dev release Dylan! I did a test and it looks good to me. Moving back to Needs Review.
Moving to needs work, as I think think we need a new release on the for 3.0.x-dev (or alpha) which points to ckeditor5-anchor-drupal-0.5.0.tgz.
Or maybe a bump to the dev version would be more appropriate, either way dev or alpha would work.
Thanks Dylan! Could we get a bump to 3.0.0-alpha2 (or some variation) on the list of releases on the project page with the new reference to the registry.npmjs.org ckeditor5-anchor-drupal-0.5.0.tgz? It seems when I reinstall the module I'm still getting 0.4.0 right now. Thanks!
I've opened a new Github PR that I think addresses this issue:
https://github.com/northernco/ckeditor5-anchor-drupal/pull/9
Not sure if this implementation is the best way to go, but it seems to be working for me.
Somewhere along the way I must have either disabled the module or never enabled it like you had experienced. After I installed the module the flag showed up. The empty anchor tags that I have in my content are disappearing now, but that was something I know others were working on and so I'll close this ticket and look into that.
Thanks Dylan, I'll give it another try and start from the beginning and get back with you.
This seems to be still an issue in 1.1, so I've changed the version to 1.1, and am moving the status to needs review, for someone to take a look at the patch and see if it solves the problem.
My last post doesn't address the issue when you try to limit the page, but you haven't set a max in the services.yml file. This still triggers that error. So I'm posting a patch here that I think fixes this issue.
I got the same error and for me it turned out that I didn't have the parameters set in the services.yml file. I had to add the following to the parameters in services.yml:
jsonapi_page_limit.size_max:
/jsonapi/taxonomy_term/my_taxonomy_term: 100
What l think is happening is that the folder docroot/libraries/ckeditor5-anchor-drupal was already present (because I had been trying to install this multiple times), and then when I ran composer require 'drupal/anchor_link:^3.0@alpha', it deleted the folder. Then when I tried removing the module, it added the folder back. Then it takes running composer require 2 times to get the folder back. It seems to be in some kind of mixed up state. Unfortunately, even when I have the folder present and the module installed, I'm still not seeing the flag button as an option.
Thanks for the quick reply Dylan! It looks like the folder docroot/libraries/ckeditor5-anchor-drupal is not there.
mkimmet → created an issue.
Thanks for the work on this. Are we at the mercy of northernco to merge in your requests, or is there a way we can patch this to get empty anchors working? Thanks!
@larowlan, thanks for the heads up on ".diff" on the MR URL. I hadn't done that before so I used the following url for the patch, hopefully that was what you meant:
https://git.drupalcode.org/project/drupal/-/merge_requests/4278.diff
I applied the patch and there were no errors, then I ran the database updates and the three updates ran with no errors (there were no duplicates found on update 10101). The error message no longer appears on the status page. Then I did some basic testing, adding forum topics, comments, editing and deleting and everything seemed to work, but like I mentioned everything seemed to work without the patch. Looked at the Drupal logs and don't see any errors or warnings.
I'm running Drupal 10.1.6.
Do you suggest I proceed with that MR diff patch for production?
Thanks!
The forum seems to work on 10.1.6 despite the error. Since it is an error, is the current advice to not use the forum with 10.1 until this issue is fixed? Is it ok to use the patch from comment 68 to get around the error? Any advice on what to do before this is fixed in 11 would be appreciated. Thanks!
Added this to a patch based on the latest merges, for easier patching until the next version is released.
psingh10's fix almost worked for me in conjunction with this issue ( https://www.drupal.org/project/meta_position/issues/3288579#comment-1526... 📌 Automated Drupal 10 compatibility fixes RTBC ), however, it didn't seem to bump the meta data down for me. So I'm posting a patch here for that. Not sure if this patch is the right way to handle this, but it seems to work for my needs.
I'm seeing this problem as well. Any word on when this might be merged into a release? Thanks!
Patch from #11 seems to work for me on Drupal 10.0.9
I had the same experience using this module with Drupal 10.0.9 while running the Gin admin theme. Clicking on the save button does nothing after you make a change to a field that is using the Form Filter Fields module.
I'm guessing it's some kind of conflict with the way the Gin theme moves the save button to the top of the page. I have not had a chance to look into it yet, and changed to another theme that is working with Form Filter Fields module for now.