🇨🇦Canada @occupant

Fixed in 1.0.0-beta10

Fixed in ckeditor5_fullscreen 1.0.0-beta10

@carstenhager I have altered the toolbar check in the dev branch again (properly this time!) and it is working in my tests. If this looks good, I'll go ahead with a new release.

I've added a check for the toolbar to the dev branch that should alleviate this issue - https://www.drupal.org/project/ckeditor5_fullscreen/releases/1.0.x-dev →

If all looks ok, I'll make a new release.

Thanks both. And thanks for confirming the issue cause @carstenhager. The toolbar was introduced into the plugin here 🐛 Fullscreen mode interferes with link button Needs review but it slipped past that this would require the toolbar to be required. I'll have to break this down and see about backing out of those changes.

I am experiencing the same issue and the supplied patch corrects the issue for me.

Added fix to 1.0.0-beta9

I believe I've discovered the issue and have committed the fix to the dev branch. I have tested in 10.3 and 10.2 and will make a new release asap

In 10.3 the CKE version was bumped and the css variable --ck-z-modal was renamed or replaced by --ck-z-panel. This plugin was using this to track the z-index, so when it was removed, the css was left with an undefined variable.

To remedy the issue, I've updated the variable and also explicitly declared it (in case this happens again) using the CKE5 default values. I don't love this, but it is a workaround and should ensure will be backward compatible with the new variable in place.

RE: catch's suggestion, I think the https://www.drupal.org/project/ckeditor5_plugin_pack → module is great, but there's a place for a standalone version.

occupant → created an issue.

Thank you for looking at this again, I really do appreciate it. I have indeed found another issue. The contextual balloon position isn't always getting recalculated properly (or at all). I'll give this another shot and hopefully get it worked out now that I can see another thing I need to be mindful of. Thanks again!

@bkosborne Thanks, yes, I'm pretty sure. The dev download page shows the last commit was March 22 (created in Aug).

To be extra sure (since the branch mess was real) I just went into simplytest.me and loaded up the dev version of the module and tested with layout builder (as above). I've attached a few screenshots.

Thanks @bkosborne, I messed up the branches and the dev version wasn't updated correctly - the dev branch was still pointing to an old commit. Whoops.

I have tested and am fairly sure that the issues you reported are fixed in 10.0+, but if you could confirm that would be fantastic. The link → is loading the composer command to the latest commit correctly now.

Changing branch - please test that it's fixed in dev branch

Didn't go quite far enough with the last dev version, so I've made some changes. Can you try the latest dev version → and see if it's resolved? I now get consistent placement and behaviour in Chrome, Firefox and Safari using Gin and Claro admin themes.

Can you try the latest dev version → and see if this is resolved? I've tested with the source plugin and also the Codemirror plugin, both in Gin and Claro. Hopefully this will take care of it.

Sorry for the delay. I've updated the module with a fix for this locally, using layout builder, both Claro and Gin themes. Can you try with the latest dev version → ?

Thanks for the report. I've updated the module with a fix for this (at least in my local testing). Can you try the latest dev version → to see if the issue is resolved?

Hmm, ok. Are you using Drupal 9 by any chance? In v10+ (not sure about Dupal 9) the Drupal.displace library is reserving space at the top of the page for the toolbars, etc. I've only tested in D10.2 so far and have been able to take care of it locally. If you have a different setup, I'd like to try that and make sure that I'm on the right track at least.

Thanks @gordon,

I've made an initial stab at making this work in the layout builder sidebar - can you try the latest dev → version to see if this behaviour is corrected?

This could be tricky depending on the admin theme you're using, but I've tested with Clara and Gin, and both seem to be ok.

@sararellano, can you try the latest dev → version to see if this remedies your issues?

Thanks @davedg629, I was able to replicate some erratic behaviour across browsers - it looks like the Drupal.displace library used by the toolbar in 10.x is causing the behaviour. I've updated the latest dev → version to try to remedy the issue.

Assuming this works as expected, I'll have to assess how Drupal.displace is used in core 9.x, but that's a later task.

@besek, I've made a new release of the module that uses data attributes instead of ids (so it should be less fragile). Are you able to try this and see if that changes things? I can test as well, but I'd like to make sure I'm not missing anything present in your use case.

Apologies, this was a mistake on my part - I changed the selectors used to apply the style changes but neglected to pull in all of my updated css changes. I've created an updated release (1.0.0-beta7) that has the intended changes.

@SpadXIII thank you, this looks great. I've merged and it will be in the next release

This is great, thank you! Merged and will be in 1.0.0-beta6

Remove duplicate SDC Display link and description, update remaining SDC Display description to use the (otherwise removed) duplicate's description.

This looks like it's outdated / duplicated by https://www.drupal.org/project/ckeditor5_fullscreen/issues/3390608 🐛 CKEditor 5 Fullscreen is not getting full height with Source Needs review

Thanks @francismak, I've been able to reproduce this consistently. I had to also install the field_group module to test (not sure if that was omitted or you achieved the layout in a different way).

I do think the selector's specificity is higher than it needs to be however - I was able to resolve without the inclusion of #block-claro-content. Can you confirm?

Thanks again!

Thanks for the report - I'm trying to replicate the issue and am seeing things inconsistent with the issue you've described. It seems like the <div class="counter">Used chars: 23</div> node is in a different place in your document. Immediately following the textarea, I have a div with the ck ck-reset ck-editor ck-rounded-corners classes. That's the one that should be targeted and changed.

I'm using:

• Core v10.1.6
• Gin admin theme v8.x-3.0-rc7
• maxlength v2.1.2
• CKEditor5 Fullscreen v1.0.0-beta5

I wonder if the id is inadvertently getting clobbered somehow? Which points to an issue - the module should use data attributes instead of ids (and the Dom traversal may have to be addressed). I think the move to data-attributes is a change that should be made regardless.

Happy to look into this further if you can provide more details

Updated formatting for previous SDC generator edit

Update to explain that the CL Generator module is no longer needed in Drush versions 12+ 

@pmagunia - could this be related to https://www.drupal.org/project/ckeditor5_fullscreen/issues/3379770 🐛 Conflict with admin toolbar module Closed: works as designed ? Could the z-index of the link window be interfered with by the admin_toolbar index?

I think it would make more sense to patch the admin_menu module in this case - in admin_menu version 3.4.0 → the rule in question was removed (after it was added in 3.3.1 → ). So this is an issue caused by an extremely aggressive CSS rule that was subsequently deemed to be a bad idea.

You can easily patch the admin menu module by removing the first rule in the admin.toolbar.css file (added in issue https://www.drupal.org/node/3335841 → ):

#toolbar-bar {
  z-index: 100000;
}

1.0.0-beta5 released with the fix applied. Thanks again!

@pmagunia, I'm unable to replicate the issue using Claro and the admin_toolbar module in 9.5.10 (screenshot attached).

Can you provide more information about this? Ie. if you inspect, does the #toolbar-bar div have the default z-index value of 502? And does your #fullscreeneditor div have the following css rules:

#fullscreeneditor {
  position: fixed !important;
  top: 0;
  left: 0;
  right: 0;
  bottom: 0;
  z-index: 1000;
  display: flex;
  flex-direction: column;
}

Thanks for the report @pmagunia. I have it working with the gin toolbar but hadn't tested with this.

Thanks for this @a.more, that file snuck in there. I've merged your change and it should be fixed on the next release.

I'm also seeing this using 2.2.4.

Closing this as it is outdated with the current release

Great, thanks for the info. I must have missed the note about the 10 day waiting period. Thank you!

Thanks for the feedback apaderno. To answer your question, not on Drupal.org, no. Most of my work (primarily theme layer) is done for internal purposes. I'm happy to give you a link to a GitHub project or two if that would suffice, but I imagine that's not what you're asking for. Alternatively, I can add Joel Pittet → (who I work with) as a co-maintainer. My goal is to have the warning removed more than anything.

In case anyone is interested, I've taken the plunge and adapted the plugin mentioned by @joelpittet in #10 📌 [upstream] Support full-screen editing - distraction free mode when it is available upstream Active and created it as a standalone project → for now.

occupant → created an issue.

longwave → credited occupant → .

This is fixed in #3338111 📌 Remove Gulp/Grunt and use NPM scripts to run scripts Fixed

@joelpittet This looks fantastic! I've run through all the node commands and they are all doing exactly what I'd expect. Nice!

@joelpittet Yes, absolutely, that issue supersedes this one. I'll close it and comment there. Thanks!

Re #5, the command I used was php core/scripts/drupal generate-theme basic --path themes/custom as per the docs → .

occupant → created an issue.

occupant → created an issue.