Not compatible with Drupal 10.3.0

Created on 6 July 2024, 4 months ago
Updated 7 August 2024, 3 months ago

Problem/Motivation

This module isn't compatible with the version of ckeditor5 that ships with Drupal 10.3.0.

See πŸ’¬ Body content not visible in ckeditor5 after 10.3.0 update Active .

Steps to reproduce

Proposed resolution

Recommend https://www.drupal.org/project/ckeditor5_plugin_pack β†’ instead which ships the same plugin and is maintained by the CKSource team.

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡¬πŸ‡§United Kingdom catch

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @catch
  • πŸ‡ΏπŸ‡¦South Africa Gomez_in_the_South

    For our use case, the ckeditor5_plugin_pack is overkill (which also has ckeditor5_premium_features as a requirement).
    We're only interested in the full screen button, so it would be great if this issue could still be resolved within this module.

    Looking at the merge request for the similar issue πŸ› Incompatibilidad con Drupal 10.3.0 Postponed: needs info with the ckeditor_font module, shows that may be to update the CKEditor plugin version within the package.json?
    I don't have an available 10.3 environment to test this at present.

  • Assigned to occupant
  • Status changed to Needs review 4 months ago
  • πŸ‡¨πŸ‡¦Canada occupant Canada

    I believe I've discovered the issue and have committed the fix to the dev branch. I have tested in 10.3 and 10.2 and will make a new release asap

    In 10.3 the CKE version was bumped and the css variable --ck-z-modal was renamed or replaced by --ck-z-panel. This plugin was using this to track the z-index, so when it was removed, the css was left with an undefined variable.

    To remedy the issue, I've updated the variable and also explicitly declared it (in case this happens again) using the CKE5 default values. I don't love this, but it is a workaround and should ensure will be backward compatible with the new variable in place.

    RE: catch's suggestion, I think the https://www.drupal.org/project/ckeditor5_plugin_pack β†’ module is great, but there's a place for a standalone version.

  • Status changed to Fixed 4 months ago
  • πŸ‡¨πŸ‡¦Canada occupant Canada

    Added fix to 1.0.0-beta9

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024