Conflict with admin toolbar module

Created on 7 August 2023, over 1 year ago
Updated 15 August 2023, over 1 year ago

Problem/Motivation

The CKE5 toolbar is hidden by the admin toolbar module when in full screen mode

Steps to reproduce

1. Install and enable admin_toolbar module
2. Install and enable fullscreenmodule

When editing text the CKE5 toolbar will be hidden (See screenshot)

Proposed resolution

TBD

Remaining tasks

TBD

User interface changes

TBD

API changes

TBD

Data model changes

TBD

πŸ› Bug report
Status

Closed: works as designed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States pmagunia Philadelphia πŸ‡ΊπŸ‡Έ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @pmagunia
  • πŸ‡¨πŸ‡¦Canada occupant Canada

    Thanks for the report @pmagunia. I have it working with the gin toolbar but hadn't tested with this.

  • Assigned to occupant
  • πŸ‡¨πŸ‡¦Canada occupant Canada
  • Status changed to Postponed: needs info over 1 year ago
  • πŸ‡¨πŸ‡¦Canada occupant Canada

    @pmagunia, I'm unable to replicate the issue using Claro and the admin_toolbar module in 9.5.10 (screenshot attached).

    Can you provide more information about this? Ie. if you inspect, does the #toolbar-bar div have the default z-index value of 502? And does your #fullscreeneditor div have the following css rules:

    #fullscreeneditor {
      position: fixed !important;
      top: 0;
      left: 0;
      right: 0;
      bottom: 0;
      z-index: 1000;
      display: flex;
      flex-direction: column;
    }
    
  • Status changed to Active over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States pmagunia Philadelphia πŸ‡ΊπŸ‡Έ

    Thanks for the quick reply.

    We are using admin_toolbar 3.3.2 and Drupal 9.5.10.

    I see this line in the older version of the admin_toolbar we are using:

    #toolbar-bar {
      z-index: 100000;
    }

    https://git.drupalcode.org/project/admin_toolbar/-/blob/3.3.2/css/admin....

    Our Drupal report is not explicitly saying its no longer supported, but there is a newer version on the Drupal.org admin_toolbar page.

  • Status changed to Needs review over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States pmagunia Philadelphia πŸ‡ΊπŸ‡Έ

    I couldn't upgrade to admin_toolbar to the latest version due to some dependencies.

    I thought it would be easier to patch here.

    Not sure its acceptable.

  • Status changed to Closed: works as designed over 1 year ago
  • πŸ‡¨πŸ‡¦Canada occupant Canada

    I think it would make more sense to patch the admin_menu module in this case - in admin_menu version 3.4.0 β†’ the rule in question was removed (after it was added in 3.3.1 β†’ ). So this is an issue caused by an extremely aggressive CSS rule that was subsequently deemed to be a bad idea.

    You can easily patch the admin menu module by removing the first rule in the admin.toolbar.css file (added in issue https://www.drupal.org/node/3335841 β†’ ):

    #toolbar-bar {
      z-index: 100000;
    }
Production build 0.71.5 2024