- Issue created by @markconroy
- @markconroy opened merge request.
- Status changed to Needs review
almost 2 years ago 5:21pm 20 February 2023 - 🇫🇮Finland lauriii Finland
We should probably enable https://stylelint.io/user-guide/rules/selector-pseudo-element-colon-nota... to make sure that we remain compliant 😅
- Status changed to RTBC
almost 2 years ago 7:10pm 20 February 2023 - Status changed to Needs work
almost 2 years ago 5:04pm 22 February 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to RTBC
almost 2 years ago 7:32pm 22 February 2023 - 🇺🇸United States andy-blum Ohio, USA
merged in commits from 10.1.x, setting back to RTBC
- Status changed to Needs work
over 1 year ago 8:48pm 23 February 2023 - 🇬🇧United Kingdom longwave UK
This looks great, one nit about the stylelint config but otherwise this is ready to go.
- Status changed to Needs review
over 1 year ago 8:01am 24 February 2023 - 🇬🇧United Kingdom longwave UK
Closed 📌 Update stylelint rule selector-pseudo-element-colon-notation to be consistent with Drupal's CSS standards Closed: duplicate as duplicate and transferred credit.
- Status changed to RTBC
over 1 year ago 1:43pm 2 March 2023 - 🇺🇸United States andy-blum Ohio, USA
Tested this with core's
yarn lint:css
script.Added the code below to an Olivero PostCss file:
.test-class:before { display: block; } .test-class:::after { display: none; } .test-class::hover { text-decoration: underline; }
The linter returned the below errors:
29:12 ✖ Expected double colon pseudo-element notation selector-pseudo-element-colon-notation 33:12 ✖ Unexpected unknown pseudo-element selector ":::after" selector-pseudo-element-no-unknown 37:12 ✖ Unexpected unknown pseudo-element selector "::hover" selector-pseudo-element-no-unknown
Ran the linter again with the --fix flag and it was able to auto-fix the selector-pseudo-element-colon-notation error while the unknown pseudo element errors remained.
- Status changed to Needs work
over 1 year ago 4:12pm 14 April 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 4:19pm 14 April 2023 - First commit to issue fork.
- last update
over 1 year ago 29,202 pass - Status changed to RTBC
over 1 year ago 4:16pm 17 April 2023 - First commit to issue fork.
- last update
over 1 year ago 29,207 pass - Status changed to Fixed
over 1 year ago 5:24pm 17 April 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
Did an additional regex check, but this is a pretty straightforward find and replace. If somehow something slipped through this doesn't preclude it from getting addressed in a separate issue, but this all looks fine. Committed to 10.1.x.
Automatically closed - issue fixed for 2 weeks with no activity.