🇺🇸United States @rpayanm

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

rpayanm → created an issue.

rpayanm → made their first commit to this issue’s fork.

rpayanm → changed the visibility of the branch 11.x to hidden.

rpayanm → made their first commit to this issue’s fork.

Setting the uid to 1, because I had issues with private files.

rpayanm → made their first commit to this issue’s fork.

I created a new patch based on the first one. Please review it.

rpayanm → changed the visibility of the branch 3477713-enabled_optional_attributes.includes-not-a-function to hidden.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

Please review.

rpayanm → created an issue.

I try to fix this with this patch.
Or we can keep the keys in the $page variable.

rpayanm → created an issue.

I also added a validation to ensure that the end date is not earlier than the start date.

The code here worked for me:
https://www.drupal.org/project/drupal/issues/3072317#comment-14926967 ✨ CKEditor embedded media previews do not render with attached assets Active

function mymodule_support_preprocess_page(&$variables) {
  if (\Drupal::service('router.admin_context')->isAdminRoute()) {
    $variables['#attached']['library'][] = 'mymodule_support/ckeditor5_fixes';
  }
}

document.body.addEventListener('click', (e) => {
  // Prevent opening colorbox images in the current tab while in the editor.
  if (e.target.parentElement.classList.contains('colorbox')) {
    e.preventDefault();
  }
});

The patch #9 did not work for me.
I created a new one based on #7, please review it.

rpayanm → made their first commit to this issue’s fork.

Please review.

rpayanm → created an issue.

Hi @Grimreaper, thank you!
I tried this but I was unable to get it to work

I added this in my custom_theme.info.yml:

ckeditor5-stylesheets:
  - /ui_styles/stylesheet.css?prefix=.ck-content

I got this error on Firefox:

The page isn’t redirecting properly

And ended up with this URL:

http://example.com/ui_styles/stylesheet.css?q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&q=ui_styles/stylesheet.css&prefix=.ck-content

If I change the URL in ui_styles/ui_styles.routing.yml from /ui_styles/stylesheet.css to /ui_styles/test and visit that URL: http://example.com/ui_styles/test?prefix=.ck-content I get the generated CSS right.

What I am doing wrong?

quietone → credited rpayanm → .

I got the issue on
Drupal v10.3.1
Gin Admin Theme 8.x-3.0-rc13

You can do it using this hook:
https://git.drupalcode.org/project/shs/-/blob/2.0.x/src/Plugin/views/fil...

$hooks = [
    'shs_js_settings',
    "shs_{$field_name}_js_settings",
    "shs_{$this->view->id()}__{$identifier}_js_settings",
    "shs_{$this->view->id()}__{$field_name}_js_settings",
    "shs_{$this->view->id()}__{$this->view->current_display}__{$identifier}_js_settings",
    "shs_{$this->view->id()}__{$this->view->current_display}__{$field_name}_js_settings",
  ];
  // Allow other modules to override the settings.
 \Drupal::moduleHandler()->alter($hooks, $settings_shs, $bundle, $field_name);

I applied the patch, and it worked fine, but this occurs when the dropdown is at the top:

I added a class to each element on this patch. Please review it.

rpayanm → created an issue.

We could compare them using "==" or apply the attached patch.

rpayanm → created an issue.

It works like a charm. Thank you!

Gutenberg >= 3.0

I added some suggestions and fixed the test error. Please review.

rpayanm → made their first commit to this issue’s fork.

Added requirements.

Could you check if this solution fixes this issue?

https://www.drupal.org/project/redirect/issues/3373123#comment-15300077 🐛 Setting 'Enforce clean and canonical URLs.' breaks CSS aggregation on multilingual Drupal 10.1.x with browser caching enabled RTBC

Please review.

rpayanm → created an issue.

Please review.

rpayanm → created an issue.

Please review.

rpayanm → created an issue.

I tried this patch and works well.
But I had the same issue as #45 on a 1400px width when the sidebar is shown:

There is no issue is the sidebar is hidden.

rpayanm → changed the visibility of the branch 3410812-10.2.x to active.

rpayanm → changed the visibility of the branch 3410812-10.2.x to hidden.

rpayanm → created an issue.

I confirm that the error is still in v1.16 and the #7 patch solves the issue.

Please review.

rpayanm → made their first commit to this issue’s fork.

Please review.

rpayanm → made their first commit to this issue’s fork.

I have created a patch for the 8.x-10.x version.
Please review.

rpayanm → made their first commit to this issue’s fork.

@aangel Please see:
https://www.drupal.org/project/title_field_for_manage_display/issues/322... →

Please review.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

Please review.

Please review.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

I rerolled it, please review.

I added the #11's suggestions.
Please review.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

I rerolled and fixed Custom Commands Failed from #33

Please review.

I rerolled the patch from #77.

Please review.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

I swapped out withConsecutive() for willReturnOnConsecutiveCalls().

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

Please review.

Please review.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

Please review.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

oh! makes sense, awesome, thank you @poker10

I rerolled the patch and applied the #27's suggestions. Please review.

Weird, the same code failed using an MR.

rpayanm → made their first commit to this issue’s fork.

rpayanm → made their first commit to this issue’s fork.

I can confirm the issue is still present in 9.5.10
And the patch #5 worked fine.