We could compare them using "==" or apply the attached patch.
It works like a charm. Thank you!
I added some suggestions and fixed the test error. Please review.
Could you check if this solution fixes this issue?
https://www.drupal.org/project/redirect/issues/3373123#comment-15300077 🐛 Setting 'Enforce clean and canonical URLs.' breaks CSS aggregation on multilingual Drupal 10.1.x with browser caching enabled RTBC
Please review.
Please review.
rpayanm → created an issue.
Please review.
I tried this patch and works well.
But I had the same issue as #45 on a 1400px width when the sidebar is shown:
There is no issue is the sidebar is hidden.
rpayanm → changed the visibility of the branch 3410812-10.2.x to active.
rpayanm → changed the visibility of the branch 3410812-10.2.x to hidden.
rpayanm → created an issue.
Please review.
rpayanm → made their first commit to this issue’s fork.
Please review.
I have created a patch for the 8.x-10.x version.
Please review.
@aangel Please see:
https://www.drupal.org/project/title_field_for_manage_display/issues/322... →
Please review.
Please review.
Please review.
rpayanm → made their first commit to this issue’s fork.
I rerolled it, please review.
I added the #11's suggestions.
Please review.
rpayanm → made their first commit to this issue’s fork.
I rerolled and fixed Custom Commands Failed from #33
Please review.
rpayanm → made their first commit to this issue’s fork.
I swapped out withConsecutive()
for willReturnOnConsecutiveCalls()
.
rpayanm → made their first commit to this issue’s fork.
Please review.
Please review.
Please review.
oh! makes sense, awesome, thank you @poker10
Weird, the same code failed using an MR.
I can confirm the issue is still present in 9.5.10
And the patch #5 worked fine.
Please review.
Please review.
Please review.
rpayanm → made their first commit to this issue’s fork.
Please review.
I added #
because we can have URL like this https://example.com?foo=1#my-string
.
And tried to fix the tests.
rpayanm → made their first commit to this issue’s fork.
rpayanm → made their first commit to this issue’s fork.
rpayanm → made their first commit to this issue’s fork.
rpayanm → made their first commit to this issue’s fork.
Sorry, I can see the all tests passed. Which tests failed?
Please review.
Please review.
Please review.
Please review.
Please review.
@smustgrave sorry, I don't see the comment, can you link it in a comment, please.