The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
over 1 year ago 9:04pm 20 April 2023 - last update
over 1 year ago 29,300 pass - Status changed to Needs work
over 1 year ago 5:09pm 23 April 2023 - 🇺🇸United States smustgrave
For the issue summary update.
Haven't done a review yet.
- Status changed to Needs review
about 1 year ago 1:12pm 21 July 2023 - 🇨🇭Switzerland mathilde_dumond
small fix in the summary about the blocks published state
- Status changed to RTBC
about 1 year ago 9:29pm 30 July 2023 - 🇺🇸United States smustgrave
Confirmed the issue on a standard install
Adding a 2nd language for the Image media bundle
Applied patch #68 and am no longer seeing the duplicates - last update
about 1 year ago 29,455 pass - 🇨🇭Switzerland Berdir Switzerland
Thanks, really hoping this will finally land :)
+++ b/core/modules/block_content/src/BlockContentTranslationHandler.php @@ -5,12 +5,28 @@ + /** + * {@inheritdoc} + */ + public function entityFormAlter(array &$form, FormStateInterface $form_state, EntityInterface $entity) { + parent::entityFormAlter($form, $form_state, $entity); + + if (isset($form['content_translation'])) { + // Block content entities do not expose the status field. Make the content + // translation status field visible instead. + // @todo This will not be necessary once this issue lands: + // https://www.drupal.org/project/drupal/issues/2834546 + $form['content_translation']['status']['#access'] = TRUE; + } + } +
As mentioned before and also in the issue summary. this part is a bit weird and an edge case between a change and a bugfix.
This is keeping the current status, which is arguably strange as the default translation has no status, but the translations then do.
We could also say it's a bugfix, there shouldn't be a translation status, but people might have unpublished translations and then they couldn't publish them anymore.
I think this is very unlikely to happen to any other contrib/custom entity type, either they have a status, and then also a UI or not.
- last update
about 1 year ago 29,457 pass - last update
about 1 year ago 29,457 pass - last update
about 1 year ago 29,458 pass - last update
about 1 year ago 29,459 pass 16:48 15:40 Running- last update
about 1 year ago 29,465 pass - last update
about 1 year ago 29,465 pass - last update
about 1 year ago 29,465 pass - last update
about 1 year ago 29,469 pass - last update
about 1 year ago 29,469 pass - last update
about 1 year ago 29,469 pass - last update
about 1 year ago 29,469 pass - Status changed to Needs review
about 1 year ago 1:44am 25 August 2023 27:08 26:39 Running- 🇳🇿New Zealand quietone New Zealand
I'm triaging RTBC issues → .
I read the IS and comments. I did not find unanswered questions. Both #15 and #22.1 question whether this should be postponed on ✨ UI for publishing/unpublishing block_content blocks Needs work . There wasn't any discussion about that. Should this be postponed? I've added this question to the remaining tasks.
I read the comments in the patch and had the following thoughts. Since this is testing against 10.1 instead of 11.x I will make a new patch for item 2 below.
-
+++ b/core/modules/block_content/src/BlockContentTranslationHandler.php @@ -5,12 +5,28 @@ + // @todo This will not be necessary once this issue lands: + // https://www.drupal.org/project/drupal/issues/2834546
It would be more helpful in the @todo gave a hint at what to do here. It is to remove that next line? But then what is the purpose of the form alter? And I guess this is not needed if the other issue is completed first, which goes back to the postponing question.
This applies to the other instances of the @todo as well.
-
+++ b/core/modules/content_translation/tests/src/Functional/ContentTranslationMetadataTrait.php @@ -0,0 +1,77 @@ + * Provides helps to assert content translation meta data fields.
A bit of incorrect grammar here I think. How about "Provides methods to assert ..."
-
- 🇳🇿New Zealand quietone New Zealand
I don't think the question about postponing and #75.1 block this from RTBC. But I really shouldn't restore RTBC because of the edit I made to a comment.
- 🇨🇭Switzerland Berdir Switzerland
> Both #15 and #22.1 question whether this should be postponed on ✨ UI for publishing/unpublishing block_content blocks Needs work . Should this be postponed? I've added this question to the remaining tasks.
:shrug:
It would simplify the patch, but we've been soft-blocked by that issue for 5 years now. It's classified as a feature, this is a bug that fixes some pretty annoying issues for multilingual sites.
Nothing changes if we get this in compared to HEAD for blocks, we just need a bit of a workaround for it, which the other issue can easily remove again. The change that happens is technically also correct, if the module for some reason doesn't want to have a status visible, why should translations? We're just doing this for BC. Thinking this through, this whole concept maybe shouldn't exist at all, it's a leftover of Drupal 7 really where modules didn't have the ability to have translatable base fields/properties. Of course, no idea how to remove it now in a way that is backwards compatible.
IMHO the hidden concern is the last paragraph of #74, whether or not there are any custom or contrib entity types with a similar case, we would have never thought of that without the current state of block_content. IMHO it's fairly unlikely. I did just create a change record to notify about the UI changes and impacts on entity types: https://www.drupal.org/node/3383265 → .
The comment change in #75 is fine, the interdiff seems a bit confused about some line changes, but I think nothing changed there.
- Status changed to RTBC
about 1 year ago 11:19pm 26 August 2023 - 🇺🇸United States smustgrave
For what it's worth I am trying to get ✨ UI for publishing/unpublishing block_content blocks Needs work into 10.2 or 10.3. But since there could be some back n forth on that one agree with @Berdir about moving this forward.
- last update
about 1 year ago 30,060 pass - last update
about 1 year ago 30,060 pass - last update
about 1 year ago 30,100 pass - last update
about 1 year ago 30,135 pass - last update
about 1 year ago 30,135 pass - Status changed to Needs work
about 1 year ago 4:17am 5 September 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 1 year ago 7:21am 6 September 2023 - last update
about 1 year ago 30,136 pass - Status changed to RTBC
about 1 year ago 7:49pm 6 September 2023 - last update
12 months ago 30,146 pass - last update
12 months ago 30,146 pass - last update
12 months ago 30,148 pass 1:49 0:40 Running- last update
12 months ago 30,161 pass - last update
12 months ago 30,164 pass - last update
12 months ago 30,168 pass - last update
12 months ago 30,168 pass - last update
12 months ago 30,205 pass - last update
12 months ago 30,363 pass - last update
12 months ago 30,361 pass - last update
11 months ago 30,360 pass - last update
11 months ago 30,362 pass - last update
11 months ago 30,379 pass - last update
11 months ago 30,377 pass - last update
11 months ago 30,382 pass - last update
11 months ago 30,388 pass, 2 fail The last submitted patch, 81: 2971390-81.patch, failed testing. View results →
33:58 32:20 Running- last update
11 months ago 30,393 pass, 2 fail The last submitted patch, 81: 2971390-81.patch, failed testing. View results →
- last update
11 months ago 30,397 pass - last update
11 months ago 30,413 pass - last update
11 months ago 30,417 pass - last update
11 months ago 30,426 pass - last update
11 months ago 30,426 pass - last update
11 months ago 30,437 pass - last update
11 months ago 30,438 pass - last update
10 months ago 30,464 pass - last update
10 months ago Patch Failed to Apply - last update
10 months ago 30,481 pass - last update
10 months ago 29,678 pass - last update
10 months ago 30,483 pass - last update
10 months ago 30,486 pass - last update
10 months ago 30,488 pass - last update
10 months ago 30,510 pass - last update
10 months ago 30,516 pass - Status changed to Needs work
10 months ago 11:45pm 10 November 2023 The Needs Review Queue Bot → tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- last update
10 months ago 30,516 pass - 🇩🇪Germany Anybody Porta Westfalica
@smustgrave what does #89 mean? Or should it mean "Find" (active)
- Merge request !7247Issue #2971390: Make exposure of translation meta fields conditional → (Open) created by Berdir
- Status changed to Needs review
5 months ago 9:08am 30 March 2024 - Status changed to Needs work
5 months ago 3:45pm 30 March 2024 - 🇺🇸United States smustgrave
Left some comments that I should of noticed before but appears to have phpcs errors also.
Thanks for picking this one back up.
- First commit to issue fork.
- Status changed to Needs review
12 days ago 1:26pm 27 August 2024