🇨🇭Switzerland @mathilde_dumond

Hey, I have added that to the MR

Reroll for 10.2

mathilde_dumond → made their first commit to this issue’s fork.

The proposed solution uses the sanitized version of the job name, but that could also lead to confusions, for example the automatic name of a job is the node name, so if the same node is translated again in the future, or in several languages through several jobs, then that solution would not work.
We propose to use together the job id, and the timestamp of the created time. Chances that two jobs with the same id are submitted at the same time to the second between 2 different websites sound reasonable enough to rely on that.

mathilde_dumond → made their first commit to this issue’s fork.

I have removed the possibility to do continuous jobs from the integration, so this way it's not offering the option if it's broken.

mathilde_dumond → made their first commit to this issue’s fork.

I added a destructor but no idea how to test it, since we ran into this issue only if we run into a fatal error earlier. I'm also wondering if adding this could mean that we can remove some of the disconnect() calls that are in the API class.

mathilde_dumond → made their first commit to this issue’s fork.

I have added that, and also a test for this change. I have run the test locally and it fails without the change, not sure how it works to test the failing tests now that we don't use patches anymore?

Pushed a fix, but tests are missing. We have a test locally that passes with that.

mathilde_dumond → created an issue.

Pushed a fix on the API that allows to pull translated content.

Thanks for the review, that's done

mathilde_dumond → made their first commit to this issue’s fork.

Hey thanks @ananya.k, there were some parenthesis problems in your patch, but I'm fixing this. This change is also breaking for drupal versions earlier than 10.1, so we're handling that so that websites with D9 do not break.
There are a few more deprecations that I am fixing in the MR (follows shortly)

mathilde_dumond → created an issue.

Forgot to update the status ):

I have opened a new MR here https://git.drupalcode.org/project/commerce_ajax_atc/-/merge_requests/4, the patch works on our website.

mathilde_dumond → created an issue.

This patch worked for us (on 10.2)

mathilde_dumond → made their first commit to this issue’s fork.

I prepared a commit, but I can't push it :sob:

Adding a patch for now until I figure this out

mathilde_dumond → created an issue.

Vrancje → credited mathilde_dumond → .

Vrancje → credited mathilde_dumond → .

Berdir → credited mathilde_dumond → .

related patch is linked

mathilde_dumond → created an issue.

I was running into the same problem, and the following patch fixed it for me.

Tested that on another of our websites and it got rid of the deprecation notice.

To reproduce: on a raw install, add a second language; create a new block; save it (redirects to the blocks overview), then translate it and save -> stays n the same page and complains that the translation already exists.

After the MR: when saving after the translation, we are redirected to the blocks overview page.

mathilde_dumond → made their first commit to this issue’s fork.

Upload of a patch with only the test, and a patch with test + fix.

mathilde_dumond → created an issue.

I decided to not remove any other selector, to be sure to not break for anyone, but following the discussion here https://www.drupal.org/project/drupal/issues/3151534#comment-15173205 🐛 "Add another item" field button is displayed as a modal action Fixed I suspect that we could remove .multiple-value-form-actions

mathilde_dumond → created an issue.

I tried my hand at a patch.

I could update from beta7 to 6.2.0 and have the correct permissions set.

mathilde_dumond → created an issue.

Patch with the update.

mathilde_dumond → created an issue.

mathilde_dumond → created an issue.

Patch fixing the issue

mathilde_dumond → created an issue.

Thanks @berdir, fixed that

with the patch

mathilde_dumond → created an issue.

fixed the group label display in the error message.

fix of a typo in the singular message

Added a patch that works for us.

mathilde_dumond → created an issue.

Patch that fixes that for us.

mathilde_dumond → created an issue. See original summary → .

mathilde_dumond → created an issue.

supporting an additional string

fixed patch

I added the other improvements from the issue https://www.drupal.org/project/opigno_learning_path/issues/3339989 🐛 Some labels aren't translatable. Active and added another that was missing.

this is a duplicate of https://www.drupal.org/project/opigno_learning_path/issues/3311371 🐛 Turn on translations of some missing strings Needs review

Forgot to change the status of the issue

Upload of a patch which displays the link only if the user has the permission to access the feature.

mathilde_dumond → created an issue.

Uploaded a patch

mathilde_dumond → created an issue.

Here is a link to the change record https://www.drupal.org/node/3376175 →

phpcs fix

small fix in the summary about the blocks published state

I updated the summary

Thanks @berdir, I addressed all your comments.

oy sorry about the patch name, the .patch is not an interdiff

I tried to rephrase the comment.

phpcs fixes.

I have been working on a test for this issue. I am uploading the test alone, and the test together with patch #65

thanks @berdir, fixed that

Added a check + log in case the module is confused and tries to fetch deleted content.

Uploading a patch that fixes the problem, I intend to extend it with test coverage.

mathilde_dumond → created an issue.

Thanks for your feedbacks :) Now with a comment explaining why we chose array_slice, and what we do in the following code

Fixed the space issue after the while

I created a related issue and uploaded a patch that runs the query in one time, but loads the entities by batches, and clears the memory regularly. It may not be enough for all situations, but already helps with memory and performance 📌 Use loadMultiple() and reset memory cache in ContentEntity source Needs work

mathilde_dumond → created an issue.

Uploading a slightly different patch.

sorry about the empty patch, here is again patch 106 with no test

version of the patch from #106 without the tests, to have a patch that applies on D9. test changes are excluded to avoid rerolls for D9

arf thanks! Here you go

He is a reroll for 1.10

mathilde_dumond → created an issue.

Patch with the paragraphs dependency updated to a D10 compatible version as well

now with composer updated for the updated client.

mathilde_dumond → created an issue. See original summary → .