- Issue created by @berdir
- First commit to issue fork.
- Merge request !6021set redirect from block edit to collection instead of self in more cases β (Open) created by mathilde_dumond
- Status changed to Needs review
11 months ago 3:34pm 4 January 2024 - π¨πSwitzerland mathilde_dumond
To reproduce: on a raw install, add a second language; create a new block; save it (redirects to the blocks overview), then translate it and save -> stays n the same page and complains that the translation already exists.
After the MR: when saving after the translation, we are redirected to the blocks overview page.
- π§πͺBelgium BramDriesen Belgium π§πͺ
Updating the IS with the steps to reproduce
- Status changed to Needs work
11 months ago 8:42pm 4 January 2024 - πΊπΈUnited States smustgrave
Could we get a failing test as a next step.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
but then that results in an exception as the translation already exists
Does anyone know if we have an existing issue about this behaviour? It feels like it would be better to display a message 'A translation already exists for the {language} language, you have been redirected to the edit form' and redirect
- π¨πSwitzerland berdir Switzerland
We should absolutely do that, that uncaught exception is horrible and easy to get to even without this bug (clicking on a already open and outdated translation overview page for example). Found π Do not fatal when trying to submit a content entity translation twice. Needs review .
- Status changed to Needs review
9 months ago 3:46am 4 March 2024 - Status changed to RTBC
9 months ago 2:42pm 4 March 2024 - πΊπΈUnited States smustgrave
Test coverage can be seen in the test-only job
1) Drupal\Tests\block_content\Functional\BlockContentCreationTest::testBlockContentFormSubmitHandlers Behat\Mink\Exception\ExpectationException: Current page is "/admin/content/block/1", but "/admin/content/block" expected. /builds/issue/drupal-3412283/core/tests/Drupal/Tests/WebAssert.php:580 /builds/issue/drupal-3412283/core/tests/Drupal/Tests/WebAssert.php:761 /builds/issue/drupal-3412283/core/modules/block_content/tests/src/Functional/BlockContentCreationTest.php:181
Verified following the steps in the issue summary and MR did solve the issue.
- Status changed to Fixed
9 months ago 9:51am 5 March 2024 - π¬π§United Kingdom catch
Committed/pushed to 11.x, cherry-picked to 10.3.x and 10.2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.