Do not fatal when trying to submit a content entity translation twice.

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

Confirmed the issue in D10 and that patch #17 addresses it.

@Gabor Hotjsy does #17 answer your comments/questions?

Ran test locally to make sure they failed and got

Behat\Mink\Exception\ExpectationException : Current response status code is 500, but 200 expected.

Triggered #17 for D10.1 tests.

All green!

Forgot to remove the tests tag as they were added in #17

The remaining tasks state that this needs a review of the proposed solution and patch. I do not see a review of the patch. There is also another proposed solution in #17 that needs to be discussed.

I took a brief view of the patch.

1. +++ b/core/modules/content_translation/src/Controller/ContentTranslationController.php
   @@ -376,7 +377,14 @@ public function add(LanguageInterface $source, LanguageInterface $target, RouteM
   +      // If the target language is lock redirect and show a helpful message.
   

   I think the grammar hear needs to be improved.

2. +++ b/core/modules/content_translation/src/Controller/ContentTranslationController.php
   @@ -376,7 +377,14 @@ public function add(LanguageInterface $source, LanguageInterface $target, RouteM
   +      $this->messenger()->addError($this->t('You are redirected to translations overview page as translation already exists.'));
   

   This doesn't read well to me.

3. +++ b/core/modules/content_translation/tests/src/Functional/ContentTranslationOperationsTest.php
   @@ -166,4 +166,19 @@ public function testContentTranslationOverviewAccess() {
   +   * Ensure that content translation add URL should throw error when we try to
   +   * access even though translation exits.
   

   This does not meet coding standards. The Summary line is to be < 80 char, among other things.

The last submitted patch, 25: 2745805-25.patch, failed testing. View results →

Addressed the comment #24 in this patch and attaching the interdiff along, made clear off php coding standard issues.

Tried to fix CCF for #27.

The last submitted patch, 28: 2745805-28.patch, failed testing. View results →