🇮🇳India @sahil.goyal

I also facing same issue in combination with content_moderation on Drupal 9.3

Updating the region width for layout specified

sahil.goyal → created an issue.

I'm getting an error and this does not configure the filter form

Drupal\Component\Plugin\Exception\PluginException: Plugin (current_state_views_filter) instance class "Drupal\views_cm_current_state\Plugin\views\filter\CurrentStateViewFilter" does not exists

I masqueraded as a different user and attempted to access the Moderation Dashboard. I noticed that it correctly directed me to the appropriate URL and displayed the correct user's information. I did not encounter any "Permission denied" errors during this process.
For example, when I masqueraded as user/2 and clicked on the Moderation Dashboard link, I was redirected to the URL /user/2/moderation-dashboard. I conducted these tests using the Moderation Dashboard version 2.1.1 in Drupal version 10.1.x-dev.
Based on my observations, it seems that the reported issue is not reproducible with the given configuration and steps.
If encounter any specific scenarios or steps that consistently lead to the "Permission denied" error, please provide additional details.

Thanks @keshavv as described #9 and #14 are now getting failed and some changes already been committed.
MR!14 is working correctly and tab history should be configurable and cookie can now and confirming its working fine and no any issue has been observed, attaching screenshots for the references.
RTBC+1

Provided #3 is working fine and no other issue observed yet. Attached before and after images for references...
RTBC+1
Thanks

I have addressed the concern in #3 and updated the patch provided by @Chinaskino.

My bad, forgot to remove commented code while working on, Here is the updated patch.

Here is the updated patch resolving the deprecated the jquery/once which replaces it and makes use of the core/once library. Moving to NR.

Creating and updating the patch, now after getting config import when we try to save/submit the config from, it saves without notifying any error, and works as expected, Moving to NeedsReview. Thanx

Hi @tatewaky, there is no need for patch, as described in #11 the issue has been observed and fixed with the version 2.2.0. As of PHP 7.4.0,
The key_exists() function has been deprecated in favour or of using the array_key_exists() function for PHP 8 and instead to ensure backward compatibility.
As in problem 2 described also addressed in version 2.2.0 as avoided the unnecessary overhead of using array_keys() just for checking existence with in_array.

Hence, In updated version functionality works as expected and no issue has been observed.

Thanx @Qusai Taha, Provided Patch #9 resolves the access check warnings in D10 & func. works as expected, Adding screenshots for references.
RTBC+1

As mention in #3 Issue already been observed and the quick fix has already been added for tag 1.0.36 and it resolved for the tagged branch, and for that no console error shown as well task can be draggable, Moving this issue to NR

Provided Patch #9 resolving the issue as google translator list eng. not shown at first shot, now after the patch in the dropdown selector show English option at first when Spanish language enabled firstly.
RTBC+1

Hi @21kPiyush Thanx for the MR, MR!8 is no doubt resolving the issue by adding the is_object condition, you ensure that the dispatch method is only called when the $event variable is indeed an object, But we can opt other approach as Symfony5/6 enforce the new syntax and needed for D10 Compatibility as well, So i created a MR !9 by updating the argument as needed and it also resolving the issue and functionally works as expected, Please Review.

Also Updating the Issue Summary for steps to reproduce.

sahil.goyal → made their first commit to this issue’s fork.

MR !2 working fine with D10 and all functionality works as expected in MR, No other issue has been observed, moving ahead to RTBC and adding Screenshot of After MR.
Also @nick.murza there is no need of #5 as it is copy of MR !2.

created patch for this

Hi @alok_singh, I reviewed the issue MR !2, It resolving the Duplicate key library definition issue, and now theme gets compatible with D10, Attaching Screenshots for reference and moving to RTBC.

Hi @alok_singh, Thanks for the MR, Looked to the MR, working as expected, Attaching the Screenshots and moving to RTBC

Hi @Eduardo Morales Alberti, thanx for the patch

I Reviewed and tested the patch. Confirmed that the following changes have been made and works as expected as:
In the valueCallback() method, returns an empty string instead of an array with empty values if no input is provided.
In the processPasswordConfirm() method, the explicit setting of for element pass1 and pass2 has been removed to depends on the value callback. Additionally, the '#maxlength' attribute is now correctly set for both fields when the attribute is specified on the PasswordConfirm element.
After thorough testing, all changes are working as expected and the functionality working fine. Moving to RTBC

Thanx @vpa24 for patch, Patch #4 is getting apply and resolves the Fatal Error and no other issue has been observed, attaching the screenshots and moving to the RTBC.

Creating a patch, this resolves the issue, patch #2 is invalid not attaching the interdiff.

working on this.

There exists one deprecated issue in the logs attaching screenshots. Updating with the MR.

Reviewing this.

looking in this

Hi @Pcate, I have been looked to the issue, as followed the mentioned steps to reproduce the issue, but when navigating to the newly created group type, not any error message get displayed. Could you please more information about the issue, Attaching screenshot shown no error message getting displayed.

Hi @rosiel, Could you please clarify the requirement for increasing the title/Name field length of media types? Because There is some confusion firstly, there is not any title field while adding the media content and secondly, i think there is no need to change the media item name field, or is there another aspect of media types that you are referring to? Please provide more information.

moving the status to Needs Review

working on it

Confirming that Provided MR resolves the Undefined array key "label" php warning while installing the Module. Move to RTBC

Hi @Juc1, I have verified again, it is not producing error for me after installation of this module, Could you please provide more info regarding thia error, so i can able to reproduce, Thanks for pointing it out..

Addressing few issues described in #5 and few more needed changes.

Fixing produced test case failure by Replacing use Drupal\Core\Database\Driver\mysql\Connection; by use Drupal\Core\Database\Connection;, attaching patch and Interdiff.

Updating the patch #16 as it failed to apply. the patch solves the issue. Updating the issue summery with proposed resolution.

Thanx @joachim for suggestion, "scheme" and "host" keys are depends on url, as scheme not added in zendesk_url would suggest warning if it is undefined, so default domain needed, and as suggested

we just bailed and did nothing if zendesk_url is empty

added condition, Removed PHPCS fix in this MR, Now created MR against correct branch.

I reviewed the code and found that the warning message was generated because the parse_url() function may not always return the "scheme" and "host" keys if they are not present in the URL string, so made changes accordingly, Along made a small PHPCS observed error/warning. Thank you.

sahil.goyal → made their first commit to this issue’s fork.

using $bundle['label'] to get the human-readable name of the bundle and capitalized the first letter of the name, as you suggested. The link text now displays the human-readable name with the first letter capitalized. Thank you.

sahil.goyal → made their first commit to this issue’s fork.

Updating the latest MR, facing some issue to fork MR so updating the patch, #17 and #22 does not seem diff so updating interdiff with 17. and made condition so trying to resolve failures.

sahil.goyal → made their first commit to this issue’s fork.

sorry, whitespace need to be fixed.

Update the patch to resolve error in #22 there is some assertion fail error thrown as some gin theme added so i have reverted it back.

Typo in token name got fixes in #2 MR, Looks good to me, Moving to RTBC

Readme file looks good, following readme template document. Applies cleanly, Moving to RTBC.

sahil.goyal → made their first commit to this issue’s fork.

As Reviewed already, no error left, MR also looks great, Moving to RTBC then.

sahil.goyal → made their first commit to this issue’s fork.

There are still some warnings shown below left, so still in NW state

FILE: /Users/sahil.goyal/Documents/MySites/101/drupal/modules/contrib/search_api_solr/search_api_solr.install
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------
 655 | WARNING | There must be no blank line following an inline comment
 741 | WARNING | There must be no blank line following an inline comment
-------------------------------------------------------------------------------------------------------------


FILE: ...MySites/101/drupal/modules/contrib/search_api_solr/tests/modules/search_api_solr_test/search_api_solr_test.module
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 10 | WARNING | Unused variable $_search_api_solr_test_index_fallback_test.
-----------------------------------------------------------------------------------------------------------------------


FILE: ...tes/101/drupal/modules/contrib/search_api_solr/modules/search_api_solr_legacy/tests/src/Kernel/SolrLegacyTest.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 109 | WARNING | Unused variable $backend.
-----------------------------------------------------------------------------------------------------------------------


FILE: ...rupal/modules/contrib/search_api_solr/src/Plugin/Field/FieldFormatter/SearchApiSolrHighlightedStringFormatter.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------------------------------------
 35 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
 37 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------


FILE: ...s/sahil.goyal/Documents/MySites/101/drupal/modules/contrib/search_api_solr/src/Commands/SearchApiSolrCommands.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------
 197 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-----------------------------------------------------------------------------------------------------------------------


FILE: ...hil.goyal/Documents/MySites/101/drupal/modules/contrib/search_api_solr/src/Utility/StreamingExpressionBuilder.php
-----------------------------------------------------------------------------------------------------------------------
FOUND 27 ERRORS AFFECTING 27 LINES
-----------------------------------------------------------------------------------------------------------------------
 224 | ERROR | Public method name "StreamingExpressionBuilder::_collection" is not in lowerCamel format
 234 | ERROR | Public method name "StreamingExpressionBuilder::_checkpoints_collection" is not in lowerCamel format
 251 | ERROR | Public method name "StreamingExpressionBuilder::_field" is not in lowerCamel format
 275 | ERROR | Public method name "StreamingExpressionBuilder::_field_list" is not in lowerCamel format
 300 | ERROR | Public method name "StreamingExpressionBuilder::_all_fields_list" is not in lowerCamel format
 329 | ERROR | Public method name "StreamingExpressionBuilder::_all_doc_value_fields_list" is not in lowerCamel format
 360 | ERROR | Public method name "StreamingExpressionBuilder::_escaped_value" is not in lowerCamel format
 395 | ERROR | Public method name "StreamingExpressionBuilder::_field_value" is not in lowerCamel format
 415 | ERROR | Public method name "StreamingExpressionBuilder::_field_escaped_value" is not in lowerCamel format
 438 | ERROR | Public method name "StreamingExpressionBuilder::_escape_and_implode" is not in lowerCamel format
 459 | ERROR | Public method name "StreamingExpressionBuilder::_select_renamed_field" is not in lowerCamel format
 476 | ERROR | Public method name "StreamingExpressionBuilder::_select_copied_field" is not in lowerCamel format
 509 | ERROR | Public method name "StreamingExpressionBuilder::_intersect" is not in lowerCamel format
 540 | ERROR | Public method name "StreamingExpressionBuilder::_merge" is not in lowerCamel format
 565 | ERROR | Public method name "StreamingExpressionBuilder::_export_all" is not in lowerCamel format
 590 | ERROR | Public method name "StreamingExpressionBuilder::_search_all" is not in lowerCamel format
 612 | ERROR | Public method name "StreamingExpressionBuilder::_update" is not in lowerCamel format
 637 | ERROR | Public method name "StreamingExpressionBuilder::_commit" is not in lowerCamel format
 665 | ERROR | Public method name "StreamingExpressionBuilder::_commit_update" is not in lowerCamel format
 678 | ERROR | Public method name "StreamingExpressionBuilder::_index_filter_query" is not in lowerCamel format
 688 | ERROR | Public method name "StreamingExpressionBuilder::_index_id" is not in lowerCamel format
 700 | ERROR | Public method name "StreamingExpressionBuilder::_site_hash" is not in lowerCamel format
 710 | ERROR | Public method name "StreamingExpressionBuilder::_request_time" is not in lowerCamel format
 720 | ERROR | Public method name "StreamingExpressionBuilder::_timestamp_value" is not in lowerCamel format
 730 | ERROR | Public method name "StreamingExpressionBuilder::_topic" is not in lowerCamel format
 745 | ERROR | Public method name "StreamingExpressionBuilder::_topic_all" is not in lowerCamel format
 767 | ERROR | Public method name "StreamingExpressionBuilder::_checkpoint" is not in lowerCamel format
-----------------------------------------------------------------------------------------------------------------------

Made change to the comment as per #30 so the comment is now quite relevant what it supposed to do.

Updated the plugin to use dependency injection for the entity-type manager instead of the global singleton \Drupal\user\Entity\User::load(). Instantiate the plugin with the entity-type manager, and modified the execute() method to load the user entity using the injected entity-type manager.

sahil.goyal → made their first commit to this issue’s fork.

Moving to Needs Review.

sahil.goyal → made their first commit to this issue’s fork.

Thanx @jedihe for the patch, changes looks alright, and functionality works as expected by applying #7 on Drupal 10.1.x. Moving to RTBC, Please revert back if needed.

Hi! Thank you for providing more information and updating the recordings to help explain the issue. From what you've described, it sounds like the problem occurs when we toggle the navigation but what i found is when the page's body element changes size or when the user scrolls out of the body element's scope, looks like navigation bar does not able to target body element correctly.
I'm updating recording of the after and before patch os it makes the issue to understand what i'm referring to.

i'm confirming that #8 is the correct patch to address the issue. The patch targets the body element correctly in the navigation, which should ensure that the toggle button works correctly regardless of any changes to the body element's size or scrolling.

Let me know if you have any other questions or concerns!
RTBC +1

updating a quick fix for the #299 CCF.

for the comment 4 we are not losing any test coverage only expected URL is sufficient to fix the failing test so, The = sign was removed because it caused the assertion to fail, but it did not affect the functionality being tested. other points mentioned in #20 has been addressed earlier.

switch back

Updating the issue summary

Update the #23 try to resolve the assertion failure.

Try to fix failure and CCF came up.

Updated the patch and addressed #4 also fix all left PHP coding standard issues and warnings. don't know how to test it with 2.1.x branch.

update patch for the corresponding version D10.1 there. sorry i couldn't able to create interdiff due to some system issue i guess.

Fixing the CCF errors arises above #32

addressed the comment #31 as removing try/catch can ensure that any errors or exceptions that occur during the call, properly reported as test failures, as they should be.

addressed #14 as per Updating the issue summery.

#38 does not get applied to 10.1x so i made it compatible so now it can applies cleany. creating interdiff giving some error so i couldn’t able to update it here!

In my case patch is applying cleanly. will look more regard the issue of being failed to apply

sahil.goyal → made their first commit to this issue’s fork.

fixing the Failure in #118 as it does not apply on D 10.1.x as some changes are not looks correct as per rerolled from #110 so attaching reroll to making it compatible with 10.1x.

Color contrast is changed and updated after applying MR on 9.5x but it not getting applied to the D10.0.x it still shows old color contrast as color: #828388. i think it needs to be updated..

Addressed the comment #15 However missing class namespace is not relevant in this case, as the namespace is already present in the code.

attached patch again instead of interdiff

address CCF errors on #10

Hard to get the diff without interdiff ☹️

Fixing a minor CCF error to make #29 pass the test.

Thanx @Manoj Raj.R for formatting the readme file, but it is not target the actual issue mentioned to i made a Commit on Same MR to update the example code, and the #3 not looks correct as we have following different parameters as described.

sahil.goyal → made their first commit to this issue’s fork.

Fixing CFF empty space error. addressed the #23

Addressed the CCF error as described in #86.

sahil.goyal → made their first commit to this issue’s fork.