- 🇬🇧United Kingdom juc1
I have applied the automated patch.
When using the Olivero theme everything seems fine.
When using another D10 theme such as Bartik or my subtheme with Olivero as base theme the UI configurator in /admin/structure/block seems fine but the block (even block title) / pager--block.html.twig is not rendered at all ie looking at the browser inspector the corresponding html is empty. - 🇬🇧United Kingdom juc1
Here is the result of https://github.com/mglaman/drupal-check
$ /vendor/bin/drupal-check pager r 3/3 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100% ------ ------------------------------------------------------------------------------------- Line src/Plugin/Block/PagerBlock.php ------ ------------------------------------------------------------------------------------- 69 PHPDoc tag @param for parameter $container with type Drupal\pager\Plugin\Block\Symfony\Component\DependencyInjection\ContainerInterface is not subtype of native type Symfony\Component\DependencyInjection\ContainerInterface. 69 Parameter $container of method Drupal\pager\Plugin\Block\PagerBlock::create() has invalid type Drupal\pager\Plugin\Block\Symfony\Component\DependencyInjection\ContainerInterface. 210 Cannot access property $class on object|true. 211 Cannot access property $class on object|true. 214 Cannot access property $class on object|true. 214 Cannot access property $class on object|true. ------ ------------------------------------------------------------------------------------- [ERROR] Found 6 errors Thanks for using drupal-check!
- 🇮🇳India sahil.goyal
Addressing few issues described in #5 and few more needed changes.
- 🇬🇧United Kingdom juc1
@sahil thanks for your patch
at /admin/structure/block I get php error =
ArgumentCountError: Too few arguments to function Drupal\pager\Plugin\Block\PagerBlock::__construct(), 7 passed in /public_html/web/modules/non-comp/pager/src/Plugin/Block/PagerBlock.php on line 87 and exactly 8 expected in Drupal\pager\Plugin\Block\PagerBlock->__construct() (line 58 of /public_html/web/modules/non-comp/pager/src/Plugin/Block/PagerBlock.php).
- 🇮🇳India sahil.goyal
Hi @Juc1, I have verified again, it is not producing error for me after installation of this module, Could you please provide more info regarding thia error, so i can able to reproduce, Thanks for pointing it out..
- 🇬🇧United Kingdom juc1
Hi sahil I tried again with a new / clean D10.1 site and default Olivero theme - same issue.
my patched PagerBlock.php = https://pastebin.com/ewuB4jHK
generated a few nodes with devel
enabled pager module
go to /admin/structure/blockPlace Block / Pager Block
/admin/reports/dblog/ =
Type php Date Friday, May 5, 2023 - 12:34 User admin Location example.com/admin/structure/block/add/pager/olivero?_wrapper_format=drupal_modal®ion=content_above Referrer example.com/admin/structure/block Message ArgumentCountError: Too few arguments to function Drupal\pager\Plugin\Block\PagerBlock::__construct(), 7 passed in /home/819629.cloudwaysapps.com/vdrkgajfpf/public_html/web/modules/patched/pager/src/Plugin/Block/PagerBlock.php on line 87 and exactly 8 expected in Drupal\pager\Plugin\Block\PagerBlock->__construct() (line 58 of /home/819629.cloudwaysapps.com/vdrkgajfpf/public_html/web/modules/patched/pager/src/Plugin/Block/PagerBlock.php). Severity Error
If you need more info please tell me what you need.
Thanks...
- Status changed to Fixed
2 months ago 11:01pm 13 October 2024