Coding Standard Issues | PHPCS

Fixed The Failed Patch .

Reviewed patch #3 there still one coding standard issue.
Attaching screenshot for reference.

added updated patch and fixed remaining issue

sahil.goyal → made their first commit to this issue’s fork.

Thanks @Akram Khan for the updated patch, patch looks good, applies cleanly, and fixing all the php coding standard issues and warnings, attaching the Screenshot and Created MR for easy Merging.

Fixing Some Error

I have applied this "fixing_coding_standard-3331514-10.patch" cleanly, but some of the errors are still there.
Please check the Screenshots for the same.

Hi @sahil.goyal,

I applied MR!3, it was applied smoothly and fixed most of the phpcs issues.

However, I still encountered an issue after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.

➜  twig_field_value git:(8.x-1.x) curl https://git.drupalcode.org/project/twig_field_value/-/merge_requests/3.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 62382    0 62382    0     0   132k      0 --:--:-- --:--:-- --:--:--  132k
patching file README.txt
patching file src/Twig/Extension/FieldValueExtension.php
patching file tests/modules/twig_field_value_test/src/Plugin/Field/FieldFormatter/EntityReferencesHiddenFieldFormatter.php
patching file tests/modules/twig_field_value_test/src/Plugin/Field/FieldFormatter/EntityReferencesHiddenThirdChildFormatter.php
patching file tests/modules/twig_field_value_test/src/Plugin/Field/FieldFormatter/StringHiddenFieldFormatter.php
patching file tests/modules/twig_field_value_test/src/Plugin/Field/FieldFormatter/StringHiddenThirdChildFormatter.php
patching file tests/modules/twig_field_value_test/twig_field_value_test.info.yml
patching file tests/src/Kernel/FieldRawTest.php
patching file tests/src/Kernel/FieldTargetEntityTest.php
patching file tests/src/Kernel/FieldValueTest.php
patching file tests/src/Unit/FieldValue/FieldRawValueTest.php
patching file tests/src/Unit/FieldValue/FieldTargetEntityTest.php
patching file tests/src/Unit/FieldValue/FieldValueTest.php
patching file twig_field_value.info.yml
patching file twig_field_value.services.yml
➜  twig_field_value git:(8.x-1.x) ✗ ..
➜  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml twig_field_value

FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/twig_field_value/src/Twig/Extension/FieldValueExtension.php
----------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------------------
 8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Access\AccessResultInterface.
----------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------------------

Time: 788ms; Memory: 12MB

➜  contrib

Thank you.

Hi,

I fixed the issue that I encountered. Please review.

Thank you.

The mentioned phpcs issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.

Automatically closed - issue fixed for 2 weeks with no activity.