Tested MR:7341 works fine on 11.x
Attaching screenshots for reference.
rajneeshb → made their first commit to this issue’s fork.
rajneeshb → made their first commit to this issue’s fork.
rajneeshb → made their first commit to this issue’s fork.
This issue due to ignore destination not set. The set ignore destination code written at RedirectForm method which not exceuted when $form_state->getResponse() is set. So to fix this issue added code to set ignore destination at doSubmitForm function.
rajneeshb → made their first commit to this issue’s fork.
Added an additional check to only execute the CSRF validation if the current user is authenticated.
rajneeshb → made their first commit to this issue’s fork.
rajneeshb → made their first commit to this issue’s fork.
rajneeshb → created an issue.
Checked the webform tokens working fine (e.g. [webform_submission:values:user:entity:mail:clear]) but global tokens not working e.g [current-user:mail], [current-user:account-name] etc. This issue comes because during display the value of element data coming from token not form DB so if we used user token in computed token field then the data will display as per logged in user .
I have created a patch to fix this issue. This patch will work only if the element have Store value in the database enabled.
I've checked with socialblue 2.5.x and Drupal 9.5.10 can reproduce it. color_get_palette function belongs to color module so if color module not enabled then this issue is reproducible. I have created a patch to fix the issue.
There is issue at preprocess.inc at material_admin_preprocess_menu_local_task function. I have created a patch to fix the reported issue.
Tested patch #9 working fine.
Attaching recording for reference.
After applying patch #4 export xls without batch working fine but breaks with batch operation. Created patch to fix the export (XLS, CSV, PDF) with and without batch operation.
rajneeshb → made their first commit to this issue’s fork.
Created patch to fix the issue.
Created a patch to set password if the password set by the user at registration form.
Reviewed #5 patch looks good, +1 for RTBC
Attaching Screenshot for reference
Reviewed MR !1 looks good, +1 for RTBC
Attaching screenshots for reference
Reviewed patch #2 all phpcs issue fixed after applying patch, looks good +1 for RTBC
Attaching screenshots for reference.
Reviewed patch #2, patch applied cleanly and resolved the reported issue looks good to me. +1 for RTBC
Reviewed MR 62 looks good. +1 for RTBC
Adding patch to fix the remaining coding standard issues.
Reviewed patch #2, patch applied cleanly. After applying patch there is still one coding standard issue
/modules/contrib/tax_number/src/Plugin/Field/FieldWidget/TaxNumberWidget.php
---------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
110 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------------
by using this command
phpcs --standard="Drupal,DrupalPractice" --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml .
Reviewd MR 19 looks good. +1 for RTBC, Attaching screenshots for reference.
Patch #5 applied but there are still coding standard issues
FILE: /modules/contrib/better_exposed_filters/tests/src/FunctionalJavascript/BetterExposedFiltersTest.php
--------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------------------------------------------------------------------------
79 | WARNING | Unused variable $display.
135 | WARNING | Unused variable $display.
136 | WARNING | Unused variable $block.
192 | WARNING | Unused variable $display.
--------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/tests/src/Kernel/Plugin/sort/LinksSortWidgetKernelTest.php
-------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $display.
-------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/tests/src/Kernel/Plugin/sort/RadioButtonsSortWidgetKernelTest.php
--------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $display.
--------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/tests/src/Kernel/Plugin/filter/SingleFilterWidgetKernelTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $display.
------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/tests/src/Kernel/Plugin/filter/FilterWidgetKernelTest.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------
81 | WARNING | Unused variable $display.
125 | WARNING | Unused variable $display.
------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/tests/src/Kernel/Plugin/filter/HiddenFilterWidgetKernelTest.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------------
27 | WARNING | Unused variable $display.
------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/tests/src/Kernel/BetterExposedFiltersKernelTest.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
26 | WARNING | Unused variable $display.
51 | WARNING | Unused variable $display.
------------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/includes/better_exposed_filters.theme.inc
--------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
162 | WARNING | '@todo' should match the format '@todo Fix problem X here.'
--------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/README.md
------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------
42 | WARNING | Line exceeds 80 characters; contains 94 characters
------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/better_exposed_filters.install
---------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------
223 | WARNING | Line exceeds 80 characters; contains 84 characters
227 | WARNING | Line exceeds 80 characters; contains 83 characters
---------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/src/Plugin/better_exposed_filters/filter/DatePickers.php
-----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------------
41 | WARNING | Unused variable $element.
-----------------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/src/Plugin/better_exposed_filters/filter/FilterWidgetBase.php
----------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------------------------------------------------------------------------------------
116 | WARNING | Only string literals should be passed to t() where possible
185 | WARNING | Only string literals should be passed to t() where possible
251 | WARNING | Line exceeds 80 characters; contains 104 characters
260 | WARNING | Line exceeds 80 characters; contains 84 characters
----------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/src/Plugin/BetterExposedFiltersWidgetBase.php
------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------
159 | WARNING | Unused bound variable $form.
159 | WARNING | Unused bound variable $element.
------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/src/Plugin/views/exposed_form/BetterExposedFilters.php
---------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------
924 | ERROR | The array declaration extends to column 94 (the limit is 80). The array content should be split up over multiple lines
925 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/better_exposed_filters/src/BetterExposedFiltersHelper.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------
80 | WARNING | Unused variable $value.
80 | WARNING | Unused variable $value.
83 | WARNING | Unused variable $value.
-------------------------------------------------------------------------------------------------------------------------
Reviewed patch #2 reported coding standard issue fixed. Attaching SS for reference.
Reviewed MR!16 looks good, all reported issue fixed, +1 RTBC
Attaching SS for reference.
Reviewed patch #2 LGTM, all reported issue fixed. +1RTBC
Attaching SS for reference.
Reviewed !12 MR all reported issue fixed. LGTM, +1RTBC
Attaching SS for Reference
Reviewed patch #3 there still one coding standard issue.
Attaching screenshot for reference.
Reviewed MR !3 , Reported coding standard fixed. Attaching screenshot for reference
Reviewed MR !2, attaching screenshots for reference, Looks good to me
Reviewed merge request !3636 working fine, attaching screenshot for the refernce.
Reviewed MR 2, Looks good, +1RTBC
Attaching screenshots for the reference.
Reviewed MR 3. Looks good, +1 RTBC
Reviewed #7 There is still coding standard issue . Attaching SS for the refrence
Reviewed #5 All coding standard issues fixed. Looks good, +1RTBC
Attaching screenshots for the same.
Reviewed merge request 6. All coding standard issues fixed. Looks good tom me + 1 RTBC
Reviewed merge request !6. These issue still there
FILE: /Users/tesboss/_PROJECTS/drupal/sharethis/src/Form/SharethisConfigurationForm.php
----------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
117 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------
FILE: /Users/tesboss/_PROJECTS/drupal/sharethis/src/SharethisManager.php
------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------
80 | WARNING | NodeType::loadMultiple calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------Reviewed patch #3 patch applied successfully and all reported coding standard issue fixed. Looks good +1 RTBC
Reviewed MR!6 coding standard issues fixed.
Attaching screenshots for the same.
Reviewed patch #6, Patch applied successfully on 10.1.x and has fixes as per proposed solution.
Reviewed #43 patch applied successfully and working fine.
Attaching screenshot for reference.
Reviewed MR!2 looks good to me +1 for RTBC
Reviewed MR!3511 Looks good. Attaching screenshots for the same.
Reviewed MR !2 there are still some coding standard issues
FILE: /ephoto_dam/modules/ephoto_dam_field/src/Plugin/Field/FieldType/EphotoDamField.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
39 | WARNING | Possible useless method overriding detected
-----------------------------------------------------------------------------------------------------------------------------
FILE: /ephoto_dam/modules/ephoto_dam_field/src/Plugin/Field/FieldFormatter/EphotoDamFieldFormatter.php
-------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------
42 | WARNING | Possible useless method overriding detected
-------------------------------------------------------------------------------------------------------------------------------------------
FILE: /ephoto_dam/src/Plugin/Filter/EphotoDam.php
--------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------
50 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------------
Reviewed MR !15 all coding standard issues fixed. Also the readme.md file warning also fixed.
Devel sf-dump class having z-index 99999, so to fix the issue for toolbar menu added z-index to 100000.