- Issue created by @davidburns
- 🇺🇸United States davidburns Philadelphia
Fixed a couple of other PHPCS things that popped up after applying that patch.
Here's the updated version that has everything passing. - Status changed to Needs work
over 1 year ago 8:46am 4 March 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, report which command has been used, which arguments have been used, and which report that command shown.
(The patches fail to apply too.)
- First commit to issue fork.
- Assigned to hardikpandya
- @hardikpandya opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 4:27am 13 March 2023 - 🇮🇳India rajneeshb New Delhi
Reviewed MR 2, Looks good, +1RTBC
Attaching screenshots for the reference.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
This will need a re-roll because of 📌 Use constructor property promotion Fixed . Please use constructor property promotion for the new properties.
- Assigned to nikhil_110
- Status changed to Needs work
over 1 year ago 7:51am 4 May 2023 - Issue was unassigned.
- Assigned to priyanka_chauhan31
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 11:18am 8 May 2023 - last update
over 1 year ago 1 pass - 🇮🇳India priyanka_chauhan31 Noida
Hi, I tried to solve the issue. Here is the patch attached for the same.
- last update
over 1 year ago 1 pass - Status changed to Needs work
over 1 year ago 2:15pm 8 May 2023 - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
On PHP 8.2, I expect there will be deprecation notices because of the use of dynamic properties.
$this->destination
and$this->renderer
need to be declared. This can be done like it is for$entityTypeManager
by adding a keyword likeprotected
in the constructor. - Status changed to Needs review
over 1 year ago 11:34am 9 May 2023 - last update
over 1 year ago 1 pass - 🇮🇳India priyanka_chauhan31 Noida
Hi, I have added protected keyword in constructor as said. Please review my new patch.
- last update
over 1 year ago Composer require failure - 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Thanks @priyanka_chauhan31. After adding
protected
, you don't need to assign the values; that happens automatically. Please test the merge request. - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago Composer require failure - last update
over 1 year ago Composer require failure - last update
over 1 year ago Composer require failure - last update
over 1 year ago Composer require failure - last update
over 1 year ago Composer require failure - last update
over 1 year ago Composer require failure - last update
over 1 year ago Composer require failure - last update
over 1 year ago 1 pass - last update
over 1 year ago Composer require failure - last update
over 1 year ago PHPLint Failed - last update
over 1 year ago PHPLint Failed - last update
over 1 year ago PHPLint Failed - last update
over 1 year ago PHPLint Failed - last update
over 1 year ago PHPLint Failed - last update
over 1 year ago PHPLint Failed - last update
over 1 year ago Composer require failure - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago 1 pass - last update
over 1 year ago Composer require failure -
Liam Morland →
committed 488f7ff9 on 1.0.x
Issue #3345859: Remove unnecessary injection of string_translation...
-
Liam Morland →
committed 488f7ff9 on 1.0.x
-
Liam Morland →
committed 5aae61ab on 1.0.x
Issue #3345859 by davidburns, hardikpandya, priyanka_chauhan31: Use...
-
Liam Morland →
committed 5aae61ab on 1.0.x
- Status changed to Fixed
over 1 year ago 9:15pm 27 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.