🇮🇳India @nikhil_110

Account created on 18 December 2014, about 10 years ago
#

Recent comments

🇮🇳India nikhil_110

I also faced the same problem so I added if (!str_starts_with($filepath, $dir) && !empty($filepath)) {
in locale_js_translate function in local.module file at line number 528.

check !empty($filepath) value

After added this, it work again.

🇮🇳India nikhil_110

I am confused about whom to provide the steps to, as the steps have already been provided, and now that I have added the STR tag according to point #17 🐛 Views incorrect display with filters, table and full pager Active , the process of conversion is confusing because the two Drupal profiles involved are different, and I am unsure how to proceed with the conversion due to these differences, so I would appreciate it if you could provide the correct details and further clarification on how to handle this situation appropriately.

🇮🇳India nikhil_110

Yes, I also checked this issue. It's a duplicate of 📌 Parent menu items with URLs are not linked to, do we make these available? Closed: outdated I think we should close this issue.

🇮🇳India nikhil_110

It's a great idea to implement a global helper function to simplify this common operation. If @cilefen and @steven.snedker agree with this approach, I can prepare a patch for the helper function. Let me know your thoughts!
Thanks

🇮🇳India nikhil_110

Attached patch against Drupal 11.x-dev.. also added inter diff file #22 🐛 Media Library field widget not enforcing image limits Active MR in file_validate_image_resolution is deprecated so don't work i have change and added new.

🇮🇳India nikhil_110

All the test cases passed and it is working fine. But I have a suggestion for changing the code. We can pass "$class::$method" to class_and_method in changePriority function itself instead of changing it in different places in the code, so that it is not necessary to change it in multiple functions.

protected static function changePriority(ContainerBuilder $container, string $hook, string $class, string $method, bool $should_be_larger, ?array $others = NULL): void {
    $class_and_method = "$class::$method";
   ... 
}
🇮🇳India nikhil_110

Test Steps for Setting Up Drupal 11.x-dev

  1. Setup Drupal 11.x-dev.
  2. Apply the Merge Request (MR).
  3. Navigate to:
    • Administration > Structure > Block layout
  4. Place a Block:
    • Click the "Place block" button in the desired region.
    • Choose a block from the "Clear cache" section.
  5. Check the Home Page:
    • Verify that the "Clear cache" block is displayed correctly.

Suggestion
I reviewed the code changes made in PerformanceController.php and ClearCacheForm.php, specifically regarding the removal of the wrapper for the "Clear Cache" block. I believe this is not an appropriate modification to the core functionality.
To test this, I completely removed the code from PerformanceController and ClearCacheForm, and observed that the "Clear Cache" block reverted to its default state.
I suggest that the necessary adjustments should be implemented within the plugin file itself, as a new block is created for the dashboard. This approach would be more suitable.
I have attached a screenshot of the removed code for your review. Please take a look.

🇮🇳India nikhil_110

I reproduced this issue on my local and added MR or checked it, but when I add a node, only when I edit the node from admin, the lock status changes, but when I edit the node from another user. the locked status of the node does not change and is also not shown to other users.

🇮🇳India nikhil_110

Tried to reproduce the issue on local, but not get any issue in Views Load More 2.0.0-alpha1 also.
attached a video's
Setup Drupal with Views Load More 2.0.0-alpha1
Created a view with pages and blocks and used load more in pager with setting 1 record per page

🇮🇳India nikhil_110

#2 Patch applied, changes working as expected. I checked it in 4 steps which are as follows.

  1. The text field value will be filled and the check box will also be checked.
  2. The text field value will be empty and the check box will be checked.
  3. The text field value will be filled and the check box will be unchecked.
  4. Both fields will be empty and checked

All test scenarios are working fine, I have also added screenshots, please check.

🇮🇳India nikhil_110

Tested patch #12 🐛 Conditional logic too wide when using Claro theme Needs review this patch fixes the issues reported at #10 🐛 Conditional logic too wide when using Claro theme Needs review , #11 🐛 Conditional logic too wide when using Claro theme Needs review . It's working fine.

Before Patch - Element is taking more width if it has long title and buttons were not set in the right place in conditional logic.
After Patch - Element is not taking much width due to long title and buttons are set at right place in conditional logic also for Claro theme.

🇮🇳India nikhil_110

I have applied the MR , it is working fine and now there is no issue in adding new another state. I have attached the screenshot/video for reference.

Step's :
1. Setup Drupal with webform v6.2.0-beta6
2. Enabled webform module.
3. Go to Administration > Structure > Webform > Add webform.
4. Add element
5. Choose any element like Checkbox and Save
6. Edit element and Go to conditions tab and remove the default empty state and again Ccick on sdd another state then showing error in browser console.
7. Apply MR and clear cache, it will working fine

🇮🇳India nikhil_110

Patch added against #27 Point 1. and still Pending 2 point so need work.

🇮🇳India nikhil_110

Attached patch against Comment #4
I've also checked that the variable is Isset with empty so that the condition works properly.

🇮🇳India nikhil_110

Attached patch against Comment #10, #11, #12

  1. Setup Drupal with Login Destination V8.x-2.0-beta1
  2. Enabled Login Destination module
  3. Go to Administration > Configuration > People > Login destinations > Add Login Destination
  4. And set Redirect upon triggers is Logout and Redirect destination Path is
  5. Apply this patch.
  6. Clear cache.
🇮🇳India nikhil_110

I applied the patch #9 it's working fine and login user are not showing in masquerade user list.I have attaching the screenshot for the reference.

Test Step:

  • 1. Setup Drupal with Masquerade V8.x-2.x-dev
  • 2. Enabled Masquerade module
  • 3. Go to Administration > Structure > Block layout > Place block in the content region > Select masquerade and save it.
  • 4. After go to Administration > People > Roles > Add New role
  • 5. After i created two user and both are same role assign.
  • 6. (view) login via user and go to Masquerade form and enter username. login user are not showing in masquerade user list. I have added screenshot for reference
🇮🇳India nikhil_110

I attempted to replicate the issue on my local machine using Drupal 9.5.9-dev along with Entity Auto Term V3.0.0. However, I was unable to reproduce the issue. I have attaching the screenshot for the reference.

Test Step

  • Setup Drupal with Masquerade Entity Auto Term V3.0.0
  • Enabled Entity Auto Term module
  • Go to Administration > Configuration > System > Entity Auto Term > Click on node tab
  • After clicking on the tab, I see the settings in the new content type, for which I have added in the screenshot.
🇮🇳India nikhil_110

I have add patch for log data export and also address Comment #3. please review

🇮🇳India nikhil_110

I have updated the patch with latest update suggested by @smustgrave, I would appreciate if someone can review these updates and provide feedback

🇮🇳India nikhil_110

I have updated the patch with latest update suggested by user @apaderno and user @smustgrave, I would appreciate if someone can review these updates and provide feedback

🇮🇳India nikhil_110

I applied the above MR on my local machine using Drupal 10.1.0-dev with FAQ Field v8.x-7.1. It is working properly
I have added the test steps and Attaching the screenshot for reference.Please review.

Test Step

🇮🇳India nikhil_110

I have add patch for log data export.. please review

🇮🇳India nikhil_110

Attached patch against Drupal 10.1.x and address #15
Still Pending issue summary update So NW on that.

🇮🇳India nikhil_110

I applied the patch on my local machine using Drupal 9.5 with login history v2.x-dev. It is not working properly..when user is logout he does not see the data in logout field. Because when user logout session is destroyed and session id is different.

$current_time = \Drupal::time()->getRequestTime();
  <strong>// Get current session ID and hash it.
  $sid = Crypt::hashBase64(\Drupal::service('session')->getId());</strong>
  \Drupal::database()->update('login_history')
    ->fields([
      'logout' => $current_time,
    ])
    ->condition('sid', $sid, '=')
    ->execute();

So this code is not working properly.
I have added the test steps and Attaching the screenshot for reference.Please review.

Test Step -

  • Setup Drupal with login history v2.x-dev
  • Enabled login history module
  • Apply patch #17 - https://www.drupal.org/project/login_history/issues/3269753#comment-1490... Add logout history Needs review
  • Run update.php and clear the cache
  • Go to Admin > Reports > Login history
🇮🇳India nikhil_110

I implemented patch on my local machine using Drupal 9.5 with Select (or other) v4.x-dev. It is working properly..
I have added the test steps and Attaching the screenshot for reference.Please review.

  • Setup Drupal with Select (or other) v4.x-dev
  • Enabled Select (or other)
  • Go to Admin > Structure > Content Types > Basic Page > Add New field List (text).
  • Go to Admin > Structure > Content Types > Basic Page > Manage form display > Go to List field and Chose Select or Other select list .
  • Go to Admin > Add content > Create new node by selecting Color name and with other options
🇮🇳India nikhil_110

I implemented MR on my local machine using Menu Block Module V8.x-1.x-dev with Drupal 10.0.3. It is working properly..I have added the test steps and am attaching the screenshot for reference. Please review.

  • Setup Drupal with Menu Block v8.x-1.x-dev
  • Enabled Menu Block and Go to Administration > Administration > Structure > Menus > Create menu.
  • Go to Administration > Administration > Structure > Block layout > Click the "Place block" button in the desired regionand Choose a block from the "Menus" category. In the form that appears, configure the Advanced options and Use as title configured as "Active trail's root title" and Initial visibility level configured as 3
  • Go to Wheat and Barley page title is showing Grains.
Production build 0.71.5 2024