Setting Use as title to "Active trail's root title" should respect Initial visibility level

I implemented MR on my local machine using Menu Block Module V8.x-1.x-dev with Drupal 10.0.3. It is working properly..I have added the test steps and am attaching the screenshot for reference. Please review.

• Setup Drupal with Menu Block v8.x-1.x-dev
• Enabled Menu Block and Go to Administration > Administration > Structure > Menus > Create menu.
• Go to Administration > Administration > Structure > Block layout > Click the "Place block" button in the desired regionand Choose a block from the "Menus" category. In the form that appears, configure the Advanced options and Use as title configured as "Active trail's root title" and Initial visibility level configured as 3
• Go to Wheat and Barley page title is showing Grains.

RTBC++ I applied MR diff to version 1.10 and can confirm that this change does indeed fix the issue.

For purposes of calculating the Root title, the root should always be derived from the "initial visibility level" of the menu block, instead of using level 1, which may be too far up the tree to be practical.

The only thing I noticed is a minor grammar issue with the docblock in the MR, which I have updated but will leave as RTBC because it is a non-functional change.

The branch is out of date. I did a quick rebase locally and generated a patch (sorry for not updating the branch). I removed $this->tree = $tree; since it did not appear to be used anywhere.

This patch is working for me locally. Moving this back to Needs Review for others to review.

Assuming:

Home > Conditions & Treatments > Childhood Cancer Overview > Tests & Procedures To Diagnose Cancer > Blood Tests For Children & Young People With Cancer

Before patch:

After patch:

Menu block settings:

Initial visibility level:
3

Use as title:
Active trail's root title

So confirming here that this is exactly what we were after!

Thank you for the patch!

We gave this a try today, and it does indeed fix the issue. Since this was on my list to review for a while, I’m going to go ahead and commit it. Hopefully, there are no side effects.

Thanks, everyone, for your work on this and for your patience!

Actually, I’m sorry, but I’m going to revert this. It does what it says, but I’d rather not change it if someone already has it working. Also, the label “root” messes with my head a bit—it doesn’t clearly indicate that it moves around depending on Initial visibility level setting.

We stated to face issue from the day when PR was merged https://git.drupalcode.org/project/menu_block/-/merge_requests/13.diff.

I noticed a comment mentioning "changes reverted." Can you confirm if all changes from PR 13 have been reverted?

@dhaval_panara As far as I know, this MR was reverted. It’s highly recommended not to use a GitLab MR URL as a patch because it can be changed at any time, breaking your build—or worse, allowing someone to inject malicious code. A safer approach is to download the diff and apply it as a local patch file.

joelpittet → changed the visibility of the branch 3321699-setting-use-as to hidden.

Ok made a new branch with the new proposal in MR34, though needs a bit of testing, I like this because it won't change expected results from under people who consider root to be the top. Re-titling

Apologies for hijacking this! I hope the new feature/option is useful for everyone, and that I didn’t cause too much disruption along the way. 😃

Automatically closed - issue fixed for 2 weeks with no activity.