πŸ‡ΊπŸ‡ΈUnited States @zipymonkey

Durham, NH
Account created on 10 August 2007, almost 17 years ago
#

Merge Requests

Recent comments

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

This patch is working for me locally. Moving this back to Needs Review for others to review.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

The branch is out of date. I did a quick rebase locally and generated a patch (sorry for not updating the branch). I removed $this->tree = $tree; since it did not appear to be used anywhere.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

I created a fork, applied the patch and updated the Deriver to fix the PHP 8.3 deprecation warning: https://git.drupalcode.org/issue/pathauto-3079275/-/commit/b93e5527a4b88...

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

I had to apply a couple other patches to apply this to 8.x-1.12 and I am setting a deprecation warning when on PHP8.3.

Deprecated function: Creation of dynamic property Drupal\pathauto\Plugin\migrate\PathautoPatternDeriver::$basePluginId is deprecated in Drupal\pathauto\Plugin\migrate\PathautoPatternDeriver->__construct() (line 41 of modules/contrib/pathauto/src/Plugin/migrate/PathautoPatternDeriver.php).

It looks like this requires defining the basePluginId variable.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

I created a fork so that the new block create permissions are respected by layout builder browser

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

I created a fork which adds a check to ensure that the user can create the inline_block.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

The patch only supports using the transitions label on the Edit page. This does not work on the Layout form. The Layout builder change is set in content_moderation_entity_form_display_alter() hook but that knows nothing about the setting. The patch will need to be updated to handle the form alter. The following changes the transition but that needs to be pulled from the moderation_labels need to be pulled from the form settings.

  if ($context['form_mode'] === 'layout_builder') {
    $form_display->setComponent('moderation_state', [
      'type' => 'moderation_state_default',
      'weight' => -900,
      'settings' => [
        'moderation_labels' => 'transition', // Get the field setting from form display?  
      ],
    ]);
  }

Alternatively, this could be a setting on each workflow instead of a settings on the field Widget.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

Added a patch that passes a boolean through to the BehaviorInvoker::getBehaviorPlugin() method so the message is only displayed `onResponse` and never `onRequest`.

I am not sure that this the best way of handling it but it does appear to work when testing this locally.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

zipymonkey β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH
πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

I updated the Forked branch to pull in changes from the 2.x branch. I also fixed a issue where multiple paragraphs were getting added to the block quote each time it was edited.

I have uploaded a patch for this as well.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

Uploading the patch from 3305288.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

@heddn The patch for https://www.drupal.org/project/group_content_menu/issues/3305288#comment... πŸ“Œ Automated Drupal 10 compatibility fixes Closed: won't fix is for 3.0.x. That removes a few references to GroupContent that are still in the module. I will create a separate ticket.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

Patch does not for 3.0.x branch so I rerolled it and add node context to the block instead of loading the node from the request.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

There are couple of references to the GroupContent in the 3.0.x branch. The attached patch removed the references or replaces them with GroupRelationship.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

I tried to combine the changes from #27 and #17, so GA4 recommended ecommerce events are used and this tracks quantity updates in the cart. Hopefully, I didn't miss anything but this appears to be working using the GA4 debugging tools.

πŸ‡ΊπŸ‡ΈUnited States zipymonkey Durham, NH

Looks like there is a mask in the tabledrag styles that is on top of the background image. Removing the mask appears to make this work.

Production build 0.69.0 2024