Group Menu not visible on Node pages and Group menu block theme suggestion config

Re-rolled patch from #11 to work with dev-3.0.x version. I also needed the patch from https://www.drupal.org/project/group/issues/2815971#comment-14881532 📌 More contexts needed Needs work to get the Group content menu to show correctly on node pages which belong to a Group.

Re-rolled #12 to work with latest 3.x-dev version

We need to make patch compatible with latest version of this module.

Applied some early check and updated patch.

Patch does not for 3.0.x branch so I rerolled it and add node context to the block instead of loading the node from the request.

The last submitted patch, 18: group_content_menu-menu-not-visible-3.0.x-3170013-18.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Can we split this issue into 2 parts please? And see comments in #5 and #6.

@heddn I'm not seeing the concern from #6 in any patch after #11. Do you want us to update the Issue?
Also without this patch I do have some theme suggestions provided

• menu--group-menu.html.twig
• menu--group-menu--<group content menu machine name>.html.twig

I feel like we don't need to provide anything more for the suggestions and theme authors can use hook_theme_suggestions_menu_alter to provide more.

This refactors the code a bit more. But honestly, not a lot. If you have some special logic on finding the "current group", you should extend or create your own context plugin.

Something like:

  my_module.group_context:
    class: Drupal\my_module\Context\GroupContext
    public: false
    decorates: group.group_route_context
    decoration_priority: 3

Then you can add any and all of your special logic in there. The menu might not be the only place that you need to know this information. This module makes no assumption that a site is even using nodes for group content. If you want to resurrect that logic from a patch here, throw it into a custom module.

For those that don't want to do the custom group context just mentioned, I've added a helper method ::getGroup()for getting the "current group". You can alter the block definition to use a custom block that extends the current class. In that extension, you can just add your group logic. You'll also want to add any cache context appropriate at the same time to ::getCacheContexts(). But creating your own context plugin is probably easier.

And I've also tagged this as a task. There's no bug here.

patch #17 📌 Group Menu not visible on Node pages Needs review worked but getting an exception

Uncaught PHP Exception Error: "Class "Drupal\group\Entity\GroupContent" not found" at \modules\contrib\group_content_menu\src\Plugin\Block\GroupMenuBlock.php line 343
I fixed the issue by calling the `GroupRelationship` class, see update #23 → patch

Thank you @shalDrupal this patch rolls out right for me.

sorry ignore my last patch #23 → and used attached corrected patch.

Patch #26 seems to work well for group_content_menu 3.0.1, group 3.2.2, and drupal 10.2.5

Rerolled #26 against 3.0.3 (July 4 2024)

menu is again not showing even after CR and permission rebuild.

Updating version to prioritize issue fork off of 3.x branch.

Also updating issue description to acknowledge that ✨ Integrate some of Menu Block module's options Fixed has added template theme suggestions.

DaleTrexel → changed the visibility of the branch 3170013-2x-group-menu-context to hidden.

Setting this to Needs Review to get some more eyes on it. Would love to get some feedback!

Have been working on a minimal Drupal setup. Will be checking on a copy of the main site that I manage next (2.x).

Adding 🐛 Starting level deeper than 1 ignores active trail, when "Expand all items" is enabled Needs work as related, where MRs merged with MRs from this issue are available as a single branch, for review and patching purposes.

The patch DaleTrexel supplied in merge request 27 appears to fix the issue for group_content_menu 3.0.3 branch on Drupal 10.3.1. I'll continue testing but so far so good.

One caveat I'm running into with DaleTrexel's patch is that I cannot get the menu to show up on the group itself unless I leave the settings for the menu block to completely unrestricted. The moment I restrict the content types to 1 of the allowed types within the group (In my case I only want the menu to show on pages in the group, not news items in the group) the menu no longer shows on the group itself, even if I explicitly specify the group type.

JayDarnell: Is this something that you had working before on previous versions of this module, or is it new?

I have been unable to replicate what you describe: make a Group Content Menu appear on a Group page after checking to restrict the menu block to one or more of the content types in its configuration. I've tried various combinations of Group 3.2.* with and without patches from 📌 More contexts needed Needs work , and Group Content Menu 3.0.* with and without patches from this issue. I'm also currently running Drupal 10.2.8-dev on my test site. In all my tests, as soon as you restrict by content type (even if you check all available types) the menu appears on the Group page.

If you were able to get GCM to appear on a Group page when using the block content type restriction setting enabled, please share the versions of Group and GCM, plus patches applied! I'd definitely like to see what's going on.

But if this is something new that you've discovered, then it should be reported as a separate issue.

(In my own testing previously, I was never able to figure out how one might use the Content Type restrictions settings OR the two confusing "Group Types" and "Group Type" settings tabs on the menu block, so I wouldn't be surprised if you've found something no one else has tried and/or reported yet.)

The group context you need here is what you should be using. group.module provides a context. Use it or extend it it to provide your own group context special rules. But this module is not going to land something that is provided already by group.module.

daletrexel - this is my first time using this module and its for a brand new build. When I started the build back in February we were using older versions of core and this module and it seemed to work fine, though to be fair I only did a cursory check as the group functionality was not priority at the time.

Now I'm on the following setup:

• Drupal 10.3.1
• Group 3.2.2
• Group Content Menu 3.0.3

I'll do more testing today to see if I can figure out what is going on. To restate my issue, I want the menu to display on the group itself and any nodes of type "Lab Page" within the group (but nothing else: no other content types, not user entities within the group, etc) I would think all I have to do to restrict this is check the appropriate boxes when I add the group_content_menu block to a given region but that doesn't seem to be the case.

@heddn, just to be sure I follow, are you saying the intended behavior of this module is to automatically display the group_content_menu block in a given region based on group context alone, with no considerations for block visibility settings and that to specify more specific visibility settings I would need to write code to extend the context provided by the group module itself?

Updated the drupal core and modules version using `composer update`

• Drupal 10.4.6
• Group 3.3.4
• Group Content Menu 3.0.5

and re-rolled patch #26 [ https://www.drupal.org/files/issues/2024-04-11/group_content_menu-menu-n... → which is compatible with updated versions.

@florisg Could you please review the patch.

heddn → closed merge request !26

heddn → closed merge request !27

jaydarnell → changed the visibility of the branch 3170013-2x-group-menu-context-b to active.

jaydarnell → changed the visibility of the branch 3170013-2x-group-menu-context-b to active.

jaydarnell → changed the visibility of the branch 3170013-2x-group-menu-context-b to hidden.

Apologies as I may be doing this wrong but I need to upgrade this module and the patch I was using no longer applies. I'm going to attempt to reopen this to see if that will give me the option to create a new issue fork with the latest updates from the 3.0.x branch.

#41 is working for me with 3.0.6

jaydarnell → closed merge request !53

I can confirm #41 is also working with 3.0.6. Apologies for the task spam. Somehow I missed that comment previously.

heddn, I still don't think this is working as designed if the intention is for a group menu to display on group pages. I can see in the getMenuInstance() that there is code to check the context and if no group entity found, check if the node page is linked to group through group_content so it seems like it should work for group nodes but on my site it is not. The patch above works for now and I don't have any more time to devote to this presently but I'll revisit in the future, walk through the code in detail and see if I figure out what is going on.

A few examples of how to write a rule for passing group context along can be found in https://www.drupal.org/project/group_context_domain → or https://www.drupal.org/project/group_context_path_prefix → . In general, it will tend to be a bit specific to each site. So developing a custom context provider is the recommended path.

One thing that is not working now (with #41) is that nodes that are in the group, but aren't in the menu don't display the menu. This is a new problem. Can anyone confirm?

Heddn, so what I think you are saying is:
Rather than use these patches, individual site owners need to create a module (or add to an existing module) to provide a group context for our nodes.

If that context is provided this menu should appear on the nodes without anything additional? I am struggling to extrapolate from your examples into what this should look like.

Thanks!

@adriancotter your assessment is correct in #55.

Thanks @heddn. However, I am struggling to extrapolate from the examples you offered how to accomplish that. Those examples contain a lot more code than is presumably necessary -- and don't actually look all that similar.

Thanks @heddn. However, I am struggling to extrapolate from the examples you offered how to accomplish that. Those examples contain a lot more code than is presumably necessary -- and don't actually look all that similar.

It is mainly:

- https://git.drupalcode.org/project/group_context_domain/-/blob/1.0.x/src...
- https://git.drupalcode.org/project/group_context_path_prefix/-/blob/1.0....

re: One thing that is not working now (with #41) is that nodes that are in the group, but aren't in the menu don't display the menu. This is a new problem. Can anyone confirm?

This is related to the recent release
https://www.drupal.org/project/group_content_menu/issues/3224816 🐛 Starting level deeper than 1 ignores active trail, when "Expand all items" is enabled Needs work
And probably a peculiarity of our group menus. that came out of a migration.

I have to put aside the context question -- I made an attempt to do it which did not work, and and I don't have time to pursue. It does seem like this would be nice to have documented more fully somewhere (specifically for group content menu and nodes) as it does not seem to me like an easy thing to jump into, and a very common thing to want. If I ever manage to do it, I'll try and make that happen.