Group Menu not visible on Node pages

Re-rolled patch from #11 to work with dev-3.0.x version. I also needed the patch from https://www.drupal.org/project/group/issues/2815971#comment-14881532 📌 More contexts needed Needs work to get the Group content menu to show correctly on node pages which belong to a Group.

Re-rolled #12 to work with latest 3.x-dev version

We need to make patch compatible with latest version of this module.

Applied some early check and updated patch.

Patch does not for 3.0.x branch so I rerolled it and add node context to the block instead of loading the node from the request.

The last submitted patch, 18: group_content_menu-menu-not-visible-3.0.x-3170013-18.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Can we split this issue into 2 parts please? And see comments in #5 and #6.

@heddn I'm not seeing the concern from #6 in any patch after #11. Do you want us to update the Issue?
Also without this patch I do have some theme suggestions provided

• menu--group-menu.html.twig
• menu--group-menu--<group content menu machine name>.html.twig

I feel like we don't need to provide anything more for the suggestions and theme authors can use hook_theme_suggestions_menu_alter to provide more.

This refactors the code a bit more. But honestly, not a lot. If you have some special logic on finding the "current group", you should extend or create your own context plugin.

Something like:

  my_module.group_context:
    class: Drupal\my_module\Context\GroupContext
    public: false
    decorates: group.group_route_context
    decoration_priority: 3

Then you can add any and all of your special logic in there. The menu might not be the only place that you need to know this information. This module makes no assumption that a site is even using nodes for group content. If you want to resurrect that logic from a patch here, throw it into a custom module.

For those that don't want to do the custom group context just mentioned, I've added a helper method ::getGroup()for getting the "current group". You can alter the block definition to use a custom block that extends the current class. In that extension, you can just add your group logic. You'll also want to add any cache context appropriate at the same time to ::getCacheContexts(). But creating your own context plugin is probably easier.

And I've also tagged this as a task. There's no bug here.

patch #17 📌 Group Menu not visible on Node pages Needs review worked but getting an exception

Uncaught PHP Exception Error: "Class "Drupal\group\Entity\GroupContent" not found" at \modules\contrib\group_content_menu\src\Plugin\Block\GroupMenuBlock.php line 343
I fixed the issue by calling the `GroupRelationship` class, see update #23 → patch

Thank you @shalDrupal this patch rolls out right for me.

sorry ignore my last patch #23 → and used attached corrected patch.

Patch #26 seems to work well for group_content_menu 3.0.1, group 3.2.2, and drupal 10.2.5