Integrate some of Menu Block module's options

This was, admittedly a fairly quick, copy/paste/adjust bonanza directly from Menu Block code, so it will undoubtedly require cleanup and refinement, just wanted to get this out there. Thanks!

A bit cleaner now, removed stuff about Fixed Parent, which is illogical in the context of this module. Also don't render the menu/block at all if the settings leave just the block title. Fixed a caching bug. I'll learn how to do an interdiff soon...I tried but got an error about whitespace 🤷‍♂️.

Another couple of changes as I do a little more functional/practical testing on the project where we're using this.

Bah. Uploaded wrong file.

There's an awful lot of phpcs changes in the last few patches. Can we roll some of that back? It makes it harder to review.

Hopefully this will do it. I really need to be schooled on how to properly patch a module :-/

That last patch seems a bit odd. It seems more of an interdiff then a diff against the original code.

Yeah, I guess I'm starting over. I really don't know how to do this properly. Stay tuned... :)

I just found ✨ Add advanced option to display children of current menu item Needs review which does some of this and I updated my patch to (hopefully!) be formatted correctly and it incorporates all of the options there as well as additional ones from menu_block.

+1 for some of these changes!

* Custom theme hook suggestion for the block and menu
* Make the initial visibility level follow the active menu item

gabesullice → changed the visibility of the branch 3366930-theme-suggestion-and-dynamic-level to hidden.

I pushed two commits to the issue branch. Thanks for the head start @scotwhith1t! I ended up starting from a blank slate based on the 3.0.x branch, but I used your patch as inspiration.

The two commits:

• Add an input to configured a theme hook suggestion
• Set the menu depth to be relative to the active menu item

I propose any remaining functionality from the menu_block module be broken out into their own feature request issues to keep the scope of changes to a minimum. I probably should have broken the two commits above apart.

Some feedback posted on MR. Also, is there a simple way to add to our test coverage?

Back to NR.

is there a simple way to add to our test coverage?

Missed this. Moving back to NW.

tl;dr: not sure yet

Added tests.

Automatically closed - issue fixed for 2 weeks with no activity.

New version just for me because I'm stuck on my custom version with some of the above and some of my own doings all mixed in. Having a caching issue and this minor change will hopefully fix that for us until I can manage to update to the newest version and create a new issue with a patch integrating the remainder of the functionality that was dropped from this issue. Thanks for getting the chunk done that was completed, but it's just divergent enough from what we implemented (my original patch) that I can't quite use it as is. This will only apply to 3.0.2 as far as I know.

Uploaded file was formatted weird.

Ultimately had to fix the getCacheContexts() method to match the 3.0.5 version because it checks properly for the menuName to be populated but having a nightmare of a time trying to create a patch on a patch and have 2 other patches for customization on top of it, so I just ended up moving my version of this module to /modules/custom so we don't accidentally undo the customizations later.