Guelph, Ontario
Account created on 7 December 2009, about 14 years ago
#

Merge Requests

Recent comments

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Patch #57 worked for me

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

JayDarnell β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

As I've started brainstorming on this, I can't help but wonder if these subscriptions should be entities. If they were entities I could leverage views to create a much more robust subscription page. At a minimum I can see how the views pager and the ability to utilize views filters would make for a more user friendly experience, especially on sites with a large number of groups.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Thanks so much bircher. I need some practice writing tests as it is. If you want I could turn this issue into a feature request and create a new branch and PR to add this as a sub module with a suitable test.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

I've tested the patch from #90 on a few sites now and it seems to work really well.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Tested with Drupal 10.1.6, PHP 8.1.21 and 8.x-1.5 and the patch from #5. Unfortunately my initial sitemap.xml generation still failed. The only way I could get it to complete is if I manually bump my memory limit with ini_set('memory_limit', '2G') But this worked even without the patch.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Hi bircher, first of all thank you for this awesome module. I wasn't quite sure how to utilize the new hook and would greatly appreciate any guidance in that respect. I couldn't figure out how to create a pattern that only ignores block config from the block_content module because the naming convention for block_content blocks and blocks from a different module all follow the same naming convention: block.block.
_.yml

Examples:

We have a custom block type called "Text" that is simply a block description and body field. I created one of these with the block description "Carl Sagan" and config management wanted to export the file: block.block.mytheme_carlsagan.yml.

A block from the book module for book navigation is exported as the file: block.block.mytheme_booknavigation.yml.

In our environment end users could create an infinite number of custom text blocks so we don't want to track any of them, but with the way these ymls are named, I can't tell the difference between a block created by block_content and other blocks. The only difference I could find was the settings->provider value within each of their yaml files (which tells us the module responsible for creating them)

Thank you in advance for your help. If we can avoid using a one off patch and can work with the module as provided that would be preferable.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

The initial merge request takes care of not tracking these items for export, but I need to update it so the custom blocks aren't deleted on import.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

I can update the issue fork to add a span around the subset of the label containing the equation in order to satisfy the failed test but wanted to get maintainer feedback first.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Also updating this to a major bug due to the fact the module as written will not pass accessibility tests.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

With this still being a problem in the 2.x branch I'm going to update the issue appropriately, create an issue fork, and reroll adriancruz's patch from #2 for the latest 2.x release.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

This no longer appears to be an issue. As mentioned above, the initial patch supplied here: https://git.drupalcode.org/project/legal/-/merge_requests/3.patch actually breaks the redirect altogether (in the 3.x branch at least). After I removed this patch I attempted to recreate the initial bug reported in this issue but cannot. I suspect the problem was fixed elsewhere and this issue merely needs to be closed.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

False alarm. The 3280 patch does in fact apply in 10.1.3. The problem is that I already had an older patch (#47) for Drupal 8+ from this issue https://www.drupal.org/project/drupal/issues/2086125 πŸ› Last read comment field/filter/argument uses still the node.changed instead of node_field_data.changed column Needs review applied but it was no longer working for Drupal 10. Replacing that patch with this one fixed the issue for me.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

I could not get the patch from 3280 to apply in Drupal 10.1.3. I will attempt to rewrite it today and report back. One thing to note in the meantime, this appears to be an issue with the Comment Statistics: Updated/commented date wholesale, not just for sorting and filtering. Just trying to output the value of the field in 10.1.3 also fails so I'll see if I can add coverage to that to a patch as well.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Good catch @majorrobot!

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

New merge request coming along momentarily. I accidentally omitted two use statements from the .install file.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

@DamienMcKenna hopefully the merge request I created above is helpful. This is the first time I've written an update hook to recreate a view from a module's config folder. This worked like a charm locally but please let me know if you find any issues with it.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

JayDarnell β†’ made their first commit to this issue’s fork.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Once more for good measure as I overlooked one of the previous changes:

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Had to add in the # for a couple lines in the info.yml which are added by the drupal.org packaging script for the patch to take:

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Attempted reroll for D10 compatibility

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

While this issue is technically for Drupal 9 compatibility, I'm going to reroll the patch above to hopefully support the 8.x-1.x branch in Drupal 10 as well. This will give folks who may still be running on this older branch of USWDS a stop gap for D10 support until they can upgrade any custom themes they have based on USWDS to use the latest release.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Good catch. I was really confused when I upgraded to 2.0.1 and saw the duplicate "modules" in the core.extension.yml :)

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Could we please get the solution from bletch merged?

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

This is the first I've heard of this concept but I love it.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

JayDarnell β†’ created an issue.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

JayDarnell β†’ created an issue.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

I'm looking into this now swirt to see if I can come up with a solution.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

JayDarnell β†’ created an issue.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Closing in favour of https://www.drupal.org/project/group_subscription/issues/3221373#comment... ✨ Improve UI/functionality for holding and requeuing subscriptions Active

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

This issue is sorta a duplicate: https://www.drupal.org/project/group_subscription/issues/3353499 ✨ Move checkbox for optionally omitting group content from subscriptions to vertical tab Closed: duplicate

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

Attempting to move this to the 3.0.x branch. We'll see if the next automated pass actually checks that branch or not.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

If a user is in multiple groups and a given piece of content is posted in both groups this could create duplication so we'll need to account for that. If we're not going to just send two immediate emails and not include two references to the item in the same daily email that means our email templates need to account for the item being in multiple groups somehow.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

This is still a pretty solid enhancement we could use.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

I'm not sure this is something I'll still work on. Definitely low on the priority list.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

This is an oversight on my part. Should just be an additional checkbox on the gnode configuration page to also send updates for comments on those items.

πŸ‡¨πŸ‡¦Canada JayDarnell Guelph, Ontario

I'm still unsure of the best way to implement this but I think its important. Group admins need to be able to specify the default subscription settings for their groups in some way. The users can still change the settings if they so choose but defaulting to disabled means users will never get notifications unless they know they need to set them up.

Allowing an admin to bulk change user subscriptions within a group after the fact is also useful in some situations but does go against the spirit of the module in that the end user ultimately has control. I have a lot of work to do to get the 3.0.x branch streamlined but I'm keeping this issue around to revisit as soon as I can.

Production build https://api.contrib.social 0.61.6-2-g546bc20