Sorting and filtering on last updated/commented date in Views is broken

This fix did not make it into 10.1. Patching core is not a permament solution.

The bug essentially breaks any view that summarizes current site activity (similar to what forums do). That functionality is so central to the misssion of Drupal, I wonder how this could have been neglected for so long.

I suggest raising its priority.

In order for others to find this issue with Google:

Sort criteria
Comment Statistics: Updated/commented date (desc)

TypeError: Cannot assign null to property Drupal\comment\Plugin\views\sort\StatisticsLastUpdated::$field_alias of type string in Drupal\comment\Plugin\views\sort\StatisticsLastUpdated->query() (line 29 of core/modules/comment/src/Plugin/views/sort/StatisticsLastUpdated.php).

Not sure how this got bumped to core 11.

Exported the diff as a patch for my D9 site, thanks @eelkeblok

Created a tests-only merge request. Not sure if the tests were already functional.

Can confirm the issue.

Wonder those with the type change in the schema if any post update hook is going to be needed?

I am doing triage on the core RTBC queue → .

The issue summary is clear and there are steps to reproduce. I used the steps to reproduce on Drupal 11.x, standard install, and got a failure when saving the last step, not before. I am updating the steps based on my results. The remaining steps could use an update.

I do not see a code review here. Setting back to NR.

On the other hand this is about comment and views, two systems that have a fair number of issues. Has anyone looked for duplicates? I am taking a moment now... There is 🐛 Last read comment field/filter/argument uses still the node.changed instead of node_field_data.changed column Needs review . This may be a duplicate of that. That needs investigation. I've put that in the remaining tasks as the next step here.

They certainly have some overlap. But appears a lot more is going on in 🐛 Last read comment field/filter/argument uses still the node.changed instead of node_field_data.changed column Needs review .

So we have a fix here should we delay this one until that one is ready? Tried testing their patch but doesn't work, causes errors in the view.

Let me know if I'm wrong. But restoring status as we got a fix on this ticket while 🐛 Last read comment field/filter/argument uses still the node.changed instead of node_field_data.changed column Needs review does not and seems to have less momentum. I believe the other issue is solving more but may not be close yet to being ready.

@eelkeblok I believe the reason that this (and all improvements/fixes to Drupal) are targetted at D11 is because it is deemed better to fix in a place that is future-proof, and then backport to current releases.

It looks like one of the MRs has a failing test.

It looks like MR 3280 is adding a new test view for the sake of a test, but I don't see any tests that are using that view.

Can we confirm we have test coverage here?

I could not get the patch from 3280 to apply in Drupal 10.1.3. I will attempt to rewrite it today and report back. One thing to note in the meantime, this appears to be an issue with the Comment Statistics: Updated/commented date wholesale, not just for sorting and filtering. Just trying to output the value of the field in 10.1.3 also fails so I'll see if I can add coverage to that to a patch as well.

False alarm. The 3280 patch does in fact apply in 10.1.3. The problem is that I already had an older patch (#47) for Drupal 8+ from this issue https://www.drupal.org/project/drupal/issues/2086125 🐛 Last read comment field/filter/argument uses still the node.changed instead of node_field_data.changed column Needs review applied but it was no longer working for Drupal 10. Replacing that patch with this one fixed the issue for me.