Account created on 7 July 2015, almost 9 years ago
#

Recent comments

In order for others to find this issue with Google:

Sort criteria
Comment Statistics: Updated/commented date (desc)

TypeError: Cannot assign null to property Drupal\comment\Plugin\views\sort\StatisticsLastUpdated::$field_alias of type string in Drupal\comment\Plugin\views\sort\StatisticsLastUpdated->query() (line 29 of core/modules/comment/src/Plugin/views/sort/StatisticsLastUpdated.php).

This fix did not make it into 10.1. Patching core is not a permament solution.

The bug essentially breaks any view that summarizes current site activity (similar to what forums do). That functionality is so central to the misssion of Drupal, I wonder how this could have been neglected for so long.

I suggest raising its priority.

This has not moved forward for almost a year. Is this still being pursued? This issue is blocking sites from translating content. How can this not be a top priority by now? I would love to fix it myself, but the convoluted Drupal code base takes at least a year to wrap your head around.

I'd be happy to apply a patch as a quick workaround, but am unable to identify the current state of patches proposed here.

Can anyone point me to the most current patch that I can apply?
Thanks.

This should not only be a global configuration option, but rather one that can be changed temporarily and programmatically by other modules that want to copy or convert content nodes and comments.

For example, if some module wants to convert a node to a different type, all comments need to be copied. This now triggers a comment notification for all users involved in a discussion that may be years old.

If there is a quick hack to prevent this, I'd like to know. Using some global Drupal variable should do the trick, I suppose.

Before:

After:

A hefty issue at least with Safari and Chrome, if I remember correctly. Almost unusable. Firefox seems to be more tolerant.

Appending the proposed snippet to the CSS file fixes this.

Found this is related to Fix Required fields to really not be required (3024419). Changed description to ask for a UI change to indicate the reason for the form blocking. This will at least avoid confusion until the parent issue is fixed.

This particular exception happens when a YouTube video is no longer available or private, which is a very common situation.

The crash can be temporarily fixed in ConvertUrlToEmbedFilter.php as shown in the snippet below, although it's really only a first attempt at getting past the road block. Please excuse the misplaced use of a Bootstrap alert here. You certainly know a better way to inject a message to make end users aware of a problem with one of the URLs in the text.

 public function process($text, $langcode) {
    try {
      $result = new FilterProcessResult(static::convertUrls($text, $this->settings['url_prefix']));
    }
    catch (NetworkException $e) {
      $result = new FilterProcessResult('<p class="alert alert-danger">A network exception occurred with embedding an URL</p> ' . $text);
    }
    return $result;
  }

I should note that manually running composer require 'drupal/components:^3.0@beta' before composer require 'drupal/bootstrap_italia:^2.3' gets you past the road block. This is at least a temporary workaround.

Production build 0.69.0 2024