Automated Drupal 10 compatibility fixes

I've created a fork and opened a merge request containing the patch generated in #2.

The Context dependency in composer.json is for Context v4.1, which is incompatible with Drupal 10. We'll have to update that to Context v5, which is compatible with Drupal 10.

I've updated to denote Context v5, would be good to get a Drupal 10 compliant release out. Please let me know if I can do anything else to help.

We would appreciate it if the merge request above by bletch could be approved and merged as soon as possible. The fix seems to be effective.

MR !2 makes modules D10 compatible, tested with upgrade status and drupal check.

Moving this issue to RTBC.

Context 4.1 is not D10 compatible so this will fail in that regard

I also tested and it worked as expected with no errors.

Could we please get the solution from bletch merged?

+1 for this being merged, the Context 5 rc1 for Drupal 10 has been released since 22 February 2023 so should be fine to go with it. Without this Drupal 10 upgrade is getting impossible.

+1 for getting this merged ASAP so D10 upgrade is possible

+1 Agreed, can we please have this merged ASAP.

I agree with comment #7 that the Context dependency in composer.json is for Context v4.1, which is incompatible with Drupal 10. I cannot update the Context to v5 until the requirement from composer.json of 'Context active trail' is not changed to the proper version.

I also tested MR2 and it worked as expected with no errors. Please merge it as soon as possible. thank you!

+1 for this to be merged

Meanwhile MR2 is merged, I have created patch for same.

One thing I'm not following is that this patch makes it D10 compatible but it has a dependency on "drupal/context": "^4.1" which is not D10 compatible and it does not have a patch to make it D10 compatible so how are people using this patch on D10? I mean it's compatible but can you actually be on D10 without updating context to ^5.0 as well?

How do I use this? Why is the merge taking so long?

I can't upgrade to D10 because of the composer.json context dependency. The patch applies after composer checks its dependencies so you can never patch composer files.

Any workaround please?

@danekin The only solution to this that I have been able to use to get past this is to:
1.) patch the current module with #23 using composer patches.
2.) Then remove this module from composer.
3.) Then move the module to my custom modules folder and commit it to my repo.
4.) drush cr (cache rebuild)

When this patch merges finally some day i will re-add this module back to composer and delete the module folder out of my custom modules folder. Make sure you do a cache rebuild via drush every time you move the module so Drupal picks it up.

If someone else has a better solution let me know. Hope this helps someone as it was the only way for me to upgrade to drupal 10 without this merged in.

Guide here for using the patch with composer-drupal-lenient package https://gorannikolovski.com/blog/how-to-upgrade-drupal-9-to-10#how-to-in...

For anyone struggling to apply patches or get this module working with context.
You inside composer.json can add the following to repositories

{
  "type": "package",
  "package": {
    "name": "drupal/context_active_trail",
    "type": "drupal-module",
    "version": "dev-8.x-2.x",
    "source": {
      "type": "git",
      "url": "https://git.drupalcode.org/issue/context_active_trail-3286756.git",
      "reference": "2ad7b4324ddaa01db07bc187772c7aa917db5def"
    }
  }
}

Make sure this goes before:

{
  "type": "composer",
  "url": "https://packages.drupal.org/8"
}

Then to require the patched version you can use:
composer require drupal/context_active_trail:dev-8.x-2.x -W

Is there a plan to get a release for the module?

gaurav_manerkar → changed the visibility of the branch 3286756-automated-drupal-10 to hidden.

gaurav_manerkar → changed the visibility of the branch 3286756-automated-drupal-10 to active.

MR2 looks good, merged