U.K. 🇬🇧
Account created on 13 July 2017, over 7 years ago
#

Merge Requests

More

Recent comments

🇬🇧United Kingdom 3li U.K. 🇬🇧

I am not using Fast Autocomplete but I had the same issue after upgrading to 3.0.x on the search page - even though that was not a view.

The patch has resolved this problem.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li changed the visibility of the branch 2846878-add-class-to-body to active.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li changed the visibility of the branch 2846878-add-class-to-body to hidden.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Works well for myself, just creating a patch for safe reference.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Changes made to change loc_id from unique to primary key.

🇬🇧United Kingdom 3li U.K. 🇬🇧

fixing issue with #6

🇬🇧United Kingdom 3li U.K. 🇬🇧

Resolves the issue for me.
Drupal 10.3.x with workspaces.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Same patch but for version 4 of graphql twig.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Following on from #243 about Session not set warning.
I have added a patch that seems to remove the warning for myself.

I do have a feeling this should be added to another issue though.

🇬🇧United Kingdom 3li U.K. 🇬🇧

I found that #16 does work, but due to the limitations of patches you cannot apply changes to composer.json to say install/update another modules requirements - https://docs.cweagans.net/composer-patches/troubleshooting/non-patchable...

I have made some changes to #16 to allow the fields to be empty and should not cause any issues.

Steps to apply:

  1. Install hubspot module 3.x: composer require 'drupal/hubspot:3.x-dev@dev'
  2. Alter composer.lock hubspot-php requirement:
    From:
    "require": {
                    "drupal/core": "^8.9 || ^9 || ^10",
                    "drupal/webform": "*",
                    "hubspot/hubspot-php": "^3.0"
                },

    To:

    "require": {
                    "drupal/core": "^8.9 || ^9 || ^10",
                    "drupal/webform": "*",
                    "hubspot/hubspot-php": "^5.2"
                },
  3. Install hubspot-php 5.2: composer require hubspot/hubspot-php:^5.2 -W
  4. Apply patch #16/#22
🇬🇧United Kingdom 3li U.K. 🇬🇧

This has fixed the Drupal 10.3 issues but the tests are not working still.

🇬🇧United Kingdom 3li U.K. 🇬🇧

The CI pipeline is now working for the previous version 10.2.x, see 🐛 Problem when using graphql_twig with twig 3.9.0+ Active about fixes for 10.3.x

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li changed the visibility of the branch 3463686-fix-ci-pipeline to active.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li changed the visibility of the branch 3463686-fix-ci-pipeline to hidden.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li created an issue.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li changed the visibility of the branch 3463682-twig-3.9 to active.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li changed the visibility of the branch 3463682-twig-3.9 to hidden.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li created an issue.

🇬🇧United Kingdom 3li U.K. 🇬🇧

re-roll for latest version

🇬🇧United Kingdom 3li U.K. 🇬🇧

Fixing a small bug.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Fixing typo in the field name.

🇬🇧United Kingdom 3li U.K. 🇬🇧
🇬🇧United Kingdom 3li U.K. 🇬🇧

This patch is built on top of Language preferred and Canonical settings missing Needs work so assuming that is used in dev it should apply nicely.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li created an issue.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Added in some tests, added default language, updated description for language for some examples and added a https warning for canonical urls.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Think I found the problem.
We should be running an extra process facets_exposed_filter_remove_validation (facets/modules/facets_exposed_filters/src/Plugin/views/FacetsViewsPluginTrait.php) which is meant to unset($element["#needs_validation"]);

However for some reason when using select2 nothing gets created and thus this process does not get attached or run, meaning that validation is still enabled.

🇬🇧United Kingdom 3li U.K. 🇬🇧

This fixes the issue for myself, I have just created a patch version of it.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Patch applied to dev.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Added the patch to dev, also added another fix on top that removes the char limit for email messages (as it only really needed for slack).

Thanks for the fix.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li created an issue.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Resolved in 2.x

🇬🇧United Kingdom 3li U.K. 🇬🇧

Trying to fix test errors and resolving an issue that prevents the correct handler being used on processing.

🇬🇧United Kingdom 3li U.K. 🇬🇧
🇬🇧United Kingdom 3li U.K. 🇬🇧

3li created an issue.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Re-roll to make compatible with Drupal 10.

🇬🇧United Kingdom 3li U.K. 🇬🇧
🇬🇧United Kingdom 3li U.K. 🇬🇧
🇬🇧United Kingdom 3li U.K. 🇬🇧
🇬🇧United Kingdom 3li U.K. 🇬🇧

Will be resolved in 📌 Drupal 10 Ready Needs review

🇬🇧United Kingdom 3li U.K. 🇬🇧
🇬🇧United Kingdom 3li U.K. 🇬🇧
🇬🇧United Kingdom 3li U.K. 🇬🇧

3li created an issue.

🇬🇧United Kingdom 3li U.K. 🇬🇧
🇬🇧United Kingdom 3li U.K. 🇬🇧

3li made their first commit to this issue’s fork.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Tests should be written to cover the new supported entities.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Fixed during 📌 Setup GitLab CI Active

🇬🇧United Kingdom 3li U.K. 🇬🇧

As this ticket has been extended by Add support for block_content and taxonomy_term name fields (core) Needs review I am going to close this one as duplicate.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li made their first commit to this issue’s fork.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Think this should be resolved now that media support has been enabled Media library support Fixed

🇬🇧United Kingdom 3li U.K. 🇬🇧
🇬🇧United Kingdom 3li U.K. 🇬🇧

Fixed apart of 📌 Setup GitLab CI Active

🇬🇧United Kingdom 3li U.K. 🇬🇧

Fixed apart of 📌 Setup GitLab CI Active

🇬🇧United Kingdom 3li U.K. 🇬🇧
🇬🇧United Kingdom 3li U.K. 🇬🇧

3li changed the visibility of the branch 3414797-setup-gitlab-ci to active.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li changed the visibility of the branch 3414797-setup-gitlab-ci to hidden.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li changed the visibility of the branch 3414797-setup-gitlab-ci to hidden.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li changed the visibility of the branch 3414797-setup-gitlab-ci to hidden.

🇬🇧United Kingdom 3li U.K. 🇬🇧

3li created an issue.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Solves the warning I was getting.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Same as tim-diels I found that #2 & MR are simply ignoring the error and not solving the problem.
The issue I was finding is that the error is caused by failing to pass data over to the resetSize function.

I found if I removed the debounce method the error went away and also for me the auto resizing of modal/dialog was happening upon load.

I'm not totally sure how we can write tests for this though.

🇬🇧United Kingdom 3li U.K. 🇬🇧

Fixes the issues for 2.x

🇬🇧United Kingdom 3li U.K. 🇬🇧

Hey rawdreeg,
Yeh thats fine, let me know if I can do anything though.

Production build 0.71.5 2024