re-roll for latest version
Fixing a small bug.
Fixing typo in the field name.
This patch is built on top of ✨ Language preferred and Canonical settings missing Needs work so assuming that is used in dev it should apply nicely.
Added in some tests, added default language, updated description for language for some examples and added a https warning for canonical urls.
Think I found the problem.
We should be running an extra process facets_exposed_filter_remove_validation (facets/modules/facets_exposed_filters/src/Plugin/views/FacetsViewsPluginTrait.php) which is meant to unset($element["#needs_validation"]);
However for some reason when using select2 nothing gets created and thus this process does not get attached or run, meaning that validation is still enabled.
This fixes the issue for myself, I have just created a patch version of it.
Think this and other PHP 8.2 issues have been resolved here: 📌 PHP 8.2 compatibility Fixed
Patch applied to dev.
Added the patch to dev, also added another fix on top that removes the char limit for email messages (as it only really needed for slack).
Thanks for the fix.
Resolved in 2.x
Trying to fix test errors and resolving an issue that prevents the correct handler being used on processing.
Re-roll to make compatible with Drupal 10.
3li → created an issue. See original summary → .
Will be resolved in 📌 Drupal 10 Ready Needs review
Tests should be written to cover the new supported entities.
Fixed during 📌 Setup GitLab CI Active
As this ticket has been extended by ✨ Add support for block_content and taxonomy_term name fields (core) Needs review I am going to close this one as duplicate.
Resolved apart of ✨ Make Unique Field Ajax 2.x compatible to Drupal 10 Fixed
Think this should be resolved now that media support has been enabled ✨ Media library support Fixed
Fixed apart of 📌 Setup GitLab CI Active
Fixed apart of 📌 Setup GitLab CI Active
3li → changed the visibility of the branch 3414797-setup-gitlab-ci to active.
3li → changed the visibility of the branch 3414797-setup-gitlab-ci to hidden.
3li → changed the visibility of the branch 3414797-setup-gitlab-ci to hidden.
3li → changed the visibility of the branch 3414797-setup-gitlab-ci to hidden.
Duplicate of 🐛 Deprecated hook_field_widget_form_alter() Needs review
Think this is a duplicate of ✨ Media library support Fixed
3li → created an issue.
Solves the warning I was getting.
Same as tim-diels I found that #2 & MR are simply ignoring the error and not solving the problem.
The issue I was finding is that the error is caused by failing to pass data over to the resetSize function.
I found if I removed the debounce method the error went away and also for me the auto resizing of modal/dialog was happening upon load.
I'm not totally sure how we can write tests for this though.
Fixes the issues for 2.x
Hey rawdreeg,
Yeh thats fine, let me know if I can do anything though.
Found the same issue still exists on 4.0.0
re-rolled the same patch with some changes to help it apply.
Applied isset on both 3.x & 4.x, Thanks!
For anyone struggling to apply patches or get this module working with context.
You inside composer.json can add the following to repositories
{
"type": "package",
"package": {
"name": "drupal/context_active_trail",
"type": "drupal-module",
"version": "dev-8.x-2.x",
"source": {
"type": "git",
"url": "https://git.drupalcode.org/issue/context_active_trail-3286756.git",
"reference": "2ad7b4324ddaa01db07bc187772c7aa917db5def"
}
}
}
Make sure this goes before:
{
"type": "composer",
"url": "https://packages.drupal.org/8"
}
Then to require the patched version you can use:
composer require drupal/context_active_trail:dev-8.x-2.x -W
No longer required after updating to Drupal 10 ready - #3287800: Automated Drupal 10 compatibility fixes →
Two new versions have been released, both Drupal 10 ready.
4.0.0-beta1- https://www.drupal.org/project/graphql_twig/releases/4.0.0-beta1 →3.0.0-beta1- https://www.drupal.org/project/graphql_twig/releases/3.0.0-beta1 →
If you find any issues please open new issues.
Released 4.0.0-beta1 -
https://www.drupal.org/project/graphql_twig/releases/4.0.0-beta1 →
If you find issues please open new issues.
Applied the $this->env->isDebug() fix to both 3.x & 4.x thank you.
Thank you for the fix.
I think we might want tickets that are separate for Gin & Claro, as they are not the same.
So here I have worked on changes just for Claro.
Before:
After:
Due to composer requirements the only way to add this fix is to adjust composer.
Add to your repositories:
{
"type": "package",
"package": {
"name": "drupal/npm",
"type": "drupal-module",
"version": "dev-2.x",
"source": {
"type": "git",
"url": "https://git.drupalcode.org/issue/npm-3288828.git",
"reference": "2fae27867f3fdf33fb755f34b218a22690653552"
}
}
}
Then require it with:
composer require 'drupal/npm:dev-2.x' -W
Have created new two new versions:
3.x -
https://www.drupal.org/project/graphql_twig/releases/3.x-dev →
4.x - see
✨
GraphQL 8.x-4.0 compatibility
Needs review
for more details
3.x should now be Drupal 10 ready, PHP 8.1 and compatible with GraphQL 3.x
Would be good if people could test it so it can be released.
will be combining information about this with #3287800: Automated Drupal 10 compatibility fixes →
Have created a new version (4.x) which should be Drupal 10 ready, PHP 8.1 and be compatible with 3.x
https://www.drupal.org/project/graphql_twig/releases/4.x-dev →
All that is missing at the moment is a few of the tests are failing but locally it all seems to be working.
If others could give this a try it would be great & possibly fix the broken tests.
Just a reminder: 4.x requires GraphQL 4.x
Adjusting patch to remove core tag.
Combined all the changes into one PR.
All good
Combining the issues above with a few more to remove all warnings.