PHP 8.2 compatibility

I've created a branch that addresses all dynamic property issues on PHP 8.2 for the 3.0 branch in a more robust manner. Instead of adding the missing property to the Result class I've added a generic storage property that can be accessed through get/set methods. This fixes the display value order processor, as well as opens up the ability for other custom processors to save arbitrary data on the result.

Sorry for the spam. Fixed the failing sort test. The tests that don't pass are not related to these changes.

For me MR 143 works.

Closed 🐛 PHP 8.2 compatibility for the 2.0.x branch Fixed and 📌 PHP 8.2 compatibility Closed: duplicate as duplicates.

I can't RTBC this because I made the last changes. But for the bits I didn't work on, I can give a whole hearted +1. The number of test failures are also the same on HEAD, so I think this is ready. LGTM.

I found some deprications:

Deprecated function: Creation of dynamic property

see the patch for inspiration

#14 needs to incorporated into the MR please.

Liam Morland → made their first commit to this issue’s fork.

Nothing has been merged.

Obviously the "merge train" didn't work. I merged manually now,

Here's a patch for the version 2.x of facets.
In our case, we can't upgrade to 3.x as we are using the facets_form module that is locked on 2.x

Automatically closed - issue fixed for 2 weeks with no activity.

Static patch from MR 143, if anyone else needs it.

Sorry for posting after this was closed.

Has this not been merged to 2.x, Or am I doing something wrong?

This was merged only in to branch 3.0.x. The 2.0.x branch was fixed in 🐛 PHP 8.2 compatibility for the 2.0.x branch Fixed ; this fixed shipped in version 2.0.7.

Re-rolled patch for 3.0.0-beta1 release because my team cannot use the more recent releases due to breaking changes.