Please fix the phpunit pipeline, also there are many warnings in the phpstan which needs to be taken care see: https://git.drupalcode.org/issue/recurring_events-3481021/-/jobs/3724042...
Method
Drupal\recurring_events\Form\EventSeriesRevisionRevertForm::__construct()
invoked with 2 parameters, 3 required. rajeshreeputra → credited ankitv18 → .
rajeshreeputra → credited ankitv18 → .
Added one comment for improvement.
ankitv18 → created an issue.
@dinarcon Sure ~~ I'll left the novice tag issues for newbies.
Just review and validate the changes and provide suggestion but if you say I'll untouch the reviewing part to for novice issue.
Phpunit pipelines are failing ~~ Moving back to NW.
Looks good to be merge ~~ Changing to RTBC.
Looks good to be merge ~~ Marking this one RTBC.
Warnings of the validate pipeline will be handle separately.
I guess you already pushed the commits but didn't raise the MR ~~ anyways I have raised the one on your behalf.
If no changes are required then please do move this ticket into review state.
MR is merged ~~ Thanks for the contribution.
Marking RTBC ~~ changes looking good
ankitv18 → created an issue.
@ivnish Either we need to fix this failing test: https://git.drupalcode.org/issue/smsframework-3480559/-/jobs/3547201#L72 or we can skip previous major pipeline.
Added few more suggestion on the MR.
Looks good ~~ Hence marking RTBC.
Great~~ let me know once you are done
ankitv18 → created an issue.
MR is conflicted ~~ please resolve the MR
Added minor suggestions to MR, please check ~~ moving back into NW.
Looks good now ~~ marking this one RTBC
Totally make sense ~~ I'll keep that in my mind :D
And thanks for the quick review & moving into RTBC.
Minor suggestion regarding the naming convention of trait class ~~ hence moving back to NW.
I saw no one has touched this issue since past two days that's why raised the MR.
Anyways I'll keep this issue in Active state for new members.
rajeshreeputra → credited ankitv18 → .
ankitv18 → made their first commit to this issue’s fork.
rajeshreeputra → credited ankitv18 → .
Changes looks good and great to see all jobs are green now ~~ marking this one RTBC.
ankitv18 → made their first commit to this issue’s fork.
deepakkm → credited ankitv18 → .
Looks good ~~ marking this one RTBC
Gitlab CI is implemented properly ~~ not sure whether we need to handle other fixes, still marking this one RTBC as all changes doesn't impact.
ankitv18 → made their first commit to this issue’s fork.
Overall changes looks ~~ just added one minor code improvement and on validating the changes on local I've found no more php warnings.
Marking this one RTBC
Feel free to change the status if anyone else having the suggestions.
Quite straightforward ~~ changes done as per proposed solution, hence marking this one RTBC
Changes looks good and project-browser/data makes more sense ~~ marking this one RTBC.
But please let these kind of issues picked by someone new to the drupal community.
Hi @pameeela,
As per the file changes ~~ could you please update the functional javascript tests.
see: https://git.drupalcode.org/issue/project_browser-3488078/-/jobs/3390931
Moving into NW
@shalini_jha Thanks for working on this one ~~ changes looks quite straightforward.
FYI, these kind of issues should be picked by newbies first. :)
For now I'm marking this one RTBC.
Is there something left in this issue? @j. ayen green
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → created an issue.
On path: admin/config/content/embed/button/add
After adding embed button, below is the output we are getting.
ankitv18 → changed the visibility of the branch 3430164-automated-drupal-11 to hidden.
Left some comments on the MR ~~ leave this one in review state for further review
Made pipelines passing with adding repositories section to include vcs path of lightning_core( D11 compatible issue for 6.x version) and adding skipped test for quickedit functional JS test ( https://www.drupal.org/project/quickedit/issues/3434080 📌 Automated Drupal 11 compatibility fixes for quickedit Needs work )
Fix composer-lint pipeline: https://git.drupalcode.org/issue/acquia_starterkits-3486734/-/jobs/3316002
Pipelines are passing ~~ we can plan a merge for this one. :)
We can simply remove the usage of upgrade_status as gitlab template default branch is D11 so there won't be a next major release in anytime soon.
cc: @dqd @phenaproxima
ankitv18 → made their first commit to this issue’s fork.
Left a comment ~~ moving into NW
I've left a comment, please check
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → changed the visibility of the branch 3431664-automated-drupal-11 to active.
ankitv18 → changed the visibility of the branch 3431664-automated-drupal-11 to hidden.
ankitv18 → changed the visibility of the branch 3484975-phpcs-fixes-2.1.x to hidden.
ankitv18 → created an issue.
I have raised two MR's one with drupal gitlab template and another one with gitlab_orca.
ankitv18 → changed the visibility of the branch 3484975-resolve-phpcs-issues to hidden.
Moving this into review ~~ welcoming the feedbacks incase of backward compatibility.
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → made their first commit to this issue’s fork.
There's lot of phpstan fixes done in the MR which is irrelevant for this issue ~~ please revert those changes and work on the phpcs pipeline fixes only or update the issue summary.
Already fixed.
ankitv18 → created an issue.
@debrup your both commits are totally irrelevant. Please do revert those commits.
Phpcs failures needs to be to address separate ~~ objective of this issue to add the phpcs.xml.dist file
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
Left few comments on the MR!12. Please do check once.
ankitv18 → made their first commit to this issue’s fork.
Hi @mysdiir,
I've left few comments on the MR, please check.
CR and Deprecation test coverage is missing, also I don't think the changes done in the MR is valid.
cc: @smustgrave
Please review and validate MR!95
MR!540 changes looks good to me, hence marking this one RTBC.