🇮🇳India @ankitv18

Please add a hook_update_N to by default enable the Acquia DAM module so that user can see the migration dashboard fully functional.

Ideally this should be the part of https://www.drupal.org/project/acquia_dam/issues/3515288 🐛 Newly created media type doesn't have media_library entity view display preconfigured. Active or if we are considering handling this separately then I've added the comment on the MR.

Added comments in the MR

MR merged by Vishal and reviewed by Deepak

ankitv18 → created an issue.

@smustgrave Thanks!!
Please do consider to fix the pipeline also: https://git.drupalcode.org/issue/drupal-3477616/-/jobs/4763371#L394

ankitv18 → created an issue.

The following files are responsible for handling the sorting and rendering of the asset count for dam_content_overview:

https://git.drupalcode.org/project/acquia_dam/-/blob/1.1.x/src/Plugin/vi...
https://git.drupalcode.org/project/acquia_dam/-/blob/1.1.x/src/Plugin/vi...

I attempted to debug this issue but was unsuccessful. I have attached a screenshot of the Xdebug for reference.

ankitv18 → made their first commit to this issue’s fork.

MR!597 is ready for a review.

ankitv18 → created an issue.

MR!39 ready for a review.

MR!62 ready for a review.

ankitv18 → created an issue.

ankitv18 → created an issue.

MR!130 is ready for a review

ankitv18 → changed the visibility of the branch 3447628-load-the-config to hidden.

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → changed the visibility of the branch 3422332-fix-gitlab-pipeline to hidden.

ankitv18 → made their first commit to this issue’s fork.

Please rebase the MR so that CI jobs at least executed properly.
With referring #21 by @adamps if there's already a test then that need to be updated.

Minor change required on MR.

Please review MR!52

ankitv18 → created an issue.

RTBC++
Faced similar issue with Drupal 11.1.3 version.
Fatal error: Declaration of Drupal\cors_ui\CorsUiCompilerPass::process(Symfony\Component\DependencyInjection\ContainerBuilder $container) must be compatible with Drupal\Core\DependencyInjection\Compiler\CorsCompilerPass::process(Symfony\Component\DependencyInjection\ContainerBuilder $container): void in /var/www/html/docroot/modules/contrib/cors_ui/src/CorsUiCompilerPass.php on line 18

I've incorporate the changes with https://git.drupalcode.org/project/acquia_dam/-/merge_requests/113/diffs... (as this MR consists of Field swapping on media_type_presave hook with most of the logic using Asset, AssetDriver and Hook)

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → made their first commit to this issue’s fork.

@i-trokhanenko please review this one.

Looks good ~~ Marking this one RTBC

ankitv18 → made their first commit to this issue’s fork.

All green.. looks good to be merge.
Moving into RTBC.

I would suggest to please wait for stable version of 1.1.x. There's lot of on-going development after RC-3 release.
And Thanks for reporting this issue.

ankitv18 → changed the visibility of the branch 3477335-include-phpcs.xml.dist to hidden.

MR!124 is ready for a review.

Looks Good, hence moving into RTBC

MR!55 is ready for a review.
@pfrenssen please check.

ankitv18 → made their first commit to this issue’s fork.

Not sure why the MR is opened against 1.x branch the FR is for 2.x

ESLint pipeline still needs attention ~~ few warnings left, please consider to fix them too.

Looks good!! Hence moving into RTBC

Thanks @ b_harold,
Now you can move into review and mark all threads resolved on the MR.

I would like to suggest to add minimum support of D10.3 and then we can avoid using deprecationHelper or version_compare then things will remain intact.
@pfrenssen Any thoughts ?

Left some comment, please check.
see@ https://www.drupal.org/node/3407994 →
You have to use version_compare to avoid this error.

Looks good, hence moving into RTBC

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → created an issue.

Already Drupal11 compatible and Site studio version 8 support is available on 1.0.3

ankitv18 → made their first commit to this issue’s fork.

Left few suggestions on the MR.
Keeping this in a NR state for other to provide inputs.

Reviewed MR!117, left one comment ~~ rest looks good to me.

Keeping this in needs review so that other's can provide their inputs.

Changes are updated and pipelines are passing.

Left few suggestion over the MR, please do check.

Hi @droath,
Thanks for merging this issue.
By the way you missed to give credits to the contributors.

Hi @silverham,
As acquia_cms_headless module recommending ^1.3 as next-acms project needs to be updated with next-drupal v2 (Which is in a RC release). As soon as next-drupal npm package have v2 release we will update the next-acms project and release the new tag.

Thanks

ankitv18 → changed the visibility of the branch 3486886-latest-versions-of to hidden.

Hi @megachriz,
There are no new patches by projectBot so I guess we can mark this one fixed

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → created an issue.

Left the comment on the MR.

MR!115 can be reviewed now!!

Hi @joseph.olstad,
Thanks for merging this issue and making this module D11 compatible.
By the I guess you missed to give credits to the contributors :)

@nitebreed Thanks for merging this issue
I guess you missed to give the credits to the contributors.

ankitv18 → changed the visibility of the branch 3501141-dam-video-formatter to hidden.

Please do review the MR!107

ankitv18 → created an issue.

ankitv18 → created an issue.

Tests pipeline are passing ~~ Hence moving into review.

ankitv18 → made their first commit to this issue’s fork.

Alright, Thanks!!

Thats how the warning message looks like ~~ included the patch to validate on local

Added a minor suggestion to shorter warning message, rest looks good and resolve the problem.

Patch: https://git.drupalcode.org/project/acquia_dam/-/merge_requests/103.patch (Use this patch for now)