Account created on 30 October 2017, almost 8 years ago
  • Software Engineer at Acquia 
#

Merge Requests

More

Recent comments

🇮🇳India ankitv18

I'll suggest we should add minimum drupal version constraint to D10.3 or add @phpstan-ignore-next-line above phpstan smell lines

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Looks good, hence moving into RTBC

🇮🇳India ankitv18

Hi @cosmicdreams,
Feel free to open a new issue for your case, will look into that separately.
1.0.6 release just having a support of Gin v5 :)

🇮🇳India ankitv18

I've just bypass the phptstan previous major CI checks.
@danrod rest looks fine, moving into RTBC

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3540573-implement-hookhelp to hidden.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Why you have reverted hook attribute? Also revert phpcs and phpstan fixes.
Moving back to Needs work

🇮🇳India ankitv18

Alright, make sense!!
Reviewed MR!36, CSPELL pipeline is green now ~~ hence moving this into RTBC

🇮🇳India ankitv18

MR is conflicted, can someone please resolve this.

🇮🇳India ankitv18

Can we have a MR for this issue so that we the changes will pass all GitLab CI checks

🇮🇳India ankitv18

MR is clean and phpunit perform most of the assertions, hence moving into RTBC

🇮🇳India ankitv18

MR!7 looks good, moving into RTBC

🇮🇳India ankitv18

Opened a issue in acquia_cms_page module as field.field.node.page.body.yml is in optional configuration and there's a minor change required in that config settings.

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3525988-few-minor-improvements to hidden.

🇮🇳India ankitv18

MR!27 is ready for a review.

🇮🇳India ankitv18

Ignore above feedback as Backward Compatibility is handled in the .module hooks

🇮🇳India ankitv18

Ignore above feedback as Backward Compatibility is handled in the .module hooks

🇮🇳India ankitv18

Left a comment, please check.
Keeping this in review for other inputs

🇮🇳India ankitv18

Left a comment, please check.
Keeping this in review for other inputs

🇮🇳India ankitv18

Left a comment, please check.
Keeping this in review for other inputs

🇮🇳India ankitv18

Left a comment, please check.
Keeping this in review for other inputs

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3538033-better-logging-to to hidden.

🇮🇳India ankitv18

Covered with https://www.drupal.org/project/acquia_optimize/issues/3525986 📌 Fix Race Conditions in AJAX Processing Active

🇮🇳India ankitv18

Proposed solution isn't fixing the actual cause also, Ajax call still conflicted with a autosave_form.
Also if I replace with the proposed solution then META description, sub-headings and Title are missing from SEO checks.

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3537922-barehtmlpagerenderer-calls-renderroot to hidden.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Once this issue: https://www.drupal.org/project/graphql/issues/3536497 📌 composer pipeline is failing with D11.2.2 Active is merged then we can rebase and pipeline will work as expected.

🇮🇳India ankitv18

Raised one issue to fix the composer pipeline separately.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Thanks @longwave for pointing this out, I'm totally unaware of security issues file process.
Closing this

🇮🇳India ankitv18

Add a comment on the MR, please check.

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3533331-description-missing-on to hidden.

Production build 0.71.5 2024