Left a comment, please check.
Keeping this in review for other inputs
Left a comment, please check.
Keeping this in review for other inputs
Left a comment, please check.
Keeping this in review for other inputs
Left a comment, please check.
Keeping this in review for other inputs
MR!26 is ready for a review.
Thanks for the contribution.
ankitv18 → created an issue.
MR!25 is ready for a review
ankitv18 → changed the visibility of the branch 3538033-better-logging-to to hidden.
Covered with https://www.drupal.org/project/acquia_optimize/issues/3525986 📌 Fix Race Conditions in AJAX Processing Active
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → created an issue.
Proposed solution isn't fixing the actual cause also, Ajax call still conflicted with a autosave_form.
Also if I replace with the proposed solution then META description, sub-headings and Title are missing from SEO checks.
ankitv18 → changed the visibility of the branch 3537922-barehtmlpagerenderer-calls-renderroot to hidden.
ankitv18 → made their first commit to this issue’s fork.
Was on different branch, already fixed
ankitv18 → created an issue.
MR!31 ready for a review.
MR!18 ready for a review.
ankitv18 → created an issue.
MR!19 is ready for a review.
ankitv18 → created an issue. See original summary → .
ankitv18 → created an issue.
ankitv18 → made their first commit to this issue’s fork.
MR!47 is ready for a review.
MR!16 ready for a review.
ankitv18 → made their first commit to this issue’s fork.
Once this issue: https://www.drupal.org/project/graphql/issues/3536497 📌 composer pipeline is failing with D11.2.2 Active is merged then we can rebase and pipeline will work as expected.
Raised one issue to fix the composer pipeline separately.
MR!46 is ready for a review.
ankitv18 → created an issue.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → created an issue.
Closing this
Thanks @longwave for pointing this out, I'm totally unaware of security issues file process.
Closing this
MR!14 is ready for a review.
ankitv18 → created an issue.
MR!12 is ready for a review.
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → made their first commit to this issue’s fork.
Add a comment on the MR, please check.
Commits pushed in the parent ticket as a part of this issue:
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
ankitv18 → changed the visibility of the branch 3533331-description-missing-on to hidden.
As it is dependent on https://www.drupal.org/project/acquia_optimize/issues/3517839 ✨ Add Experience Builder extension Active so I have separate commit: https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
All the changes as a part of this issue is covered ~~ hence moving into review
ankitv18 → created an issue.
ankitv18 → created an issue.
MR!29 is against 2.x branch ~~ phpcs pipeline + composer changes are fixed now, hence moving into review.
ankitv18 → changed the visibility of the branch 3528488-fix-the-phpcs-8.x-2.x to hidden.
ankitv18 → changed the visibility of the branch 3528488-fix-phpcs-issue to hidden.
ankitv18 → changed the visibility of the branch 8.x-1.x to hidden.
ankitv18 → made their first commit to this issue’s fork.
Validated the MR!5
Query builder page throwing 404 error
jsonapi_query_builder_update_10001 isn't executed properly
MR!6 is ready for a review
Pipeline is passing after adding few phpunit and mink dev packages
Also made some tweaks and skipping few tests of Functional JsonApiQueryBuilderTest
uhhghh... I missed your comment :(
FYI, there are console.error and console.warn also in the react-app directory.
Do we need to remove them also in this ticket?
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → made their first commit to this issue’s fork.
Provided few suggestion on the MR and also test case is missing for this new drush command.
ankitv18 → created an issue. See original summary → .
ankitv18 → made their first commit to this issue’s fork.
As per discussion this will covered in another issue
ankitv18 → created an issue.
MR!8 is ready for a review.
Tests are also fixed as a part of this issue ~~ now pipelines are passing, hence moving into NR.
ankitv18 → made their first commit to this issue’s fork.
Ignore my comment ~~ went through the file then understood the reason of typecasting the numeric value.
Changes looks to be mergeable as pipeline are clean ~~ marking this one RTBC
thanks @batigolix, Changes looks good ~~ marking this one RTBC
@noored please use this patch: https://git.drupalcode.org/project/gin_login/-/merge_requests/39.patch
@cmlara I guess you missed to give credit to the contributors for this issue :)
I have validated this MR on local with XB ~~ attaching the screenshot for the result.
@mglaman @grasmash is there any remaining work on this FR?
ankitv18 → created an issue.
If changes looks good then we can consider to merge this into 3.1.x also
MR!45 is ready for a review.
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → created an issue.