Hi @joachim,
I've created the MR ~~ not sure if this this is only changes required here.
Please do comment if anything else is needed
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → created an issue.
I guess these warnings are coming from drupal core.
There's one instance in TimestampDatetimeNoDefaultWidget where Datetime::valueCallback is called
@jonathan1055 if you have solution then please proceed ~~ I created the branch but then realised the issue was created in june and after that many changes were pushed with new release. Also I'm occupied with other work.
ankitv18 → created an issue.
Left some suggestions over MR ~~ please consider
ankitv18 → created an issue.
ankitv18 → created an issue.
@megachriz Saw D11 compatible RC release is out there ~~ now we can close this one?
ankitv18 → changed the visibility of the branch 3373694-fix-the-issues to hidden.
@mandclu ,
I believe MR!9 changes will fix the concern.
ankitv18 → created an issue.
MR!84 is ready for a review.
ankitv18 → created an issue.
ankitv18 → created an issue.
DeprecationHelper also introduced in D10.1 so it's better if we can stick with FileSystemInterface::REPLACE until the minimum support is D10.3 or later on at the time of the D12 readiness.
cc: @damienmckenna
Added codemirror_editor in the require section of composer.json with version 1 and 2 ~~ not sure is there any configuration required.
@anybody: quick question why are we supporting D8 for this module ~~ any specific reason?
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → made their first commit to this issue’s fork.
That would be the maintainers call ~~ I would suggest open a new ticket for D11 compatibility and fix those changes there.
cc: @batigolix
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
Correct as 2.0.x-dev isn't really a D11 compatible.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
Now this can be reviewed.
MR!28 is ready for a review.
ankitv18 → created an issue.
@wells This won't before D10.3 so I would suggest better to live with this and take care at the time D12 readiness.
@wells I guess you have missed out to give the credit to the members.
I've confirmed your user profil, now you can see the CR shared via @quietone ~~ I guess you need to add only this issue url over there.
@quietone please confirm on the same?
Indeed ~~ to sync the forked the branch this needs to be fixed.
Please review MR!31
ankitv18 → created an issue.
Because D11 isn't in the info.yml
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → created an issue.
ankitv18 → made their first commit to this issue’s fork.
Please review MR!28
Hi @anybody,
We need to fix the test ~~ randomMachineName get appended with the default value of node title that's why assertions are failing.
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → made their first commit to this issue’s fork.
Please review MR!9
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → created an issue.
ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → created an issue.
Hi,
This change https://git.drupalcode.org/project/views_bulk_edit/-/commit/ad9d0c75555e... needs to be handle for backward compatibility.
Should be open a new issue or should be fix here only?
cc: @anybody @joseph.olstad @grevil
ankitv18 → made their first commit to this issue’s fork.
MR!25 is ready for a review!!
ankitv18 → created an issue.
ankitv18 → made their first commit to this issue’s fork.
Pipelines aren’t passing ~~ hence moving back into NW
Changes looks good ~~ validated the changes on local as I have noticed ombedAPI forces for APP id and App Secret via META.
So moving both App id and Secret with constraint into schema is good way to handle this.
Marking this one RTBC.
Updated the patch as it is failing with D11 please see the screenshot: