Account created on 30 October 2017, almost 8 years ago
  • Software Engineer at Acquia 
#

Merge Requests

More

Recent comments

🇮🇳India ankitv18

Looks fine!!

🇮🇳India ankitv18

ankitv18 created an issue.

🇮🇳India ankitv18

ankitv18 created an issue.

🇮🇳India ankitv18

Looks good

🇮🇳India ankitv18

Attempted to create a logo
If looks good then we can push into the MR

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

I’m not seeing any changes in .info.yml
Also we can remove D7 reference from readme.md file
As we should support only D10 and above

🇮🇳India ankitv18

Provides a simple, standalone machine-name field.
Use this if you only need a single machine-name input.
For two linked fields (a common Drupal core pattern), choose Safeword instead.

How’s this sound?

🇮🇳India ankitv18

MR merged hence moving into fixed state.

🇮🇳India ankitv18

MR!41 is ready for a review.

🇮🇳India ankitv18

Hey @marcus
It seems you have missed to give the credit for this fix.

🇮🇳India ankitv18

MR!191 is ready for a review.

🇮🇳India ankitv18

ankitv18 created an issue.

🇮🇳India ankitv18

Moving into review.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

ankitv18 created an issue.

🇮🇳India ankitv18

MR!40 is ready for a review.

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3111456-language-issues to hidden.

🇮🇳India ankitv18

Closing in favour of https://www.drupal.org/project/acquia_optimize/issues/3544753 📌 Rename to Acquia Web Governance Active

🇮🇳India ankitv18

ankitv18 created an issue.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

ankitv18 created an issue.

🇮🇳India ankitv18

Looks good to me, hence moving this to LGTM

🇮🇳India ankitv18

MR!39 is ready for a review.

🇮🇳India ankitv18

Hi @anybody @danrod
Except Phpcs(which should be covered in https://www.drupal.org/project/entity_browser/issues/3036556 📌 Fix the issues reported by phpcs RTBC ) rest all the pipeline is clean.

Note: I have added SKIP_ESLINT to avoid any functional failures due to Javascript (I think it is ideal to cover this separately)
Also 1 suggestion should we bump drupal version to 10.3 as we fixed deprecation here: https://git.drupalcode.org/project/entity_browser/-/merge_requests/97/di...

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

ankitv18 created an issue.

🇮🇳India ankitv18

ankitv18 created an issue.

🇮🇳India ankitv18

Anything pending here? or can we mark this as Fixed?

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

MR!9 is ready for a review.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Thanks @traviscarden,
I'll validate again with 1.0.x-dev branch to check whether this issue still there.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

:( Yep isn't reflecting on my profile.

🇮🇳India ankitv18

Hi @gagosha
Seems you missed to add credit 😅

🇮🇳India ankitv18

Plugin Id is general whereas as title is General MCP and this plugin generally returns the site information.
New plugin name suggestion

  1. SiteInformation
  2. SiteInfoMcp
  3. GeneralSiteInfo
  4. BasicSiteInfoMcp
🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

MR!24 is ready for a review.

🇮🇳India ankitv18

Merge this one first then take in consideration to merge https://www.drupal.org/project/metatag_ai/issues/3545322 📌 Add autowire to services Active

🇮🇳India ankitv18

PHPCS CI pipeline is clean now, MR!20 is ready for a review.

🇮🇳India ankitv18

Hi @nx2611
It seems you forgot to add credit on this issue 😄

🇮🇳India ankitv18

MR!19 is ready for a review, Cspell is passing now

🇮🇳India ankitv18

MR!18 is ready for a review!!

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3543530-missing-api-key to hidden.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Hi @traviscarden,
I've validated the functionality of this module and found few issues on sorting tab.
When I add the moderation_state
Drupal\Core\Entity\Query\QueryException: 'moderation_state' not found in Drupal\Core\Entity\Query\Sql\Tables->ensureEntityTable() (line 373 of /var/www/html/docroot/core/lib/Drupal/Core/Entity/Query/Sql/Tables.php).

When I add the UUID or Path field getting 400 error in response.
Drupal\Core\Http\Exception\CacheableBadRequestHttpException: Invalid nested filtering. The field `uuid`, given in the path `uuid`, does not exist. in Drupal\jsonapi\Context\FieldResolver->resolveInternalEntityQueryPath() (line 292 of /var/www/html/docroot/core/modules/jsonapi/src/Context/FieldResolver.php).

🇮🇳India ankitv18

I have included the MR!5 of https://www.drupal.org/project/jsonapi_query_builder/issues/3529219 Replace JSON:API Schema dependency with Open API JSON:ARG module Active and then tried to reproduce the issue but it working fine now

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

I created a symlink to version 5 of gin at my local to validate it using MR!5 of issue https://www.drupal.org/project/jsonapi_query_builder/issues/3529219 Replace JSON:API Schema dependency with Open API JSON:ARG module Active .

Adding screenshot for your reference

🇮🇳India ankitv18

Changes looks good and all pipelines are green now.

🇮🇳India ankitv18

Then in that case we should not enable previous major and if we want to run on previous major then we should restrict the module to install on php 8.3+ application.

🇮🇳India ankitv18

MR!176 is ready for a review

🇮🇳India ankitv18

Covered in https://www.drupal.org/project/ai_agents/issues/3542950 📌 Add PHP 8.1 tests Active

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Hi @danrod,
Maintainer section doesn't have a proper format. See

🇮🇳India ankitv18

MR!15 is ready for a review.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

MR!14 is a ready for a review.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3542913-integration-with-key to hidden.

🇮🇳India ankitv18

@danrod,
Fixed the pipeline but Readme still needs some work like for Maintainers section we need to do the proper formatting [Author](URL)

🇮🇳India ankitv18

Looks good and it would be great if we fix this also

[The Jonthornton jQuery Timepicker](https://github.com/jonthornton/jquery
-timepicker)
[jQuery Timepicker Addon](https://github.com/trentrichardson/jQuery
-Timepicker-Addon)

Check the screenshot how it is looking in the https://readme.so/editor

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3536086-fix-validate-pipeline to hidden.

🇮🇳India ankitv18

Covered in https://www.drupal.org/project/acquia_optimize/issues/3538217 Node edit page Acquia Optimize Functional restructure Active

🇮🇳India ankitv18

Changes looks good ~~ Pipeline are passing , CSpell is still having some smell which I can guess cover in this only.
Keeping this in NR for other to take a look.

Production build 0.71.5 2024