Account created on 30 October 2017, almost 8 years ago
  • Software Engineer at Acquia 
#

Merge Requests

More

Recent comments

🇮🇳India ankitv18

Left a comment, please check.
Keeping this in review for other inputs

🇮🇳India ankitv18

Left a comment, please check.
Keeping this in review for other inputs

🇮🇳India ankitv18

Left a comment, please check.
Keeping this in review for other inputs

🇮🇳India ankitv18

Left a comment, please check.
Keeping this in review for other inputs

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3538033-better-logging-to to hidden.

🇮🇳India ankitv18

Covered with https://www.drupal.org/project/acquia_optimize/issues/3525986 📌 Fix Race Conditions in AJAX Processing Active

🇮🇳India ankitv18

Proposed solution isn't fixing the actual cause also, Ajax call still conflicted with a autosave_form.
Also if I replace with the proposed solution then META description, sub-headings and Title are missing from SEO checks.

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3537922-barehtmlpagerenderer-calls-renderroot to hidden.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Once this issue: https://www.drupal.org/project/graphql/issues/3536497 📌 composer pipeline is failing with D11.2.2 Active is merged then we can rebase and pipeline will work as expected.

🇮🇳India ankitv18

Raised one issue to fix the composer pipeline separately.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Thanks @longwave for pointing this out, I'm totally unaware of security issues file process.
Closing this

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Add a comment on the MR, please check.

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3533331-description-missing-on to hidden.

🇮🇳India ankitv18

As it is dependent on https://www.drupal.org/project/acquia_optimize/issues/3517839 Add Experience Builder extension Active so I have separate commit: https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...

🇮🇳India ankitv18

All the changes as a part of this issue is covered ~~ hence moving into review

🇮🇳India ankitv18

MR!29 is against 2.x branch ~~ phpcs pipeline + composer changes are fixed now, hence moving into review.

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3528488-fix-the-phpcs-8.x-2.x to hidden.

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 3528488-fix-phpcs-issue to hidden.

🇮🇳India ankitv18

ankitv18 changed the visibility of the branch 8.x-1.x to hidden.

🇮🇳India ankitv18

Validated the MR!5
Query builder page throwing 404 error

jsonapi_query_builder_update_10001 isn't executed properly

🇮🇳India ankitv18

MR!6 is ready for a review
Pipeline is passing after adding few phpunit and mink dev packages
Also made some tweaks and skipping few tests of Functional JsonApiQueryBuilderTest

🇮🇳India ankitv18

uhhghh... I missed your comment :(
FYI, there are console.error and console.warn also in the react-app directory.
Do we need to remove them also in this ticket?

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Provided few suggestion on the MR and also test case is missing for this new drush command.

🇮🇳India ankitv18

Tests are also fixed as a part of this issue ~~ now pipelines are passing, hence moving into NR.

🇮🇳India ankitv18

ankitv18 made their first commit to this issue’s fork.

🇮🇳India ankitv18

Ignore my comment ~~ went through the file then understood the reason of typecasting the numeric value.

Changes looks to be mergeable as pipeline are clean ~~ marking this one RTBC

🇮🇳India ankitv18

thanks @batigolix, Changes looks good ~~ marking this one RTBC

🇮🇳India ankitv18

@cmlara I guess you missed to give credit to the contributors for this issue :)

🇮🇳India ankitv18

I have validated this MR on local with XB ~~ attaching the screenshot for the result.

@mglaman @grasmash is there any remaining work on this FR?

🇮🇳India ankitv18

If changes looks good then we can consider to merge this into 3.1.x also

Production build 0.71.5 2024