🇮🇳India @ankitv18

Gitlab CI is implemented properly ~~ not sure whether we need to handle other fixes, still marking this one RTBC as all changes doesn't impact.

ankitv18 → made their first commit to this issue’s fork.

Overall changes looks ~~ just added one minor code improvement and on validating the changes on local I've found no more php warnings.

Marking this one RTBC

Feel free to change the status if anyone else having the suggestions.

Quite straightforward ~~ changes done as per proposed solution, hence marking this one RTBC

Changes looks good and project-browser/data makes more sense ~~ marking this one RTBC.

But please let these kind of issues picked by someone new to the drupal community.

Hi @pameeela,
As per the file changes ~~ could you please update the functional javascript tests.
see: https://git.drupalcode.org/issue/project_browser-3488078/-/jobs/3390931

Moving into NW

@shalini_jha Thanks for working on this one ~~ changes looks quite straightforward.
FYI, these kind of issues should be picked by newbies first. :)
For now I'm marking this one RTBC.

Is there something left in this issue? @j. ayen green

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → created an issue.

On path: admin/config/content/embed/button/add
After adding embed button, below is the output we are getting.

ankitv18 → changed the visibility of the branch 3430164-automated-drupal-11 to hidden.

Left some comments on the MR ~~ leave this one in review state for further review

Made pipelines passing with adding repositories section to include vcs path of lightning_core( D11 compatible issue for 6.x version) and adding skipped test for quickedit functional JS test ( https://www.drupal.org/project/quickedit/issues/3434080 📌 Automated Drupal 11 compatibility fixes for quickedit Needs work )

Fix composer-lint pipeline: https://git.drupalcode.org/issue/acquia_starterkits-3486734/-/jobs/3316002

Pipelines are passing ~~ we can plan a merge for this one. :)

We can simply remove the usage of upgrade_status as gitlab template default branch is D11 so there won't be a next major release in anytime soon.

cc: @dqd @phenaproxima

ankitv18 → made their first commit to this issue’s fork.

Left a comment ~~ moving into NW

I've left a comment, please check

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

ankitv18 → changed the visibility of the branch 3431664-automated-drupal-11 to active.

ankitv18 → changed the visibility of the branch 3431664-automated-drupal-11 to hidden.

ankitv18 → changed the visibility of the branch 3484975-phpcs-fixes-2.1.x to hidden.

ankitv18 → created an issue.

I have raised two MR's one with drupal gitlab template and another one with gitlab_orca.

ankitv18 → changed the visibility of the branch 3484975-resolve-phpcs-issues to hidden.

Moving this into review ~~ welcoming the feedbacks incase of backward compatibility.

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → made their first commit to this issue’s fork.

There's lot of phpstan fixes done in the MR which is irrelevant for this issue ~~ please revert those changes and work on the phpcs pipeline fixes only or update the issue summary.

Already fixed.

ankitv18 → created an issue.

@debrup your both commits are totally irrelevant. Please do revert those commits.
Phpcs failures needs to be to address separate ~~ objective of this issue to add the phpcs.xml.dist file

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

Left few comments on the MR!12. Please do check once.

ankitv18 → made their first commit to this issue’s fork.

Hi @mysdiir,
I've left few comments on the MR, please check.

CR and Deprecation test coverage is missing, also I don't think the changes done in the MR is valid.

cc: @smustgrave

Please review and validate MR!95

MR!540 changes looks good to me, hence marking this one RTBC.

ankitv18 → created an issue.

ankitv18 → created an issue.

Can anyone please validate if below MR patch fixes the cause?
MR Pach: https://git.drupalcode.org/project/google_tag/-/merge_requests/95.patch

@rohitrajputsahab,
could you please check if below MR patch work for you?
Patch: https://git.drupalcode.org/project/google_tag/-/merge_requests/95.patch

That I guess @damienmckenna can do as he cut the MR against 2.0.x
Also MR needs be to synced to the forked branch.

cc: @anybody

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → made their first commit to this issue’s fork.

damienmckenna → credited ankitv18 → .

I would like to suggest to consider both MR as MR!48 with backward compatibility and MR!49 with minimum support for d10.3 for next major release i.e 2.x

With above discussion threads on MR!48 for bifurcating the cleaner implementation without managing the version_compare checks for handling the deprecations, I've cut the separate branch i.e 3435760-d11-readiness against 2.x considering the next major release with supporting drupal version ^10.3 || ^11

Please review MR!49 ~~ pipelines are passing for phpunit and we can fix the validate pipeline separately.

cc: @anybody @grevil @acbramley

The difference between the project bot MR and other MR is project consists of core_version_requirement constraints in autosave_form_test.info.yml instead of testing package
Also non-project bot MR consists of gitlab CI file to execute the pipelines.

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → made their first commit to this issue’s fork.

I've pushed a commit with marking skippedTests: https://git.drupalcode.org/project/entity_embed/-/merge_requests/47/diff...

Either we can push the maintainer to merge this one: https://git.drupalcode.org/project/entity_embed/-/merge_requests/47
and work on the failing tests in this issue or we can do all test fixing in the D11 issue only.

ankitv18 → made their first commit to this issue’s fork.

Fixtures needs to be updated: https://git.drupalcode.org/issue/panelizer-3433802/-/jobs/3111002#L49

Thanks @8ballsteve,
This is already covered in https://www.drupal.org/project/entity_embed/issues/3430164 📌 Automated Drupal 11 compatibility fixes for entity_embed Needs review (MR!47)

Moving back to NW to avoid confusion.

Hi @gslente,
I've updated the steps to reproduce. Plan is to make entity_embed D11 compatible.

@Nikolay Shapovalov @acbramley
Would be helpful if fixing of tests can be done in D11 compatible issue i.e https://www.drupal.org/project/entity_embed/issues/3430164 📌 Automated Drupal 11 compatibility fixes for entity_embed Needs review

ankitv18 → created an issue.

Clearly tests aren't passing in the current scenario.

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → created an issue.

Hi @darvanen,
$typedConfigManager must be Drupal\\Core\\Config\\TypedConfigManagerInterface introduced in the D10.2.x
It would be better we add a minimum support of D10.2 into the info.yml

ankitv18 → changed the visibility of the branch 3430164-d11_ready to hidden.

@lavanyatalwar we can use _CSPELL_WORDS in case of few words are reported and you create .cspell-project-words.txt file to add all words as a dictionary in that file.

Please proceed with other feedback from @anybody

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → created an issue.

@wells gitlab CI having default branch 11.x so next major won't work and same goes for upgrade_status. Only thing we can keep is previous_major with minimum php version 8.3
Below variables will work on D10.x

OPT_IN_TEST_PREVIOUS_MAJOR=1
CORE_PREVIOUS_PHP_MIN: 8.3

ankitv18 → made their first commit to this issue’s fork.

Changes looks good ~~ marking this one RTBC

ankitv18 → made their first commit to this issue’s fork.

@lkmorlan @jrockowitz can we please move this issue ahead?

Changes pushed in 1.6.2 release tag.

Thanks @chandu7929 for quick response.
Looks better now ~~ Hence marking this one RTBC

Just added a minor suggestion which seems Ideal as D8 is EOL so better to have minimum D9.5.11 support ~~ Rest of the changes looks good and pipelines are passing without any warnings

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

ankitv18 → made their first commit to this issue’s fork.

@jrockowitz Only thing is remaining is to update the CR with the deprecation reason of this sub-module: https://www.drupal.org/docs/8/modules/webform/webform-frequently-asked-q... →
With that we can merge MR!501.

Changes looks good ~~ pipelines are passing for each jobs without any warning, hence moving into RTBC