Rebasing the MR make the pipeline pass.
changes are quite straightforward, hence moving into RTBC
I like to suggest to update the alias instead of adding new one or we can plan to remove older alias and replace all the reference where QueueFactory is injected or used.
Moving into review
Opened new issue https://www.drupal.org/project/acquia_dam/issues/3554165 🐛 Update hook missing for Archive media type. Active to have fix as follows:
- Archive Dam media type is available in existing application after upgrade
- Error on status report page is gone
Hi @nicxcvan,
I believe she has made significant changes where it is required, I have checked within my application and found MR consists of those number of files which are having ckeditor5:ckeditor5 dependency in the test modules in the whole codebase.
here is the command grep -r "ckeditor5:ckeditor5" --include="*.info.yml"
I'm moving into review, for other's to give another look.
Looks good but can we review & merge this one first https://www.drupal.org/project/jqcloud/issues/3550394 📌 Add minor and major variables in gitlab ci. Needs review and rebase the MR of this issue?
MR!13404 changes covered all the required updates, https://www.drupal.org/docs/8/theming isn't exists in the codebase.
ankitv18 → made their first commit to this issue’s fork.
Totally agree with you @mondrake, pushed the commit with the required changes. Hence moving into review.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → made their first commit to this issue’s fork.
MR!17 now supports HookAttribute for D10 version, hence moving into RTBc
Covered almost all the required details to set the rules within copilot.
Looks good to me, hence moving into RTBC
As per the comment on the MR by @vishal I agree with him, hence moving back into NW.
ankitv18 → changed the visibility of the branch 3548364-rename-XbAcquiaOptimizeController to hidden.
use #[LegacyHook] to support the D10 version application instead of deleting .module file
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → made their first commit to this issue’s fork.
Isn't the hook attribute is introduced in 11.1.0 version?
I have noticed you deleted .module file, can't we use #[LegacyHook] to support the D10 version application?
Keeping this in review, to have other's opinion.
Attempted to create a logo
If looks good then we can push into the MR
ankitv18 → made their first commit to this issue’s fork.
I’m not seeing any changes in .info.yml
Also we can remove D7 reference from readme.md file
As we should support only D10 and above
Provides a simple, standalone machine-name field.
Use this if you only need a single machine-name input.
For two linked fields (a common Drupal core pattern), choose Safeword instead.
How’s this sound?
Hey @marcus
It seems you have missed to give the credit for this fix.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → changed the visibility of the branch 3111456-language-issues to hidden.
Closing in favour of https://www.drupal.org/project/acquia_optimize/issues/3544753 📌 Rename to Acquia Web Governance Active
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → made their first commit to this issue’s fork.
Hi @anybody @danrod
Except Phpcs(which should be covered in
https://www.drupal.org/project/entity_browser/issues/3036556
📌
Fix the issues reported by phpcs
RTBC
) rest all the pipeline is clean.
Note: I have added SKIP_ESLINT to avoid any functional failures due to Javascript (I think it is ideal to cover this separately)
Also 1 suggestion should we bump drupal version to 10.3 as we fixed deprecation here: https://git.drupalcode.org/project/entity_browser/-/merge_requests/97/di...
ankitv18 → made their first commit to this issue’s fork.
Anything pending here? or can we mark this as Fixed?
ankitv18 → made their first commit to this issue’s fork.
MR is ready for a review.
ankitv18 → made their first commit to this issue’s fork.