🇮🇳India @ankitv18

ankitv18 → created an issue.

Please review MR!99

ankitv18 → changed the visibility of the branch 3434566-automated-drupal-11 to hidden.

I guess we can drop atleast Drupal 8 version.

Indeed gitlab template is required further ~~ marking this RTBC.

Please check below code: If we check at initial level of having a permission then only it could be useful for any further logic implementation.

/**
 * Implements hook_form_alter() for node form alter to add the Generator button.
 */
function metatag_ai_form_alter(&$form, FormStateInterface $form_state, $form_id) {
  if (\Drupal::currentUser()->hasPermission('administer metatag content')) {
     $form_object = $form_state->getFormObject();
    if ($form_object instanceof NodeForm) {
      $content_type = $form_object->getEntity()->getType();
      $selected_content_types = \Drupal::config('metatag_ai.content_settings')->get('metatag_ai.metadata_content_types');
      if (!empty($selected_content_types) && in_array($content_type, $selected_content_types)) {
          $form['actions']['generate_metadata'] = [
            '#type' => 'button',
            '#value' => t('Generate Metatag'),
            '#weight' => 4,
            '#ajax' => [
              'callback' => 'metatag_ai_generate_submit_form',
              'event' => 'click',
            ],
          ];
        }
      }
    }
  }

Will add missing typehint to dataProviders method.

Reviewed the MR and changes made are clearer and understandable in the statement and usage of cspell-ignore and disable is at appropriate place.
This looks good to be merged, hence marking this RTBC

Considering the CSpell pipeline changes looks fine to be merged ~~ Marking this RTBC

I've raised a MR!7, please review

ankitv18 → made their first commit to this issue’s fork.

drupal-off-canvas is deprecated
Follow the link: https://www.drupal.org/node/3305664 → to support off-canvas dialog before and after D10.

ankitv18 → created an issue.

Marking this RTBC ~~ confirming it working as expected.
Clicking on the configure will redirect to the admin settings page.

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → created an issue.

MR!36 can be reviewed ~~ included the changes of gitlab-ci from https://www.drupal.org/project/acquia_search/issues/3448516 📌 Automated Drupal 11 compatibility fixes Needs review

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

@itamair typedConfigManager passed as an argument from D10.2 in configFormBase class and settingsForm.php consists of config.factory and typed.config which is already passed as an argument in https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Form%21Co...

So as parent class already having those argument so I don't see any objective of repeating those property again and creating the instance with the same properties.

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → made their first commit to this issue’s fork.

Will raise the MR considering the suggestion of #7 and patches provided

ankitv18 → made their first commit to this issue’s fork.

Requires to update the tests especially for AjaxBehaviourTest.php file ~~ hence moving into needs work.

Thanks @vensires apart from these failures https://git.drupalcode.org/issue/facets-3052574/-/jobs/1903753#L873
I've covered all fixes in the Drupal 11 compatibility issue.

RTBC+1 to merge this one

Assigning to myself to fix the warning in the minor and major phpunit.
By the way enabled the cspell job (Good to have to report the typo)
cc: mradcliffe

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

ankitv18 → made their first commit to this issue’s fork.

Can someone please review MR!217?

Noticed AjaxBehaviorTest phpunit tests are failing while working on the D11 compatibility issue against 2.0.x branch.
I believe tests should also be consider here to update them or provide new once. Also please rebase the MR so that gitlab pipeline would show the actual result.

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

ankitv18 → created an issue.

Finally pipeline passed ~~ included 9.5 || 10 || 11 and also fixed the cspell job.

ankitv18 → changed the visibility of the branch 3425236-drupal-11-compatibility to hidden.

ankitv18 → changed the visibility of the branch 3425236-search-api-ready-d11 to hidden.

As search_api is released with D10.1 and D11 support, Rechecking if any work is left on this.

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → made their first commit to this issue’s fork.

Thanks @jcnventura,
I have dropped the D9 and used timeZoneHelper as you suggested.
Please review the MR and make it ease for @MegaChriz

Ohh alright fair and square ~~ noted
Thanks :)

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

Yes @itamir
Sorry actually I just considered the MR feedback didn't take a look on the issue status.
Please review the MR!31 and let me know any changes required.

Did some tweaks to fix cspell and phpcs pipeline ~~ marking this one RTBC

ankitv18 → made their first commit to this issue’s fork.

Created a MR with patch #10

MR!19 is ready for a review.

ankitv18 → changed the visibility of the branch 3440317-fixes-for-remaining to hidden.

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

ankitv18 → made their first commit to this issue’s fork.

Updated the MR and enabled the next major pipeline, please review the MR!173
Created new issue to support book and laminas-feed tests and fix all deprecated method introduced in phpunit 10
https://www.drupal.org/project/feeds/issues/3454788 📌 PHPunit Next Major pipeline failure Active

cc: @MegaChriz

ankitv18 → created an issue.

Now pipeline is failing on https://git.drupalcode.org/issue/jsonapi_extras-3451984/-/jobs/1867677#L102
So I believe we can't run the tests below D10 cause of return type hint of public function normalize($object, $format = NULL, array $context = []): array|bool|string|int|float|null|\ArrayObject {
Dropping the D9 from info.yml, phpcs:ignore for comma trailing and previous major from gitlab

cc: @bbrala @ptmkenny

for phpunit previous major: https://git.drupalcode.org/issue/jsonapi_extras-3451984/-/jobs/1867426#L217 (These are the failing)
Reason: to avoid phpcs issues like this: Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma
There are many places where comma separator is added at the end of closing statement in the constructor (These changes taken place couple of weeks ago).

So do we need that change or we can remove comma separator from those places and add phpcs:ignore Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma above last argument in the method.

cc: @bbrala

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

Updated the MR and fixes remaining type hint, validated on local by installing the module.

ankitv18 → made their first commit to this issue’s fork.

CSpell pipeline is passing now: https://git.drupalcode.org/issue/default_content-3454594/-/jobs/1860474
Please review MR!47

ankitv18 → created an issue.

Rebased with 3.0.x branch and added the D11 in info.yml

ankitv18 → made their first commit to this issue’s fork.

Rebased with 3.0.x branch to run the CI pipeline.

@MegaChriz I've noticed you pushed logException Method few days back: https://git.drupalcode.org/project/feeds/-/merge_requests/127/diffs#a56d...
And going through the feeds.services.yml below logger is already there.

  logger.channel.feeds:
    parent: logger.channel_base
    arguments: ['feeds']

In this MR I used direct drupal call using \Drupal::logger('feeds')->error($e) instead of watchdog_exception
For PhpassHashedPassword deprecation I've replaced it with a https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Password%...

There's already a separate issue where all the phpstan fixes are considered. Please check below issue
https://www.drupal.org/project/feeds/issues/3425218 🐛 Fix PHPStan errors Needs work

Made the changes as requested Please review MR!59

ankitv18 → made their first commit to this issue’s fork.

Created a MR with the patch#2 as it's a trivial change so would be better if its merged straight away.

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → changed the visibility of the branch project-update-bot-only to hidden.

MR!57 is ready for a review.

PHPunit next major fatal error i.e

Fatal error: Declaration of Drupal\facets\Entity\Facet::__sleep() must be compatible with Drupal\Core\Config\Entity\ConfigEntityBase::__sleep(): array in /builds/issue/facets_pretty_paths-3430412/web/modules/contrib/facets/src/Entity/Facet.php on line 1213
/builds/issue/facets_pretty_paths-3430412/vendor/bin/phpunit:122

Is fixed in the https://git.drupalcode.org/project/facets/-/merge_requests/217/diffs#08e...

Rest all the pipelines are passing, hence marking this one as RTBC.

MR!58 is ready for a review

ankitv18 → created an issue. See original summary → .

MR!56 is ready for a review @DamienMcKenna