MR is ready for a review.
ankitv18 → made their first commit to this issue’s fork.
I'll suggest we should add minimum drupal version constraint to D10.3 or add @phpstan-ignore-next-line above phpstan smell lines
Covered in https://www.drupal.org/project/node_revision_delete/issues/3543128 📌 Fix PHPCS issues Active
alexpott → credited ankitv18 → .
ankitv18 → made their first commit to this issue’s fork.
MR!34 is ready for a review.
ankitv18 → created an issue.
MR!33 is ready for a review.
Looks good, hence moving into RTBC
MR!32 is ready for a review.
ankitv18 → created an issue.
ankitv18 → created an issue.
Hi @cosmicdreams,
Feel free to open a new issue for your case, will look into that separately.
1.0.6 release just having a support of Gin v5 :)
I've just bypass the phptstan previous major CI checks.
@danrod rest looks fine, moving into RTBC
ankitv18 → changed the visibility of the branch 3540573-implement-hookhelp to hidden.
ankitv18 → made their first commit to this issue’s fork.
MR!37 is ready for a review.
ankitv18 → made their first commit to this issue’s fork.
Why you have reverted hook attribute? Also revert phpcs and phpstan fixes.
Moving back to Needs work
Yes 1.0.6 consists of this change, please check: https://git.drupalcode.org/project/sitestudio_gin/-/blob/1.0.6/composer....
Alright, make sense!!
Reviewed MR!36, CSPELL pipeline is green now ~~ hence moving this into RTBC
ankitv18 → made their first commit to this issue’s fork.
MR is conflicted, can someone please resolve this.
Can we have a MR for this issue so that we the changes will pass all GitLab CI checks
MR is clean and phpunit perform most of the assertions, hence moving into RTBC
MR!7 looks good, moving into RTBC
Opened a issue in acquia_cms_page module as field.field.node.page.body.yml is in optional configuration and there's a minor change required in that config settings.
ankitv18 → created an issue.
MR!29 ready for a review.
ankitv18 → created an issue.
RTBC ++
MR!23 is ready for a review.
ankitv18 → changed the visibility of the branch 3525988-few-minor-improvements to hidden.
MR!27 is ready for a review.
ankitv18 → created an issue.
Ignore above feedback as Backward Compatibility is handled in the .module hooks
Ignore above feedback as Backward Compatibility is handled in the .module hooks
Left a comment, please check.
Keeping this in review for other inputs
Left a comment, please check.
Keeping this in review for other inputs
Left a comment, please check.
Keeping this in review for other inputs
Left a comment, please check.
Keeping this in review for other inputs
MR!26 is ready for a review.
Thanks for the contribution.
ankitv18 → created an issue.
MR!25 is ready for a review
ankitv18 → changed the visibility of the branch 3538033-better-logging-to to hidden.
Covered with https://www.drupal.org/project/acquia_optimize/issues/3525986 📌 Fix Race Conditions in AJAX Processing Active
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → created an issue.
Proposed solution isn't fixing the actual cause also, Ajax call still conflicted with a autosave_form.
Also if I replace with the proposed solution then META description, sub-headings and Title are missing from SEO checks.
ankitv18 → changed the visibility of the branch 3537922-barehtmlpagerenderer-calls-renderroot to hidden.
ankitv18 → made their first commit to this issue’s fork.
Was on different branch, already fixed
ankitv18 → created an issue.
MR!31 ready for a review.
MR!18 ready for a review.
ankitv18 → created an issue.
MR!19 is ready for a review.
ankitv18 → created an issue. See original summary → .
ankitv18 → created an issue.
ankitv18 → made their first commit to this issue’s fork.
MR!47 is ready for a review.
MR!16 ready for a review.
ankitv18 → made their first commit to this issue’s fork.
Once this issue: https://www.drupal.org/project/graphql/issues/3536497 📌 composer pipeline is failing with D11.2.2 Active is merged then we can rebase and pipeline will work as expected.
Raised one issue to fix the composer pipeline separately.
MR!46 is ready for a review.
ankitv18 → created an issue.
ankitv18 → made their first commit to this issue’s fork.
ankitv18 → created an issue.
Closing this
Thanks @longwave for pointing this out, I'm totally unaware of security issues file process.
Closing this
MR!14 is ready for a review.
ankitv18 → created an issue.
MR!12 is ready for a review.
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → created an issue.
ankitv18 → made their first commit to this issue’s fork.
Add a comment on the MR, please check.
Commits pushed in the parent ticket as a part of this issue:
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
ankitv18 → changed the visibility of the branch 3533331-description-missing-on to hidden.