🇮🇳India @ankitv18

ankitv18 → created an issue.

MR!12 is ready for a review.

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → made their first commit to this issue’s fork.

Add a comment on the MR, please check.

Commits pushed in the parent ticket as a part of this issue:
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...
https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...

ankitv18 → changed the visibility of the branch 3533331-description-missing-on to hidden.

As it is dependent on https://www.drupal.org/project/acquia_optimize/issues/3517839 ✨ Add Experience Builder extension Active so I have separate commit: https://git.drupalcode.org/project/acquia_optimize/-/merge_requests/6/di...

All the changes as a part of this issue is covered ~~ hence moving into review

ankitv18 → created an issue.

ankitv18 → created an issue.

MR!29 is against 2.x branch ~~ phpcs pipeline + composer changes are fixed now, hence moving into review.

ankitv18 → changed the visibility of the branch 3528488-fix-the-phpcs-8.x-2.x to hidden.

ankitv18 → changed the visibility of the branch 3528488-fix-phpcs-issue to hidden.

ankitv18 → changed the visibility of the branch 8.x-1.x to hidden.

ankitv18 → made their first commit to this issue’s fork.

Validated the MR!5
Query builder page throwing 404 error

jsonapi_query_builder_update_10001 isn't executed properly

MR!6 is ready for a review
Pipeline is passing after adding few phpunit and mink dev packages
Also made some tweaks and skipping few tests of Functional JsonApiQueryBuilderTest

uhhghh... I missed your comment :(
FYI, there are console.error and console.warn also in the react-app directory.
Do we need to remove them also in this ticket?

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → made their first commit to this issue’s fork.

Provided few suggestion on the MR and also test case is missing for this new drush command.

ankitv18 → created an issue. See original summary → .

ankitv18 → made their first commit to this issue’s fork.

As per discussion this will covered in another issue

ankitv18 → created an issue.

MR!8 is ready for a review.

Tests are also fixed as a part of this issue ~~ now pipelines are passing, hence moving into NR.

ankitv18 → made their first commit to this issue’s fork.

Ignore my comment ~~ went through the file then understood the reason of typecasting the numeric value.

Changes looks to be mergeable as pipeline are clean ~~ marking this one RTBC

thanks @batigolix, Changes looks good ~~ marking this one RTBC

@noored please use this patch: https://git.drupalcode.org/project/gin_login/-/merge_requests/39.patch

@cmlara I guess you missed to give credit to the contributors for this issue :)

I have validated this MR on local with XB ~~ attaching the screenshot for the result.

@mglaman @grasmash is there any remaining work on this FR?

ankitv18 → created an issue.

If changes looks good then we can consider to merge this into 3.1.x also

MR!45 is ready for a review.

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → created an issue.

ankitv18 → created an issue.

Validated the changes on local and now I'm able to get the Quick Scan result without any browser console error ~~ Hence marking this one RTBC

ankitv18 → made their first commit to this issue’s fork.

Minor suggestion moving that line of change from constructor to Query function would work.

MR!154 is ready for a review.

ankitv18 → made their first commit to this issue’s fork.

ankitv18 → created an issue.

MR!49 is ready for a review.

Marking this one outdated as this issue isn't replicated with latest release.
Feel free to open new issue if related issue encounter.

ankitv18 → made their first commit to this issue’s fork.

I had tried to reproduce this issue at my local machine with the latest version of Key module along with other contributed modules like workbench_moderation, shield and encrypt on Drupal 11.1.5 application.

Can anyone else give a shot to check whether this issue still exists?

cc: @acbramley @rlhawk @q0rban

Hey @joseph.olstad
Is this issue still exists as I tried with the below version:
Drupal: 11.1.5
Key: 1.20
smtp: 1.4.0
symfony_mailer: 1.5.0
symfony_mailer_lite: 2.0.2

Below are the screenshot of overriding smtp username with custom test key.

Am I missing something here? could you check with the latest version of modules and update the issue accordingly?

Minor suggestion ~~ Please check, moving into NW

So I've updated the MR ~~ now it consists changes in composer.json file and hook_update_N (to install acquia_dam).

We should set a soft dependency, allowing users to uninstall media_acquiadam after successfully migrating assets.

Keeping acquia_dam in the info.yml prevents users from performing the uninstall action.

Also user needs to upgrade on latest version of media_acquiadam so by default they won't get acquia_dam module enabled and However, the migration process requires the acquia_dam module, which users can enable manually through the extend menu.

Pipeline runs smoothly ~~~ No more warnings are there. Also, changes looks mergeable ~~ Hence moving into RTBC.

Provided some suggestion ~~ also validated the functionality, it works as expected.

Please add a hook_update_N to by default enable the Acquia DAM module so that user can see the migration dashboard fully functional.

Ideally this should be the part of https://www.drupal.org/project/acquia_dam/issues/3515288 🐛 Newly created media type doesn't have media_library entity view display preconfigured. Active or if we are considering handling this separately then I've added the comment on the MR.

Added comments in the MR

MR merged by Vishal and reviewed by Deepak

ankitv18 → created an issue.

@smustgrave Thanks!!
Please do consider to fix the pipeline also: https://git.drupalcode.org/issue/drupal-3477616/-/jobs/4763371#L394

ankitv18 → created an issue.

The following files are responsible for handling the sorting and rendering of the asset count for dam_content_overview:

https://git.drupalcode.org/project/acquia_dam/-/blob/1.1.x/src/Plugin/vi...
https://git.drupalcode.org/project/acquia_dam/-/blob/1.1.x/src/Plugin/vi...

I attempted to debug this issue but was unsuccessful. I have attached a screenshot of the Xdebug for reference.

ankitv18 → made their first commit to this issue’s fork.

MR!597 is ready for a review.

ankitv18 → created an issue.

MR!39 ready for a review.

MR!62 ready for a review.

ankitv18 → created an issue.

ankitv18 → created an issue.

MR!130 is ready for a review

ankitv18 → changed the visibility of the branch 3447628-load-the-config to hidden.

ankitv18 → made their first commit to this issue’s fork.