- Issue created by @vipin.mittal18
- Merge request !157Issue#3523850: Add drush command for import. ā (Merged) created by divyansh.gupta
- š®š³India divyansh.gupta Jaipur
I have added the option to import using drush command.
Please review. - First commit to issue fork.
- š®š³India rajeshreeputra Pune
I would like to propose a discussion regarding the implementation of the commands
acquiadam:queue-assets
andacquiadam:import-assets
. Specifically, we need to consider whether these should be implemented as two separate commands or combined into a single command that handles both queuing and processing of assets.Additionally, I suggest we introduce an option to limit the asset import process. For instance, we could allow users to specify a limit on the number of assets imported from the queue. An example:
./vendor/bin/drush acquiadam:import-assets --batch-size=50 --item-limit=500
This command would process 10 batches to import a total of 500 assets and then stop, even if there are remaining items in the queue. I believe this feature would enhance the flexibility and usability of the asset import process, especially for users dealing with large datasets.
Looking forward to your thoughts on this!
- š®š³India ankitv18
Provided few suggestion on the MR and also test case is missing for this new drush command.
- š®š³India rajeshreeputra Pune
Hello @ankitv18 - test coverage will be added once the discussion from #7 ⨠Support Drush Command for Bulk Import Feature Active gets resolved.
- First commit to issue fork.
- šŗšøUnited States japerry KVUO
Updated the code to modern standards (while still supporting our supported versions of Drupal), as well as make it consistent with the other Drush Commands in DAM.
- šŗšøUnited States japerry KVUO
Thank you rajeshreeputra for fixing the tests! Looks good, committed.
-
japerry ā
committed c5720bec on 1.1.x authored by
divyansh.gupta ā
Issue #3523850: Support Drush Command for Bulk Import Feature
-
japerry ā
committed c5720bec on 1.1.x authored by
divyansh.gupta ā
-
japerry ā
committed a920af04 on 1.1.x
Followup for issue #3523850 by vishal.khode: Add attributes as CLI for...
-
japerry ā
committed a920af04 on 1.1.x
- š®š³India divyansh.gupta Jaipur
Hi,
Just wanted to mention that I had started the initial work on this issue. Getting credit on issues like this really helps motivate contributors like me to stay involved and keep contributing. Iād appreciate it if that could be reflected here.
Thanks, and looking forward to continuing to collaborate! - Merge request !167Resolve #3523850 "Remove queue asset method call from process queue commands." ā (Merged) created by rajeshreeputra
- š®š³India rajeshreeputra Pune
Missed to remove queueAssets() method removal from processQueue(). Requesting review.
-
japerry ā
committed 4196fbf7 on 1.1.x authored by
rajeshreeputra ā
Issue #3523850 by rajeshreeputra: Support Drush Command for Bulk Import...
-
japerry ā
committed 4196fbf7 on 1.1.x authored by
rajeshreeputra ā
- šŗšøUnited States japerry KVUO
@divyansh.gupta -- credits are given to those who contribute substantially to an issue. If you compare your commit (or mine) to what work was done, it did not rise sufficiently in this case to get credit.
@rajeshreeputra -- Ugh thats unfortunate. Fixed, but will need to go into the next version.