- Issue created by @danrod
- First commit to issue fork.
- ๐ง๐ทBrazil julio_retkwa Balneรกrio Camboriรบ
Hi @danrod sorry, yes
I was not aware that you was working on this, sorry for jumping in
- ๐ง๐ทBrazil julio_retkwa Balneรกrio Camboriรบ
I created a MR against branch 8.x-2.x-dev but its failing on composer step
https://git.drupalcode.org/issue/google_calendar_service-3528488/-/jobs/...I'm missing something here?
PS: I see there are some PHPCS issues on branch 1.x should those be addressed as well? Let me know
https://git.drupalcode.org/issue/google_calendar_service-3528488/-/jobs/...Thanks!
- ๐จ๐ฆCanada danrod Ottawa
@julio_retkwa it is ok, work on the branch 8.x-2.x, which is the one I still want to maintain, if possible.
Thanks a lot for your work.
- Merge request !28Issue # 3528488 by danrod: Fix PHPCS issues in the 8.x-2.x branch โ (Open) created by danrod
- ๐จ๐ฆCanada danrod Ottawa
@julio_retkwa I'm seeing the same composer issues when trying to create a MR against the 8.x-2.x branch, if you have some time to look on it, that would be great, if not, no worries, I'll look on it later.
- First commit to issue fork.
- ๐ฎ๐ณIndia ankitv18
ankitv18 โ changed the visibility of the branch 8.x-1.x to hidden.
- ๐ฎ๐ณIndia ankitv18
ankitv18 โ changed the visibility of the branch 3528488-fix-phpcs-issue to hidden.
- ๐ฎ๐ณIndia ankitv18
ankitv18 โ changed the visibility of the branch 3528488-fix-the-phpcs-8.x-2.x to hidden.
- ๐ฎ๐ณIndia ankitv18
MR!29 is against 2.x branch ~~ phpcs pipeline + composer changes are fixed now, hence moving into review.
- ๐จ๐ฆCanada danrod Ottawa
Thanks a lot @nkitv18 and the others !
There's some CSPELL and other issues that I will fix now.
- ๐จ๐ฆCanada danrod Ottawa
Finally it's green now !!!
I'll move it to RTBC+1 and then merged to the corresponding branch.
Thanks a lot for everyone involved.